mirror of
https://github.com/TrinityCore/TrinityCore.git
synced 2026-01-19 08:55:32 +01:00
Core/Spells: fix penance and holy shock targetting for non faction friendly npcs that appear friendly. should also fix the issue with using mixed groups
This commit is contained in:
@@ -289,8 +289,8 @@ class spell_pal_holy_shock : public SpellScriptLoader
|
||||
{
|
||||
Player* caster = GetCaster()->ToPlayer();
|
||||
if (GetTargetUnit())
|
||||
if (Player* target = GetTargetUnit()->ToPlayer())
|
||||
if (caster->GetTeam() != target->GetTeam() && !caster->IsValidAttackTarget(target))
|
||||
if (Unit* target = GetTargetUnit())
|
||||
if (!caster->IsFriendlyTo(target) && !caster->IsValidAttackTarget(target))
|
||||
return SPELL_FAILED_BAD_TARGETS;
|
||||
return SPELL_CAST_OK;
|
||||
}
|
||||
|
||||
@@ -228,8 +228,8 @@ class spell_pri_penance : public SpellScriptLoader
|
||||
{
|
||||
Player* caster = GetCaster()->ToPlayer();
|
||||
if (GetTargetUnit())
|
||||
if (Player* target = GetTargetUnit()->ToPlayer())
|
||||
if (caster->GetTeam() != target->GetTeam() && !caster->IsValidAttackTarget(target))
|
||||
if (Unit* target = GetTargetUnit())
|
||||
if (!caster->IsFriendlyTo(target) && !caster->IsValidAttackTarget(target))
|
||||
return SPELL_FAILED_BAD_TARGETS;
|
||||
return SPELL_CAST_OK;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user