Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-16 07:30:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

Scripts/Shadowmoon Valley: Fix static analysis issues added in cd48ee01c0

Browse Source 
Fix static analysis issues added in cd48ee01c0 about uninitialized values and pointers possibly point to free'd memory being dereferenced.
In memory of all the developers who got banned from IRC in the process of fixing these issues.
This commit is contained in:
jackpoz
2014-09-21 17:21:04 +02:00
parent 31234c0ca0
commit b71f8367e4
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/server/scripts/Outland/zone_shadowmoon_valley.cpp
View File

@@ -71,7 +71,10 @@ public:
struct npc_invis_infernal_casterAI : public ScriptedAI
{
npc_invis_infernal_casterAI(Creature* creature) : ScriptedAI(creature) { }
npc_invis_infernal_casterAI(Creature* creature) : ScriptedAI(creature)
{
ground = 0.f;
}
void Reset() override
{
@@ -148,12 +151,12 @@ public:
void IsSummonedBy(Unit* summoner) override
{
if (summoner->ToCreature())
caster = summoner->ToCreature();
casterGUID = summoner->ToCreature()->GetGUID();;
}
void JustDied(Unit* /*killer*/) override
{
if (caster)
if (Creature* caster = ObjectAccessor::GetCreature(*me, casterGUID))
caster->AI()->SetData(TYPE_INFERNAL, DATA_DIED);
}
@@ -175,7 +178,7 @@ public:
}
private:
Creature* caster;
ObjectGuid casterGUID;
};
CreatureAI* GetAI(Creature* creature) const override