Core/Misc: ASSERT() cleanup

Move some functions calls out of ASSERT() calls. ASSERT() should only apply checks without modifying any object and without having any side effect.

(cherry picked from commit 572eab1c35)
This commit is contained in:
jackpoz
2018-02-17 23:26:50 +01:00
committed by funjoker
parent cb0a889177
commit b7aef385e8
4 changed files with 18 additions and 8 deletions

View File

@@ -169,7 +169,8 @@ bool Group::Create(Player* leader)
Group::ConvertLeaderInstancesToGroup(leader, this, false);
ASSERT(AddMember(leader)); // If the leader can't be added to a new group because it appears full, something is clearly wrong.
bool addMemberResult = AddMember(leader);
ASSERT(addMemberResult); // If the leader can't be added to a new group because it appears full, something is clearly wrong.
}
else if (!AddMember(leader))
return false;