Core/Auras: Corrected SPELL_AURA_MOD_HONOR_GAIN_PCT implementation - it should only increase honor gains from some sources

This commit is contained in:
Shauren
2025-09-24 00:21:31 +02:00
parent 5fad0fb43a
commit c56d18287d
10 changed files with 43 additions and 21 deletions

View File

@@ -664,7 +664,7 @@ struct battleground_strand_of_the_ancients : BattlegroundScript
{
battleground->UpdatePvpStat(player, PVP_STAT_GATES_DESTROYED, 1);
if (rewardHonor)
battleground->UpdatePlayerScore(player, SCORE_BONUS_HONOR, battleground->GetBonusHonorFromKill(1));
battleground->UpdatePlayerScore(player, SCORE_BONUS_HONOR, battleground->GetBonusHonorFromKill(1), true, HonorGainSource::TeamContribution);
}
}
}

View File

@@ -72,7 +72,7 @@ public:
if (handler->HasLowerSecurity(target, ObjectGuid::Empty))
return false;
target->RewardHonor(nullptr, 1, amount);
target->RewardHonor(nullptr, 1, amount, HonorGainSource::Spell);
return true;
}
@@ -91,7 +91,7 @@ public:
if (handler->HasLowerSecurity(player, ObjectGuid::Empty))
return false;
handler->GetSession()->GetPlayer()->RewardHonor(target, 1);
handler->GetSession()->GetPlayer()->RewardHonor(target, 1, -1, HonorGainSource::Kill);
return true;
}

View File

@@ -107,7 +107,7 @@ bool OutdoorPvPSI::HandleAreaTrigger(Player* player, uint32 trigger, bool /*ente
// reward player
player->CastSpell(player, SI_TRACES_OF_SILITHYST, true);
// add 19 honor
player->RewardHonor(nullptr, 1, 19);
player->RewardHonor(nullptr, 1, 19, HonorGainSource::TeamContribution);
// add 20 cenarion circle repu
player->GetReputationMgr().ModifyReputation(sFactionStore.LookupEntry(609), 20);
// complete quest
@@ -133,7 +133,7 @@ bool OutdoorPvPSI::HandleAreaTrigger(Player* player, uint32 trigger, bool /*ente
// reward player
player->CastSpell(player, SI_TRACES_OF_SILITHYST, true);
// add 19 honor
player->RewardHonor(nullptr, 1, 19);
player->RewardHonor(nullptr, 1, 19, HonorGainSource::TeamContribution);
// add 20 cenarion circle repu
player->GetReputationMgr().ModifyReputation(sFactionStore.LookupEntry(609), 20);
// complete quest