Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-24 19:06:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

Core/PathFinding: Fix buffer overflow

Browse Source
This commit is contained in:
jackpoz
2020-04-29 22:01:23 +02:00
committed by Ovahlord
parent 298c2593df
commit c5c99f1eea
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/server/game/Movement/PathGenerator.cpp
View File

@@ -516,7 +516,9 @@ void PathGenerator::BuildPointPath(const float *startPoint, const float *endPoin
G3D::Vector3 prevVec = startVec;
float len = diffVec.length();
diffVec *= SMOOTH_PATH_STEP_SIZE / len;
while (len > SMOOTH_PATH_STEP_SIZE)
// If the path is short PATHFIND_SHORT will be set as type
while (len > SMOOTH_PATH_STEP_SIZE && pointCount < MAX_POINT_PATH_LENGTH)
{
len -= SMOOTH_PATH_STEP_SIZE;
prevVec += diffVec;
@@ -526,8 +528,12 @@ void PathGenerator::BuildPointPath(const float *startPoint, const float *endPoin
++pointCount;
}
memcpy(&pathPoints[VERTEX_SIZE * pointCount], endPoint, sizeof(float)* 3); // last point
++pointCount;
// If the path is short PATHFIND_SHORT will be set as type
if (pointCount < MAX_POINT_PATH_LENGTH)
{
memcpy(&pathPoints[VERTEX_SIZE * pointCount], endPoint, sizeof(float) * 3); // last point
++pointCount;
}
}
else if (_useStraightPath)
{
@@ -571,7 +577,7 @@ void PathGenerator::BuildPointPath(const float *startPoint, const float *endPoin
_type = PathType(_type | PATHFIND_NOPATH);
return;
}
else if (pointCount == _pointPathLimit)
else if (pointCount >= _pointPathLimit)
{
TC_LOG_DEBUG("maps.mmaps", "++ PathGenerator::BuildPointPath FAILED! path sized %d returned, lower than limit set to %d", pointCount, _pointPathLimit);
BuildShortcut();