Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-22 18:15:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Scripts/Gilneas: fixed two possible crash locations caused by modifying iterators while iterating through them

Browse Source 
closes #55
This commit is contained in:
Ovahlord
2019-03-30 17:20:51 +01:00
parent c991d4bfe7
commit cf9825dd82
1 changed files with 16 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/server/scripts/EasternKingdoms/Gilneas/chapter1.cpp
View File

@@ -526,15 +526,18 @@ class npc_greymanes_horse : public CreatureScript
{
if (Creature* krennan = passenger->ToCreature())
{
for (Unit* attacker : me->getAttackers())
{
if (!attacker)
continue;
std::vector<Unit*> storedAttackers;
for (Unit* attacker : me->getAttackers())
storedAttackers.push_back(attacker);
for (Unit* attacker : storedAttackers)
{
if (Creature* creature = attacker->ToCreature())
if (creature->IsAIEnabled)
creature->AI()->EnterEvadeMode();
}
player->ExitVehicle();
krennan->AddUnitState(UNIT_STATE_ROOT);
krennan->ExitVehicle();
@@ -650,18 +653,23 @@ class npc_crowleys_horse : public CreatureScript
me->GetMotionMaster()->MovePath(PATH_ID_CROWLEYS_HORSE_2, false);
break;
case EVENT_DISMOUNT_PLAYER:
for (Unit* attacker : me->getAttackers())
{
if (!attacker)
continue;
{
std::vector<Unit*> storedAttackers;
for (Unit* attacker : me->getAttackers())
storedAttackers.push_back(attacker);
for (Unit* attacker : storedAttackers)
{
if (Creature* creature = attacker->ToCreature())
if (creature->IsAIEnabled)
creature->AI()->EnterEvadeMode();
}
me->RemoveAurasDueToSpell(VEHICLE_SPELL_RIDE_HARDCODED);
me->DespawnOrUnsummon(Seconds(5));
break;
}
case EVENT_MOVE_OFF_PATH:
me->SetControlled(false, UNIT_STATE_ROOT);
_currentPath = PATH_ID_CROWLEYS_HORSE_3;