Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-15 23:20:36 +01:00
Code Issues Packages Projects Releases Wiki Activity

Core/Networking: Initialize MPSCQueueIntrusive dummy node without undefined behavior

Browse Source
This commit is contained in:
Shauren
2020-08-20 16:06:15 +02:00
parent 89fd7d4592
commit e1289805fc
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/common/Threading/MPSCQueue.h
View File

@@ -95,10 +95,10 @@ class MPSCQueueIntrusive
public:
MPSCQueueIntrusive() : _dummyPtr(reinterpret_cast<T*>(std::addressof(_dummy))), _head(_dummyPtr), _tail(_dummyPtr)
{
T* front = _head.load(std::memory_order_relaxed);
(front->*IntrusiveLink).store(nullptr, std::memory_order_relaxed);
// _dummy is constructed from aligned_storage and is left uninitialized so we init only its Next here
(_dummyPtr->*IntrusiveLink).store(nullptr, std::memory_order_relaxed);
// _dummy is constructed from aligned_storage and is intentionally left uninitialized (it might not be default constructible)
// so we init only its IntrusiveLink here
std::atomic<T*>* dummyNext = new (&(_dummyPtr->*IntrusiveLink)) std::atomic<T*>();
dummyNext->store(nullptr, std::memory_order_relaxed);
}
~MPSCQueueIntrusive()