Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-24 19:06:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

Core/Spells: 6c0cf9580b followup and improved readability of the code

Browse Source 
superceeds #223
This commit is contained in:
Ovahlord
2021-01-19 14:18:48 +01:00
parent 6c0cf9580b
commit f91c30868f
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/server/scripts/Spells/spell_rogue.cpp
View File

@@ -1419,8 +1419,8 @@ class spell_rog_bandits_guile : public AuraScript
uint32 spellId = SPELL_ROGUE_SHALLOW_INSIGHT;
int32 basepoints = 10;
// Todo: validate this for lower ranks. 3/3 requires 4 hits.
uint8 neededProcs = uint8(7 - GetSpellInfo()->GetRank());
// Todo: validate if the required number of successful procs itself changes or if the proc chance of lower ranks is taking care of it already.
uint8 const neededProcs = 4;
// We are striking a new opponent, reset progress
if (_recentTargetGUID != procTarget->GetGUID())
@@ -1442,6 +1442,7 @@ class spell_rog_bandits_guile : public AuraScript
{
spellId = SPELL_ROGUE_DEEP_INSIGHT;
basepoints = 30;
_procStrikes = 0;
}
else if (_procStrikes >= neededProcs * 2)
{
@@ -1449,9 +1450,9 @@ class spell_rog_bandits_guile : public AuraScript
basepoints = 20;
}
if (_procStrikes >= neededProcs * 3 && target->HasAura(SPELL_ROGUE_MODERATE_INSIGHT, target->GetGUID()))
if (spellId == SPELL_ROGUE_DEEP_INSIGHT && target->HasAura(SPELL_ROGUE_MODERATE_INSIGHT, target->GetGUID()))
target->RemoveAurasDueToSpell(SPELL_ROGUE_MODERATE_INSIGHT, target->GetGUID());
else if (_procStrikes >= neededProcs * 2 && target->HasAura(SPELL_ROGUE_SHALLOW_INSIGHT, target->GetGUID()))
else if (spellId == SPELL_ROGUE_MODERATE_INSIGHT && target->HasAura(SPELL_ROGUE_SHALLOW_INSIGHT, target->GetGUID()))
target->RemoveAurasDueToSpell(SPELL_ROGUE_SHALLOW_INSIGHT, target->GetGUID());
target->CastSpell(target, spellId);