Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-22 18:15:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Core/Threat: Only send SMSG_THREAT_UPDATE if the threat list actually changed

Browse Source
This commit is contained in:
Treeston
2018-08-27 20:41:07 +02:00
committed by Ovahlord
parent 990127590a
commit fd599605da
2 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/server/game/Combat/ThreatManager.cpp
View File

@@ -41,6 +41,7 @@ void ThreatReference::AddThreat(float amount)
HeapNotifyIncreased();
else
HeapNotifyDecreased();
_mgr._needClientUpdate = true;
}
void ThreatReference::ScaleThreat(float factor)
@@ -52,6 +53,7 @@ void ThreatReference::ScaleThreat(float factor)
HeapNotifyIncreased();
else
HeapNotifyDecreased();
_mgr._needClientUpdate = true;
}
void ThreatReference::UpdateOffline()
@@ -125,6 +127,8 @@ void ThreatReference::UpdateTauntState(TauntState state)
HeapNotifyDecreased();
else
HeapNotifyIncreased();
_mgr._needClientUpdate = true;
}
void ThreatReference::ClearThreat()
@@ -157,7 +161,7 @@ void ThreatReference::UnregisterAndFree()
return true;
}
ThreatManager::ThreatManager(Unit* owner) : _owner(owner), _ownerCanHaveThreatList(false), _ownerEngaged(false), _updateTimer(THREAT_UPDATE_INTERVAL), _currentVictimRef(nullptr), _fixateRef(nullptr)
ThreatManager::ThreatManager(Unit* owner) : _owner(owner), _ownerCanHaveThreatList(false), _ownerEngaged(false), _needClientUpdate(false), _updateTimer(THREAT_UPDATE_INTERVAL), _currentVictimRef(nullptr), _fixateRef(nullptr)
{
for (int8 i = 0; i < MAX_SPELL_SCHOOL; ++i)
_singleSchoolModifiers[i] = 1.0f;
@@ -355,7 +359,6 @@ void ThreatManager::AddThreat(Unit* target, float amount, SpellInfo const* spell
if (it != _myThreatListEntries.end())
{
ThreatReference* const ref = it->second;
// causing threat causes SUPPRESSED threat states to stop being suppressed
if (ref->GetOnlineState() == ThreatReference::ONLINE_STATE_SUPPRESSED)
if (!ref->ShouldBeSuppressed())
@@ -488,10 +491,14 @@ Unit* ThreatManager::GetFixateTarget() const
void ThreatManager::UpdateVictim()
{
ThreatReference const* const newVictim = ReselectVictim();
bool const newHighest = (newVictim != _currentVictimRef);
bool const newHighest = newVictim && (newVictim != _currentVictimRef);
_currentVictimRef = newVictim;
SendThreatListToClients(newVictim && newHighest);
if (newHighest || _needClientUpdate)
{
SendThreatListToClients(newHighest);
_needClientUpdate = false;
}
}
@@ -747,6 +754,7 @@ void ThreatManager::SendThreatListToClients(bool newHighest) const
void ThreatManager::PutThreatListRef(ObjectGuid const& guid, ThreatReference* ref)
{
_needClientUpdate = true;
auto& inMap = _myThreatListEntries[guid];
ASSERT(!inMap, "Duplicate threat reference at %p being inserted on %s for %s - memory leak!", ref, _owner->GetGUID().ToString().c_str(), guid.ToString().c_str());
inMap = ref;

1
src/server/game/Combat/ThreatManager.h
View File

@@ -203,6 +203,7 @@ class TC_GAME_API ThreatManager
void PutThreatListRef(ObjectGuid const& guid, ThreatReference* ref);
void PurgeThreatListRef(ObjectGuid const& guid);
bool _needClientUpdate;
uint32 _updateTimer;
threat_list_heap _sortedThreatList;
std::unordered_map<ObjectGuid, ThreatReference*> _myThreatListEntries;