7915 Commits

Author SHA1 Message Date
ccrs
b7346bac48 Scripts/PoS: a7a96d4 followup
(cherry picked from commit 40116f1025)
2021-12-18 23:22:54 +01:00
ccrs
7594ae72d7 Scripts/PoS: little implementation cleanup in boss_krickandick with, you guessed it, movement related corrections
also, never forgetti  -->
                                     ¨¨Ç*^¿?_:;_^!"·Ç!Ñ·$%/(/)/()(=)(=]]{
Unit::StopMoving() is evil, and so is MotionMaster::Clear()

the first can really mess up existing movement generators
the second can interrupt "controlled" movements... can do it literally mid-air

(cherry picked from commit a7a96d4271)
2021-12-18 23:22:38 +01:00
ccrs
a73e6a7438 Scripts/PoS: move boss_krickandick into new script definition
(cherry picked from commit d27fd717c1)
2021-12-18 23:22:08 +01:00
ccrs
d3ddb3726a Core/AI: 06443e3 followup
cause its not "that" horrible

(cherry picked from commit a71c5f4c7f)
2021-12-18 23:03:00 +01:00
jackpoz
d5d04a6c55 Core/Misc: Fix C++17 build errors
(cherry picked from commit 30823f9b79)
2021-12-18 22:51:50 +01:00
ForesterDev
4a47e1c6be Core/Defines: define UNIT_FLAG_SWIMMING (#23630)
(cherry picked from commit c03c88d0c0)
2021-12-18 22:50:52 +01:00
Giacomo Pozzoni
3da3683a90 Scripts/Kologarn: Fix "stuck in combat" issues (#23866)
Fix players stuck in combat with NPC_ARM_SWEEP_STALKER and/or both arms after killing the boss.

(cherry picked from commit fed030da19)
2021-12-18 22:47:49 +01:00
Keader
db03975a57 Scripts/ICC: Fixed some issues with Rotface Oozes (#23845)
(cherry picked from commit a108f2ba61)
2021-12-18 22:40:29 +01:00
Keader
e5accfa71a Scripts/ICC: Fixed Death Plague (Frost Giant) (#23847)
(cherry picked from commit 8210b4a539)
2021-12-18 22:40:16 +01:00
Keader
03a1b03633 Scripts/Forge of Souls: Fixed spell Soul Sickness (#23843)
(cherry picked from commit 34ee2effc8)
2021-12-18 22:37:30 +01:00
Keader
9abdc4ee3d Scripts/ICC: Fixed Tear Gas not getting removed of Abomination in phase change of PP (#23846)
(cherry picked from commit 16fde1ffad)
2021-12-18 22:33:47 +01:00
Giacomo Pozzoni
02c2ee9a43 Scripts: Fix crossfaction combat issue (#23818)
* Scripts/PitOfSaron: Fix Martin Victus combat in crossfaction groups

Fix Martin Victus attacking players in crossfaction groups because it was spawned as summon of the boss, triggering DoCombatInZone()

* Scripts/ForgeOfSouls: Fix guards combat in crossfaction groups

Fix Devourer of Souls guardians attacking players in crossfaction groups because they were spawned as summons of the boss, triggering DoCombatInZone()

* Scripts/Misc: Fix no PCH build

(cherry picked from commit ef694cc251)
2021-12-18 22:27:40 +01:00
Keader
5d2b37634b Scripts/Tempest Keep: Fixed a typo in Nethermancer Sepethrea
Closes #23828
Ty Rizztazz

(cherry picked from commit 746a1d89b3)
2021-12-18 22:24:21 +01:00
Killyana
f6e176b7d7 Instance/Script: Gorkun Ironskull & Martin Victus
(cherry picked from commit 8e3862cfbd)
2021-12-18 22:21:41 +01:00
Gildor
6c239a8612 Scripts/Icecrown Citadel: Remove duplicated Spell enum (#23810)
(cherry picked from commit a392216d20)
2021-12-18 22:19:35 +01:00
Kelno
368d99787c Core/Commands: Fixed wrong permissions for .lookup map commands (#23800)
(cherry picked from commit 6fc7ab3448)
2021-12-18 22:19:05 +01:00
Artamedes
4e487c35a7 Scripts/Pet: Fix npc_pet_gen_soul_trader not following owner (#23772)
(cherry picked from commit 8ecc45cd1a)
2021-12-18 21:45:25 +01:00
Artamedes
e3cb89c168 Scripts/PitOfSaron: Make sure ick stops moving when casting Explosive Barrage (#23768)
(cherry picked from commit 88e74ac385)
2021-12-18 21:45:15 +01:00
Artamedes
a2e792f0bc Scripts/PitOfSaron: Fix Krick sometimes stuck in combat after finish kill Ick (#23767)
(cherry picked from commit a17c83bde8)
2021-12-18 21:45:06 +01:00
Artamedes
8fbaab7337 Scripts/Ulduar: Fix Stormcaller Brundir walking into walls (#23755)
* Scripts/Ulduar: Fix Stormcaller Brundir walking into walls

* Cleanup and fix logic + review

* Review: remove autos

(cherry picked from commit 876a848730)
2021-12-18 21:44:43 +01:00
Artamedes
0b43b43566 Scripts/ScarletMonastery: Rewrite Mograine and Whitemane encounter (#23761)
* Scripts/ScarletMonastery: Rewrite Mograine and Whitemane encounter

* qq

* qq 2

* tryfix circleci build

* review suggestions

(cherry picked from commit 832c95fa4f)
2021-12-18 21:41:10 +01:00
Artamedes
e4607725dd Scripts/Outland: Change auto to TempSummon* (#23764)
(cherry picked from commit 1b095811b8)
2021-12-18 21:37:15 +01:00
Artamedes
913f0903a3 Scripts/Outland: Fix npc_ancestral_wolf not starting waypoint (#23763)
* Scripts/Outlands: Fix npc_ancestral_wolf not starting waypoint, and also add a way to not follow owner automatically in CreatureAI::JustAppeared() for tempsummons

* fix nopch

(cherry picked from commit 0b3a9e2a2b)
2021-12-18 21:37:02 +01:00
Treeston
0bffed380d Scripts/ICC: Professor Putricide no longer tries to add threat on units it cannot add threat on because of immunity flags. Instead, its AI manually controls the engagement state. Should close #23727.
(cherry picked from commit 23fd193e4e)
2021-12-18 21:31:31 +01:00
Keader
9d3dd3db84 nopch fix
(cherry picked from commit 10f6e38185)
2021-12-18 21:18:56 +01:00
Keader
f2e03dc9e5 Core/Scripts: Proper fix Gal'Darah Puncture remove
(cherry picked from commit cbc01f35b6)
2021-12-18 21:18:44 +01:00
Keader
b7503b6c76 Fix nopch build
(cherry picked from commit 1886507e7f)
2021-12-18 21:16:51 +01:00
Keader
2d0d0a3e58 Scripts/Gundrak: Fixed Puncture when Gal'darah die
(cherry picked from commit 130a3859ec)
2021-12-18 21:16:40 +01:00
Keader
7c2665bdca Scripts/Gundrak: Added a missing entry in Gal Darah Stampede Charge script
Noob Keader, Shame !

(cherry picked from commit 61ad87d106)
2021-12-18 21:15:40 +01:00
Sorikoff
374db51bae Scripts/Spells: Code style adjustments for druid scripts (#23725)
(cherry picked from commit 63bbf4a4be)
2021-12-18 21:14:53 +01:00
Sorikoff
568e60ef51 Scripts/Spells: Port druid scripts to new script registration syntax (2 of 3) (#23696)
* Scripts/Spells: Port Druid Scripts to New Script Registration

* Revert

* Revert 2

* Revert 3

* Revert 4

(cherry picked from commit 9a8a01925a)
2021-12-18 21:11:58 +01:00
Shauren
8f3904f8fd Core/Map: Kill zoneId from RespawnInfo, all it did was significantly slow down startup to make one gm command faster
(cherry picked from commit 3a4216fd97)
2021-12-18 20:57:38 +01:00
Sorikoff
6cf301d4f6 Scripts/Spells: Port druid scripts to new script registration syntax (3 of 3) (#23714)
(cherry picked from commit f7793e7800)
2021-12-18 20:42:13 +01:00
Treeston
0b61c3b7b1 [3.3.5] Core/Authserver: TOTP rewrite: (PR #23633)
- Proper management commands (.account 2fa)
- Secrets can now be encrypted (set TOTPTokenSecret in .conf)
- Secret now stored in binary
- Argon2 and AES primitives
- Base32/64 support

(cherry picked from commit 4211645834)
2021-12-18 20:24:50 +01:00
Sorikoff
66f5275d26 Scripts/Spells: Runic Healing Injector (#23690)
* Scripts/Spells: Runic Healing Injector

* Rename 9999_99_99_99_world.sql to 2019_08_08_00_world.sql

(cherry picked from commit 382f563571)
2021-12-18 19:15:11 +01:00
Sorikoff
26f0c1182a Scripts/Spells: Port Part of Druid Scripts to New Script Registration (#23691)
(cherry picked from commit 996d4f7cc4)
2021-12-18 19:11:34 +01:00
Treeston
7704d8fc7a Scripts/Commands: Add .go boss, and do a usability pass over .go instance to match it.
(cherry picked from commit 57b36dfdc6)
2021-12-18 16:13:24 +01:00
Treeston
c7e7c52c1a Scripts/Commands: Cleanup some output from .go instance
(cherry picked from commit 4320a021e9)
2021-12-18 16:00:20 +01:00
Sorikoff
cd0fb6edbf Scripts/Blackrock Depths: Use DB Texts for Doom'rel (#23681)
* Scripts/Blackrock Depths: Use DB Texts for Doom'rel

* Quick Fix

(cherry picked from commit 33807a065a)
2021-12-18 15:36:00 +01:00
Treeston
51fbda4223 Core/Pooling: Quest pooling rewrite: (PR#23627)
- Split quest pooling from PoolMgr (into QuestPoolMgr)
- Proper saving/restoring on server restart
- No more hacking into sObjectMgr to insert/remove available quests

(cherry picked from commit a5e73e41c0)
2021-12-18 15:28:45 +01:00
Treeston
14c38a1c52 Core/Unit: Spell focusing now no longer nonsensical. HasSpellFocus always const. Error logs for various stuff.
(cherry picked from commit 4a219eda07)
2021-12-18 11:36:50 +01:00
aquadeus
da8d6b5180 Scripts/Spells: Fix Incanters Flow (#27395) 2021-12-18 11:24:10 +01:00
ccrs
a58881d6da Core/Unit: rename more methods
Workaround prework till actual facing system rework arrives

(cherry picked from commit 85ad0befc5)
2021-12-18 00:29:38 +01:00
ccrs
be4ed9152c Core/Unit: rename IsFocusing method
Workaround prework till actual facing system rework arrives

(cherry picked from commit ec9f15a5ff)
2021-12-18 00:25:14 +01:00
Wyrserth
75114dd820 Script/Hyjal: prevent Archimode from attacking players while invisible, and fix his scale (thanks Killyana!).
Closes #16424.

(cherry picked from commit 9da5e850f6)
2021-12-18 00:11:44 +01:00
Sorikoff
1fd0ba816f Scripts/Spells: Devour Humanoid (#23660)
(cherry picked from commit 0d53a0ba98)
2021-12-18 00:01:56 +01:00
Treeston
87786b1ebc Scripts/Hyjal: Seriously, who calls EnterEvadeMode in a AI constructor????
(cherry picked from commit c444cb17e1)
2021-12-17 23:57:18 +01:00
Treeston
8c3eb07889 Scripts/FollowerAI: Some cleanup:
- FollowerAI properly resumes follow after evading.
- Removed duplicated getters from CreatureAI (IsEscorted vs IsEscortNPC), they were used to do the same thing
- FollowerAI properly assists in combat.
- FollowerAI properly despawns if quest is abandoned.
- FollowerAI now supports dynamic respawning for escort NPCs.

(cherry picked from commit 3d4bebd8d9)
2021-12-17 23:05:55 +01:00
Treeston
917d9b7621 Scripts/ICC: Prevent Professor Putricide from displaying weird behavior during the Rotface/Festergut encounters as a result of his boss boundary
(cherry picked from commit 7fa990edc6)
2021-12-17 22:46:06 +01:00
Giacomo Pozzoni
77eaa2c1ac Scripts/Blood Furnace: Fix infinite loop in Broggok encounter
Fix infinite loop in Broggok encounter caused by https://github.com/TrinityCore/TrinityCore/pull/23300

(cherry picked from commit 30a4aca266)
2021-12-17 21:52:33 +01:00