Commit Graph

580 Commits

Author SHA1 Message Date
megamage
012d6fa865 [8381] Some refactoring work in Unit::m_currentSpells code. Author: VladimirMangos
* Restrict access, use enum args, move some repeated code parts to function.
    * Make m_selfContainer set only part of Unit::SetCurrentCastedSpell

--HG--
branch : trunk
2009-08-19 16:52:51 -05:00
megamage
6a9693a1e4 [8369] Some step back in triggered effect caster selection. Author: VladimirMangos
(I do not know what spells this will fix)

--HG--
branch : trunk
2009-08-17 15:54:39 -05:00
Machiavelli
43dc0c97d1 * Fix bug that player cannot receive credit for killing a creature if damage done to the creature by spell reflect >=49% of the creatures HP.
--HG--
branch : trunk
2009-08-17 06:02:01 +02:00
QAston
e2e70b936b *Cleanups and obsolete spell handlers remove.
--HG--
branch : trunk
2009-08-11 19:57:27 +02:00
megamage
462086f3b1 *Fix a bug that UNIT_STAT_CASTING is not cleared when delayed spells are casted.
--HG--
branch : trunk
2009-08-08 11:53:48 -05:00
QAston
6b4772207f *Cleanups, remove obsolete code and minor optimizations in spellauras.cpp and spelleffects.cpp
*Remove GetDummyAura(uint32 spellid) function - it is faster to use GetAuraEffect or GetAura if id is known than iterate threw dummy auras list
*Move Death Strike code from HandleDummyAuraProc to Spell::EffectDummy - original patch by hununza.

--HG--
branch : trunk
2009-08-08 16:18:05 +02:00
megamage
0f7b23070f *Fix a bug introduced in 3874. This makes IsNonMeleeSpellCasted cannot correctly check if caster is casting.
*This fixes the bug that Heigan chases players when he is channelling.

--HG--
branch : trunk
2009-08-07 16:12:50 -05:00
megamage
3549c0bddd *Check category instead of flags for some spells. Author: VladimirMangos
--HG--
branch : trunk
2009-08-07 14:40:37 -05:00
megamage
e3e09cc86a *Fix a typo.
--HG--
branch : trunk
2009-08-05 16:42:12 -05:00
megamage
907342d5b0 [8308] More generic code for new continent spell casting including fly form/mounts. Author: VladimirMangos
* Check new continent requirement by SPELL_ATTR_EX4_CAST_ONLY_IN_OUTLAND in
      SpellMgr::GetSpellAllowedInLocationError.
    * Also in this function let ignore any area requirement in GM-mode (except client side checks ofc if use spellbook/item)
    * For fly form/mount auras check only speciaal reqirement like special fly skill and ignore it for dead state.
    * Drop explicit fly auras drop at zone update, now this part GetSpellAllowedInLocationError functionality.
    * Allow in `spell_area` have data deepndent from ghost auras

    This all allow implement apply spells 55173/55164 to player ghost wiht DB support in `spell_area`

--HG--
branch : trunk
2009-08-05 16:33:34 -05:00
QAston
d7df4cfa09 *Fix Coyote Spirit Despawn Aura (52172) and Blood Parrot Despawn Aura (60244) - inspired by Disassembler's patch.
--HG--
branch : trunk
2009-08-05 17:00:01 +02:00
QAston
d883bf5b44 *Fix target selection for Ancestral Awakening and Replenishment - by Them
--HG--
branch : trunk
2009-08-05 04:37:19 +02:00
QAston
50ce9f8cfa *Correct implementation and use of dbc data for aura SPELL_AURA_CONVERT_RUNE(249)
*Fix Blood of the North, Reaping - original patch by thenecromancer
*Fix Death Rune Mastery.

--HG--
branch : trunk
2009-08-05 02:36:26 +02:00
QAston
d95e9c1027 *Fix Gargoyle feeding behaviour - original patch by thenecromancer.
*Add SPELL_TARGET_TYPE_CONTROLLED for spell_script_target table for fast search of units(grid search skipped) and to prevent applying effects to not owned summons

--HG--
branch : trunk
2009-08-04 19:28:31 +02:00
megamage
a1d5f174be Avoid target requirement checks for spells with caster base target selection (self,pet,around). Author: VladimirMangos
This fix cast fail for some spells, mostly triggered or scripted with unexpected prowided explicit tatrget different from caster.

--HG--
branch : trunk
2009-08-02 10:03:38 +08:00
megamage
e1571c0492 *Handle target area path as area cone for now.
--HG--
branch : trunk
2009-07-31 11:12:04 +08:00
QAston
a2701d589d *Correct some trap proc checks (do not threat trap cast as triggered)
*Fix a typo causing freeze.

--HG--
branch : trunk
2009-07-30 19:07:51 +02:00
megamage
af2d5e3fd4 [8250] Cleanup code and data for spell_threat Author: nos4r2zod
* Load table data to std::map instead SQLStorage and add check loaded spell existance.
    * Drop from table not existed spells.

--HG--
branch : trunk
2009-07-30 11:37:08 +08:00
QAston
c15c25aca4 *Cleanups and Fixes in Mirror Image script.
--HG--
branch : trunk
2009-07-28 21:34:18 +02:00
QAston
288fe6ef21 *Restore correct drop of charges after EventAi cancast fix.
--HG--
branch : trunk
2009-07-28 14:53:08 +02:00
QAston
40b9fc57ed *Do not allow to cast corpse explosion twice on one corpse - by thenecromancer.
--HG--
branch : trunk
2009-07-27 19:08:26 +02:00
QAston
1630842f03 *Spell_bonus_data for Shattering throw and Hand of Reckogning
*Do not check SPELL_ATTR_EX_CANT_TARGET_SELF for triggered spells

--HG--
branch : trunk
2009-07-27 11:07:15 +02:00
QAston
4a17224a65 *Creature eventAI cancast power check - by smellbee.
--HG--
branch : trunk
2009-07-23 18:32:32 +02:00
QAston
91c309387a *Implement attribute flag SPELL_ATTR_EX_CANT_TARGET_SELF.
--HG--
branch : trunk
2009-07-18 18:44:16 +02:00
megamage
e152ff8ec5 [8183] Some gameobject despanw related fixes Author: VladimirMangos
* Implement use `consumable` field in gameobject template for gameobject required explcit despawn at use.
    * Move gameobject template fields cech function from Gameobject to gameobject template class, and update callers.
    * Cast spells at gameobject use with gameobject guid as original caster guid, as already used in some other cases. (skipped)

--HG--
branch : trunk
2009-07-16 12:06:07 +08:00
megamage
208087ff6e [8182] Store and use Map* pointer in WorldObject instead map ids for speedup Author: Ambal
Also some code logic cleanups.
    Changes let make more cleanups in base map access and other places,
    but this chnages not inlcuded in patch.

*This patch may cause crash.

--HG--
branch : trunk
2009-07-16 11:49:00 +08:00
QAston
87ca52c2a9 *Do not allow spells having damage to break root casted by the spell.
*Typohunt: wand skill gain, Improved spell reflection aura drop from party.

--HG--
branch : trunk
2009-07-14 18:31:59 +02:00
QAston
2f5befd26a *Move target selection check for Death Coil to Spell::CheckCast - by Astellar
--HG--
branch : trunk
2009-07-14 13:26:28 +02:00
QAston
310f15e546 *Make charge-like spells with talented warbringer correctly remove movement impairing auras.
*Fix Revitalize.
*Use MaxHp of target instead of base hp for CC auras amount.

--HG--
branch : trunk
2009-07-13 21:27:05 +02:00
QAston
aee2b18160 *Set pvp flag for spells with SPELL_ATTR_EX3_NO_INITIAL_AGGRO if needed.
--HG--
branch : trunk
2009-07-13 15:38:48 +02:00
megamage
bd02855bb6 *Try to fix a crash caused by charm spells. Do not allow to apply charm aura on invalid target.
--HG--
branch : trunk
2009-07-12 17:34:37 +08:00
QAston
84644b7644 *Some improvements in procflags:
-handle proc_flag_death
 -allow trap selection in spell proc event entry for proc_flag_on_trap
*Add spell_proc_event entry for Lock and Load - by Bengan
*Add spell_proc_event entry for Improved Spell Reflection.

--HG--
branch : trunk
2009-07-11 20:06:02 +02:00
Kudlaty
a15748df60 Rewrite script for quest 12680
Add support for spells 52267 and 52264
Thanks to Drethek for patch

--HG--
branch : trunk
2009-07-11 02:03:20 +02:00
megamage
9d77c5736d [8131] Some anti-cheating server side checks. Author: Lightguard
* Loot in ghost state
    * Apply duplicate glyphs.

--HG--
branch : trunk
2009-07-10 08:34:28 +08:00
QAston
f829ee0dc0 *Correct target requirement for eyes of the beast and add some crash preventing checks to charm code.
--HG--
branch : trunk
2009-07-08 22:26:46 +02:00
thenecromancer
e208f8750d *fix some addons tracking autoshot cooldown
--HG--
branch : trunk
2009-07-08 14:34:15 +02:00
QAston
68b58c1433 *Implement attribute flag SPELL_ATTR_EX3_DISABLE_PROC - this fixes double proc of seal auras
*Add Judgement Anti-Parry/Dodge Passive spell for paladins.

--HG--
branch : trunk
2009-07-08 13:00:08 +02:00
QAston
f28810576d *Fix the bug that freezing trap has not diminished duration.
--HG--
branch : trunk
2009-07-08 00:16:51 +02:00
QAston
69f013db89 *Fix Improved Aspect of the Hawk.
--HG--
branch : trunk
2009-07-07 21:02:21 +02:00
QAston
6e3b4b5a4f *Do not apply fear diminishings for creatures.
*Remove obsolete code for blood fury - by maxdestroyer.

--HG--
branch : trunk
2009-07-07 16:40:44 +02:00
QAston
67f8ec608c *Allow dest target spells to proc spellcast.
*Allow source target spells to be triggered during spellproc if no unit target avalible.

--HG--
branch : trunk
2009-07-05 16:58:42 +02:00
QAston
3225eb9648 *Redefine procflags:
PROC_FLAG_SUCCESSFUL_POSITIVE_MAGIC_SPELL = 0x00004000
PROC_FLAG_TAKEN_POSITIVE_MAGIC_SPELL      = 0x00008000
PROC_FLAG_SUCCESSFUL_NEGATIVE_MAGIC_SPELL = 0x00010000
PROC_FLAG_TAKEN_NEGATIVE_MAGIC_SPELL      = 0x00020000
*Add procEx flag:
PROC_EX_NOT_ACTIVE_SPELL    = 0x0008000 for spells which proc on spells not doing damage and not specified by familyflags.

--HG--
branch : trunk
2009-07-02 21:32:19 +02:00
QAston
7a4d99cc90 *Fix 'crazy procs' issue and shadowstep remove on stealth.
--HG--
branch : trunk
2009-07-02 14:13:30 +02:00
megamage
255d21b52b [8088] Fixed min_range checking for spell casts. Author: ApoC
Skip in check values 0.0f from DBC, this spells
    do not have min range limitation.

    This should fix some inappropriate target too close messages.

--HG--
branch : trunk
2009-07-01 17:34:09 -05:00
megamage
177297973a *Fix a crash caused by charm spells.
--HG--
branch : trunk
2009-07-01 17:30:01 -05:00
QAston
fd86e6a369 *Fix possible exploits with flying paths.
--HG--
branch : trunk
2009-07-01 16:18:37 +02:00
QAston
55a4458009 *Fix a typo causing problems with triggered spell procing.
*More correct damage calculation for conflagrate - by tlexii

--HG--
branch : trunk
2009-06-30 15:45:47 +02:00
QAston
6faa99e009 *Correct typo in spellid check for Corpse Explosion.
--HG--
branch : trunk
2009-06-30 13:58:39 +02:00
QAston
24efcabdd9 Remove cooldown of spells triggered on stance change - this fixes shadowform dot crit.
--HG--
branch : trunk
2009-06-30 13:51:53 +02:00
QAston
8609527066 *Fix the issue of water elemental GCD preventing freeze to be casted - by Larva
*Correct a typo in prev commit.

--HG--
branch : trunk
2009-06-29 20:50:38 +02:00