Commit Graph

27916 Commits

Author SHA1 Message Date
Shauren
023d252155 Revert "Core/Groups: fix wrong query for loading group instance data. canReset attribute was calculated in the wrong way"
This reverts commit 0c1dd398bd.

Closes #19745
2017-06-01 23:17:11 +02:00
Keader
ed43883160 Core/Spells: Removed duplicated check again followup 3a0417f712
to send some info to client
2017-06-01 09:08:01 -03:00
Keader
3a0417f712 Core/Spells: Removed duplicated check
unitTarget was checked twice in Spell::EffectTaunt
2017-06-01 09:04:40 -03:00
ariel-
ce3787f190 Core/AI: Factory functions cleanup
- Get rid of fugly void pointers
- Streamlined AI selection code, using Permissible as it should've been instead of harcoded checks on the selector code
- Moved IdleMovementGenerator singleton to factory code
2017-06-01 02:29:20 -03:00
treeston
aeaa8ecfab Fix an issue where CanSpawn would never get invoked on creatures without per-guid script. 2017-05-31 14:03:48 +02:00
treeston
302a039b7c Add another helper to ScriptedGossip.h for resolving listId -> action. 2017-05-30 21:50:49 +02:00
sirikfoll
aa6cd460ee DB/Creature: Add missing values in creature_model_info for Ulduar bosses 2017-05-29 20:12:11 -03:00
sirikfoll
1cc0458b11 Core/Scripts Properly set Freya's BossState do DONE and avoid some loot exploits
Closes #19823
2017-05-29 19:20:13 -03:00
ForesterDev
dd4ff1fe54 Scripts/Command: implement .debug play music command
Closes #19809
2017-05-29 23:17:49 +02:00
Treeston
69fd6245dc Partial revert of 15a207f, which was causing issues (ref #4943 and #19768). Instead, fix the underlying issue from 15a207f one level further down - Unit::getAttackerForHelper() shouldn't return units that we aren't in combat with (victim can be such a unit for players/player pets, which can startattack from a distance without entering combat). (#19814)
Fixes the following issues:
- Player pets would aggro neutral mobs as soon as they start autocasting (Imp's Firebolt) if they're in react range (due to victim != null, autocast counts as autoattack and sets victim)
- Neutral mobs would randomly evade when aggro switched between targets.

Closes #19768, #19485 and #10921.

(from PR #19814)
2017-05-29 16:39:20 +02:00
Killyana
60a69bcd3d DB: Add some missing Broadcast Text 2017-05-29 00:51:46 +02:00
ariel-
79d0868604 DB/Spell: fix Deep Freeze proc
Closes #19780
2017-05-28 18:19:42 -03:00
ariel-
63e502a67d Core/Spell: in case of immunity, check all effects to choose correct procFlags, as none has technically hit 2017-05-28 18:19:15 -03:00
Treeston
1945874f96 Fix evade issues when a spell hits the target just before evading. (#19815)
- Creatures should no longer get stuck in evade mode following a target if a spell hits the creature just as it's entering evade mode.
- Fixes and closes #4943. Finally.
2017-05-28 17:18:22 -03:00
Dr-J
607686a912 DB/Conditions: Charles Worth
Correct conditions for gossip 

closes #19516
2017-05-28 19:18:41 +01:00
tkrokli
c37eee532e DB/creature: fix invalid equipment on Caynrus (creature ID 4240)
* Since 2014_03_30_04_world_creature_equip_template.sql,
  Caynrus <Shield Merchant> has erroneously been equipped with
  item ID 1961 (Monster - Shield, Buckler Wooden) and in wrong hand,
  making the item look like a blue & white box ("unobtainium").

  Instead of moving the buckler to his off-hand slot,
  he gets his 2H Bent Staff (item ID 35) back.

  His equipped item was removed in Cataclysm, patch 4.0.3a.
2017-05-28 19:18:28 +02:00
Killyana
7f1315f77d DB/Creature: Remove double spawns from Death Knights area 2017-05-28 18:09:07 +02:00
Dr-J
f2c351158b DB/SAI: Add some missing charmed flags
DB/SAI: Add missing charmed flags to blight geists which is required for when they are charmed as part of it roll's downhill.
2017-05-28 11:43:08 +01:00
ariel-
69a1386ddb Core/Pools: fix VS dynamic linking 2017-05-27 21:13:03 -03:00
ariel-
c3d0a3c1a8 Core/Misc: fix some clang 5 warnings 2017-05-27 17:23:05 -03:00
treeston
1c528c30f8 Quickfix a bug introduced by 2f19d97 which prevented GTAoE from being cast. 2017-05-27 21:05:26 +02:00
treeston
b6a4e9f3f9 Instances/Ulduar: Fix a super edge case bug where Algalon would evade if his tank successfully tanked a Cosmic Smash and got knocked up. Shadow priests everywhere rejoiced. 2017-05-27 20:49:24 +02:00
ariel-
f2b0819e53 Core/SmartAI: allow SMART_ACTION_SEND_GOSSIP_MENU to override default gossip
Closes #19769
2017-05-27 03:56:09 -03:00
ariel-
e27c385b48 Core/Spell: fixed some problems with per caster aura states
- Update clients whenever target has more than one application of an aura that applies such aurastate
- Update again when one application gets removed
- Fixed Fire and Brimstone computing damage if any warlock applied the Immolate (should only count for own)

Closes #19790
2017-05-27 03:16:47 -03:00
ariel-
47d387d6b0 Core/Creature: fix _DespawnAtEvade saving wrong respawn time
Closes #19557
2017-05-27 02:21:06 -03:00
ariel-
2f19d97d21 Core/Spell: abort channeling if no valid targets are found after searching
Closes #17624
2017-05-27 01:40:14 -03:00
ariel-
d9a1c82ab4 Scripts/VioletHold: fix stack overflow when reflecting 'Splash'
Closes #19514
2017-05-27 00:39:32 -03:00
ariel-
44381a7873 Core/PlayerDump: use extent 2017-05-26 13:30:24 -03:00
ariel-
4bf8802da1 Core/PlayerDump: more travis 2017-05-26 12:42:05 -03:00
ariel-
545f1a8385 Core/PlayerDump: Travis fix 2017-05-26 12:27:20 -03:00
ariel-
9bdbd69655 Core/PlayerDump: general revamping
- Changed insert queries to include column names, check columns on dump load
- Modify and search columns by name instead of storing magic offsets
- Fully forward and backward compatible with previous dumps
- Added better logs, C++11-ize code
2017-05-26 12:06:38 -03:00
Keader
4fcea41519 DB/Spells: Fixed Paladin T8 Holy 2P Bonus proc
Close #19796
2017-05-25 17:12:08 -03:00
Dr-J
a261056f58 DB/SAI: Tormenting the softknuckles
Fix script so that if player does not sucessfully kill the hardknuckle matriach it does not remain hostile as an invisible mob to players doing damage to players who get in agro range.
2017-05-25 12:03:41 +01:00
Killyana
66bd3459e4 DB/GamObject: Sons of Hodir Gameobject quest givers Visibility
Closes #19787
2017-05-24 17:03:39 +02:00
Killyana
b90fc70c20 DB/Quest: Blowing Hodir's Horn requirement
Ref #19787
2017-05-24 02:13:12 +02:00
ariel-
d03e97d53f Core/Player: update interaction checks, some info taken from client 2017-05-23 20:18:45 -03:00
Aokromes
3b8f85fd81 DB/Commands: Typo in account set gmlevel help field
Closes #19448 by Heaven31415
2017-05-23 23:29:18 +02:00
Shauren
9ec2a82cac Core/Misc: Prefix all preprocessor defines from CompilerDefs with TRINITY_ to avoid conflicts (PLATFORM_WINDOWS is used/defined by CascLib)
(cherry picked from commit b8db320bf1)
2017-05-23 18:46:44 +02:00
DoctorKraft
04dfd78dac Core/Hotswap: Fix Reload on Linux
* Closes #19465
2017-05-23 18:17:40 +02:00
Shauren
cb5d22a6cb Core/Hotswap: Replace #ifdef conditions with comparisons of values defined in CompilerDefs.h
(cherry picked from commit 43510a258c)
2017-05-23 18:16:02 +02:00
Naios
5032fb462e Build: Fix a build error which happened on unix debug builds
* Thanks DDuarte for the fix
* Closes #19786
2017-05-23 17:45:52 +02:00
Aokromes
195db7c7bb Fix build 2017-05-23 12:53:11 +02:00
ForesterDev
abea8bf4cb Core/Defines: define faction templates and replace magic numbers from scripts 2017-05-23 12:30:27 +02:00
Killyana
d96482b2d4 DB/Creature: Blightguard spawns 2017-05-22 21:37:26 +02:00
ccrs
7afe0b7fb0 Scripts/ICC: add missing cases for Dark Martyrdom difficulty entries
how come nobody noticed this?
2017-05-19 13:49:49 +02:00
Aokromes
edd2c1c039 Update showoptions.cmake 2017-05-17 08:08:46 +02:00
Killyana
586cc0e0b4 DB: Fix some DB errors 2017-05-17 06:07:01 +02:00
ariel-
4a69f5bda5 Core/Scripts: improvements on the Thorim script
Improvements done to initial work by joschiwald:

- Fixed stormhammer casting and visuals
- Fixed spell credits
- Implemented removal of Impale when HP is higher than 90%
- Corrected faction templates for the pre combat creatures
- Implemeted Leap on the arena adds (thanks to joschiwald for implementing conditions)
- Scripted lighting charge using AuraScript periodic
- Fixed timings
- Corrections on the hallway encounters (added knockback immunity to minibosses too)
- Fixed multiple blizzards issue
- Lever will now reset properly, should players fail to get inside. This allows the door to be opened more than once during the combat
- Corrections in the outro event
- Implemented paralytic field traps on the hallway.
- Implemented Ancient Gate of the Keepers opening.
- Changed blizzard bunny targetting to conditions entirely.
- Removed obsolete scripts
- Standards: delete spell script names by ScriptName instead of spell_id
- Swapped factions for pre-adds (alliance should get horde trash and vs)
- Fixed Leap setting home position for adds
- Removed a bunch of magic numbers
- Runic Colossus should finish current Runic Explosion before beginning to attack
- Fixed UpdateAI logic to put it in line with other scripts (ie don't stop casts)

Special thanks to:
- chaodhib for the blizzard trigger waypoints and investigation on spell radius
- Malcrom for creating the Conditions Creator :P

Closes #15008
Closes #17072
2017-05-16 20:23:52 -03:00
joschiwald
5e90c76fd4 Scripts/Ulduar: Initial implementation of the Thorim Encounter
Closes #7651

Fix logic fail in achievement:
SPELL_LIGHTNING_CHARGE aka 62279 is casted on Thorim itself to buff him, not the damage spell tracked by the achievement.
2017-05-16 20:17:58 -03:00
Aokromes
b702e0eabd DB/Gameobject: Fix 3 startup errors 2017-05-16 07:52:09 +02:00