Commit Graph

21225 Commits

Author SHA1 Message Date
treeston
08b78720bb PvP/Dueling: Fix an edge case crash that could happen if a duel ended while an aura effect was being removed (Living Bomb, Unstable Affliction and similar). Closes #17177. 2016-07-20 15:49:23 +02:00
tkrokli
d1333835f7 Core/Scripts: boss_majordomo hardcoded text
2 more text lines removed in the ongoing series:
"Remove hardcoded text from core scripts".

Core script for boss Majordomo Executus:
- add missing gossip_menu_option entries
- link the options via the table gossip_menu
- remove hardcoded text from the script
- minor enum line order sorting cleanup
- replace OnGossipSelect() with sGossipSelect()

The scripted events are unchanged.
If the script is inaccurate, make a new PR.
2016-07-20 15:48:14 +02:00
treeston
3708204f9b Scripts/BlackrockMountain: Nefarian. (#16346 f-u) 2016-07-20 15:47:18 +02:00
treeston
e8a145d1ac Scripts/MoltenCore: Fix Ragnaros (#16346 follow-up). 2016-07-20 15:47:07 +02:00
treeston
af864282a6 Scripts/Instances: More #16346 follow-ups. Fixed this time: Halls of Reflection, Ignis the Furnace Master, Mimiron and Rend Blackhand. 2016-07-20 15:46:53 +02:00
Snapper
7185ae680c Core/SmartAI: delay SMART_ACTION_FLEE_FOR_ASSIST if creature is rooted/stunned.
Prevents creatures from teleporting around when fleeing while stunned/rooted.
2016-07-20 15:46:31 +02:00
jackpoz
d9f485273c Core/VMaps: Fix some vmap height edge cases
Fix Map::GetWaterOrGroundLevel() checking dynamic object only in phase 1 instead of current Unit phase.
Improve DynamicMapTree::getHeight() dynamic object check by casting the ray at +0.5f from the passed Z coordinate, this value will be tuned to improve even more the results.
2016-07-20 15:45:05 +02:00
treeston
ff2e59e15c Compiler warning fix. 2016-07-20 15:43:16 +02:00
treeston
0f0b795c50 Scripts/TotC: More follow-up to #16346. Also code style cleanup. Who names all their creature pointers "temp"? 2016-07-20 15:42:51 +02:00
treeston
1f801908f0 Scripts/Instances: Follow-up to #16346. Fix Illidan and Northrend Beasts. 2016-07-20 15:42:24 +02:00
treeston
2f15b10342 AI/PlayerAI: Fix potential edge case crash. 2016-07-20 15:41:57 +02:00
Aokromes
2387591f1a Core/Creatures: Remove resetting of UNIT_FLAG_IMMUNE_TO_PC on combat clearing 2016-07-20 15:39:16 +02:00
Aokromes
d59e84fcb2 Core/SmartAI: Allow SMART_ACTION_FORCE_DESPAWN on no-SmartAI GameObjects 2016-07-20 15:33:33 +02:00
treeston
7490ca5eab Scripts/Naxxramas: Fix Frogger event. Closes #16488. 2016-07-20 15:31:45 +02:00
Aokromes
e9c6ddbf8b Core/DB/Updater: engrish corrections in DBUpdater.cpp (#17262)
English grammar and syntax corrections in DBUpdater.cpp
- string texts corrected, source code unchanged
- comments improved and checked for typos
2016-07-20 15:29:45 +02:00
treeston
34ad561ff5 AI/PlayerAI: Code style cleanup. 2016-07-20 15:23:58 +02:00
Aokromes
00fa7d03ed AI/PlayerAI: Finally implement cast logic for controlled players. 2016-07-20 15:19:53 +02:00
Aokromes
59b4b36bdc Core/World: Remove unused config CONFIG_SIGHT_GUARDER 2016-07-20 14:45:41 +02:00
Aokromes
7cc54c08bb Revert "Merge pull request #16433 from Tonghost/3.3.5"
This reverts commit e3d5299, reversing
changes made to 6d8e39f.
2016-07-20 14:39:58 +02:00
Aokromes
20ac85954b Core/Quests: Remove wrong call to SendQuestComplete() 2016-07-20 14:30:52 +02:00
Aokromes
0fc8ecf7c2 another build fix 2016-07-20 14:22:55 +02:00
Aokromes
74cb8608c3 compile fix 2016-07-20 14:16:33 +02:00
Shauren
5942d4da0a Core/Scripts: build fix 2016-07-20 14:15:04 +02:00
Aokromes
d3083df169 Core/Guilds: Fix Guild::HandleSetMemberNote logic according to method declaration. (#17078)
This change has no effect on server behavior.
2016-07-20 14:02:11 +02:00
Shauren
e58f0e805c Core/Units: Renamed and documented UNIT_FLAG_DISABLE_MOVE to prevent people from trying to use this flag to root a creature leaving them wondering why it doesn't do anything 2016-07-20 13:56:16 +02:00
Trond B Krokli
d716e6049a [3.3.5] Core/Spell: restore old pet values after dismount (#16551)
* Core/Spell: restore old pet values after dismount & re-summon
Original PR #15667 by ghost

Closes #873
2016-07-20 13:54:49 +02:00
Shauren
85e2bf54eb Core/Loot: Fixed resaving looted items from containers
Closes #15299
2016-07-20 13:51:07 +02:00
Shauren
1aed8daf9a Core/Spells: Implemented SPELL_ATTR1_DISMISS_PET
Closes #7372
2016-07-20 13:50:29 +02:00
Aokromes
006d89310b Core: updated creature type flags enum (#17128)
Core/Misc: Update CreatureTypeFlags enum according to TrinityCoreWiki
2016-07-20 13:47:25 +02:00
sirikfoll
712baeba27 Core/Unit Do not allow addition of threat to units in evade mode 2016-07-20 13:29:22 +02:00
treeston
1bd85c1a9b Conditions/ConditionMgr: Add a comment so MitchesD can go away. 2016-07-20 13:29:05 +02:00
Shauren
f11a9a31c2 Core/Containers: Warning fixes and RandomResizeList with predicate optimization 2016-07-20 13:28:41 +02:00
Alan Deutscher
fabc7f02dd Core/Spells Make certain spells (e.g. Mind Control) properly flag the caster for PvP (#17145)
* This issue was caused by PvP-flagging being done calculated after the target's flag was turned off by becoming a pet.
2016-07-20 13:22:13 +02:00
Shauren
0233ced55e Core/Auras: Implemented auras SPELL_AURA_PREVENT_DURABILITY_LOSS and SPELL_AURA_PREVENT_DURABILITY_LOSS_FROM_COMBAT
(cherry picked from commit 17118f4832)
2016-07-20 13:21:47 +02:00
Aokromes
218fe7ba24 Core/Spells: Perform proc roll after all conditions passed to only consume spellmods when the aura is allowed to proc in the first place 2016-07-20 13:16:27 +02:00
Shauren
5c6802d509 Core/Spells: Fixed flat SPELLMOD_DAMAGE_MULTIPLIER calculation
(cherry picked from commit 35ab476f16)
2016-07-20 13:04:59 +02:00
Aokromes
7fcaf84c49 Core/Spells: Fixed spell mod application order 2016-07-20 13:03:43 +02:00
ForesterDev
43e1534a7b improve error message 2016-07-20 12:57:45 +02:00
joschiwald
65184de143 Makes travis happy 2016-07-20 12:55:52 +02:00
joschiwald
1e092ee8e2 Scripts/Freya: removed obsolete code 2016-07-20 12:53:39 +02:00
Aokromes
11636faadf Core: define CREATURE_FAMILY_NONE to avoid magic numbers in code 2016-07-20 12:49:38 +02:00
vincent-michael
dadd81afe0 Core/Quests: Fixed issue reported by static analysis
Coverity defect ID: 1355241
2016-07-20 11:01:10 +02:00
mik1893
13c5e4be65 Core/Spells: Fix Blood Tap activation when Blood Rune is in cooldown as Death Rune (#17132) 2016-07-20 11:00:56 +02:00
mik1893
4f6c7158a1 Core/Unit: Pet shouldn't be notified for DOT damage on the owner (#17133)
- Fix by @MrSmite
- Closes #16894
2016-07-20 11:00:40 +02:00
r00ty-tc
d219b18c68 Core/Cinematic: Optimize cinematic loading
- Remove pointless cast string->char*->string
2016-07-20 10:59:53 +02:00
Aokromes
0db05c610c Coverity: Correct two static analysis catches
#1355242 - Uninitialized scalar field
 #1355240 Resource leak in object
2016-07-20 10:59:10 +02:00
treeston
330167da7a Seriously, who doesn't support std::string instead of char* in 2016? 2016-07-20 10:49:52 +02:00
treeston
7279304c7c Add a LOG_WARN when attempting to summon a non-existing summon group. 2016-07-20 10:49:36 +02:00
treeston
ee10877d52 Allow BossAI::_DespawnAtEvade to work on creatures other than the boss itself (optional argument). 2016-07-20 10:48:44 +02:00
treeston
ef80fbd6c0 Core/Scripts: Added reasonable default params to GetCreatureListWithEntryInGrid/GetGameObjectListWithEntryInGrid for ease of use. Also, entry = 0 means no filter now, since we lacked an easy way to get a list of all creatures in grid. 2016-07-20 10:48:23 +02:00