Commit Graph

26895 Commits

Author SHA1 Message Date
Ovahlord
0c15b2ac7c Core/Objects: fixed destination calculation for destination based spells casted by flying units
* Additionally he PathGenerator will now check for realtime movement flags instead of creature based template data only so scripted flying movement and players will now correctly get their path calculated

(cherry picked from commit fdcb7388a6)
2022-01-04 15:33:04 +01:00
Shauren
98272944ee Core/Commands: Fixed .npc add overwriting existing spawns when used on transports
(cherry picked from commit 75ab3619bd)
2022-01-04 15:33:04 +01:00
Giacomo Pozzoni
9cb01a7904 Fixes/3.3.5 aura infinite loop (#24631)
* Core/Auras: Attempt to fix infinite loop with aura 18950 on map unload

* Core/Auras: Log a detailed error and assert when failing to remove all auras after a few tries

* Code cleanup

* Fix build warnings

* Fix more build warnings

(cherry picked from commit bd2d60c267)
2022-01-04 15:33:04 +01:00
joshwhedon
e95215e9ae Removing a duplicate item combat spell handling causing poisons (and others) to proc twice. (#24627)
https://github.com/TrinityCore/TrinityCore/issues/24608
(cherry picked from commit 4db77bc913)
2022-01-04 15:33:04 +01:00
Giacomo Pozzoni
89afeed41b Core/MMAPs: Adjust walkable climb and fix a lot of mmap raycast issues (#24539)
* Core/MMAPs: Adjust walkable climb

Adjust walkable climb as recast using walkableClimb also to find the poly from a position, giving priority to polys that are below the position but closer than walkableClimb.

* Temporarily disable static collision (the whole check should be removed)

* Core/Spells: removed deprecated mmap path check for TARGET_DEST_CASTER_FRONT_LEAP

* Core/Objects: allow flying units to use the helper as well (flying units casting radius based spells)

* Code refactor

* Handle raycasts that end in a point with no height in the mmap mesh as PATHFIND_NOPATH

* Walk back a bit from raycast hitpoints as sometime the 2D result point is outside of the polygons due to floating point errors.

* Remove whitespace

* Revert 4a197ba22a as a raycast point path should have the Z retrieved with getPolyHeight(). Raycast will only return a 2-point path with Start and Hitpoint/End

* Cleanup PathGenerator raycast case

* Fix PathGenerator raycast broken if start and end are on same poly.
Fix PathGenerator raycast broken if no wall is hit.
Remove unused case of using raycast with an existing previous path (can be added back properly if needed).
Remove forcing poly length to 2 when we actually have already the right number.

* Use closestPointOnPolyBoundary on the second try of finding a point on poly for raycast.
Note that in this case the mesh height is not used which might cause issues. The poly boundary height will be used instead.

* Handle cases where getPolyHeight() fails because the point is on polygon border (and caused by floating point imprecision)

* Add far from poly flags

* Set PATHFIND_INCOMPLETE in raycast case if startFarFromPoly or endFarFromPoly

* Fix blink close to walls with no valid polygon behind the wall

* Require to re-extract mmaps

Co-authored-by: Ovah <dreadkiller@gmx.de>
(cherry picked from commit c0b75bf40d)
2022-01-04 15:33:04 +01:00
HelloKitty
406c7219ad Further improve ChrRace DBC handling (#24508)
* Core/DBC: Added ChrRacesAllianceType for ChrRaces.dbc

* Core/Character: Check ChrRace DBC playable in HandleCharCreateOpcode

* Core/DBC: Implement ChrRacesFlags removing literals

Cannot take credit for this enum, derived from documentation in
https://wowdev.wiki/DB/ChrRaces

* Core/Character: Check CHRRACES_FLAGS_NOT_PLAYABLE on creation

* Core/DBC: Fix formatting of ChrRaces enums

* Core/DBC: Use ChrRaces CreatureType instead of hardcoded humanoid assumption

* Address enum style code changes

(cherry picked from commit 43b595111d)
2022-01-04 15:33:04 +01:00
Shauren
5e37b1cd5d Scripts/Icecrown Citadel: Fixed Professor Putricide oozes not moving during their channel
(cherry picked from commit 1d43003cfa)
2022-01-04 15:33:04 +01:00
Metalaka
d62886685b Core/CreatureAI: Shambling Horror re-cast Enrage as soon as it is not stun (#24618)
(cherry picked from commit e2434e4f47)
2022-01-04 15:33:04 +01:00
ccrs
9fd26c5f09 Core/Movement: 9080e78 followup
actually port back the previous implementation, now correctly
this implies that a unit that has a different victim than the one its chasing will stand still till either:
- a new movement replaces the current, for w/e reason
- the chase target is again the current victim

probably a pause implementation on the generator is a more elegant solution...

updates #24600

(cherry picked from commit 472e1fd8ae)
2022-01-04 15:33:04 +01:00
Jildor
9d27de8b80 DB/Spell: Arm Dead Damage Kologarn
Closes #24577

(cherry picked from commit 9170567218)
2022-01-04 00:55:07 +01:00
Shauren
c0f976d23d Core/Spells: Added helper function to select random injured healing spell targets 2022-01-03 13:07:30 +01:00
Shauren
08b5a0586a Core/Util: Added iterator range overload for Trinity::Containers::RandomShuffle 2022-01-03 12:48:40 +01:00
Shauren
3a67e37681 Core/Time: Remove artificially high minimal update intervals 2022-01-03 11:26:23 +01:00
Sorikoff
74174332c6 Scripts/Pet: Lil' K.T (#24528)
* Lil' K.T.

* Rename 9999_99_99_99_world_335.sql to 2020_05_10_00_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 34fecde022)
2022-01-02 19:24:18 +01:00
Shauren
d30e4a20e5 Core/Misc: Define and use ChrRacesFlag and CreatureModelDataFlags (ref 772f506a3b) 2022-01-02 19:14:32 +01:00
Shauren
d56d92fbe7 Core/Units: Allow mind controlling non-controllable vehicles (for example players that become vehicle during boss encounters or creatures that only are vehicles to show non standard power type)
Closes #24562

(cherry picked from commit 1fecbc6892)
2022-01-02 16:17:18 +01:00
NoName
0aa98a5bc9 Core/Maps: fix respawn times for manual respawns (#24571)
by joshwhedon

(cherry picked from commit 5bbab32793)
2022-01-02 13:56:18 +01:00
ccrs
b9bb07de03 Core/Movement: modify MovementInform trigger condition & checks in ChaseMovementGenerator
(cherry picked from commit ac12bd1391)
2022-01-02 00:41:22 +01:00
ccrs
06334ab734 Core/Movement: de832b6 followup
lets keep that failsafe there, doesnt hurt

(cherry picked from commit 71ed2e5d5e)
2022-01-02 00:30:33 +01:00
ccrs
e6c0022a4d Core/Movement: modify MovementInform trigger condition & checks in FollowMovementGenerator
ref #24552

(cherry picked from commit de832b6980)
2022-01-02 00:30:33 +01:00
Shauren
6413466693 Core/Spells: Relaxed aura exclusivity check to allow casting spells that have other, non-aura effects even if aura will not be applied
Closes #24553

(cherry picked from commit 829cf38c67)
2022-01-02 00:30:31 +01:00
ccrs
875da43780 Core/Movement: 0e2342c followup
(cherry picked from commit b8422e667b)
2022-01-02 00:22:57 +01:00
Ovahlord
b8e1de0f92 Core/Objects: use the static vmap check in MovePositionToFirstCollision for all path results to avoid falling below wmo surfaces when the mmap path returns unreliable data
(cherry picked from commit a548d9f9b0)
2022-01-01 23:49:31 +01:00
Shauren
6d94bc2f4b Core/Spells: Fixed refreshing stat buff auras that have been improved by talents
Closes #24527

(cherry picked from commit 978745220a)
2022-01-01 23:45:39 +01:00
Ovah
26e7da1622 Core/Objects: further improvements for MovePositionToFirstCollision (#24523)
* Core/Objects: further improvements for MovePositionToFirstCollision

* the PathGenerator will now normalize incomplete destinations as well
* normalize destination positions before launching detour raycasts to get better direction data
* exclude unwanted pathfinding results from further use to avoid unintended behaivior

* Core/PathFinding: Split PATHFIND_FARFROMPOLY into PATHFIND_FARFROMPOLY_START and PATHFIND_FARFROMPOLY_END for start and end position

Handle PATHFIND_FARFROMPOLY_END as valid in MovePositionToFirstCollision

Co-authored-by: jackpoz <giacomopoz@gmail.com>
(cherry picked from commit 6485422c61)
2022-01-01 23:30:48 +01:00
offl
f32f812e29 DB/Quest: Becoming a Spellfire Tailor
Closes #24522

(cherry picked from commit 9638f0ad0b)
2022-01-01 23:22:09 +01:00
Ovahlord
b8805f4389 Core/Objects: optimize and improve MovePositionToFirstCollision results
* removed redundant static LOS checks as they are covered by the mmap raycast prior to the check
* removed unnecessary VMap height lookups to determine rapid falloffs as they are covered by the mmap raycast as well

(cherry picked from commit cf849df50a)
2022-01-01 23:19:31 +01:00
ForesterDev
9d38eeec7e Core/Player: add helper methods for PLAYER_FLAGS_DEVELOPER (#24511)
* Core/Player: add helper methods for PLAYER_FLAGS_DEVELOPER. Update .dev command to new command model

* Rename _player -> player

(cherry picked from commit 8128bb97db)
2022-01-01 23:18:04 +01:00
jackpoz
7d632d5711 Core/PathFinding: Fix buffer overflow
(cherry picked from commit dc7856644f)
2022-01-01 22:59:49 +01:00
NoName
6c6b8cb1c6 Scripts/IcecrownCitadel: Adding IsAlive check to avoid possible crash in Event (#24514)
(cherry picked from commit 22aaf32a79)
2022-01-01 22:59:24 +01:00
Shauren
679e9910e0 Core/Auras: Prevent getting negative scale with auras
Closes #24040

(cherry picked from commit 50576fa1f5)
2022-01-01 22:49:58 +01:00
Shauren
c9443f190a Core/Spells Fixed scroll stacking check when not targeting self
* Reuse code that removes non-stackable auras at apply to check before casting the spell to keep reagents/cast item

(cherry picked from commit 43d9ffd1bc)
2022-01-01 22:27:05 +01:00
FAQ
88afe180b4 Core/Spells: Scrolls should not be consumed, when they fail to apply.
(cherry picked from commit 8d87c834e7)
2022-01-01 21:55:29 +01:00
Killyana
6300b096ac DB/Pet: Lil' K.T
Ref #1364

(cherry picked from commit ee5eace3c6)
2022-01-01 21:49:09 +01:00
Ovahlord
f4f56c105f Core/Vehicles: update the power display of vehicles before being added to world to avoid building unnecessary update_object packets right after spawning them
(cherry picked from commit 1610337e67)
2022-01-01 21:47:30 +01:00
HelloKitty
a20526077d Core/DataStores: Use ResSicknessSpellID from ChrRaces instead of hardcoding it (#24504)
(cherry picked from commit f1ad04b31b)
2022-01-01 21:45:52 +01:00
Killyana
567b26e0c7 DB/Pet: Toxic Wasteling
Closes #12773

(cherry picked from commit 3f5e0927c3)
2022-01-01 21:42:51 +01:00
NoName
5417438731 Core/Spells: Crystallize should not use DIMINISHING (#24502)
and also correcting spelling in script

by Rushor and wotlk-enthusiast

(cherry picked from commit 45993428f5)
2022-01-01 21:38:13 +01:00
Rushor
db825c3221 Game/AI: Implement new targettype SMART_TARGET_CLOSEST_UNSPAWNED_GAMEOBJECT (#24494)
* Game/AI: Implement new targettype SMART_TARGET_CLOSEST_UNSPAWNED_GAMEOBJECT which allows to search for closest unspawned gameobjects

* updates: https://github.com/TrinityCore/TrinityCore/issues/24067

* Game/AI: Implement new targettype SMART_TARGET_CLOSEST_UNSPAWNED_GAMEOBJECT which allows to search for closest unspawned gameobjects

(cherry picked from commit 2d948d3366)
2022-01-01 21:33:34 +01:00
Rushor
ecd6bce5d2 Game/AI: Enable check for SMART_TARGET_GAMEOBJECT_RANGE (#24493)
* Thanks to joshwhedon
* Updates: https://github.com/TrinityCore/TrinityCore/issues/24439

(cherry picked from commit a41bb4f77b)
2022-01-01 21:33:27 +01:00
Eridium
88b898b92c Core/GameObject: Remove linked traps when the main GameObject is remo… (#24480)
* Core/GameObject: Remove linked traps when the main GameObject is removed from from the world

* Indentation

(cherry picked from commit 7e9bc9599b)
2022-01-01 20:30:54 +01:00
Gildor
5ce8c26914 Scripts/OnyxiasLair: Fix Onyxia Eruption spell (#24472)
(cherry picked from commit e4476fab6e)
2022-01-01 20:30:06 +01:00
Ovah
a6a6a15973 Core/AI: Implemented OnSpellCastInterrupt and OnSuccessfulSpellCast hooks
Ported from: 020825902c and 1aa42e97a8

(cherry picked from commit f1e4ee21f8)
2022-01-01 20:17:45 +01:00
Keader
c11288af78 Making travis happy
(cherry picked from commit ee218a5642)
2022-01-01 20:16:05 +01:00
Keader
a21ad2079a Scripts/Black Temple: Fixed Reliquary of Souls after combat rewrite changes.
Closes #23879
* Fixed combat start/evade issue
* Fixed visual issue in Soul Release spell
* Fixed some timers issue
* Fixed some codestyle issues

PS: Please, stop break my black temple babys.
(cherry picked from commit d8e726de58)
2022-01-01 20:15:51 +01:00
ForesterDev
6bddc8ff5e Core/Database: fix wrong password logging (#24487)
(cherry picked from commit 48c700347c)
2022-01-01 20:13:25 +01:00
jackpoz
d690648bce Scripts/BWL: Fix crash in Razorgore encounter
(cherry picked from commit 7b8b02c32e)
2022-01-01 20:13:04 +01:00
Rushor
864ce5a11c Game/SmartScripts: Reset counter in SAI only on Initialize. (#24489)
* Game/SmartScripts: Reset counter in SAI only on Initialize.

* Game/SmartScripts: Reset counter in SAI only on Initialize.

(cherry picked from commit 4f52f7d7c9)
2022-01-01 20:12:55 +01:00
jackpoz
e71352db6f Core/Spells: Fix assertion triggered
(cherry picked from commit 740afc7135)
2022-01-01 20:11:02 +01:00
Shauren
3f2f715f35 Core/Misc: Improve assert message with more detail
(cherry picked from commit 9407f9bdfa)
2022-01-01 20:10:45 +01:00