Commit Graph

20370 Commits

Author SHA1 Message Date
Duarte Duarte
0eadb41ed1 Merge pull request #11310 from Ric101/can_quest_reward
Core/Players: On CanRewardQuest, use the same item dest vector for all potential rewards

Solves issues where the player has enough bag space for each item individually, but not all of them together.

Example to reproduce previous issue:

Obtain Battle of the Crimson Watch (10781)
Make sure you only have 1 slot available in your inventory
Turn in the quest, watch as you don't receive one of the rewards
2014-01-11 16:21:41 -08:00
Duarte Duarte
65c941b88d Merge pull request #11342 from Carbenium/Svala
Scripting/Utgarde Pinnaccle: Fix visual during Svala's transformation
2014-01-11 16:20:16 -08:00
Dr-J
b83c252851 Scripts/NPCs: Remove core script for rogue trainers which was overriding db conditions
SAI and conditions for rogue trainers to provide elegant leter to rogues provided that is level 24 or higher, does not have elegant letter and does not have taken, rewarded or complete the quest which elegant letter starts

Closes #11378

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
2014-01-12 00:17:21 +00:00
Dehravor
a1f0798792 DB/Guild: Fix incorrect input length limits
There is one incorrect field length related to guilds in the database, which can be used to cause an overflow client-side, by sending CMSG_GUILD_INFO_TEXT with long strings.

The guild information has the same 500 characters client-side limit as the guild bank tab information, but on server-side it can be 65k characters long. A lengthy guild info makes the whole Guild panel unusable.

Length of the other fields match the client's limits in the database: guild bank tab name (16), public note (31), officer note (31), motd (128), guild bank tab info (500).

Closes #11395

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
2014-01-12 00:12:38 +00:00
mthsena
0b5728f8a7 Core&Conf: Small cosmetic fixes
Closes #11392

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
2014-01-12 00:07:29 +00:00
Duarte Duarte
e42cc9d5dd Merge pull request #11426 from Dehravor/invalidate-player
Core/Entities: Implement SMSG_INVALIDATE_PLAYER
2014-01-11 12:47:12 -08:00
Duarte Duarte
c9d81bd0c2 Merge pull request #11427 from Dehravor/force-rename
Core/Entities: Don't allow to login while character is forced to rename
2014-01-11 12:33:04 -08:00
Dehravor
4d3b7e6799 Core/Entities: Don't allow to login while character is forced to rename 2014-01-11 21:20:24 +01:00
Dehravor
619f42c1b0 Core/Entities: Implement SMSG_INVALIDATE_PLAYER 2014-01-11 18:22:56 +01:00
jackpoz
086622bfc1 Core/Battlegrounds: Fix offline players not being resurrected when Battleground ends
Fixes #7081
2014-01-11 17:18:36 +01:00
jackpoz
6f6ad952b9 Core/Wintergrasp: Fix typo in CMSG_HEARTH_AND_RESURRECT handler
Fix CMSG_HEARTH_AND_RESURRECT handler trying to resurrect players with 100x hp/mana/energy ( SetHealth()/SetPower() were sanitizing the input anyway ) .
2014-01-11 15:23:52 +01:00
jackpoz
8fcfabe784 Core/Spells: Fix potions cooldown in combat
Fix a cooldown issue related to potions allowing Players in combat to use more than 1 potion in a row, especially with high latency.
This also fixes an exploit about using infinite potions in combat just by skipping the client-side check.
The original implementation c064c2e2e1 was missing a check in Spell::CheckCast() about this particular case since Potion cooldown is added only after the Player goes out of combat.
Fixes #1259 .
2014-01-10 22:39:08 +01:00
joschiwald
41b613186e Core/Battlefield: some codestyle changes 2014-01-10 17:42:08 +01:00
joschiwald
7378baee49 Scripts/PoS/Garfrost: cleanup saronit blocks after death 2014-01-10 17:37:03 +01:00
joschiwald
7ec7fcf78c Core/SAI: drop unneeded code 2014-01-10 17:36:04 +01:00
Kittnz
dc09715312 DB/Spawns: remove duplicate NPCs on Zeppelin from Orgrimmar to Thunder Bluff
Closes #11420
2014-01-09 23:44:14 +01:00
joschiwald
6fff9d08b2 Fix build 2014-01-09 23:31:52 +01:00
joschiwald
e80d1f3465 Scripts/BloodFurnace:
* cleanup InstanceScript
* fix broggok poison cloud

Scripts/Naxxramas/Grobbulus:
* fix poison cloud
* fix mutating injection
2014-01-09 23:17:02 +01:00
joschiwald
1a5c0ad92f DB/Creature: update more creature templates 2014-01-08 16:12:36 +01:00
joschiwald
2b9234b32a DB: update some creature templates 2014-01-07 00:06:30 +01:00
joschiwald
a60ba240b7 Core/Entities: add some log messages in CheckCreatureTemplate
* Happy Error Spam
2014-01-06 20:30:11 +01:00
Shauren
619edff196 Misc:
* Tools: Fixed a compile warning
* Commands: Fixed npcflag format in .npc info
2014-01-06 13:53:29 +01:00
Shauren
15cbe5858c Core/Movement: Fixed vehicle passengers disappearing clientside
Closes #11411
2014-01-06 13:51:40 +01:00
joschiwald
95f14f921b Scripts/HoS: update Maiden of Grief 2014-01-05 16:47:07 +01:00
Shauren
ad84759d2f Core/Threading: Handle CMSG_ZONEUPDATE only in WorldSession update - changing zones triggers changing chat channels, what is not a thread safe operation 2014-01-05 00:52:10 +01:00
joschiwald
738afccfc1 DB/Spells: correct more spelldifficulty_dbc entries
* add log message to find wrong entries
2014-01-05 00:49:54 +01:00
joschiwald
853b9e9c58 DB/Spells: remove duplicate/invalid entries from spelldifficulty_dbc
* For new entries: use spellid0 as id to avoid conflicts with dbc file
2014-01-04 23:29:36 +01:00
joschiwald
cd76d32907 Core/Entities: correct creature damage, offhand damage should work too
* todo: some creatures need dmg_multiplier update in creature_template
2014-01-04 18:22:06 +01:00
Warpten
ff61e4d79d Scripts/Halion: Fixed Soul Consumption's pull effect.
Thanks to Winterfell for pointing out the issue.
2014-01-04 17:48:51 +01:00
jackpoz
1f170c99ef Core/Instances: Fix Instance binding
Fix players not being bound to instance if the group was disbanded before killing any boss.
Fixes #437
2014-01-03 18:56:11 +01:00
Shauren
9d6904f03d Core/Vehicles
* Fixed vehicle orientation on transports
* Fixed exiting vehicles on moving transports
2014-01-02 14:20:05 +01:00
jackpoz
82181a8622 Core/Loot: Fix Master Loot exploit
Fix Master Loot exploit allowing any online Player to receive loot.
2014-01-01 21:42:15 +01:00
Vincent_Michael
e773c9a693 Update more copyright note for 2014.
I have no excuse for my fail :/
2014-01-01 18:20:16 +01:00
Shauren
b5e0caaa72 Merge pull request #11394 from Dehravor/guild-create-log
Core/Guild: Fix an exploit related to CMSG_GUILD_CREATE
2014-01-01 06:09:14 -08:00
Dehravor
14287326c7 Core/Guild: Fix an exploit related to CMSG_GUILD_CREATE 2014-01-01 13:52:03 +01:00
Vincent_Michael
20004050bc Update copyright note for 2014.
Happy new year.
2014-01-01 00:07:53 +01:00
jackpoz
0c2f5340cc Core/Quests: Fix crash on startup
Fix a crash on startup when loading Quest POIs if quest_poi table referenced POIs not in quest_poi_points table, caused by 5de48a67c6 .
Fixes 11390.
2013-12-31 20:08:11 +01:00
Shauren
fd72065645 Merge pull request #11391 from Nawuko/waypoint-fix
Core/Waypoints: Revert partly f1a82a578b t...
2013-12-31 10:43:41 -08:00
Nawuko
3209a32fa4 Core/Waypoints: Revert partly f1a82a578b to fix a crash caused by accessing uninitialized splines 2013-12-31 19:22:10 +01:00
Malcrom
0e7805bac9 Db/Classlevelstats: Little fix for base warrior damage.
I won't be working on this anymore until next year
2013-12-31 13:52:16 -03:30
Malcrom
3018ff4e6c Core/Creature: Obtain Attack power and base damage from creature_classlevelstats table. 2013-12-31 12:45:56 -03:30
Shauren
1cdc2e8c2a Core/Movement: Fixed creature movement on transports 2013-12-31 14:12:02 +01:00
Shauren
9a1282aac6 Core/Spells: Fixed movement from SPELL_EFFECT_PULL_TOWARDS_DEST 2013-12-31 13:08:45 +01:00
Malcrom
997d2adb21 DB/classlevelstats: Update mage exp0, exp1, exp2 base damage 2013-12-31 00:05:54 -03:30
Malcrom
ba43e38d6f DB/classlevelstats: Exp1 & Exp2 Paladin base damage.
Exp1 57 to 60 and 71 to 73 estimated.
Exp2 67 to 70 and 81 to 83 estimated.
2013-12-30 22:12:34 -03:30
Malcrom
27c58c3ed8 DB/Classlevelstats: Fix damage for Exp0 Paladin Class.
25, 55, 59, and 61 to 83 are estimated all others are accurate.
2013-12-30 21:28:39 -03:30
jackpoz
64b42c75d2 Scripts/Misc: Code cleanup
Remove some NULL checks not needed anymore after 3744c14184 .
Fix an invalid Creature to TempSummon cast.
2013-12-30 23:36:49 +01:00
Subv
6ec7b03f9b Merge pull request #11386 from Nawuko/vincent-fix
Core: user defined literals need a space in front
2013-12-30 11:41:50 -08:00
Nawuko
6d21d33aac Core: user defined literals need a space in front 2013-12-30 20:35:37 +01:00
jackpoz
0895cdc8ad Buildsystem: Fix GCC not being recognized on Ubuntu
Fix CMake not recognizing /usr/bin/cc as GCC on Ubuntu ( 13.10 x64 ) .
2013-12-30 16:50:16 +01:00