Commit Graph

36361 Commits

Author SHA1 Message Date
Ovah
0feebcdf5b Core/Groups: do not allow lfg groups to change the loot mode (#23336)
While the UI does not allow changing the loot mode you can still trigger the opcode by running interface scripts which we will now block as well so nobody can ninja-loot anymore.

(cherry picked from commit 49a9cbf20a)
2021-12-09 00:32:17 +01:00
jackpoz
b4652a38d3 Core/Misc: Headers cleanup
Use simple std::string concatenation instead of stringstream to avoid including <sstream> header.

(cherry picked from commit 9c790e231e)
2021-12-09 00:32:05 +01:00
Killyana
a265e5bed1 DB/Creature: Forgus
(cherry picked from commit 33074b34c8)
2021-12-09 00:28:47 +01:00
Killyana
cfaeb72237 DB/Quest: Dark Iron Legacy
(cherry picked from commit a99f67c381)
2021-12-09 00:27:44 +01:00
Killyana
b325f738d1 DB/Misc: Skorn - Howling Fjord
From cce38b05fb
By Grz3s
Closes #14839

(cherry picked from commit d823c6896e)
2021-12-09 00:27:04 +01:00
Giacomo Pozzoni
33347c7d5f Core/Misc: Fix static analysis issues
Fix static analysis issues reported by Coverity Scan

(cherry picked from commit e12398afdc)
2021-12-09 00:24:41 +01:00
Nitair
f6048aca9a Scripts/Stratholme: Baron Rivendare rewrite (#22572)
* Adding last state of rivendare rewrite

* Fix aura beeing removed on reset, fix death pact

* Not needed

* SQL: Changed remove/inset into update, fixed delete at conditions part

* Typo

* Remove link spell, fix blank lines, change magic numbers to enum

* Test changes with SpellScript and DoCastSelf

* Revert SpellScript and moved DoCastSelf for the aura into UpdateAI part

* Damn, copyright.

* Fix Unholy Aura

* Fix again (does attack now / does cast if encounter resets)

* Adding handling of the aura to the db

* Rename 2018_99_99_99_world_335.sql to 2019_05_31_02_world_335.sql

(cherry picked from commit ee5101fbf7)
2021-12-09 00:24:26 +01:00
Killyana
c77a4e6281 DB/Quest: Slain by the Wretched
Closes #23332

(cherry picked from commit d333cd0ccf)
2021-12-09 00:16:04 +01:00
Killyana
200db638ee DB/Quest: Jack Likes His Drink
From b97e6f36c6
By sluggor

(cherry picked from commit 5f1d9fc304)
2021-12-09 00:14:48 +01:00
Wyrserth
9d865f7536 Core/Misc: don't allow players to use/activate/loot non-allowed gameobjects while under the effect of a damage immunity aura (#23319)
* Core/Misc: don't allow players to use/activate/loot non-allowed gameobjects while under the effect of a damage immunity aura.

* Forgot to change this in last-second rename.

* Apply suggested changes, thanks Shauren!

(cherry picked from commit 8bc5451864)
2021-12-09 00:13:59 +01:00
jackpoz
049606e31e Core/MovementGenerator: Add more details to asserts
Implement GetDebugInfo in MovementGenerator, PathMovementBase, FlightPathMovementGenerator, WaypointMovementGenerator.
Add an additional assert in FlightPathMovementGenerator::DoEventIfAny(), the input node must not be null

(cherry picked from commit 9da8123959)
2021-12-08 23:51:21 +01:00
Wyrserth
1edd93bc0c Core/Script: add script hook to allow overriding of a vehicle passenger's exit position (#23322)
* Core/Script: add script hook to allow overriding of a vehicle passenger's exit position.

* Allow to change orientation, and fix nopch.

* Keep original orientation, thanks jackpoz!

* Update Unit.cpp

Code cleanup

* Update Unit.cpp

(cherry picked from commit 88c6c61b95)
2021-12-08 23:51:07 +01:00
jackpoz
2cade0e6e3 Core/Channel: Sanitize channel names
(cherry picked from commit 7b8f294c02)
2021-12-08 23:47:07 +01:00
jackpoz
97249ff7b4 Core/Channel: Fix CRT Debug Assert triggered with invalid channel names
(cherry picked from commit f0bd90cc35)
2021-12-08 23:43:19 +01:00
Killyana
3796978a8f DB/Quest: The Wrath of Neptulon
(cherry picked from commit 22888f80e9)
2021-12-08 23:40:56 +01:00
Killyana
d036411cd7 DB/Creature: Scryer Cavalier
(cherry picked from commit d1e3de15d9)
2021-12-08 23:38:46 +01:00
Killyana
1ccb3fa847 DB/Creature: Add Grip immunity to Nightbane
(cherry picked from commit c946966275)
2021-12-08 23:37:57 +01:00
Killyana
438cedb711 DB/Creature: Lightsworn Elekk Rider
(cherry picked from commit f417615514)
2021-12-08 23:37:26 +01:00
Giacomo Pozzoni
6e28ecd22e Core/Movement: Fix assertion triggered in SplineChainMovementGenerator
Fix an assertion triggered in SplineChainMovementGenerator happening when a new generator is added while last spline of the SplineChainMovementGenerator is being processed but is not finalized yet.
Fix #23077

(cherry picked from commit 5d7f0eef6e)
2021-12-08 23:35:01 +01:00
Killyana
f45befd607 DB/Creature: Black Temple Battle Sensor
(cherry picked from commit 1cc7944f72)
2021-12-08 23:34:50 +01:00
dr-j
b0b9492e44 DB/Creature: Wolver Orphan & Oracle Orphan event in Dalaran
Closes #14621

(cherry picked from commit 64dabaad80)
2021-12-08 23:34:02 +01:00
Killyana
d45bc9b47b DB/Creature: Outland Children's Week Dark Portal Trigger
(cherry picked from commit 2717b72f3e)
2021-12-08 23:32:55 +01:00
Killyana
69d5093c66 DB/Creature: Ethereum Avenger
(cherry picked from commit c99193325b)
2021-12-08 23:32:02 +01:00
Killyana
2139c07aab DB/Creature: Arcane Burst
(cherry picked from commit 16bf11ab20)
2021-12-08 23:31:02 +01:00
Killyana
eab9d57108 DB/Creature: Eclipsion Hawkstrider
(cherry picked from commit e8b7cc6e1c)
2021-12-08 23:30:29 +01:00
Killyana
b16fa8f493 DB/Creature: Dragonmaw Nether Drake
(cherry picked from commit f024c0d2f7)
2021-12-08 23:29:43 +01:00
Killyana
952d48bf46 DB/Creature: Enslaved Doomguard
(cherry picked from commit 4f6bf01a19)
2021-12-08 23:28:03 +01:00
Ovah
0d433b1bc8 Core/Players: out of range group updates will now get sent every 5 seconds instead of as soon as they are available to reflect retail behaivior. (#23323)
* according to sniffs the group update packet for out of range members has a fixed 5 seconds interval instead of spaming packets like crazy for example when updating positions. On 4.x and above this will fix a very nasty and ugly fps drop
* validated with 4.3.4 and 3.3.5 sniffs

(cherry picked from commit 635cefc67e)
2021-12-08 23:22:12 +01:00
lactoseti
6b2e40257a Creature/Script: npc_tallhorn_stag
Ref #2623

(cherry picked from commit bfffa5d45e)
2021-12-08 23:20:51 +01:00
Killyana
2bf8ffd5d9 DB/Quest: Vyletongue Corruption
Ref #21078

(cherry picked from commit 6023d7e7e1)
2021-12-08 23:19:53 +01:00
Wyrserth
2344671af5 Core/Console: start CliRunnable thread after all log messages have been printed. (#23321)
(cherry picked from commit d8ce37e0c9)
2021-12-08 21:55:04 +01:00
Ovah
09fe78dd59 Core/GameObjects: goober gameobjects may reset only if they have a lock id or a reset time specified (#23298)
* Core/GameObjects: goober gameobjects may reset only if they have a lock id

Tests have shown that Goobers without a lock id (Data0=0) are not allowed to reset their go state such as the teleporters in Ulduar and Icecrown Citadel. The tests has been expanded by checking 4.x goobers as well and the perfect example that confirms that result is the Ancient Bell for Atramedes' intro which also is not suposed to reset after using it.

* Core/GameObjects: allow to reset goobers without a lock id if a reset time is defined

* fixed a typo

(cherry picked from commit a70845c93d)
2021-12-08 21:54:41 +01:00
jackpoz
e9aed3e442 Core/SmartAI: Improve SMART_EVENT_GOSSIP_HELLO
Add another value to event_param1 for SMART_EVENT_GOSSIP_HELLO to support all cases of OnGossipHello/OnReportUse in GameObjects:
- event_param1 set to 0: execute the action for both OnGossipHello and OnReportUse. This might result in the action being executed twice when clicking the GameObject
- event_param1 set to 1: execute the action for only OnGossipHello
- event_param1 set to 2: execute the action for only OnReportUse

(cherry picked from commit 9e58ef6940)
2021-12-08 21:33:58 +01:00
sirikfoll
6afa2fe45f DB/Quest: No Place to Run
Closes #22719

(cherry picked from commit f1ab05ab46)
2021-12-08 21:33:45 +01:00
Killyana
aaa181e85f DB/SAI: Update gossip hello event for game objects to trigger only in OnReportUse() and not OnGossipHello()
The only remaining case is the gob 188596 as apparently it triggers OnReportUse() only

(cherry picked from commit 64786995d5)
2021-12-08 21:33:13 +01:00
Killyana
122584ae58 DB/Spell: D.I.S.C.O.
(cherry picked from commit 346514b50d)
2021-12-08 21:04:19 +01:00
Killyana
d69847fbdd DB/Quest: Improvements for Death From Below
(cherry picked from commit 069d3c3952)
2021-12-08 20:44:35 +01:00
Kittnz
9c2ce24c8a Core/Weather: Define WEATHER_STATE_DRIZZLE state
(cherry picked from commit cf05c3dd2c)
2021-12-08 20:37:10 +01:00
Killyana
8f1020ec78 DB/Creature: Hydross the unstable npc triggers
Update the correct channel spell SPELL_BLUE_BEAM and spawn triggers used to cast it

(cherry picked from commit 2829f5fb9c)
2021-12-08 20:36:43 +01:00
Killyana
e2e18ddd1a DB: Typo in the previous commit
(cherry picked from commit 3731c4be95)
2021-12-08 20:35:27 +01:00
Killyana
229d35adba DB/Creature: Dark Portal Dummy 1.30
(cherry picked from commit fdec429f18)
2021-12-08 20:31:38 +01:00
Killyana
5b724ebfe3 DB/Misc: Eclipsions Npcs
(cherry picked from commit ba20ca75f8)
2021-12-08 20:31:32 +01:00
Killyana
f0df2186c8 DB/Quest: Portals of the Legion
(cherry picked from commit 6910dc4d9c)
2021-12-08 20:28:37 +01:00
Shauren
a937767289 Core/Misc: Exclude boost 1.78 and newer from boost_1_73_process_windows_nopch hack 2021-12-08 19:02:59 +01:00
Shauren
df2d0f3670 Core/AreaTriggers: Added helper static function AreaTrigger::CreateNewMovementForceId for use in scripts with movement forces 2021-12-08 19:02:33 +01:00
Shauren
e2de5000ac Core/Movement: Defined movement force type enum 2021-12-08 19:02:02 +01:00
Shauren
8341082ac4 Core: Updated allowed build to 9.1.5.41359 2021-12-08 00:33:14 +01:00
funjoker
833e179985 Core/Misc: Add helper table phase_name and improve .npc info and .gps
.gps and .npc info now displays names for known phase names
2021-12-07 20:38:26 +01:00
Gildor
9752ef4d6e Core/Spells: Fix spells with Health Leech effect, now check damage absorb when calculate Heal (#23312)
Closes: #23311
(cherry picked from commit ad89472fe3)
2021-12-07 00:31:48 +01:00
jackpoz
6034992dff Core/SmartAI: Implement SMART_EVENT_SUMMONED_UNIT and SMART_EVENT_SUMMON_DESPAWNED for GameObject owners
(cherry picked from commit 507a56d627)
2021-12-07 00:31:26 +01:00