Commit Graph

14235 Commits

Author SHA1 Message Date
Aokromes
1160efe59e fix build try 2016-11-27 04:58:07 +01:00
Aokromes
12068f4cc1 typo fix 2016-11-27 04:50:47 +01:00
Aokromes
b4f82f183e Missing part 2016-11-27 04:44:33 +01:00
Aokromes
d8d165241d Core/MotionMaster: cleanup, reordering and renaming 2016-11-27 03:56:15 +01:00
Aokromes
cadaba4082 Core/Battlefield: Wintergrasp 'Tenacity' buff 2016-11-27 03:26:00 +01:00
Killyana
4bf2a6d008 Creature/script: Add area restriction for Freed Proto Drake
Closes #11754
Thanks to ariel-
2016-11-27 03:21:33 +01:00
Aokromes
be8cb29c93 Core/Unit: add impurity attack power bonus to healing too (for Death …
…Coil for example)
2016-11-27 03:21:03 +01:00
Aokromes
90dc4159b2 Core/Player: fix regression with EquippedItemClass requiring spells 2016-11-27 03:15:05 +01:00
Aokromes
f2fdbd81d6 fix build 2016-11-27 03:12:08 +01:00
ariel-
009adc4324 Revert "Core/Spell: add EquipedItemClass/EquippedItemSubClass check to passive spell casts"
This reverts commit f188ff1ce4.

Was breaking Titan's Grip.
Spells are loaded before items, and they CAST the spell on the player.
When items are then loaded, Player::ApplyItemDependentAuras only has AddAura on it. Titan's Grip is an effect, no auras involved.

In turn reverting this commit will now allow Two-handed weapon specialization and similar from spells load. Which is the lesser of two evils.
2016-11-27 03:11:27 +01:00
ariel-
6283cce52f Core/Player: fix build 2016-11-27 03:10:07 +01:00
ariel-
f348c015c0 Core/Spell: add EquipedItemClass/EquippedItemSubClass check to passive spell casts
- Was adding auras on login that didn't satisfy requirements (like Two-Handed Weapon Specialization)
2016-11-27 03:09:47 +01:00
Aokromes
c0ba6c2dfe Core/Auras: Rewritten conditionally applying SPELL_AURA_MOD_WEAPON_CR…
…IT_PERCENT, SPELL_AURA_MOD_DAMAGE_DONE and SPELL_AURA_MOD_DAMAGE_PERCENT_DONE auras

* Now the entire aura is removed when changing equipment
* All aura types can now depend on equipped items
2016-11-27 03:09:29 +01:00
Aokromes
0ca62b97e0 Core/Spells: Updated spell required items check, EquippedItemInventor…
…yTypeMask should only be used for enchantments
2016-11-27 02:45:32 +01:00
Aokromes
b2c17b4881 Core/Guild: avoid data integrity problems wrapping delete+insert statements in a transaction 2016-11-27 02:41:25 +01:00
Aokromes
ba8791ddcd Core/Player: recheck shapeshift bonus auras when switching spec.
- Fixes Leader of the Pack stuck when switching specs while shapeshifted
2016-11-27 01:53:19 +01:00
ariel-
bc25bbcd42 Core/Spell: register items received through SPELL_EFFECT_SUMMON_CHANGE_ITEM for quest credit
- Also sends proper SMSG_ITEM_PUSH_RESULT packet

Closes #3505
2016-11-27 01:42:18 +01:00
ariel-
331a88ef8f Core/Spell: Fixed Drain Soul incorrectly downscaling ranks when targetting lower level enemies 2016-11-27 01:41:58 +01:00
ariel-
b1b31fd685 Core/Gameobject: fixed sometimes not found linked trap
Closes #18256
2016-11-27 01:39:22 +01:00
Aokromes
6c76eff031 Core/Unit: fix some SPELL_AURA_MOD_DAMAGE_PERCENT_DONE effects being …
…applied more than once

No more overpowered dps for you
2016-11-27 01:36:22 +01:00
ariel-
227dc4d907 Core/Unit: fix build
Ctrl-S failure
2016-11-27 01:24:19 +01:00
ariel-
de4aec3204 Core/Spell: fix a potential null dereference crash 2016-11-27 01:09:37 +01:00
Krudor
64763f86de Core/Creatures: Enable swimming creatures to chase targets in 3d (#18298)
Closes #11060
2016-11-23 11:18:06 +01:00
ariel-
2f1910476e Core/Spell: fix warning 2016-11-19 07:40:32 +01:00
Aokromes
abea2d8d3f Core/Misc: Missing part 2016-11-19 07:27:22 +01:00
Aokromes
66b91e07fa Core/Misc: Compile fix try 2016-11-19 07:19:38 +01:00
Aokromes
d9e8c7a285 Core/Spell: Missing change, partialy revert change 2016-11-19 06:59:05 +01:00
Aokromes
dbd4fc3eca Core/Spell: Compile fix try 2016-11-19 06:35:33 +01:00
Aokromes
b1d4f802ef Core/Spell: move attribute helpers to spellInfo
- Renamed CheckEffectExecuteData to AssertEffectExecuteData and made const, better reflects its purpose
- Added missing attribute check to IsNextMeleeSwingSpell
- Reworked SPELL_ATTR4_CAST_ONLY_IN_OUTLAND attr check (researched behavior)
2016-11-19 06:23:06 +01:00
Aokromes
e4dd97765e Core/Spell: revamp of immunities system
- Spell attributes research
- Container optimization
- Do not skip damage immunity checks on SPELL_ATTR0_UNAFFECTED_BY_INVULNERABILITY present
- Added additonal arguments support to SendCastResult / CheckCast, spells can now send proper error messages
- Loads spell immune masks/states/effects at startup.
- This cached info is used whenever a spell cast requires immunities to be known beforehand (to see if an aura could be applied for example)
2016-11-19 06:10:14 +01:00
ariel-
b6f8ecbefc Core/GameObject: use a friendly trigger for positive spells.
Fixes an issue with Skadi Harpoons.

Note to self: should actually implement GameObject casting already :/
2016-11-15 05:48:22 +01:00
ariel-
ad927acae4 Core/Spell: do not fail triggered Charge effects in case a root is present.
Fixes Master's call when pet is rooted
2016-11-15 05:47:59 +01:00
ariel-
66fb271921 Core/Spell: use SpellEntry to select implicit targets in case RadiusEntry wasn't set for the current effect.
Closes #15388
2016-11-15 05:46:42 +01:00
ariel-
1fcb8e0b4e Core/Unit: consider creatures with same faction to be on the same party/raid for the purposes of spell/aura targets
Ref #18233
2016-11-15 05:46:05 +01:00
ariel-
760bef2453 Core/SpellScript: allow optional parameters to be passed to FinishCast
followup of 50a3ce5703
2016-11-15 05:45:56 +01:00
ariel-
0037363f3a Core/Battleground: Fix issue reported by static analysis 2016-11-15 05:45:08 +01:00
Keader
d6f31175f3 Core/Scripts: Cleanup in instance_black_temple and added missing datas (#18246)
* Core/Scripts: Cleanup in instance_black_temple and added missing datas

* Fixed door timing issue

* Remove redundant call
2016-11-15 05:43:45 +01:00
Shauren
5ddf50bdee Core/Auras: Fixed removing auras triggered by aurastates
Closes #17868

(cherry picked from commit f94e6cee38)
2016-11-15 05:43:30 +01:00
Aokromes
688942feec Missing part 2016-11-11 01:42:48 +01:00
Aokromes
a7d378689d Core/Auth: Resolved authentication bypass 2016-11-10 23:53:49 +01:00
Keader
8a94094c26 Core/Scripts: Fixed a typo and removed randtime of Shade of Akama events (#18231) 2016-11-10 23:45:11 +01:00
ariel-
03c3279395 Core/Gameobject: remove immune flags from trigger used to cast GO spells
Spells were failing flags check in Unit::_IsValidAttackTarget

Closes #18206
2016-11-10 23:42:29 +01:00
Aokromes
8a4bda8c9f Core/Spell: apply SPELLFAMILY_GENERIC mods to all spells by default 2016-11-05 02:29:56 +01:00
Richard
b66a4f8dcb [3.3.5] Core/Loot: Fix conditional Master Loot (#17943)
* Core/Loot: Fix master looting of conditional items

follow_loot_rules was a flag intended to force certain quest items to be
master looted. It should not be used for the
NonQuestNonFFAConditionalLoot.

The flag was originally introduced in 869ea349
"Core/Loot: fix the way quest items are handled. so far ive only found 3
quest items that should be able to be masterlooted. added a new flag to
item_template.flagsCustom to allow for making a quest item always follow
loot rules. a bonus may be the fix of the handlelootmasteropcode crash!"

* Core/Loot: Rename QuestItem to NotNormalItem

QuestItem struct was being used for quest items, ffa items, and
conditional items. Renaming it to avoid confusion when working with ffa
and conditional items

* Core/Loot: Use existing AddAllowedLooter rather than reaching into allowedGUIDs directly

* Core/Loot: Rename NotNormalItem to NotNormalLootItem
2016-11-04 12:26:09 +01:00
treeston
c91f195554 Core/Creature: Correctly reset pathfinding capability on respawn. Prevents evade chains on some bosses. Closes #18188. 2016-11-03 16:14:09 +01:00
tkrokli
5896b95e41 Core/Scripts: Archmage Arugal event script (#17922)
Implement boss script for Archmage Arugal
- add yells used in boss event to DB
- use proper spells instead of only melee fighting
- add DataType in shadowfang_keep.h
- add event scheduling in the script

By Riztazz
Closes issue #17916
2016-11-03 16:13:00 +01:00
Aokromes
0fe4e3e73e Core/Misc: Fix dynamic build 2016-11-02 09:06:57 +01:00
Aokromes
94ca5c157a Core/Gameobject: Build fix 2016-11-02 07:26:46 +01:00
Aokromes
c9dd490372 Core/Misc: copy&paste enrrage is bad 2016-11-02 06:28:28 +01:00
Aokromes
cdccb459bd Core/Gameobject: Revert bad delete 2016-11-02 06:21:20 +01:00