Commit Graph

21185 Commits

Author SHA1 Message Date
Aokromes
11636faadf Core: define CREATURE_FAMILY_NONE to avoid magic numbers in code 2016-07-20 12:49:38 +02:00
vincent-michael
dadd81afe0 Core/Quests: Fixed issue reported by static analysis
Coverity defect ID: 1355241
2016-07-20 11:01:10 +02:00
mik1893
13c5e4be65 Core/Spells: Fix Blood Tap activation when Blood Rune is in cooldown as Death Rune (#17132) 2016-07-20 11:00:56 +02:00
mik1893
4f6c7158a1 Core/Unit: Pet shouldn't be notified for DOT damage on the owner (#17133)
- Fix by @MrSmite
- Closes #16894
2016-07-20 11:00:40 +02:00
r00ty-tc
d219b18c68 Core/Cinematic: Optimize cinematic loading
- Remove pointless cast string->char*->string
2016-07-20 10:59:53 +02:00
Aokromes
0db05c610c Coverity: Correct two static analysis catches
#1355242 - Uninitialized scalar field
 #1355240 Resource leak in object
2016-07-20 10:59:10 +02:00
treeston
330167da7a Seriously, who doesn't support std::string instead of char* in 2016? 2016-07-20 10:49:52 +02:00
treeston
7279304c7c Add a LOG_WARN when attempting to summon a non-existing summon group. 2016-07-20 10:49:36 +02:00
treeston
ee10877d52 Allow BossAI::_DespawnAtEvade to work on creatures other than the boss itself (optional argument). 2016-07-20 10:48:44 +02:00
treeston
ef80fbd6c0 Core/Scripts: Added reasonable default params to GetCreatureListWithEntryInGrid/GetGameObjectListWithEntryInGrid for ease of use. Also, entry = 0 means no filter now, since we lacked an easy way to get a list of all creatures in grid. 2016-07-20 10:48:23 +02:00
treeston
334a705860 This discussion is more effort than it takes to change it. 2016-07-20 10:47:32 +02:00
treeston
221201dd3f Core/AI: Add DoCastSelf helper.
(I have no idea why I never bothered to do this before, really. It had crossed my mind a few times.)
2016-07-20 10:47:14 +02:00
treeston
35596cee5c Too many damn stars in that damn argument list. 2016-07-20 10:46:50 +02:00
Aokromes
d3dae41ded Core/Movement: Fix issues where creatures cancel spell casts chasing target and Implement SPELL_ATTR5_CAN_CHANNEL_WHEN_MOVING 2016-07-20 10:46:07 +02:00
treeston
dbd1d58f9d Creature/CreatureAI:
- Default range for DoZoneInCombat: 50.0f -> 250.0f.
- Add optional second arg to SummonList::DoZoneInCombat to specify range.
- Also a bunch of random NULL -> nullptr cleanup.
2016-07-20 10:39:10 +02:00
Shauren
0bf6e30f44 Build fix 2016-07-20 10:30:36 +02:00
Shauren
a4498c7cab Core/Auras: Renamed fields of SpellProcEntry structure and change types to more appropriate ones 2016-07-20 10:25:03 +02:00
Aokromes
817eb007db Compile fix 2016-07-19 19:01:13 +02:00
Aokromes
78c2b11747 Core/Movement: Implement 3 missing opcodes
From wowsource.
2016-07-19 18:51:50 +02:00
Aokromes
551990fb4c Compile fix, partialy revert a3ca833d0d need help to port
dc3327f9c5
2016-07-19 18:09:05 +02:00
Aokromes
41b26981bb Core/Spells: Fix wrong totem placement 2016-07-19 17:50:53 +02:00
Aokromes
cd9acb7d05 Core/Spells: Fixed overwriting summon requests 2016-07-19 17:15:06 +02:00
Aokromes
a3ca833d0d Core/Scripts: Cleanup cs_modify.cpp
* Removed a chunk of duplicate code
* Generalized Message notification
* Generalized checking of resources modification with a min-max
* Generalized checking of single value modification
2016-07-19 17:01:15 +02:00
Aokromes
6e68a60e6d Core/Unit: Do not remove auras from Pets and Guardians after evading 2016-07-19 16:21:41 +02:00
Aokromes
28a7ce2007 Core/Spell: Magic Absorption Calculation 2016-07-19 16:16:53 +02:00
Aokromes
0c5007efe9 Core/Misc: Fix issues reported by static analysis 2016-07-19 16:11:21 +02:00
Aokromes
5d835e4526 Core/SmartScripts: Improve SMART_EVENT_DISTANCE_CREATURE so it can be used with SMART_TARGET_ACTION_INVOKER 2016-07-19 16:05:20 +02:00
Aokromes
1a1a33d0f0 Core/PacketIO: Missing changes from 548aa11 that could result in a crash due to double Locking (#17008)
Socket will be closed because of ReadDataHandlerResult::Error.
2016-07-19 15:58:23 +02:00
DDuarte
c47ec46ebc Scripts: Add missing override 2016-07-19 15:55:11 +02:00
Gacko
bba08ed29c Scripts: Add missing overrides.
(cherry picked from commit aac868a6d9)
2016-07-19 15:54:54 +02:00
Aokromes
6ca223187b Compile fix 2016-07-19 15:46:44 +02:00
Aokromes
a65ac56b74 Core/Entities: Ported byte field offset naming from 6.x 2016-07-19 15:08:35 +02:00
Naios
29eed2c20f Core/Scripts: Move the ragefire chasm scriptloader into the correct file
(cherry picked from commit 4710b1c8fe)
2016-07-19 14:18:42 +02:00
Naios
74a588b462 Core/Misc: Replace tc's optional with boost::optional. (very partial cherry-pick)
* benefits from empty optimization (objects are only constructed if needed).
* supports r-value references (move semantics) (boost >= 1.56.0).
* preparation for c++14/17's std::optional and std::none_t.
* add move constructor to CompactArray.

(cherry picked from commit 800d5d8939)
2016-07-19 13:37:37 +02:00
Aokromes
a71da1c603 Entities/Unit: Finally fix no-path evasion.
- When a creature cannot find a path to its victim, it begins evading all attacks and regenerating health.
- If this persists for 5 seconds, it evades back to spawn position with new EvadeReason value EVADE_REASON_NO_PATH.
- Also some SmartAI cleanup (why oh why does it have so much duplicated code) and getting rid of #defines in favor of type-checked compile-time constants.
2016-07-19 13:33:04 +02:00
Aokromes
cf47ef8be0 Build Fix 2016-07-19 13:04:50 +02:00
Aokromes
f5de65fd96 Core/Misc: MSVC /W4 warning fixes 2016-07-19 13:02:54 +02:00
Aokromes
9c1b965136 Core/Misc: MSVC warning fixes 2016-07-19 12:40:58 +02:00
Aokromes
4e7dabc09d Core/Commands: Prevent creating accounts containing '@' character with .account create command 2016-07-19 12:27:06 +02:00
Aokromes
3f0c7f6b2f Core/Spells: Renamed EnsureSpellInfo to AssertSpellInfo to minimize differences between branches 2016-07-19 12:02:52 +02:00
Aokromes
eaf9d524e8 Entities/Unit: Fix aggression checks when testing player pets vs neutral creatures.
Pets will no longer be able to attack unattackable creatures in some situations.
2016-07-19 11:51:41 +02:00
Rochet2
7378c2ba97 Add missing GAME_API exports 2016-07-19 11:33:55 +02:00
Aokromes
5c5977bd48 Core/Tools: Fix pdump load 2016-07-19 11:22:15 +02:00
Aokromes
11c028f4bb Core/Tools: Fix pdump write 2016-07-19 11:08:51 +02:00
Golrag
9179cd478d Core/Object: Use object edges to calculate LoS 2016-07-19 11:06:20 +02:00
Aokromes
f0400b7ae6 Make travis happy 2016-07-19 08:31:37 +02:00
Aokromes
bbaf1216df Core/Spells: Fixed all cases of spells that crash the client when pressing ESC after being cast 2016-07-18 22:06:16 +02:00
Aokromes
8c45b115f7 Core/Spells: Glyph of the Monkey
By Linrasis @ ArkCORE
Closes #79
2016-07-18 21:37:13 +02:00
Aokromes
193489f3a7 Core/Players: Split playerBytes fields in characters table
(cherry picked from commit 2a6f65f)
(i think i don't have broken nothing, loged with fresh created chars and old chars and all looks to be ok)
2016-07-18 21:14:24 +02:00
Keader
07f1bde1c3 Core/Scripts Improve Felflame Infernal of Lord Jaraxxus fight (#16998) 2016-07-17 16:42:10 +02:00