Commit Graph

10557 Commits

Author SHA1 Message Date
Carbenium
12ae32a9b6 Merge pull request #15720 from Tonghost/3.3.5
Core/Items: Fix a trading spoof exploit.
2015-11-03 17:48:01 +01:00
sirikfoll
22f1d26986 DB/CORE Minor change in quest Kick, What Kick? and some codestyle
Remove the line that despawns the 'Apple' npc, this despawn is non-blizzlike and breaks the quest.
Thx Killyana for sql and valuable information

Closes #15480
2015-11-03 17:01:25 +01:00
ShinDarth
7ab1d1b7d0 Core/Ticket improved ticket system
- Safely close ticket before character deletion
- Allow to keep trace of delete characters tickets (configurable)
- Closes #15655

Closes #15699
2015-11-03 16:07:30 +01:00
treeston
91de0322bb Scripts/Naxxramas: Anub'rekhan encounter cleanup.
- Cleaned up events behavior to use phases instead of weird checks for auras.
- Cleaned up Crypt Guard despawn behavior, they should no longer despawn instantly upon death.
- Moved initial greeting from MoveInLineOfSight hack to proper areatrigger script.
- Fixed Crypt Guard respawn behaviour to prevent pulling them before Anub'rekhan has fully reset.
- Fixed Crypt Guard aggro behaviour to call for help on aggro. This prevents pulling the initial pair of Crypt Guards without engaging the boss.
- Added missing boss emotes.
- Code style cleanup.
2015-11-01 22:31:48 +01:00
MitchesD
c82311897a Merge pull request #15681 from Treeston/3.3.5-faerlina
Scripts/Naxxramas: Faerlina cleanup
2015-11-01 20:49:10 +01:00
jackpoz
da0671f4fe Scripts/Naxxramax: Fix clang warning 2015-11-01 18:40:35 +01:00
Shauren
965d29484b Core/Items: Corrected all spellid checks from item_template to also check -1
Closes #15797
2015-11-01 16:29:29 +01:00
Naios
570e6baa09 Core/AI: Cleanup in CreatureAISelector
(cherry picked from commit 6fa4588191)
2015-11-01 15:05:16 +01:00
Naios
105f624763 Core/AI: Convert the hardcoded variadic RAND functions into one C++11 variadic template version.
(cherry picked from commit 0b6f784591)
2015-11-01 15:03:02 +01:00
Shauren
e8909de8de Core/Accounts: Check active column when determining if account is banned or not 2015-11-01 13:16:29 +01:00
Vincent-Michael
98cd477149 Core/Misc: Update game creature template locale in simple system
(cherry picked from commit 8aa55a0b57)
2015-10-31 20:54:59 +01:00
Shauren
14d382f185 Core/Conditions: Optimizations part 3 changed ConditionStore to a simple array
(cherry picked from commit db0c48c17f)
2015-10-31 20:26:40 +01:00
Shauren
cba122ad94 Core/Conditions: Optimizations part 3 removed copying condition containers all over the place
(cherry picked from commit b09e63e9de)
2015-10-31 20:26:40 +01:00
Shauren
57c4b3d42c Core/Conditions: Add const to methods not modifying ConditionMgr
(cherry picked from commit 2cce998e90)
2015-10-31 20:26:40 +01:00
Shauren
6ab90cc57d Core/Conditions: Optimizations part 2 removed unneeded code
(cherry picked from commit e5c1e7d71c)
2015-10-31 20:26:40 +01:00
Shauren
3158605603 Core/Conditions: Optimizations part 1 - use containers more suited for their role
(cherry picked from commit 9fa938f3e0)
2015-10-31 20:26:40 +01:00
Shauren
dc74454356 Core/Conditions: Type renaming
(cherry picked from commit 5e0cee85dd)
2015-10-31 20:26:40 +01:00
joschiwald
36a205ec00 Core: fixed warning introduced in last commit
(cherry picked from commit fe0c07a6fe)
2015-10-31 19:13:05 +01:00
joschiwald
df88c7f278 Core/Misc: removed some useless map checks
(cherry picked from commit cf1e80e3d0)
2015-10-31 19:11:41 +01:00
Shauren
635dc9c02a Core/Players: Fixed automatic learning skills gained from learning spells when leveling
Closes #15391

(cherry picked from commit 3fceabfa11)
2015-10-31 18:57:59 +01:00
joschiwald
3a4f33d007 Scripts/Ulduar/Algalon: fixed achievement "He Feeds On Your Tears"
Ref #6157

(cherry picked from commit d68e3325d5)
2015-10-31 18:38:34 +01:00
Shauren
b8e86b9b7a Core/DBLayer: Allowed using GetDouble for SUM results instead of requiring string conversions
(cherry picked from commit 3109ab2da0)
2015-10-31 18:25:40 +01:00
David Carlos Manuelda
a410072d6d Removed unneeded nullptr check
(cherry picked from commit 20215a8c42)
2015-10-31 18:22:55 +01:00
David Carlos Manuelda
8dc10022a6 Fixed boss evade and doors closed by cr4st.
Should close #6377 and #15239

(cherry picked from commit e430f3f61a)
2015-10-31 18:21:23 +01:00
Shauren
f56bb2e0a6 Core/Spells: Extended spell required shapeshift masks to 64 bits and defined a new spell attribute
(cherry picked from commit 191d2c7262)
2015-10-31 18:14:36 +01:00
StormBytePP
072375dbd8 Core/Spells: Fixed gcc-4.7.x compile
(cherry picked from commit 595bb841a9)
2015-10-31 18:02:54 +01:00
David Girón
bc187f8760 Script/Commands: Add some sanity checks to cast commands
Closes #15061

(cherry picked from commit 15dec9a76c)
2015-10-31 18:02:32 +01:00
MitchesD
a968595977 Core/PacketIO: fixed instance binding of gamemasters
(cherry picked from commit 231fb1d322)
2015-10-31 17:39:17 +01:00
Shauren
1de03cf107 Core/Players: Implemented serverside validation of reserved/profane names
Closes #15357

New library dependency: Boost.Regex

(cherry picked from commit b564c10b13)
2015-10-31 17:27:45 +01:00
Shauren
60da7c6552 Core/Networking: Fixed possible crashes happening if async query retrieving account data takes too long
Closes #14944

(cherry picked from commit 590c6e399d)
2015-10-31 16:04:14 +01:00
Shauren
97fe228334 Core/Threading: Fixed possible data races after making auth queries async by moving their processing to boost::asio::io_service::run threads
(cherry picked from commit f6bc87fe5d)
2015-10-31 15:56:02 +01:00
Shauren
b95648ae27 Core/Threading: Significantly reduced the severity of possible data race during player login
* This commit changes a data race on a pointer value to data race on integers (guid)

(cherry picked from commit dbe2051056)
2015-10-31 15:41:32 +01:00
Shauren
517a30d7c1 Core/DBLayer: Sprinkle some async magic on worldserver auth/session load process
(cherry picked from commit 0e49eefe85)
2015-10-31 15:36:48 +01:00
joschiwald
5e28a8e375 Core/PlayerDump: cherry picked refactoring from commit e49462fc1e)
Fixed reguiding items in character_equipmentsets on pdump load
2015-10-31 13:49:27 +01:00
Shauren
6c53f820ae Core/Players: Fixed saving players with incorrect gender 2015-10-31 12:30:22 +01:00
Kittnz
16f9d4ceeb Core/Player: Fixed tab issues 2015-10-31 00:03:38 +01:00
Kittnz
3c82b498cc Core/Player: Set correct Gender by Modelid
An example: You are a blood elf female, you use [Iron Boot Flask], you turn into a male dwarf, you use  [Orb of the Sin'dorei] and it will turn you into a blood elf male. This is the correct behavior like retail.
2015-10-30 23:57:23 +01:00
Shauren
61094c911d Core/Misc: Warning fix 2015-10-30 18:40:29 +01:00
Shauren
e62f091a4b Core/Misc: Warning fix 2015-10-30 18:32:01 +01:00
Shauren
2e2bdec28f Travis fix. 2015-10-30 18:20:33 +01:00
Shauren
8c9ea7782a Core/Corpses: Fixed a crash happening when a corpse is added to a grid that was not yet fully loaded
Closes #15684
2015-10-30 17:53:00 +01:00
Shauren
a94bdd00a9 Core/Corpses: Prevent deleting corpses by ObjectGridUnloader, fixes accessing freed memory in multiple places due to the corpse still being registered in Map containers
Closes #15775
Closes #15781
2015-10-30 17:51:19 +01:00
Shauren
4a36850167 Core/World: Store account id in CharacterInfo to reduce the amount of database queries
(cherry picked from commit aaaa1c3441)
2015-10-29 21:08:00 +01:00
Shauren
c7bad70e55 Core/Players: Check if player can enter the instance during login before trying to add him to map
* Fixes name displaying as "Unknown"

(cherry picked from commit 45994a177c)
2015-10-29 18:59:06 +01:00
Shauren
b1b72dafd0 Warning fixes
(cherry picked from commit 82db416b5d)
2015-10-29 18:56:26 +01:00
Shauren
31cf5ea305 Core/Misc: Removed manually defined ObjectGuid copy/move constructors. This will cause the compiler to automatically generate trivial constructors allowing them to be treated as simple integers
(cherry picked from commit 3fd15ed22a)
2015-10-29 18:52:00 +01:00
MitchesD
079c6b47f9 Core/Player: remove unused method prototypes
(cherry picked from commit 9617da7249)
2015-10-29 18:50:30 +01:00
Shauren
1d17475791 Core/Corpses: Fixed map crash happening during map unload when there are corpses inside 2015-10-29 18:46:37 +01:00
Shauren
7dcddd90be Core/Spells: Improved spell category cooldown handling
* Category cooldown is stored with the spell that started the cooldown (and only resetting cooldown on that spell will clear cooldowns on entire category - this fully mirrors client behavior)
* This significantly reduces the amount of data saved to database for cooldowns
* Spell casts from items that have a different category specified than on spell will now check for cooldown during the cast

(cherry picked from commit 1efb3f08e2)

Closes #15766
Closes #15137
Closes #14837
2015-10-29 17:56:18 +01:00
Shauren
20b4e6f03a Core/Corpses: Fixed leaking corpses
Closes  #15765

(cherry picked from commit bd16520ecc)
2015-10-28 21:56:40 +01:00