Commit Graph

22379 Commits

Author SHA1 Message Date
offl
1316ca482d DB/Quest: Convert & update support for 'When the Cows Come Home' to SAI
Closes #24685
2020-05-25 23:32:50 +02:00
offl
0e7cabd7f1 DB/Quest: Convert & update support for 'Cuergo's Gold' to SAI
Closes #24675
2020-05-25 23:10:12 +02:00
Killyana
5856f520bb Boss/Script: Remove Hex Lord Malacrass wrong equipment from the script and use the one from the DB 2020-05-25 15:52:23 +02:00
NoName
1680f2221e Core/Misc: Sync some funcion names with master (#24683) 2020-05-24 21:56:34 +02:00
NoName
89193c3548 Scripts/RuinsOfAhnQiraj: Crystal handling (#24679)
+ make crystal usable with animation and despawn after use;
+ small code update;
+ spell rearrange;
+ define some magic numbers;
+ update crystal coordinates from sniffed data
2020-05-24 20:45:28 +02:00
Gildor
dd3fbf426c Scripts/Icecrown Citadel: Fix Sindragosa movement when Wipe in fly phase (#24665) 2020-05-24 20:38:24 +02:00
NoName
2efaf1dda8 Entities/Player: Restore old checks for UpdatePvPFlag (#24372)
Partly revert 671052575a
+ implemented timer reset to 300s after relog never worked, therefore removing that part;
+ reverting other parts with 300s timer changes, as not needed;
2020-05-24 20:35:34 +02:00
Killyana
fd66e291b5 DB/Quest: Convert "HELP!" & "Corki's Gone Missing Again!" & "Cho'war the Pillager" to SAI
Closes #24649
2020-05-23 02:44:18 +02:00
offl
2008cb7dd3 DB/Quest: Convert & update support for 'Prisoners of Wyrmskull' to SAI
Closes #24650
2020-05-22 00:32:06 +02:00
offl
0cfd63fd26 DB/GameObject: Convert & update support for Shrine of the Eagle / Falcon / Hawk to SAI
Closes #24647
2020-05-21 23:52:02 +02:00
offl
626aeb5817 DB/Creature: Convert Sayge to SAI
Closes #24663
2020-05-21 23:34:59 +02:00
jackpoz
013301088d Scripts/Misc: Fix issues reported by ASan 2020-05-21 22:17:13 +02:00
offl
9c1c34a794 DB/GameObject: Convert & update support for Tablet of Madness
Closes #24670
2020-05-21 21:21:38 +02:00
ForesterDev
84dad1b29b Core/Packets: updated CMSG_PLAYED_TIME, SMSG_PLAYED_TIME (#24674)
(cherry picked from commit 50b4a3a707)

# Conflicts:
#	src/server/game/Server/Packets/CharacterPackets.cpp
#	src/server/game/Server/Protocol/Opcodes.cpp
#	src/server/game/Server/WorldSession.h
#	src/server/scripts/Northrend/Nexus/Nexus/nexus.h

Co-authored-by: MitchesD <majklprofik@seznam.cz>
2020-05-21 14:55:30 +02:00
Giacomo Pozzoni
247564a7ab Core/Creature: Allow to disable HP regen in Raids even if the target is unreachable (#24646) 2020-05-21 14:48:09 +02:00
Killyana
6b9a14ca94 DB/GameObject: Convert & update support for Jump-a-tron 4000 to DB script
Closes #24668
2020-05-21 02:05:44 +02:00
offl
cfe6b651bc DB/Quest: Convert Escape from Umbrafen to SAI
Closes #24648
2020-05-21 00:28:41 +02:00
dr-j
e80b66fd52 DB/Quest: With a little help from my friends
Closes #24639
2020-05-20 23:20:37 +02:00
offl
cc5bea023a DB/Quest: Convert & update support for 'Hypercapacitor Gizmo' to SAI
Closes #24640
2020-05-19 23:06:05 +02:00
offl
c3e4420a2b DB/GameObject: Convert & update support for Fel & Bash'ir crystalforges
Closes #24643
2020-05-19 22:46:31 +02:00
offl
44aba5dcdf DB/Quest: Convert support for 'Strength of One' to SAI
Closes #24641
2020-05-19 22:21:37 +02:00
Shauren
a26304478d Core/Quests: Add missing GO_DYNFLAG_LO_ACTIVATE to lootable chests related to quests but not having quest loot
Closes #24474
2020-05-19 21:21:39 +02:00
Shauren
449bd9058b Core/Quests: Fixed gameobject sparkle state for lootable quest items by moving ItemAddedQuestCheck/ItemRemovedQuestCheck after item is added/removed
This is neccessary so that GameObject::BuildValuesUpdate from BuildValuesUpdateBlockForPlayer picks up correct inventory state and sets GO_DYNFLAG_LO_ACTIVATE
2020-05-19 20:50:53 +02:00
Keader
99c457c270 Scripts/ICC: Fixed duplicated call of reputation spell 2020-05-19 11:45:12 -03:00
Keader
d1e1b8753c Scripts/ICC: Fixed Deathbringer/Valithria reputation handler + codestyle fixes
* Added correct reputation spell for both bosses
* Fixed debuffs remove when deathbringer dies (it also fix recount)
* Changed all DoCast(me, xxx) -> DoCastSelf(xx)
* Removed old reputation hack in DB
* Fixed my OCD with spells enum :)
2020-05-19 11:42:11 -03:00
NoName
868748007d Scripts/RazorfenDowns: quest "Extinguishing the Idol" (#24658) 2020-05-19 13:19:10 +02:00
NoName
d2b88fbd50 Core/Objects: Add GOSummonType argument to SummonGameObject accepting XYZ arguments instead of Position (#24655) 2020-05-19 11:40:50 +02:00
offl
049cba3ace DB/Quest: Convert & update support for 'Shizz Work' to SAI
Closes #24638
2020-05-18 00:08:58 +02:00
offl
2815db52a6 DB/Quest: Convert & update support for 'Finding the Survivors' to SAI
Closes #24636
2020-05-17 23:36:34 +02:00
offl
a2068cade5 DB/Creature: Convert & update support for Ashyen & Keleth to SAI
Closes #24635
2020-05-17 21:53:02 +02:00
Ovahlord
fdcb7388a6 Core/Objects: fixed destination calculation for destination based spells casted by flying units
* Additionally he PathGenerator will now check for realtime movement flags instead of creature based template data only so scripted flying movement and players will now correctly get their path calculated
2020-05-16 17:40:08 +02:00
Shauren
75ab3619bd Core/Commands: Fixed .npc add overwriting existing spawns when used on transports 2020-05-16 11:23:34 +02:00
Giacomo Pozzoni
bd2d60c267 Fixes/3.3.5 aura infinite loop (#24631)
* Core/Auras: Attempt to fix infinite loop with aura 18950 on map unload

* Core/Auras: Log a detailed error and assert when failing to remove all auras after a few tries

* Code cleanup

* Fix build warnings

* Fix more build warnings
2020-05-16 11:06:03 +02:00
joshwhedon
4db77bc913 Removing a duplicate item combat spell handling causing poisons (and others) to proc twice. (#24627)
https://github.com/TrinityCore/TrinityCore/issues/24608
2020-05-15 21:54:33 +02:00
Giacomo Pozzoni
c0b75bf40d Core/MMAPs: Adjust walkable climb and fix a lot of mmap raycast issues (#24539)
* Core/MMAPs: Adjust walkable climb

Adjust walkable climb as recast using walkableClimb also to find the poly from a position, giving priority to polys that are below the position but closer than walkableClimb.

* Temporarily disable static collision (the whole check should be removed)

* Core/Spells: removed deprecated mmap path check for TARGET_DEST_CASTER_FRONT_LEAP

* Core/Objects: allow flying units to use the helper as well (flying units casting radius based spells)

* Code refactor

* Handle raycasts that end in a point with no height in the mmap mesh as PATHFIND_NOPATH

* Walk back a bit from raycast hitpoints as sometime the 2D result point is outside of the polygons due to floating point errors.

* Remove whitespace

* Revert 4a197ba22a as a raycast point path should have the Z retrieved with getPolyHeight(). Raycast will only return a 2-point path with Start and Hitpoint/End

* Cleanup PathGenerator raycast case

* Fix PathGenerator raycast broken if start and end are on same poly.
Fix PathGenerator raycast broken if no wall is hit.
Remove unused case of using raycast with an existing previous path (can be added back properly if needed).
Remove forcing poly length to 2 when we actually have already the right number.

* Use closestPointOnPolyBoundary on the second try of finding a point on poly for raycast.
Note that in this case the mesh height is not used which might cause issues. The poly boundary height will be used instead.

* Handle cases where getPolyHeight() fails because the point is on polygon border (and caused by floating point imprecision)

* Add far from poly flags

* Set PATHFIND_INCOMPLETE in raycast case if startFarFromPoly or endFarFromPoly

* Fix blink close to walls with no valid polygon behind the wall

* Require to re-extract mmaps

Co-authored-by: Ovah <dreadkiller@gmx.de>
2020-05-15 20:43:12 +02:00
HelloKitty
43b595111d Further improve ChrRace DBC handling (#24508)
* Core/DBC: Added ChrRacesAllianceType for ChrRaces.dbc

* Core/Character: Check ChrRace DBC playable in HandleCharCreateOpcode

* Core/DBC: Implement ChrRacesFlags removing literals

Cannot take credit for this enum, derived from documentation in
https://wowdev.wiki/DB/ChrRaces

* Core/Character: Check CHRRACES_FLAGS_NOT_PLAYABLE on creation

* Core/DBC: Fix formatting of ChrRaces enums

* Core/DBC: Use ChrRaces CreatureType instead of hardcoded humanoid assumption

* Address enum style code changes
2020-05-15 20:41:16 +02:00
Shauren
1d43003cfa Scripts/Icecrown Citadel: Fixed Professor Putricide oozes not moving during their channel 2020-05-15 18:16:03 +02:00
Metalaka
e2434e4f47 Core/CreatureAI: Shambling Horror re-cast Enrage as soon as it is not stun (#24618) 2020-05-14 21:17:00 +02:00
NoName
26439c8951 Core/ByteBuffer: Fixed output truncation in ByteBuffer::hexlike (#24595)
Co-authored-by: Shauren <shauren.trinity@gmail.com>
2020-05-11 22:21:31 +02:00
ccrs
472e1fd8ae Core/Movement: 9080e78 followup
actually port back the previous implementation, now correctly
this implies that a unit that has a different victim than the one its chasing will stand still till either:
- a new movement replaces the current, for w/e reason
- the chase target is again the current victim

probably a pause implementation on the generator is a more elegant solution...

updates #24600
2020-05-11 19:38:36 +02:00
Shauren
c189fe4911 Core/Spells: Fix refreshing exclusive auras that have different values in each effect
Closes #24592
2020-05-10 16:30:48 +02:00
ForesterDev
6caba62572 Core/PacketIO: updated some pet packets (#24531)
* Core/PacketIO: Updated and enabled CMSG_PET_ABANDON

(cherry picked from commit 0b76381283)

# Conflicts:
#	src/server/game/Handlers/PetHandler.cpp
#	src/server/game/Server/Packets/PetPackets.h
#	src/server/game/Server/Protocol/Opcodes.cpp
#	src/server/game/Server/WorldSession.h

* Core/PacketIO: Updated and enabled CMSG_PET_STOP_ATTACK

(cherry picked from commit dea718e4ed)

# Conflicts:
#	src/server/game/Handlers/PetHandler.cpp
#	src/server/game/Server/Packets/PetPackets.h
#	src/server/game/Server/Protocol/Opcodes.cpp
#	src/server/game/Server/WorldSession.h

* Core/PacketIO: Updated and enabled CMSG_PET_SPELL_AUTOCAST

(cherry picked from commit 1f8268c89c)

# Conflicts:
#	src/server/game/Handlers/PetHandler.cpp
#	src/server/game/Server/Packets/PetPackets.h
#	src/server/game/Server/Protocol/Opcodes.cpp
#	src/server/game/Server/WorldSession.h

* Core/PacketIO: Updated SMSG_PET_LEARNED_SPELL

* Core/PacketIO: Updated SMSG_PET_UNLEARNED_SPELL

* fix build

* Remove whitespaces

* Unify naming for PetGUID

* Initialize variables

Co-authored-by: Carbenium <carbenium@outlook.com>
2020-05-10 16:25:08 +02:00
Sorikoff
34fecde022 Scripts/Pet: Lil' K.T (#24528)
* Lil' K.T.

* Rename 9999_99_99_99_world_335.sql to 2020_05_10_00_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-05-10 16:23:13 +02:00
ForesterDev
5eaf68670a Core/PacketIO: Updated logout opcodes (#24519)
(cherry picked from commit f59a701e29)

# Conflicts:
#	src/server/database/Database/Implementation/LoginDatabase.cpp
#	src/server/database/Database/Implementation/LoginDatabase.h
#	src/server/game/Handlers/MiscHandler.cpp
#	src/server/game/Server/Packets/AuthenticationPackets.cpp
#	src/server/game/Server/Packets/AuthenticationPackets.h
#	src/server/game/Server/Packets/CharacterPackets.h
#	src/server/game/Server/Protocol/Opcodes.cpp
#	src/server/game/Server/Protocol/Opcodes.h
#	src/server/game/Server/WorldSession.cpp
#	src/server/game/Server/WorldSession.h
#	src/server/game/Server/WorldSocket.cpp

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2020-05-10 14:37:44 +02:00
HelloKitty
772f506a3b Improve Creature DBC Handling (#24509)
* Core/DBC: Add CreatureModelDataFlags to remove hardcoded literals

* Core/DBC: Use CreatureType flags in Creature::CanGiveExperience calculation

* Core/DBC: Fixed CreatureType Flags Misinterpretation

Meaning of this was wrong, wowdev wiki was incorrect. Partially reverts
0d61e653f4

* Address enum codestyle

* Update DBCStructure.h

* Update DBCfmt.h

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-05-10 14:30:25 +02:00
Shauren
1fecbc6892 Core/Units: Allow mind controlling non-controllable vehicles (for example players that become vehicle during boss encounters or creatures that only are vehicles to show non standard power type)
Closes #24562
2020-05-06 16:45:03 +02:00
NoName
5bbab32793 Core/Maps: fix respawn times for manual respawns (#24571)
by joshwhedon
2020-05-05 21:09:50 +02:00
ccrs
ac12bd1391 Core/Movement: modify MovementInform trigger condition & checks in ChaseMovementGenerator 2020-05-03 17:20:37 +02:00
ccrs
71ed2e5d5e Core/Movement: de832b6 followup
lets keep that failsafe there, doesnt hurt
2020-05-03 17:03:12 +02:00
ccrs
de832b6980 Core/Movement: modify MovementInform trigger condition & checks in FollowMovementGenerator
ref #24552
2020-05-03 16:53:21 +02:00