Commit Graph

28169 Commits

Author SHA1 Message Date
Treeston
184c45cfe0 Core/Scripts: dynamic_spawning follow-up, I had forgotten JustRespawned existed.
- Rename JustRespawned to JustAppeared, which better matches its behavior anyway.
- Properly invoke JustAppeared for new (re-)spawns - fixes #20111.
- Fix Thaddius script to work with dynamic_spawning (mostly unrelated to the above) - Feugen/Stalagg should really be a summon group, but I don't have time to fix that right now.
- Fix default value for DynamicEscortNPC to match worldserver.conf.dist.
2017-08-06 16:07:30 +02:00
tkrokli
dbda060ae7 DB/Quest: A Boaring Time for Grulloc (10721): wrong RewardText content
http://www.wowhead.com/quest=10721/a-boaring-time-for-grulloc
https://wow.gamepedia.com/Quest:A_Boaring_Time_for_Grulloc

- Quest 10721 showed up in-game with the same Reward Text as Quest Description
- quest_template.QuestDescription was inserted as quest_offer_reward.RewardText
- issue also found in https://github.com/dalaranwow/dalaran-wow/issues/1926
- Correct RewardText is based on content from the 3 linked pages above.
2017-08-06 09:48:36 +02:00
tkrokli
8de9f1c359 DB/Quest: Surveying the Ruins (10335): add missing RewardText, end half
http://www.wowhead.com/quest=10335/surveying-the-ruins

- Another quest_offer_reward.RewardText cut short, missing half of its content.
- Previous: 114 characters. Added: 115 characters. Full text: 229 characters.
2017-08-06 08:10:48 +02:00
tkrokli
61fdbe57f2 DB/Quest: Invaluable Asset Zapping (10203): add missing RewardText end
http://www.wowhead.com/quest=10203/invaluable-asset-zapping

- Another quest_offer_reward.RewardText cut short, missing ≈33% of its content.
- Previous: 290 characters. Added: 143 characters. Full text: 433 characters.
2017-08-06 06:15:52 +02:00
tkrokli
b5876c7664 DB/Quest: In A Scrap With The Legion (10232): add missing RewardText
http://www.wowhead.com/quest=10232/in-a-scrap-with-the-legion

- Another quest_offer_reward.RewardText cut short, missing ≈ 60% of its content.
- Previous content: 137 characters. Added content: 193 characters. Full text: 330 characters.
- RewardText content source (besides verifying the actual content on wowhead.com):

https://github.com/TrinityCore/TrinityCore/blob/master/sql/old/4.3.4/TDB0_to_TDB1_updates/world/012_quest_template.sql
2017-08-06 05:06:07 +02:00
Necropola
ecf5978608 Core/Pet: Fix an issue that was causing lower ranks of pet spells to remain in DB (#20112) 2017-08-06 03:15:04 +02:00
tkrokli
f27c4806fd DB/Quest: Sabotage the Warp-Gate! (10310): add missing end half of RewardText
- Previous content: 103 characters. Added content: 163 characters. Full text: 266 characters.
- RewardText completion source: sql/old/4.3.4/TDB0_to_TDB1_updates/world/012_quest_template.sql
2017-08-05 16:00:33 +02:00
Aokromes
92359de5ef Revert permision change 2017-08-05 09:49:43 +02:00
tkrokli
446ea12127 DB/Quests: Terokkar Forest quest text typos
Fixed the following typos:
- 'Clues in the Thicket' (9971) RewardText typo (Is it was/Is it what)
- `An Unseen Hand` (10013) RewardText typo (duplicated words "it to me")
- 'Evil Draws Near' (10923) Progress typo (ben/been)
2017-08-05 05:19:34 +02:00
Necropola
906498e9f4 [3.3.5] Core/Pet: Make pet action bar autocast persist properly (#20110)
Partial revert of of 6c21ddd9b9.
Closes #16211.
2017-08-04 03:52:24 +02:00
Treeston
70a48ff182 DB/InstanceSpawn: More low-hanging fruit - Ruby and Obsidian Sanctum. 2017-08-04 01:57:10 +02:00
Treeston
fd9a93b45e DB/InstanceSpawn: The easy ones. Gruul's Lair, Magtheridon's Lair, Onyxia's Lair, Eye of Eternity. 2017-08-04 01:42:57 +02:00
Treeston
84590be26d Scripts/InstanceScript: Implement database framework for managing spawn groups based on boss state. (#20103) 2017-08-04 00:23:40 +02:00
Treeston
2644fa703a Core/Unit: Don't apply liquid effects to game masters. 2017-08-03 19:38:15 +02:00
Shauren
6691e41873 Core/Misc: Revert back to using boost::regex, std::wregex doesn't work for name validation
Closes #20094
2017-08-03 00:13:21 +02:00
Treeston
759357049c Scripts/Commands: Fix some quirkiness and potential crashes with live DB modification commands (npc move and npc delete), which are horrible and should be deleted anyway.
Fixes #20104.
2017-08-02 22:05:40 +02:00
Treeston
c70b328eda more unneeded checks (follow-up 3b02029) 2017-08-01 18:14:55 +02:00
Treeston
3b02029cb6 remove an unused variable (follow-up fcd6fe0) 2017-08-01 17:58:17 +02:00
Treeston
fcd6fe0aac Scripts/Commands: New utility command: .list spawnpoints.
(I just needed it for dynspawn follow-up work, really.)
2017-08-01 03:42:11 +02:00
Aokromes
41721642f7 NoPCH Build fix 2017-07-31 22:56:21 +02:00
Treeston
232db9777a Merge remote-tracking branch 'base/dynamic_spawning' into 3.3.5 (PR #19056).
IT'S HAPPENING.
2017-07-31 21:23:26 +02:00
r00ty-tc
59db2eeea0 Dynamic Creature/Go spawning:
- True blizzlike creature spawn/respawn behavior - new creature = new object
 - Toggleable spawn groups (with C++/SAI/command options to use them)
 - Custom feature: dynamic spawn rate scaling. Accelerates respawn rate based on players in the zone.
 - Backward compatibility mode (set via group and for summons)
   to support creatures/gos that currently don't work well with this
   (this should be removed once the exceptions are fixed)

Fixes and closes #2858
Tags #8661 as fixable.
Fixes and closes #13787
Fixes #15222.
2017-07-31 21:21:04 +02:00
Shauren
d24ce1739a Core/Misc: Util changes
* Move IteratorPair to its own header
* Add AsUnderlyingType function to cast enum value to its underlying type (avoids repeating std::underlying_type everywhere)

(cherry picked from commit fdd9227b23)
2017-07-29 15:04:45 +02:00
tkrokli
9cbacb56da DB/Quests: add missing progress text to 'Bandages for the Field'
- Silithus / Cenarion Circle repeatable quests (Field Duty)
- 'Bandages for the Field' progress text (quest_request_items):
  "You have something for me, <name>?", requesting 4 quest items.
2017-07-28 18:45:23 +02:00
Treeston
508c9d2fc1 Core/Chat: Provide a fully-formed protocol for addons to interact with GM commands (#20074)
Send success/fail state, allow interleaving, and indicate end of output. Add framework for supporting non-human-readable output in commands.
2017-07-28 02:45:57 +02:00
Foereaper
a0bdf7e836 DB/Quest: stay mounted on Infected Kodo Beast in all 4 intended Borean Tundra zones
- Add conditions to allow player to stay mounted in the quest zones.
- Update comment text for existing condition, adding zone name.

By Foereaper
Updates issue #20078
2017-07-25 21:54:11 +02:00
Treeston
98aa7806c4 Core/Player: Always set flight state change packets for players, even if their latest MovementInfo doesn't indicate it's needed (the MI might be outdated). Fixes a player flight exploit and closes #20079. 2017-07-25 20:00:13 +02:00
tkrokli
2875bea3f1 DB/Quests: use correct gender format in Argent Dawn repeatable quests
- Gender selection for the words brother/sister = $gbrother:sister;
- in existing quest RewardText $g is flipped and shown as straight text
  (instead of "brother" or "sister" the quest says "g$sister:brother")
2017-07-25 10:17:01 +02:00
tkrokli
20fe8cad94 DB/Quests: 'The Crimson Courier' (14350) - add missing text
- add missing CompletionText (Progress) and RewardText to quest 14350
- identical to quest ID 6145, only Bragor Bloodfist's text is changed
- fix minor typo in Reward Text for quest ID 838 'Scholomance'(Horde)
2017-07-25 07:47:39 +02:00
Treeston
7cbb6c101e Scripts/IcecrownCitadel: Prevent players from becoming inaccessible when killed by Lord Marrowgar's Impale spell (the initial damage, not the DoT). Also fix the underlying bug in vehicle logic. 2017-07-25 02:01:32 +02:00
ccrs
1de89579c7 Core/AI: correct Permit level for trigger flagged creatures
This broke several mechanics such as LK hc Frostmourne Room or Rotface's slime, how come no one noticed it? Like really, no one?
ref ce3787f190
2017-07-23 18:01:42 +02:00
Treeston
f2f45765e4 Core/Unit: No code change, just updating a comment with insights gleaned from sniffs. 2017-07-23 02:07:18 +02:00
Treeston
28b3469e89 Core/WorldObject: Properly initialize position data for all types when initially creating them. Fixes some issues with PvP objectives not having the correct area ID set on initialization. Closes #20028. 2017-07-23 00:01:11 +02:00
Killyana
21b03e7d9b Core/Npc: Remove bytes1 once the npc start a combat
Closes #16832
By Rushor
2017-07-22 09:09:16 +02:00
Treeston
331e463de8 Core/PlayerAI: Some adjustments:
- Add a 2 second delay before the AI begins using spells. This should provide opportunity for counterplay before that rogue activates cloak and goes on an unstoppable rampage among your healers. (Sorry, guys.)
- Stopped the AI from attacking invalid targets under some conditions. It should now properly leash back and follow the charmer if we try to select an invalid target.
- Stopped the AI from constantly re-creating the follow movement generator (and thus spamming movesplines).
2017-07-21 23:00:14 +02:00
Shauren
1f63554312 Core/Auth: Fixed client getting stuck on login or realm change 2017-07-21 20:34:00 +02:00
Treeston
40c78cac4c Warning fix (c7896f3 follow-up) 2017-07-21 18:12:59 +02:00
Treeston
c7896f3102 Core/Unit: For convenience, explicitly redirect CastSpell with nullptr as first argument to the Unit* overloads. No more ->CastSpell((Unit*)nullptr, ...) all over the place! 2017-07-21 18:02:48 +02:00
Treeston
42c993f8ad nopch fix 2017-07-21 17:36:04 +02:00
Treeston
d80d7c6685 Scripts/Auchindoun: Last one, hopefully. Remove reliance on large grid searchers by integrating with instance script. 2017-07-21 17:29:06 +02:00
Treeston
04dc47e7e2 Scripts/Auchindoun: Blackheart the Inciter fully fixed now. I had way too much fun with this one.
Two points of note:
1) Spawning 5 invisible triggers with 5 distinct factions which then MC one target each? Biggest. Hack. Ever. Best part? It's blizzlike.
2) For over ten years, I thought it was spelled "Auchinodoun". It's not. It's spelled "Auchindoun". TIL.
2017-07-21 16:07:27 +02:00
Treeston
068254d6b9 nopch fix 2 2017-07-21 05:29:39 +02:00
Treeston
777befaaa9 nopch fix 2017-07-21 05:27:39 +02:00
Treeston
a38141fd6c Scripts/Auchindoun: Replace the Blackheart the Inciter hack-filled script with a slightly less hack-filled script that actually mostly works. This should at least make the boss encounter possible to complete. No claims to correctness, of course. 2017-07-21 05:22:26 +02:00
Treeston
49aa8a2e59 Scripts/Spell: Port spell_generic.cpp to new script registration syntax wherever possible. No actual changes in functionality. (fb87ac8 follow-up) 2017-07-20 16:43:45 +02:00
Treeston
37f59f8850 Scripts/Item: Port spell_item.cpp scripts to new script registration syntax wherever possible. No actual changes in functionality. (fb87ac8 follow-up) 2017-07-20 01:26:15 +02:00
treeston
fb87ac8e8d Core/Scripts: Implement generic script loaders (and script registry macros) to greatly reduce code duplication (#19526) (cherry-picked from commit a9174d5). 2017-07-20 00:27:20 +02:00
ariel-
bce40818bc Dep/gSOAP: Update gSOAP to 2.8.49
Closes #20039
2017-07-19 12:51:28 -03:00
ariel-
f0357a861d Core/Tools: fix whitespace 2017-07-19 12:40:01 -03:00
tkrokli
a59ebb35b6 DB/Quest: Stone Is Better than Cloth - use actual player name ($N)
Progress gossip contained the name "Orthanc" instead of player name.
(Maybe result of a bad sniff sample or copy-paste.)
2017-07-18 22:05:30 +02:00