Commit Graph

21928 Commits

Author SHA1 Message Date
Treeston
23fd193e4e Scripts/ICC: Professor Putricide no longer tries to add threat on units it cannot add threat on because of immunity flags. Instead, its AI manually controls the engagement state. Should close #23727. 2019-08-30 01:04:11 +02:00
AlιAѕѕaѕѕιN
92d83c3c2e [3.3.5] Fix spell_area not checking for zoneID for quests (#23719)
* Fix spell_area not checking for zoneID for quests

* Addendum to bdffe0a4a6

* Fix spell_area handle same spell with the same quests

Also fix not checking for quest_end at all.

* Addendum to 2d6b0545e3

* Better commenting for 7a50189de3

* Addendum to 2d6b0545e3
2019-08-28 08:03:41 +02:00
ForesterDev
07e2264964 Core/PacketIO: updated SMSG_PLAY_SOUND, SMSG_PLAY_MUSIC and SMSG_PLAY_OBJECT_SOUND (#23636)
* Core/PacketIO: SMSG_PLAY_SOUND

(cherry picked from commit 82a33c7fa8)

# Conflicts:
#	src/server/game/Battlefield/Battlefield.cpp
#	src/server/game/Battlegrounds/Battleground.cpp
#	src/server/game/Battlegrounds/BattlegroundMgr.cpp
#	src/server/game/Battlegrounds/BattlegroundMgr.h
#	src/server/game/Entities/Object/Object.cpp
#	src/server/game/Server/Packets/MiscPackets.cpp
#	src/server/game/Server/Protocol/Opcodes.cpp
#	src/server/game/Texts/CreatureTextMgr.cpp
#	src/server/game/Texts/CreatureTextMgr.h
#	src/server/scripts/Commands/cs_misc.cpp

* Update for 3.3.5

* Core/PacketIO: updated and enabled SMSG_PLAY_MUSIC

(cherry picked from commit c6718dc120)

# Conflicts:
#	src/server/game/Maps/Map.cpp
#	src/server/game/Server/Packets/MiscPackets.cpp
#	src/server/game/Server/Protocol/Opcodes.cpp
#	src/server/game/Server/Protocol/Opcodes.h
#	src/server/game/Spells/SpellEffects.cpp

* Core/Packets: added SMSG_PLAY_OBJECT_SOUND packet class

(cherry picked from commit 1272e9eea6)

# Conflicts:
#	src/server/game/Server/Packets/MiscPackets.cpp
#	src/server/game/Server/Packets/MiscPackets.h
#	src/server/game/Server/Protocol/Opcodes.cpp

* fic build

* change variable names

* fix build error field will be initialized after
2019-08-23 19:28:21 +02:00
ForesterDev
448facc5e7 Core/Spells: Fixed warlock's Banish cancel if target was already banished (#23697)
* Core/Spells: Add SpellMissInfo argument to BeforeHit hooks and call them also when the spell doesn't hit. (#17613)

(cherry picked from commit 8ff5b35be1)

# Conflicts:
#	src/server/game/Spells/Spell.cpp
#	src/server/scripts/Northrend/IcecrownCitadel/boss_the_lich_king.cpp
#	src/server/scripts/Spells/spell_warlock.cpp

* Core/Spells: Fixed warlock's Banish cancel if target was already banished (#17614)

(cherry picked from commit 4587b5d880)

# Conflicts:
#	src/server/scripts/Spells/spell_warlock.cpp
2019-08-23 19:24:56 +02:00
Keader
10f6e38185 nopch fix 2019-08-21 23:08:36 -03:00
Keader
cbc01f35b6 Core/Scripts: Proper fix Gal'Darah Puncture remove 2019-08-21 23:03:25 -03:00
Keader
1886507e7f Fix nopch build 2019-08-20 06:35:02 -03:00
Keader
130a3859ec Scripts/Gundrak: Fixed Puncture when Gal'darah die 2019-08-19 23:52:04 -03:00
Sorikoff
d56dd89635 Scripts/Spells: Code style adjustments for druid scripts (final?) (#23726) 2019-08-19 09:13:38 +02:00
Keader
61ad87d106 Scripts/Gundrak: Added a missing entry in Gal Darah Stampede Charge script
Noob Keader, Shame !
2019-08-18 13:07:18 -03:00
Sorikoff
63bbf4a4be Scripts/Spells: Code style adjustments for druid scripts (#23725) 2019-08-18 17:24:18 +02:00
Sorikoff
9a8a01925a Scripts/Spells: Port druid scripts to new script registration syntax (2 of 3) (#23696)
* Scripts/Spells: Port Druid Scripts to New Script Registration

* Revert

* Revert 2

* Revert 3

* Revert 4
2019-08-18 15:56:27 +02:00
Shauren
aa0d468e04 Tools/Misc: Document strange array access indexing
Closes #23723
2019-08-18 12:40:38 +02:00
Treeston
9665bbf665 Entities/Creature: Fix a bug that caused map respawn timers to be scheduled for compatibility mode creatures. 2019-08-18 12:30:21 +02:00
jackpoz
c4cce31a13 Core/Misc: Fix linux build 2019-08-18 11:15:54 +02:00
jackpoz
5a98022649 Core/MMaps: Fix mobs evading when target is out of MMap meshes
Fix mobs evading when target is out of MMap meshes causes by an overzealous check added in c602220e02 when trying to fix an infinite loop in Recast.
If the target is outside of the MMap mesh (for example very close to a wall which is an un-walkable area with current TrinityCore settings and that might be changed in the future) Detour will not be able to find the height of the poly and getPolyHeight() will return DT_FAILURE | DT_INVALID_PARAM . Most of the time this is ok and can be ignored and it's still better than having the Unit evade.
Fix #23613
2019-08-18 11:08:06 +02:00
Shauren
7ee0891b0f Warning fix 2019-08-17 22:40:50 +02:00
Shauren
3a4216fd97 Core/Map: Kill zoneId from RespawnInfo, all it did was significantly slow down startup to make one gm command faster 2019-08-17 22:30:27 +02:00
Shauren
677663139c Core/Spells: Removed PROC_ATTR_DISABLE_EFF_* attributes and store that in a separate column 2019-08-17 17:42:58 +02:00
Keader
ea16c4ac9f Scripts/Spells: Implemented Wyvern Sting script
- Removed old hack with spell_linked_spell
2019-08-17 11:48:27 -03:00
Keader
43c08b1761 Core/Spells: Fixed some issues with Drain Soul
Issue 1: Drain soul was always negative, but effect2 need be positive.
Issue 2: Drain soul was interrupted if someone in your group die. Caused by negative effects proccing in creature.
Issue 3: Since effect2 is positive, it was down-ranking in low level targets and should never happens (fixed before by ariel, transforming everything in negative in 2c8a6fb771 but it's wrong)

#MakeWarlockAfflictionGreatAgain
2019-08-15 10:46:23 -03:00
Sorikoff
f7793e7800 Scripts/Spells: Port druid scripts to new script registration syntax (3 of 3) (#23714) 2019-08-15 12:38:59 +02:00
Keader
fec48caabe Core/Spells: Drain Soul need be affected by Death's Embrace
Make Warlock Affliction great again !
2019-08-13 13:02:23 -03:00
Keader
95284b23d1 Core/Spells: Fixed SPELL_EFFECT_DISPEL when target has 2 spells with same ID (#23710)
Ty sirikfoll for all help :)
2019-08-13 08:55:00 -03:00
Treeston
6590a0bfce Entities/Creature: Fix an edge case assertion failure with pets dying in specific situations while casting spells. 2019-08-12 19:43:38 +02:00
Aokromes
028db8432e Core/Spells: Survey Sinkholes will now have a bigger range to be able…
… to hit all trigger npcs

By Ovahlord
2019-08-12 16:59:52 +02:00
Treeston
3750c1cad9 I actually changed compilers in godbolt this time. This does it. Really. (31b5632 7378bcb 0a40252) 2019-08-12 14:37:01 +02:00
Treeston
0a40252c29 i am so done with compilers for today , WHY IS STD::SWAP NOT A CONSTEXPR ASDFOWQWDO (31b5632 7378bcb follow-up grml) 2019-08-12 14:33:04 +02:00
Treeston
7378bcb418 ugh. compilers. 31b5632 follow-up. 2019-08-12 14:25:28 +02:00
Treeston
31b5632c00 Common/Utilities: Explicit tail recursion to keep the compilers happy. 2019-08-12 14:19:22 +02:00
Treeston
1c2b1cbba8 Entities/Player: ReacquireSpellFocusTarget is now private. It should've been private all along. 2019-08-11 13:56:42 +02:00
Treeston
fcce90508d Core/Creature: Fix an issue that sometimes prevented spellcast focus targets from being reacquired. 2019-08-11 13:31:46 +02:00
Treeston
0f7e070ed4 Common/Crypto: Make C++14 compilers happy. 2019-08-11 13:29:50 +02:00
Treeston
4211645834 [3.3.5] Core/Authserver: TOTP rewrite: (PR #23633)
- Proper management commands (.account 2fa)
- Secrets can now be encrypted (set TOTPTokenSecret in .conf)
- Secret now stored in binary
- Argon2 and AES primitives
- Base32/64 support
2019-08-10 21:34:51 +02:00
Treeston
464b0b059b Core/Channels: Fix a bug that would cause channel settings to disappear in certain settings. Fix a bug that would cause channels to not be saved on .server shutdown without delay. Closes #23699. 2019-08-09 12:04:20 +02:00
Sorikoff
382f563571 Scripts/Spells: Runic Healing Injector (#23690)
* Scripts/Spells: Runic Healing Injector

* Rename 9999_99_99_99_world.sql to 2019_08_08_00_world.sql
2019-08-08 14:12:49 +02:00
Sorikoff
996d4f7cc4 Scripts/Spells: Port Part of Druid Scripts to New Script Registration (#23691) 2019-08-08 09:22:05 +02:00
Treeston
910da94d20 that should make gcc complain less (57b36df follow-up) 2019-08-07 13:24:00 +02:00
Treeston
aa7fc4b6ef nopch fix 2019-08-07 11:21:53 +02:00
Treeston
57b36dfdc6 Scripts/Commands: Add .go boss, and do a usability pass over .go instance to match it. 2019-08-07 01:45:24 +02:00
Treeston
4320a021e9 Scripts/Commands: Cleanup some output from .go instance 2019-08-06 23:46:07 +02:00
Treeston
268384d2af coverity 2019-08-06 12:32:19 +02:00
Treeston
b2b9880377 Core/Common: fix a bug in BigNumber::AsByteArray that was causing incorrect output in 1/256 cases with explicit minSize (iff MSB zero) 2019-08-06 11:24:48 +02:00
Treeston
4fcb322010 typo fix in comment 2019-08-06 11:21:44 +02:00
ccrs
30f4aabf64 Core/Creature: 4a219ed codestyle followup, for real this time 2019-08-05 17:06:07 +02:00
Sorikoff
33807a065a Scripts/Blackrock Depths: Use DB Texts for Doom'rel (#23681)
* Scripts/Blackrock Depths: Use DB Texts for Doom'rel

* Quick Fix
2019-08-05 14:09:09 +02:00
Treeston
a4d5b24874 Common/Util: Sorry about that unexpected downtime at 3AM last night, everyone. (We call them happy little features.) 2019-08-05 11:23:57 +02:00
Treeston
dad1718f1b Revert "Core/Creature: 4a219ed codestyle followup"
This reverts commit 37b15e05bc.
2019-08-04 20:08:24 +02:00
Keader
7bd1b077f1 Build fix
Followup: 7b541098d5
2019-08-04 12:02:33 -03:00
ccrs
37b15e05bc Core/Creature: 4a219ed codestyle followup 2019-08-04 16:58:31 +02:00