Commit Graph

38201 Commits

Author SHA1 Message Date
Shauren
2864efdc53 Build: Disable Visual Studio 2022 MSBuild resource manager to make compile take only as much time as it does in Visual Studio 2019 2022-01-28 12:52:05 +01:00
Shauren
4fbf6dacff Core/Spells: Exclude empty mods from affecting spells and ignore PointsIndexX mods for spells that don't have any effect at that index 2022-01-28 11:19:48 +01:00
Robingad
5b57722211 Scripts/Spells: Fix shaman Lava Surge proc (#27667)
Co-authored-by: Shauren <shauren.trinity@gmail.com>
2022-01-28 11:18:45 +01:00
Robingad
1696d73860 Scripts/Spells: Move shaman Lava Burst crit chance calculation to scripts and add Lava Burst Overload (#27676) 2022-01-27 23:23:37 +01:00
Shauren
7fa2fa2f5e DB/Gossip: Restore gossip_menu_option Box* values that were wrongly set by 88659dcebf 2022-01-27 22:43:36 +01:00
Robingad
3e725e1d25 Scripts/Spells: Fix shaman Earthquake (#27620)
Co-authored-by: Shauren <shauren.trinity@gmail.com>
2022-01-27 22:18:46 +01:00
shamage
2b7545378a DB/GameObject: Remove duplicate board spawn in Stormwind
* removing cata era one

Closes #27672
2022-01-27 17:00:12 +01:00
ModoX
842e280d9e DB/Creature: Fixed sheath state of Apprentice Mages in Wizards Sanctum (Stormwind) 2022-01-27 16:59:02 +01:00
Shauren
d0bfca5a73 SQL: Fix 2022_01_26_45_world.sql for mysql 5.7 2022-01-27 11:13:04 +01:00
Shauren
88659dcebf Core/Gossip: Sync naming and db structure with 3.3.5 2022-01-26 23:49:42 +01:00
Peter Keresztes Schmidt
d33214c50a Core/ChatCommands: Do not parse partial strings for numeric paramters (PR #25259)
Check if integral/floating point type arguments were parsed successfully.

std::stoull will happily parse floating point strings until the decimal separator and return the value.
Make sure for all parsing methods that we actually parsed the whole token.

This allows to use handler arguments like Variant<uint32, float> which will be populated with the right type
depending on the token value (e.g "10" vs "10.0").

(cherry picked from commit 7edad0d601)
2022-01-26 22:30:13 +01:00
Giacomo Pozzoni
f2ee365da4 Core/SAI: Spell casts that cannot be executed because the unit is currently casting another spell will be retried asap with priority over other events (#25238)
* Core/SAI: Spell casts that cannot be executed because the unit is currently casting another spell will be retried asap with priority over other events

* Core/SAI: Re-sort the events only when needed

* Fix some priority reset and wrong mEventSortingRequired handling

* Code cleanup.
Sort only events loaded from db (not stored events, not timed action list).

* Code cleanup.
Raise priority of failed casts so they are retried before other spells

* Keep priority of the action fails and is rescheduled on next update

* Don't try recasting a spell in SMART_ACTION_CAST if there are multiple targets and at least 1 was successful

(cherry picked from commit ca25e8d019)
2022-01-26 22:26:08 +01:00
Peter Keresztes Schmidt
2d1a1d8ac3 Core/ChatCommands: Honor exact matches during enum arg parsing (PR #25255)
(cherry picked from commit df29f60595)
2022-01-26 22:16:24 +01:00
Peter Keresztes Schmidt
ec44c8296d Scripts/Commands: Use enum type arg for HandleDebugAnimCommand (PR #25256)
* Core/Shared: Make Emote enum smart
* Scripts/Commands: Use enum type arg for HandleDebugAnimCommand

(cherry picked from commit 86dc58974a)
2022-01-26 22:16:05 +01:00
Treeston
d297f65df2 Core/DB: Move every gameobject that uses the spawntimesecs < 0 hack into the legacy spawn group
(cherry picked from commit b74dc4754d)
2022-01-26 22:14:24 +01:00
scizzydo
1429237144 Core/Warden: Fix for LUA_STR_CHECK (#25247)
The check above is what I use to actually get a real result for LUA_STR_CHECK, which when I used variables that would have a string to them it actually fails the check. When checking for items like a function if it exists of course it won't work... In addition, fixing the Unk2 to Unk3 causes people to be able to adjust the address of the check to the address 0x00419210 to make warden perform the FrameScript__Execute to run lua on the client. This seems to be the big request like in https://github.com/TrinityCore/TrinityCore/issues/23035

(cherry picked from commit 4125a81bb1)
2022-01-26 22:13:25 +01:00
Peter Keresztes Schmidt
3923650aeb Core/ChatCommands: Add support for enum type arguments (PR #25242)
(cherry picked from commit 5e40eb20e2)
2022-01-26 22:13:06 +01:00
Peter Keresztes Schmidt
2e3c612c80 Core/Unit: Make HandleEmoteCommand typesafe (#25249)
* Scripts/ScarletMonastery: Fix wrong emote during Headless Horseman encounter

* Scripts/HoR: Fix wrong emote during escape event

* Core/Unit: Make improve type safety of HandleEmoteCommand

Change argument type to the expected enum type Emote

* Scripts/CoS: Use SetUInt32Value to set UNIT_NPC_EMOTESTATE

UNIT_NPC_EMOTESTATE is no flag field

(cherry picked from commit 6c7837f947)
2022-01-26 21:46:51 +01:00
Peter Keresztes Schmidt
595e89e02b Core/Spells: Mark constructors of Spell/AuraScript handlers as explicit (#25248)
Mostly to make clang-tidy happier

(cherry picked from commit 34d403e83f)
2022-01-26 20:57:27 +01:00
Shauren
b87f56d070 Core/Quests: Sync comments/log with 3.3.5 2022-01-26 20:46:42 +01:00
Aokromes
e538d42f12 Script/Quest: The Light of Dawn (#25243)
remove incorrect check, source:
https://www.wowhead.com/spell=53606/the-light-of-dawn
Flags
Can be used while dead

https://www.wowhead.com/quest=12801/the-light-of-dawn#comments:id=1495830
https://www.wowhead.com/quest=12801/the-light-of-dawn#comments:id=374127
(cherry picked from commit 681c738c61)
2022-01-26 20:44:35 +01:00
Rushor
7f9986a8a8 DB/Creature: Add script & waypoints to Warden Treelos
Closes #13055

(cherry picked from commit 40e4777831)
2022-01-26 20:43:34 +01:00
offl
255adc9350 DB/Creature: Add CREATURE_FLAG_EXTRA_NO_COMBAT to Toxic Tunnel (Naxxramas)
Closes #16490

(cherry picked from commit 9d11c25e18)
2022-01-26 20:42:41 +01:00
Cerveciento
b40c928d2a DB/Locale/esES+esMX Texts missing in quests (Part 19)
Closes #25245

(cherry picked from commit afd2146ad2)
2022-01-26 20:41:34 +01:00
Cerveciento
f14d636a24 DB/Locale/esES+esMX Texts missing in quests (Part 18)
Closes #25241

(cherry picked from commit e9a1f747fc)
2022-01-26 20:41:09 +01:00
Giacomo Pozzoni
7d548c34a9 Core/AI: Remove code that removed UNIT_DYNFLAG_LOOTABLE from possessed units (#25229)
* Core/AI: Remove code that removed UNIT_DYNFLAG_LOOTABLE from possessed units

* Update PassiveAI.cpp

Restored logic that removes loot flag while being possessed

* Restored logic that removes loot flag while being possessed

(cherry picked from commit 298d799485)
2022-01-26 20:40:24 +01:00
offl
bf1d04e3f4 DB/Quest: Update support for 'The Plains of Nasam' (11652)
Closes #23695

(cherry picked from commit dc7691a549)
2022-01-26 20:39:50 +01:00
offl
0184ea625c DB/Creature: Remove some wrong spawns
Ref #23791

(cherry picked from commit 2b8f314183)
2022-01-26 20:39:02 +01:00
offl
14f696f9fe DB/Creature: Fix gold value for world bosses
Source d10a189755

(cherry picked from commit 4c4e3b956f)
2022-01-26 20:38:24 +01:00
Cerveciento
d4cbe4c6cb DB/Locale/esES+esMX Texts missing in quests (Part 17)
Closes #25240

(cherry picked from commit 5188f723b4)
2022-01-26 20:37:42 +01:00
Cerveciento
5a48662abc DB/Locale/esES+esMX Texts missing in quests (Part 16)
Closes #25237

(cherry picked from commit 870e754998)
2022-01-26 20:36:57 +01:00
offl
4a21e54cc5 DB/Creature: Fix gold value for TBC raid bosses
Closes #19262

(cherry picked from commit 8ed3efd820)
2022-01-26 20:36:01 +01:00
Gildor
27c70ca728 Scripts/Naxxramas: Adjust Frogger event timer (#25214)
* Scripts/Naxxramas: Adjust Frogger event timer

Co-authored-by: Carbenium <carbenium@outlook.com>
(cherry picked from commit 7035a9caf1)
2022-01-26 19:51:48 +01:00
Rothend
6f10847512 Script/Quest: fix (More) Torch Catching (#24907)
* Script/Quest: fix (More) Torch Catching.

Closes #24893

Co-authored-by: Carbenium <carbenium@outlook.com>
(cherry picked from commit a375f15ae2)
2022-01-26 19:50:50 +01:00
Treeston
319ddd9bcd Core/Warden: Warden refactors (PR #25235)
(cherry picked from commit 6116e5b385)
2022-01-26 19:42:11 +01:00
offl
cf369301c4 DB/Locale: Add missing esMX quest locales
Copied from already added esES locales since they're almost always similar

(cherry picked from commit cce1ccdd5c)
2022-01-26 19:27:08 +01:00
Cerveciento
ac6e50f90e DB/Locale/esES+esMX Texts missing in quests (Part 15)
Closes #25234

(cherry picked from commit ca9ce8a70b)
2022-01-26 19:26:37 +01:00
dr-j
a7f4e50097 DB/Creature: Sindragosa's Fall Wyrm Reanimator/Frost Brood Spawn events
Closes #25231

(cherry picked from commit be8affa5be)
2022-01-26 19:26:09 +01:00
Cerveciento
70342659e5 DB/Locale/esES+esMX Texts missing in quests (Part 14)
Closes #25228

(cherry picked from commit b8f21d4540)
2022-01-26 19:24:46 +01:00
offl
7afcd3f4a2 DB/SAI: Rework support for corrupted & cleansed plants from Felwood
Closes #4960

(cherry picked from commit 2ff51396c0)
2022-01-26 19:24:12 +01:00
Giacomo Pozzoni
e11e1938b5 Core/SAI: Fix creatures casting with flag SMARTCAST_COMBAT_MOVE not switching to melee when the school of the spell they are trying to cast gets silenced (and other cases of spell failure) (#25226)
* Core/SAI: Fix creatures casting with flag SMARTCAST_COMBAT_MOVE not switching to melee when the school of the spell they are trying to cast gets silenced (and other cases of spell failure)

* Core/SAI: Retry casting after 500ms if a cast failed

Fixes #24914

(cherry picked from commit 63a6e1e048)
2022-01-26 19:21:10 +01:00
jackpoz
26894508ef Core/Misc: Code cleanup
(cherry picked from commit dd28cecda3)
2022-01-26 19:18:46 +01:00
offl
92f17bf40f DB/Texts: Add correct BroadcastTextId and comments to some creature texts
(cherry picked from commit 39f2d2d1cf)
2022-01-26 19:18:32 +01:00
offl
6fbef47eff DB/Texts: Add correct BroadcastTextId and comments to some creature texts, reoder some texts and add missing
(cherry picked from commit cf57ea2045)
2022-01-26 19:17:53 +01:00
jackpoz
b3f0d92b81 Scripts/Command: Fix .mmap loc always printing command usage
(cherry picked from commit 0eb49a3cc9)
2022-01-26 19:16:55 +01:00
offl
2350c20385 DB/Texts: Add BroadcastTextId to one of Molthor's texts & remove useless locales
(cherry picked from commit 08dd9ebf78)
2022-01-26 19:16:32 +01:00
Cerveciento
c4e2ae4603 DB/Locale/esES Texts missing in quests (Part 13)
Closes #25225

(cherry picked from commit 769d47c617)
2022-01-26 19:15:55 +01:00
jackpoz
d8cdbac670 Core/Warden: Fix Warden reporting false positive checks
Issue introduced in 210176fd91

(cherry picked from commit c04f53b886)
2022-01-26 19:15:22 +01:00
Cerveciento
00a6f6f705 DB/Locale/esES Texts missing in quests (Part 12)
Closes #25221

(cherry picked from commit b0734f81bd)
2022-01-26 18:58:55 +01:00
offl
1503c84d3a DB/SAI: Remove useless param inside SMART_ACTION_CALL_TIMED_ACTIONLIST for gameobject scripts
(cherry picked from commit 6ca6a54083)
2022-01-26 18:58:29 +01:00