Commit Graph

10625 Commits

Author SHA1 Message Date
Machiavelli
33f3397976 Core/Spells: Completely remove spells which were taught by SPELL_EFFECT_LEARN_SPELL on talent reset or talent spec switch - instead of keeping them stored as disabled. Reason for this is that if the primary spell with effect SPELL_EFFECT_LEARN_SPELL is learnt again, a 'new' secondary spell will be taught while the old one was still around. The latter was the reason for primary key violations in character_spell that led to transaction failures and thus character rollbacks.
Closes #1231
Closes #480
2011-06-23 02:39:36 +02:00
Machiavelli
719a079464 Core/WorldSession: Store correct packet in CharacterCreateInfo 2011-06-22 23:30:30 +02:00
Machiavelli
78a90e7bad Core/Worldsession: Fix death knight character creation logic after recent commits 2011-06-22 23:03:53 +02:00
Lopin
279bd87835 Scripts/Ulduar: Fixed achievement Getting Back to Nature in Freya's encounter 2011-06-22 21:54:32 +02:00
Machiavelli
2b3ee302f7 Missing line from 9b17b9. 2011-06-22 20:55:32 +02:00
Lopin
5bf8102b9c Scripts/Ulduar: Fixed achievements Knock on Wood & Knock, Knock on Wood & Knock, Knock, Knock on Wood in Freya's encounter 2011-06-22 18:30:50 +02:00
Machiavelli
9b17b9c3ba Core/DBLayer: Fix possible crashes from fe8cb7 2011-06-22 18:04:12 +02:00
Lopin
41254653a2 Scripts/Ulduar: Fixed achievement Deforestation in Freya's encounter 2011-06-22 15:18:10 +02:00
Machiavelli
0df059d5a2 Core/DBLayer: Don't lock a connection when doing mysql_real_escape_string as it doesn't need to interact with the server. 2011-06-22 15:04:13 +02:00
Machiavelli
fe8cb75bf1 Core/DBLayer: Make database interaction after create character packet completely asynchronous. This is more performant and fixes a DoS loophole and possible data desynchronisation caused by spamming this packet.
Closes #584
Closes #2089
2011-06-22 14:22:08 +02:00
Lopin
5c85d43030 Scripts/Ulduar: Properly fixed achievements I Love the Smell of Saronite in the Morning & Shadowdodger in General Vezax's encounter 2011-06-22 14:18:02 +02:00
QAston
c4818f1892 Core/Auras: Fix refresh of auras with spellmodifiers applied to currently cast spell. 2011-06-21 19:59:17 +02:00
Shauren
65233f8e66 Scripts/Ulduar:
* Removed achievement hacks from Ignis the Furnace Master's script and scripted them properly
* Code style cleanups
2011-06-21 19:26:12 +02:00
Shauren
f4047ff7dc Core/Alcohol: Drunk players will now properly see drunk-visible units. 2011-06-21 16:09:07 +02:00
QAston
2ac777f8ce Revert "Core/Auras: Fix work of proc auras are refreshed during proc event routine."
This reverts commit 2a47163771.
2011-06-21 15:58:30 +02:00
QAston
fcc02a045a Core/Auras: Remove auras with AURA_INTERRUPT_FLAG_HITBYSPELL on spell hit, only when target hit is enemy. 2011-06-21 15:57:18 +02:00
tobmaps
a02d145a17 Core/Spells: Prevent hit main target by 5 yard AOE effect of Starfall
Closes #1186
Closes #2085
2011-06-21 19:45:36 +07:00
Machiavelli
8bf53f4a6b Fix copypasta mistake from acb47d, thanks to Lopin for pointing out. 2011-06-21 13:05:08 +02:00
QAston
2a47163771 Core/Auras: Fix work of proc auras are refreshed during proc event routine. 2011-06-21 12:03:54 +02:00
Machiavelli
aa55e2a417 Scripts/Ulduar/Flame Leviathan: Make Pool of Tar actually apply harmful auras without resetting instantly.
Closes #1798
2011-06-21 02:07:06 +02:00
Machiavelli
3f5453c657 Scripts/Ulduar/Kologarn: Fix Stone Shout target selection 2011-06-21 01:52:01 +02:00
Machiavelli
acb47d719c Scripts/Ulduar/XT002:
- Fix heart phase triggering if boss recovered health from scrapbots previously
- Fix scrapbot enter vehicle visual
- Allover cleanup and codestyle appliance
2011-06-21 01:15:43 +02:00
Lopin
77afbeb84e Scripts/Ulduar: Corrected Feral Essence amount of stacks 2011-06-20 17:20:25 +02:00
Lopin
24f4cf6cb5 Core/Achievements: Fixed achievement Safety Dance in Heigan the Unclean's encounter 2011-06-20 17:07:01 +02:00
Lopin
93a15bc528 Core/Achievements: Fixed achievement A Void Dance in Zuramat the Obliterator's encounter 2011-06-20 10:25:29 +02:00
Lopin
dbabcd0e20 Core/Achievements: Fixed achievement King's Bane in King Ymiron's encounter 2011-06-20 10:21:50 +02:00
tobmaps
afd524f36b Core/Misc: Some random cleanups and code style fixes 2011-06-20 04:04:20 +07:00
tobmaps
24764a674b Core/Spells: Fix crash with spellstealing of Divine Illumination 2011-06-20 03:39:07 +07:00
elecyb
66ce66ab73 Core/Spells: Fix diminishing group for Curse of the Elements 2011-06-20 01:15:33 +07:00
tobmaps
6c33347511 Core/Spells: Set a MaxDuration of spellstolen aura to the original aura MaxDuration 2011-06-19 23:08:41 +07:00
Lopin
50a716e031 Revert "Core/Spells: Fixed Righteous Fury stacking exploit"
This reverts commit b7d504a7e6.
2011-06-19 17:47:23 +02:00
Nay
62908812cb Core/Gossip: Ditch gossip_scripts as it is no longer used. SAI is a better option 2011-06-19 15:24:59 +01:00
Lopin
d77d5ce3fd Scripts/Ulduar: Remove Aura of Despair from players on Vezax's death 2011-06-19 15:43:57 +02:00
Lopin
ec82cc2e78 Core/Totems: Added new function allowing set totem's duration 2011-06-19 14:30:39 +02:00
Lopin
dbba53b745 Core/Spells: Fixed Sigil of the Vengeful Hearth 2011-06-19 14:29:51 +02:00
Lopin
b7d504a7e6 Core/Spells: Fixed Righteous Fury stacking exploit 2011-06-19 14:28:22 +02:00
Shauren
011e5a9003 Core/Achievements: Removed some hardcoded quest ids for achievement_criteria_data checks 2011-06-19 14:07:07 +02:00
Shauren
d3971b4944 Core/Achievements: Allow attaching criteria scripts to any criteria type 2011-06-19 13:51:14 +02:00
QAston
aebb75b816 Core/Auras: Move periodic aura effect handlers to separate functions, do a little cleanup in these, also allow periodic dummy/periodic trigger spell auras to tick when caster is not available. 2011-06-19 13:13:41 +02:00
Lopin
0f95cf7ffd Core/Spells: Fixed two more diminish returns - Curse of Tongues & Curse of Elements 2011-06-19 10:58:28 +02:00
Lopin
5edfc789ab Scripts/Ulduar: Fixed events and incorrect Feral Essence stacking of Feral Defender 2011-06-19 10:19:41 +02:00
elecyb
89c97b94fd Core/Spells: Judgment of Justice should be limited to 10 seconds in PvP
Closes #2036
2011-06-19 02:27:46 +07:00
Lopin
19ede8fa72 Core/Quests: Fixed destroying of quest items which start a quest and are also needed for completing this quest 2011-06-18 21:08:14 +02:00
click
f778c5e739 Whitespace cleanups... 2011-06-18 19:51:28 +02:00
Shocker
587eb053c6 Merge branch 'master' of github.com:TrinityCore/TrinityCore 2011-06-18 18:31:02 +03:00
Shocker
d7762a9ebb Core/Spells: Remove duplicated code for Tiny Abomination in a Jar 2011-06-18 18:30:37 +03:00
Shauren
5a18ee0e66 Core/Quests: Fixed autoaccept quests for quest chains 2011-06-18 17:15:52 +02:00
click
348ec6ddd5 Scripts/Ulduar: Fix non-PCH build 2011-06-18 15:41:45 +02:00
tobmaps
439fe1b95c Core/Spells: Fix typo in last rev 2011-06-18 20:23:13 +07:00
tobmaps
bfe1977f94 Core/Spells: Fix Seal of Vengeance and Seal of Corruption. Original patch by kezo90
Closes #1243
Closes #1461
2011-06-18 20:18:38 +07:00