Commit Graph

19904 Commits

Author SHA1 Message Date
Shauren
39175ac680 Core/Transports
* Fixed fall damage on transports while teleporting
* Fixed packets not being received by owner if sent by a controlled minion
* Fixed an issue when a teleporting transport would attempt to reload its creature passengers on old map

Closes #11140
2013-11-02 13:22:14 +01:00
Aokromes
8d15c4c743 DB/Misc: Correct some game event data
By Foldor, closes #10960
2013-11-02 10:10:48 +01:00
Aokromes
15efc1e30f DB/Loot: Voidwalker Minions are not meant to drop loot
By dr-j and Exodius closes #11012
2013-11-02 10:01:36 +01:00
Aokromes
a61872ac27 DB/Misc: Neltharaku
By untaught, closes #11031
2013-11-02 09:54:36 +01:00
Aokromes
5b404ec279 DB/SAI: Slaves of the Stormforged
By untaught, closes #10509
2013-11-02 09:00:22 +01:00
Aokromes
8576360360 DB/SAI: Sprouted Frond
By untaught, closes #11123
2013-11-02 08:57:01 +01:00
Aokromes
4355d55acd DB/Misc: Quest item "Drain Schematics" drop
By trickerer, fixes #10394
2013-11-02 08:52:20 +01:00
Aokromes
c04109047e DB/Misc: Fixes 2 innkeepers of Hallow's End event
By dr-j and untaught, closes #11108
2013-11-02 08:48:13 +01:00
Aokromes
f95769eb56 DB/Misc: Make invisible some visible Triggers
By untaught, closes #10648
2013-11-02 08:42:42 +01:00
Filip
3d5a317b75 DB/SAI: Dragonmaw Sky Stalker
By @MitchesD fixes #11148
2013-10-28 21:14:35 +01:00
jackpoz
f002b0552b Core/Vehicles: Add missing NULL check in cf72f7cc5c
Add an additional NULL check for me->GetVehicleKit() , otherwise the crash fixed in cf72f7cc5c becomes a NULL dereference crash.
2013-10-28 20:32:56 +01:00
Aokromes
f81316a5eb Merge pull request #11147 from LeGuybrush/master
Core/Code: Unify [more] codestyle for brackets: )\n{\n} to ) { }.
2013-10-28 12:19:13 -07:00
leguybrush
0a308144a8 Core/Code: Unify [more] codestyle for brackets: )\n{\n} to ) { }. 2013-10-28 14:36:07 -04:00
Aokromes
5cfd180247 Merge pull request #11138 from Ascathor/master
Core/Code: Unify codestyle for brackets: {} to { }.
2013-10-28 09:57:48 -07:00
Ascathor
7a7ad4a60a Core/Code: Adding copyright to all the mesh_extractor files. 2013-10-27 23:56:58 +01:00
Ascathor
2607738990 Core/Code: Unify codestyle for brackets: {} to { }.
Also added missing copyright to some files.
2013-10-27 23:46:02 +01:00
Shauren
cf72f7cc5c Core/Vehicles: Fixed a crash caused by accessing freed memory
Valgrind log:
==1357== Invalid read of size 8
==1357== at 0x108339C: std::_Rb_tree<signed char, std::pair<signed char const, VehicleSeat>, std::_Select1st<std::pair<signed char const, VehicleSeat> >, std::less<signed char>, std::allocator<std::pair<signed char const, VehicleSeat> > >::begin() (stl_tree.h:685)
==1357== by 0x1082B23: std::map<signed char, VehicleSeat, std::less<signed char>, std::allocator<std::pair<signed char const, VehicleSeat> > >::begin() (stl_map.h:321)
==1357== by 0x1567152: VehicleAI::CheckConditions(unsigned int) (CombatAI.cpp:330)
==1357== by 0x1566EE5: VehicleAI::UpdateAI(unsigned int) (CombatAI.cpp:285)
==1357== by 0x11A8FB3: Creature::Update(unsigned int) (Creature.cpp:543)
==1357== by 0x11BC1A2: TempSummon::Update(unsigned int) (TemporarySummon.cpp:47)
==1357== by 0x12E8194: Trinity::ObjectUpdater::Visit(GridRefManager<Creature>&) (GridNotifiersImpl.h:45)
==1357== by 0x12F31BD: void VisitorHelper<Trinity::ObjectUpdater, Creature>(Trinity::ObjectUpdater&, ContainerMapList<Creature>&) (TypeContainerVisitor.h:64)
==1357== by 0x12F2CCB: void VisitorHelper<Trinity::ObjectUpdater, Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > >(Trinity::ObjectUpdater&, ContainerMapList<TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > >&) (TypeContainerVisitor.h:70)
==1357== by 0x12F251F: void VisitorHelper<Trinity::ObjectUpdater, GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > >(Trinity::ObjectUpdater&, ContainerMapList<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > >&) (TypeContainerVisitor.h:71)
==1357== by 0x12F1BA5: void VisitorHelper<Trinity::ObjectUpdater, TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > >(Trinity::ObjectUpdater&, TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > >&) (TypeContainerVisitor.h:94)
==1357== by 0x12F0DDD: TypeContainerVisitor<Trinity::ObjectUpdater, TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > > >::Visit(TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > >&) (TypeContainerVisitor.h:105)
==1357== by 0x12EF5A0: void Grid<Player, TypeList<Player, TypeList<Creature, TypeList<Corpse, TypeList<DynamicObject, TypeNull> > > >, TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > >::Visit<Trinity::ObjectUpdater>(TypeContainerVisitor<Trinity::ObjectUpdater, TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > > >&) (Grid.h:91)
==1357== by 0x12ED766: void NGrid<8u, Player, TypeList<Player, TypeList<Creature, TypeList<Corpse, TypeList<DynamicObject, TypeNull> > > >, TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > >::VisitGrid<Trinity::ObjectUpdater, TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > >(unsigned int, unsigned int, TypeContainerVisitor<Trinity::ObjectUpdater, TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > > >&) (NGrid.h:157)
==1357== by 0x12EA2D3: void Map::Visit<Trinity::ObjectUpdater, TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > > >(Cell const&, TypeContainerVisitor<Trinity::ObjectUpdater, TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > > >&) (Map.h:701)
==1357== by 0x12DCD84: Map::VisitNearbyCellsOf(WorldObject*, TypeContainerVisitor<Trinity::ObjectUpdater, TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > > >&, TypeContainerVisitor<Trinity::ObjectUpdater, TypeMapContainer<TypeList<Player, TypeList<Creature, TypeList<Corpse, TypeList<DynamicObject, TypeNull> > > > > >&) (Map.cpp:604)
==1357== by 0x12DD045: Map::Update(unsigned int) (Map.cpp:646)
==1357== by 0x1520E03: MapUpdateRequest::call() (MapUpdater.cpp:54)
==1357== by 0x1596958: DelayExecutor::svc() (DelayExecutor.cpp:52)
==1357== by 0x5184E56: ACE_Task_Base::svc_run(void*) (in /usr/lib/libACE-6.0.3.so)
==1357== Address 0x2a849600 is 32 bytes inside a block of size 168 free'd
==1357== at 0x4C2BADC: operator delete(void*) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==1357== by 0x107F309: Vehicle::~Vehicle() (Vehicle.cpp:66)
==1357== by 0x10BE0D2: Unit::RemoveVehicleKit() (Unit.cpp:15949)
==1357== by 0x10B52CA: Unit::RemoveFromWorld() (Unit.cpp:13440)
==1357== by 0x11A7D73: Creature::RemoveFromWorld() (Creature.cpp:204)
==1357== by 0x11BCBAA: TempSummon::RemoveFromWorld() (TemporarySummon.cpp:279)
==1357== by 0x11BCD5E: Minion::RemoveFromWorld() (TemporarySummon.cpp:308)
==1357== by 0x10B5514: Unit::CleanupBeforeRemoveFromMap(bool) (Unit.cpp:13481)
==1357== by 0x10B5605: Unit::CleanupsBeforeDelete(bool) (Unit.cpp:13503)
==1357== by 0x12E3B67: Map::AddObjectToRemoveList(WorldObject*) (Map.cpp:2401)
==1357== by 0x10FCAAC: WorldObject::AddObjectToRemoveList() (Object.cpp:2138)
==1357== by 0x11BCABA: TempSummon::UnSummon(unsigned int) (TemporarySummon.cpp:256)
==1357== by 0x11BCAFA: ForcedUnsummonDelayEvent::Execute(unsigned long, unsigned int) (TemporarySummon.cpp:261)
==1357== by 0x159B665: EventProcessor::Update(unsigned int) (EventProcessor.cpp:47)
==1357== by 0x10858E2: Unit::Update(unsigned int) (Unit.cpp:318)
==1357== by 0x11A8E6C: Creature::Update(unsigned int) (Creature.cpp:519)
==1357== by 0x11BC1A2: TempSummon::Update(unsigned int) (TemporarySummon.cpp:47)
==1357== by 0x12E8194: Trinity::ObjectUpdater::Visit(GridRefManager<Creature>&) (GridNotifiersImpl.h:45)
==1357== by 0x12F31BD: void VisitorHelper<Trinity::ObjectUpdater, Creature>(Trinity::ObjectUpdater&, ContainerMapList<Creature>&) (TypeContainerVisitor.h:64)
==1357== by 0x12F2CCB: void VisitorHelper<Trinity::ObjectUpdater, Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > >(Trinity::ObjectUpdater&, ContainerMapList<TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > >&) (TypeContainerVisitor
2013-10-27 23:05:31 +01:00
Subv
29570076d5 Merge pull request #11137 from Ascathor/master
Core/Command: Fix ban info order for .pinfo
2013-10-27 12:41:46 -07:00
Ascathor
e5553cfb78 Core/Command: Fix ban info order for .pinfo 2013-10-27 20:38:33 +01:00
Filip
fa33c428e9 DB/Cond: Prevent multiple spawns in vicinity
By @dr-j fixes #11128
2013-10-27 19:15:57 +01:00
Shauren
f0794d7585 Core/Transports: Correct path generation for a few transports 2013-10-27 11:15:56 +01:00
Shauren
b81bf7d025 Core/Spells: Implemented additional conditions for spells that start cooldown after an event instead of after cast 2013-10-26 14:39:00 +02:00
jackpoz
daf5a4b5c3 Core/Chat Commands: Allow to add overlapping teles .
Allow to add overlapping teles like "abc" even if "abcde" already exists. This wasn't possible and a "Teleport already exists" error was thrown instead.
2013-10-25 21:50:52 +02:00
Subv
a14bbf773e Merge pull request #11120 from AliveShiro/battlefield_cosmetic
Game/Battlefield: Cosemtic changes
2013-10-25 09:06:57 -07:00
AliveShiro
cc89ac0be3 Game/Battlefield:
- Remove double definition of one NPC
- Use definition instead a "magic number"
2013-10-25 17:30:24 +02:00
Filip
5e62edd7c9 Db/Update: Rockjaw Backbreaker script spam
By @untaught fixes #11112
2013-10-25 15:52:26 +02:00
Shauren
f93ac805fd Core/Transports: Fixed double deleting IoC transports 2013-10-25 12:37:48 +02:00
Filip
b926039e18 DB/SAI: Cleansing the Scar
By @untaught fixes #11117
2013-10-24 21:19:20 +02:00
Filip
8949636257 DB/SAI: Swift Discipline
By @untaught fixes #11118
2013-10-24 21:19:16 +02:00
Filip
626f1f0f9f DB/Errors: Db error clean up
By @untaught fixes #11116
2013-10-24 15:18:15 +02:00
Discover-
950ac949cb DB/SAI: Fix scripts using SMART_TARGET_NONE that were 'broken' by 9653576cb4. 'Broken' is quoted because scripts using SMART_TARGET_NONE are most of the time broken by default anyway. 2013-10-24 06:22:00 +02:00
Filip
f6f102c70b DB/SAI: Add Gymer text and faction friendly to horde also. 2013-10-23 14:09:43 +02:00
Filip
63cfb712d3 DB/SAI: This just in: Fire still hot!
By @untaught fixes #10752
2013-10-23 13:45:11 +02:00
jackpoz
cdcee93854 Core/IoC: Fix uninitialized timer
Fix uninitialized Docks timer in Isle Of Conquest .

Valgrind log:
 Conditional jump or move depends on uninitialised value(s)
  at : BattlegroundIC::HandleCapturedNodes(ICNodePoint*, bool) (BattlegroundIC.cpp:665)
  by : BattlegroundIC::PostUpdateImpl(unsigned int) (BattlegroundIC.cpp:228)
  by : Battleground::Update(unsigned int) (Battleground.cpp:300)
  by : BattlegroundMgr::Update(unsigned int) (BattlegroundMgr.cpp:93)
  by : World::Update(unsigned int) (World.cpp:2062)
2013-10-22 22:59:47 +02:00
Gacko
635e1467a4 Rename SQL file (thx Aokromes) 2013-10-22 20:40:43 +02:00
Gacko
e8e148bee9 Rename sql file and apply some code style. *sigh* 2013-10-22 20:27:50 +02:00
gerripeach
5c0cf982a7 Core/Spell: Shaman Bloodlust/Heroism ignore LOS
closes: #6307
2013-10-22 20:27:50 +02:00
Vincent_Michael
9802c7b891 Scripts/Misc: Coding Style unification? (by Aokromes) 2013-10-22 20:24:05 +02:00
Gacko
0f92d513f8 Merge pull request #11092 from gerripeach/pull_request
Core: add missing comment
2013-10-22 11:14:10 -07:00
gerripeach
d745e32f1c Core: add missing comment 2013-10-22 17:24:59 +02:00
Shauren
06f5011071 Core/Auras: Added serverside checking for UNIT_FLAG_PACIFIED when attempting to start melee attack
Closes #8623
2013-10-22 17:09:41 +02:00
Shauren
3e12fe84c8 Core/Transports: Fixed players taking fall damage when teleporting from transports
Closes #11076
2013-10-22 17:02:01 +02:00
Discover-
0cc32e28e3 Core/SAI: Rename SMART_EVENT_TARGET_CASTING to SMART_EVENT_VICTIM_CASTING as that's what it actually does. It was often confused to use the target_type field instead of the victim. 2013-10-22 15:59:32 +02:00
jackpoz
fc947e2508 Core/Quest: Remove assertion
Remove assertion about Quest ExclusiveGroup since they are triggered even when adding valid quests to npcs. Fixes #8336 .
How to reproduce steps:
- .gm off
- add quest 11335 in creature_queststarter
- .reload creature_queststarter
- get in range of that creature
- .gm on
- assertion triggered
2013-10-21 23:41:31 +02:00
Filip
989cc35d8c DB/SAI: Misc Fixes from IT
By @dr-j and @untaught
Fixes #11081 fixes #11080 fixes #11082
2013-10-21 23:11:38 +02:00
Subv
4123468f72 Merge pull request #11050 from Ascathor/master
Core/Command: Improve .group list to feature several notes and features ...
2013-10-21 05:28:35 -07:00
Discover-
1a6157985c Core/Misc: Get rid of some useless code 2013-10-21 09:15:17 +02:00
Aokromes
2853e57c3f Merge pull request #11077 from Elron103/pullrequests2
DB/Gossip: Update some data for trainer NPCs from sniffs
2013-10-20 07:47:09 -07:00
Elron103
468425608a DB/Gossip: Update some data for trainer NPCs from sniffs 2013-10-20 16:40:39 +02:00
Shauren
b6db622b52 Core/Transports: Fixed crashes happening when passenger is removed from transport during teleport
Closes #11067
2013-10-20 14:27:17 +02:00