ForesterDev
448facc5e7
Core/Spells: Fixed warlock's Banish cancel if target was already banished ( #23697 )
...
* Core/Spells: Add SpellMissInfo argument to BeforeHit hooks and call them also when the spell doesn't hit. (#17613 )
(cherry picked from commit 8ff5b35be1 )
# Conflicts:
# src/server/game/Spells/Spell.cpp
# src/server/scripts/Northrend/IcecrownCitadel/boss_the_lich_king.cpp
# src/server/scripts/Spells/spell_warlock.cpp
* Core/Spells: Fixed warlock's Banish cancel if target was already banished (#17614 )
(cherry picked from commit 4587b5d880 )
# Conflicts:
# src/server/scripts/Spells/spell_warlock.cpp
2019-08-23 19:24:56 +02:00
Keader
10f6e38185
nopch fix
2019-08-21 23:08:36 -03:00
Keader
cbc01f35b6
Core/Scripts: Proper fix Gal'Darah Puncture remove
2019-08-21 23:03:25 -03:00
Keader
1886507e7f
Fix nopch build
2019-08-20 06:35:02 -03:00
Keader
130a3859ec
Scripts/Gundrak: Fixed Puncture when Gal'darah die
2019-08-19 23:52:04 -03:00
Keader
61ad87d106
Scripts/Gundrak: Added a missing entry in Gal Darah Stampede Charge script
...
Noob Keader, Shame !
2019-08-18 13:07:18 -03:00
Treeston
a5e73e41c0
Core/Pooling: Quest pooling rewrite: (PR#23627)
...
- Split quest pooling from PoolMgr (into QuestPoolMgr)
- Proper saving/restoring on server restart
- No more hacking into sObjectMgr to insert/remove available quests
2019-08-04 12:22:57 +02:00
Treeston
4a219eda07
Core/Unit: Spell focusing now no longer nonsensical. HasSpellFocus always const. Error logs for various stuff.
2019-08-04 01:26:20 +02:00
ccrs
85ad0befc5
Core/Unit: rename more methods
...
Workaround prework till actual facing system rework arrives
2019-08-03 17:53:22 +02:00
ccrs
ec9f15a5ff
Core/Unit: rename IsFocusing method
...
Workaround prework till actual facing system rework arrives
2019-08-03 17:45:06 +02:00
Treeston
7fa990edc6
Scripts/ICC: Prevent Professor Putricide from displaying weird behavior during the Rotface/Festergut encounters as a result of his boss boundary
2019-07-31 16:02:29 +02:00
ForesterDev
0c317498a5
Scripts/Defines: cleanup some magic numbers in factions ( #23631 )
2019-07-25 12:54:49 +02:00
Treeston
0e7c66cb4c
Core/AI: Finally move the "is creature engaged" flag to be a property of the creature AI, where it honestly always belonged. Fixes #17981 and #23602 for real this time.
2019-07-21 01:50:52 +02:00
Wyrserth
e7cf24d263
Script/BoreanTundra: move Pile of Fake Furs' script (related to quest Unfit for Death) from ItemScript to SpellScript.
...
Closes #21890 .
2019-07-17 19:57:21 +02:00
Treeston
d60082ae86
Core/Misc: Various dynspawn cleanup and refactors split off from pooling rewrite:
...
- Map::RemoveRespawnTime(SpawnObjectType, LowType, doRespawn) split into Map::Respawn and Map::RemoveRespawnTime, without the extra boolean
- Map::RemoveRespawnTime(RespawnInfo*) merged into Map::DeleteRespawnInfo(RespawnInfo*) and is now private
- Map::DeleteRespawnInfo(void) renamed to Map::UnloadAllRespawnInfos to properly describe what it does
- Map::ProcessRespawns now actually saves the delayed respawn time to DB if the respawn was delayed
- Map::AddRespawnInfo now takes const reference, and returns success as a boolean
- Map::AddRespawnInfo no longer offers an unused "replace" parameter
- Map::DeleteRespawnInfo no longer offers a variety of unused private overloads
- Map::SaveRespawnTime no longer offers a tantalizing writeDB parameter. Parameter is now called "startup" to properly describe what it does.
- Map::SaveRespawnInfoDB now takes RespawnInfo reference instead of all the various fields. Still public because compatibility mode. QQ.
- Map::GetWorldObjectBySpawnId sanitized
- Map::GetXRespawnTime methods sanitized to all go through Map::GetRespawnTime
2019-07-15 17:14:58 +02:00
Treeston
be96d8242c
warning fix f2cd721 follow-up
2019-07-08 21:53:50 +02:00
Treeston
f2cd721d53
Scripts/Naxxramas: Thaddius no longer evades on transition, and some general cleanup to that script. Fixes #23026 .
2019-07-08 20:16:29 +02:00
jackpoz
283ac3d374
Core/Misc: Fix no-pch build
2019-07-07 13:35:11 +02:00
Wyrserth
644910bdc1
DB/Trainer: remove required ability from Riding spells. The client should only show the required amount of skill.
...
Also comment out unused argument in previously committed script, thanks Aokromes for noticing!
2019-07-07 02:57:24 +02:00
Wyrserth
6199d458c3
Core/Misc: use Trinity's RandomShuffle() instead of soon-to-be-deprecated std::random_shuffle().
...
Thanks Riztazz for noticing!
2019-07-07 02:49:40 +02:00
Wyrserth
37862942ce
Script/TheOculus: adapt Mage-Lord Urom's script to use EventMap, fix various issues with Teleport and Empowered Arcane Explosion, add missing heroic-mode spell Frost Buffet.
...
Closes #19452 .
2019-07-07 02:32:53 +02:00
Wyrserth
30ba9c97fe
Misc: explicitly mark fallthrough in switch statement as to avoid confusion.
2019-07-05 17:09:46 +02:00
Gildor
a0a64b10b5
Scripts/Icecrown Citadel: Ensure Deathbringer Saurfang cast Frenzy ( #23559 )
2019-07-03 19:32:27 +02:00
Wyrserth
a8b8a43b8d
Script/HallsOfLightning: fix mistake related to Shattering Stomp in Volkhan's script, introduced in 3bb0abcd52.
...
Closes #23337 .
2019-07-02 11:12:34 +02:00
ccrs
401777d024
Core/Unit: rename several getters to follow codestyle
...
uint8 GetLevel()
uint8 GetLevelForTarget(WorldObject const* /*target*/)
void SetLevel(uint8 lvl)
uint8 GetRace()
uint32 GetRaceMask()
uint8 GetClass()
uint32 GetClassMask()
uint8 GetGender()
2019-07-01 21:36:32 +02:00
ccrs
4c398743b9
Scripts/ICC: cleanup ReadSaveDataMore definition
2019-07-01 01:08:21 +02:00
ccrs
b19a23a5c6
Scripts/ICC: 3dbf3fe followup
...
repeat timer typo
2019-07-01 00:56:05 +02:00
ccrs
aabf181bdf
Build: fix error
...
/home/circleci/project/src/server/scripts/Northrend/IcecrownCitadel/boss_sister_svalna.cpp:211:5: fatal error: redefinition of enumerator 'NPC_YMIRJAR_BATTLE_MAIDEN'
NPC_YMIRJAR_BATTLE_MAIDEN = 37132,
^
/home/circleci/project/src/server/scripts/Northrend/IcecrownCitadel/icecrown_citadel.h:274:5: note: previous definition is here
NPC_YMIRJAR_BATTLE_MAIDEN = 37132,
^
1 error generated.
2019-06-30 19:54:05 +02:00
ccrs
3dbf3fed7c
Scripts/ICC: base support for Ymirjar Vrykuls AI
2019-06-30 19:48:50 +02:00
ccrs
3e9b553618
Scripts/ICC: 1eb2aef followup
2019-06-30 18:10:23 +02:00
ccrs
1eb2aef179
Scripts/ICC: move Sister Svalna to her own file
...
I've almost guttered her, so lets try it more gently this time
2019-06-30 17:50:30 +02:00
ccrs
eb6ea57e7f
Scripts/ICC: 94b60ff followup
2019-06-29 19:38:16 +02:00
ccrs
22b3b21ae3
Core/Instances: improve DoRemoveAurasDueToSpellOnPlayers & DoCastSpellOnPlayers handling
2019-06-29 18:36:11 +02:00
ccrs
626a24822b
Misc: some corrections after recent merges
2019-06-29 16:01:58 +02:00
Sorikoff
8d1a5fa126
Scripts/Spells: Remove Collapsing Cave Aura ( #23533 )
...
* Scripts/Spells: Remove Collapsing Cave Aura
* Rename 9999_99_99_99_world.sql to 2019_06_29_00_world.sql
2019-06-29 13:35:11 +02:00
jackpoz
de88691e25
Core/Misc: Fix static analysis issues reported by Coverity Scan
2019-06-28 22:18:30 +02:00
Sorikoff
62b2c379b3
Scripts/Spells: Deathbolt ( #23531 )
...
* Scripts/Spells: Deathbolt
* Rename 9999_99_99_99_world.sql to 2019_06_28_01_world.sql
2019-06-28 20:18:02 +02:00
Keader
079b77b5fc
Script/FoS: prevent Wailing Souls from becoming desynched in the Devourer of Souls encounter.
2019-06-26 17:32:06 +02:00
ccrs
4a8736b829
Scripts/Misc: couple corrections to the recent PRs
2019-06-24 13:32:43 +02:00
Treeston
1158f267df
Combat/Threat: Split ThreatManager::NotifyDisengaged off from ThreatManager::ClearAllThreat. NotifyDisengaged signifies intent to clear the engagement flag, and should only be called from AI. Fixes #23490 .
2019-06-23 23:31:51 +02:00
Sorikoff
40b09e3df1
Scripts/Spells: Ultra-Advanced Proto-Typical Shortening Blaster ( #23456 )
...
* Scripts/Spells: Ultra-Advanced Proto-Typical Shortening Blaster
* Fix NoPCH
* Correct header
* fixup! Clean up
* Rename 9999_99_99_99_world.sql to 2019_06_22_00_world.sql
2019-06-22 09:44:23 +02:00
Keader
f9a366628a
Build fix
2019-06-20 21:20:58 -03:00
Keader
3b0743ea67
Scripts/Icecrown Citadel: Fixed some bugs on Blood Orb object and trash mobs around him
...
Followup: 394b119664
2019-06-20 21:11:56 -03:00
Keader
70cbedd75d
Core/Scripts: Fixed a reference error introduced in 394b119664
2019-06-17 13:06:24 -03:00
Keader
394b119664
Scripts/Icecrown Citadel: Fixed Blood Orb Game Object ( #23397 )
...
Close #18005 and Update #18529
2019-06-17 08:38:37 -03:00
Keader
94b60ff0ef
Core/Misc: Implemented Icecrown Citadel buff disable ( #23394 )
...
Closes #8576
Closes #7940
2019-06-12 15:22:32 -03:00
Keader
136964769d
Scripts/Icecrown Citadel: Fixed Heroic Attempts logic ( #23379 )
2019-06-07 08:18:48 -03:00
Wyrserth
5016f588d5
Script/Dalaran: don't allow Dalaran faction guards to teleport a player that has the Trespasser! debuff. ( #23373 )
2019-06-06 11:40:53 +02:00
Wyrserth
b5e04c8920
Script/Quest: implement event for the quest Orabus the Helmsman ( #23346 )
...
* Script/Quest: implement event for the quest Orabus the Helmsman.
Thanks Wyreth for the original script.
* Fix coordinates that I inverted by mistake.
* Rename 9999_99_99_99_world.sql to 2019_06_04_04_world.sql
2019-06-04 19:21:40 +02:00
Wyrserth
65aea13c25
Script/GunDrak: fix order for yell and altar texts on death for two bosses ( #23357 )
2019-06-03 22:35:50 +02:00