Commit Graph

798 Commits

Author SHA1 Message Date
offl
496eba4e8d Scripts/Spells: Correctly implement Murmur's Touch & Dire Brew (#28058)
(cherry picked from commit f0d2418e5f)
2022-09-05 19:37:13 +02:00
Shauren
b08a58dec6 Core/Misc: Reduce differences between branches (refactors from 44ac5cbbea) 2022-09-02 15:12:28 +02:00
Shauren
073a036d84 Core/Battlefields: Refactor Battlefield creation to be linked to host map creation instead of having globally accessible objects 2022-07-19 23:18:19 +02:00
Aqua Deus
2358e51182 Scripts/Spells: Fix mage spell Ray of Frost (#28090) 2022-07-16 16:04:06 +02:00
Shauren
3d34febd6d Core/Auras: Don't save auras to db with SpellAuraInterruptFlags::LeaveWorld 2022-07-07 16:03:43 +02:00
Meji
a1f673d1ca Core/BattlePets: Move BattlePet stuff from SpellMgr to BattlePetMgr (#27986) 2022-06-09 13:58:54 +02:00
Shauren
94aac14b4d Core/Spells: Rename SpellAttr6 to use official attribute names 2022-05-06 20:23:13 +02:00
Shauren
d800c87137 Core/Misc: Remove implicit conversions from RaceMask class, fixes racemask check failing during loading from db 2022-05-06 18:45:51 +02:00
Shauren
d818add0e2 Core/Auras: Added support for SPELL_ATTR5_LIMIT_N limit to other number than just 1 2022-05-02 16:14:41 +02:00
Shauren
738f285432 Core/Spells: Rename SpellAttr5 to use official attribute names
* Implemented SPELL_ATTR8_HASTE_AFFECTS_DURATION
2022-05-02 01:11:38 +02:00
Shauren
8d16a79dea Core/Spells: Rename SpellAttr4 to use official attribute names
* Corrected implementation of SPELL_ATTR4_CLASS_TRIGGER_ONLY_ON_TARGET
* Implemented SPELL_ATTR4_NO_HELPFUL_THREAT
* Implemented SPELL_ATTR4_NO_PARTIAL_IMMUNITY
* Implemented SPELL_ATTR4_ALLOW_PROC_WHILE_SITTING
* Implemented SPELL_ATTR4_USE_FACING_FROM_SPELL
* Implemented SPELL_ATTR4_BOUNCY_CHAIN_MISSILES
* Implemented SPELL_ATTR4_AURA_NEVER_BOUNCES
* Implemented SPELL_ATTR4_AURA_BOUNCE_FAILS_SPELL
* Implemented SPELL_ATTR4_AURA_IS_BUFF
* Implemented SPELL_ATTR5_MELEE_CHAIN_TARGETING

* Implemented SpellEffectAttributes::ChainFromInitialTarget
2022-05-01 20:01:13 +02:00
Shauren
88d7b58a3d Core/Spells: Rename SpellAttr3 to use official attribute names
* Implemented SPELL_ATTR3_NO_AVOIDANCE
* Implemented SPELL_ATTR3_ONLY_PROC_OUTDOORS
* Implemented SPELL_ATTR3_ONLY_PROC_ON_CASTER
* Implemented SPELL_ATTR3_PVP_ENABLING
* Implemented SPELL_ATTR3_SUPPRESS_CASTER_PROCS
* Implemented SPELL_ATTR3_SUPPRESS_TARGET_PROCS
2022-04-30 16:57:32 +02:00
Shauren
dda375b986 Core/Spells: Rename SpellAttr2 to use official attribute names
* Corrected implementation of SPELL_ATTR1_ALLOW_WHILE_STEALTHED
* Implemented SPELL_ATTR2_RETAIN_ITEM_CAST
* Implemented SPELL_ATTR2_ALLOW_WHILE_INVISIBLE
* Implemented SPELL_ATTR0_PROC_FAILURE_BURNS_CHARGE
* Implemented SPELL_ATTR2_PROC_COOLDOWN_ON_FAILURE
* Implemented SPELL_ATTR2_NO_TARGET_PER_SECOND_COSTS
* Implemented SPELL_ATTR2_DO_NOT_REPORT_SPELL_FAILURE
* Implemented SPELL_ATTR1_REQUIRE_ALL_TARGETS
* Implemented SPELL_ATTR2_CHAIN_FROM_CASTER
* Implemented SPELL_ATTR2_NO_ACTIVE_PETS
* Implemented SPELL_ATTR2_ENCHANT_OWN_ITEM_ONLY
2022-04-28 18:31:26 +02:00
Shauren
c88b602a2c Core/Spells: Rename SpellAttr1 to use official attribute names
* Implemented SPELL_ATTR1_NO_SKILL_INCREASE, SPELL_ATTR1_AURA_STAYS_AFTER_COMBAT, SPELL_ATTR1_DISPEL_ALL_STACKS
2022-04-25 22:16:56 +02:00
Shauren
a31e681944 Core/Spells: Rename SpellAttr0 to use official attribute names 2022-04-24 18:40:10 +02:00
Traesh
87723e32e2 Core/Battlegrounds: Implement mercenary system 2022-04-16 12:15:37 +02:00
Grindelwald
a799a10a90 Core/Spells: Add MaxAffectedTargets for Domination (#27541)
(cherry picked from commit 5f0e80bf43)
2022-03-24 23:50:03 +01:00
Grindelwald
67954a6991 Core/Spells: Add MaxAffectedTargets to Chains of Naberius(36146) (#27291)
Closes #27289

(cherry picked from commit c3973ff577)
2022-03-22 23:18:01 +01:00
Keader
8d841679fc Scripts/ScarletMonastery: Headless Horseman Rewrite (#25614)
(cherry picked from commit a93abcf803)
2022-02-28 23:38:36 +01:00
Shauren
02979daf76 Core/Auras: Proc flag updates
* Rename to official names
* Corrected logic selecting flags for each spell cast - determine them by attributes instead of DmgClass
* Implemented new proc flags (PROC_FLAG_CAST_ENDED, PROC_FLAG_LOOTED)
2022-02-10 21:11:07 +01:00
Shauren
68a662ae04 Core/Spells: Add type safety to proc related functions - using enum arguments instead of plain integers 2022-02-10 12:25:27 +01:00
Shauren
3844c79adb Core/Spells: Load entire proc flags array from db2 2022-02-09 23:46:29 +01:00
Shauren
b6bc8a50ac Core/Spells: Correct implementation of SPELL_ATTR2_TRIGGERED_CAN_TRIGGER_PROC, SPELL_ATTR3_TRIGGERED_CAN_TRIGGER_PROC_2, SPELL_ATTR3_CAN_PROC_WITH_TRIGGERED and rename them (SPELL_ATTR2_ACTIVE_THREAT, SPELL_ATTR3_NOT_A_PROC, SPELL_ATTR3_CAN_PROC_FROM_PROCS) 2022-02-02 13:56:49 +01:00
Robingad
3e725e1d25 Scripts/Spells: Fix shaman Earthquake (#27620)
Co-authored-by: Shauren <shauren.trinity@gmail.com>
2022-01-27 22:18:46 +01:00
Giacomo Pozzoni
864d775280 Core/Misc: Fix static analysis issues (#25194)
(cherry picked from commit 07fd84b679)
2022-01-26 14:06:40 +01:00
Trond B. Krokli
fa444aca66 Scripts/Quest: Force of Neltharaku quest credit (#24807)
* Scripts/Quest: Force of Neltharaku quest credit

**Description:**

Suggested solution to resolve the kill credit double cast issue
in the quest "The Force of Neltharaku" (10854).

by Rushor

**Changes proposed:**

- Remove duplicate spell casts in the zone quest script
- Remove commented-out script section
- Set a couple of unit flags (anim/stand/hover)
- Move return new creature script override to end of script
- Move PlayerGUID, FlyTimer, and Tapped to Private
- Add DB flight movement control to Enslaved Netherwing Drake
- Add SpellMgr MaxAffectedTargets = 1 for spell 38762
- Add movement enum POINT_MOVE_UP
- Add missing enum for quest ID

**Target branch(es):** 3.3.5/master

- [X] 3.3.5
- [X] master

**Issues addressed:** Closes #24796

**Tests performed:** (Does it build, tested in-game, etc.)

Pending for now.

**Known issues and TODO list:** (add/remove lines as needed)

- [X] Open PR in draft mode until testing is cleared
- [ ] Compile and create local server
- [ ] Test changes on local server

* Rename 9999_99_99_99_world.sql to 2020_07_29_00_world.sql

Co-authored-by: Rushor <Rushor@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit e0dae8feb6)
2022-01-24 13:19:36 +01:00
Peter Keresztes Schmidt
ad340466d0 Misc: Use [[fallthrough]] attribute instead of comment to mark intentional fallthroughs (#25054)
Related: #25006
(cherry picked from commit 85b5b842ca)
2022-01-23 22:02:03 +01:00
Shauren
b4b58c563b Core/Spells: Fixed typo in loading serverside spells 2022-01-11 21:08:22 +01:00
Shauren
415aaae7f2 Core/Spells: Validate spell_proc.AttributesMask on startup 2022-01-11 19:05:35 +01:00
Shauren
241193cd02 Core/Items: Implemented many new enchantment flags 2022-01-09 16:31:12 +01:00
Shauren
bd60df2ce0 Scripts/Spells: Fixed mage talent Chrono Shift
Closes #19575
2022-01-07 22:46:00 +01:00
Carbenium
49523a74a4 Battlefields: Move BF scripts out of game
This commit introduces the usual script interface
for battlefields.

(cherry picked from commit f7faf20254)
2022-01-07 00:20:57 +01:00
Keader
4110a06e81 Core/Misc: Fixed resistance calculate for Mutated Transformation and Twilight Bloodbolt (#24717)
Ref: 9f7b464a6a
- Implemented a new SpellScript hook that allow control Resistance/Absorb amount of a damage spell.

(cherry picked from commit d81a9e5bc3)
2022-01-06 19:59:50 +01:00
Killyana
6300b096ac DB/Pet: Lil' K.T
Ref #1364

(cherry picked from commit ee5eace3c6)
2022-01-01 21:49:09 +01:00
Killyana
567b26e0c7 DB/Pet: Toxic Wasteling
Closes #12773

(cherry picked from commit 3f5e0927c3)
2022-01-01 21:42:51 +01:00
Killyana
ad2e5aabc4 Spell: Move "Dark Conclave Ritualist Channel" outside Ulduar spells
(cherry picked from commit 9e58573272)
2022-01-01 20:04:42 +01:00
Killyana
b4dd7c642b Spell: Fix "Dark Conclave Ritualist Channel" range and cast
(cherry picked from commit 64878e19fb)
2022-01-01 20:02:50 +01:00
NoName
37178ff311 Core/Spells: SPELL_AURA_48 implementation (#24054)
by xvwyh

(cherry picked from commit b3b7f0761d)
2021-12-20 22:30:41 +01:00
Killyana
ef794af489 Spell: "Fierce Lightning Stike" must hit only one target
(cherry picked from commit 8942142286)
2021-12-20 22:15:44 +01:00
Keader
b9def15aa7 Scritps/ICC: Fixed resistance calculation for Mutated Transformation (Professor Putricide) (#23858)
More Info in: #23837

(cherry picked from commit 9f7b464a6a)
2021-12-19 15:33:41 +01:00
Trond B. Krokli
3e835a77bb Core/Spells: add spell fix to Trained Rock Falcon (#23896)
fixed by sirikfoll

(cherry picked from commit 42f1861f30)
2021-12-18 23:43:49 +01:00
Keader
03a1b03633 Scripts/Forge of Souls: Fixed spell Soul Sickness (#23843)
(cherry picked from commit 34ee2effc8)
2021-12-18 22:37:30 +01:00
tarwyn
474d903d79 Fix inconsistent NPC aggro on spell miss (#23816)
(cherry picked from commit c8dc9fdc41)
2021-12-18 22:23:00 +01:00
AlιAѕѕaѕѕιN
e1598fa1d6 [3.3.5] Fix spell_area not checking for zoneID for quests (#23719)
* Fix spell_area not checking for zoneID for quests

* Addendum to bdffe0a4a6

* Fix spell_area handle same spell with the same quests

Also fix not checking for quest_end at all.

* Addendum to 2d6b0545e3

* Better commenting for 7a50189de3

* Addendum to 2d6b0545e3

(cherry picked from commit 92d83c3c2e)
2021-12-18 21:31:17 +01:00
Aokromes
fc7ea18039 Core/Spells: Survey Sinkholes will now have a bigger range to be able…
… to hit all trigger npcs

By Ovahlord

(cherry picked from commit 028db8432e)
2021-12-18 20:31:45 +01:00
Treeston
2b65dbbeab Core/Misc: Kick a Totem error log upstairs one stack frame to give it access to various debug info and make Aokromes happy.
(cherry picked from commit e813200e5e)
2021-12-17 22:36:55 +01:00
Treeston
b8c7260bfd typo fix, duplicate assignment
(cherry picked from commit 7d6896b541)
2021-12-15 22:41:58 +01:00
Killyana
4378ad98ab DB/Quest: Seeds of the Blacksouled Keepers
(cherry picked from commit 42abf69a27)
2021-12-15 21:51:07 +01:00
Martin Topholm
dc0728b9a0 Script/BlackrockDepths: fix Ironhand Guardian's Gout of Flame spell cast. (#21816)
(cherry picked from commit 4529a94e0d)
2021-12-14 21:19:01 +01:00
Wyrserth
f31d8f7ffb Script/Acherus: script out of combat event for Frost Death Knight trainer Amal'thazad.
(cherry picked from commit 8fcc82138f)
2021-12-14 21:11:10 +01:00