Commit Graph

20096 Commits

Author SHA1 Message Date
joschiwald
9bc85921bf Update RBAC.h 2017-05-14 11:43:13 +02:00
TecDian
4b8644d6e6 Scripts/Events: Add missing line for "Love is in the air" boss fight (#19521) 2017-05-14 11:30:02 +02:00
Rochet2
6e3a48c873 Core/Gossip: Fix gossip bug on modify money (#19551) 2017-05-14 11:27:42 +02:00
ariel-
05b42eef7e Core/Unit: don't clear low health aura states on death
- Confirmed with sniffs, healthless states aren't cleared
- Prevents some procs from happening

Closes #19754
2017-05-14 06:11:49 -03:00
Aokromes
cacde7b9f5 Core/Logs: Reword some logs 2017-05-12 10:40:22 +02:00
xinef1
538f60a880 Core/Quests: Display quest objective explore completion message
- Game client should show an on-screen message for explored quest objectives
  (AreaExploredOrEventHappens) when the objective has been completed.

Closes #19543
2017-05-07 20:15:19 +02:00
ariel-
1d905b78ec Core/Globals: fix array out of bounds crash on loading npc_text_locale
Closes #19556
2017-05-07 05:35:30 -03:00
ariel-
c3176a8143 Core/Players: fix null dereference crash 2017-05-06 15:49:56 -03:00
ariel-
97e608b053 Core/Entities: allow guardian pets to inherit spellmods 2017-05-05 19:27:28 -03:00
Chazy Chaz
4843544c21 Scripts/Commands: Update reload commands names 2017-05-05 05:52:49 +02:00
Mikhail Redko
8a5b998f48 Core/Spells: Move Big Blizzard Bear implementation to spell script (#19544) 2017-05-04 12:46:10 -03:00
Chazy Chaz
5ff8601d36 Core/Misc: Update locales_gossip_menu_option to simple system 2017-05-04 17:35:43 +02:00
Chazy Chaz
838b46e33e Core/Misc: Update locales_npc_text to simple system 2017-05-04 17:11:35 +02:00
Chazy Chaz
d17a45ee7e Core/Misc: Update locales_creature_text to simple system 2017-05-04 16:46:53 +02:00
Shauren
011b8847d1 Core/Movement: Ported teleport packet fixes from master branch to get rid of ugly relocations 2017-05-03 17:48:42 +02:00
ccrs
b6274578b1 Core/Unit: revert recent changes
master cherry pick incomming :D
2017-05-03 15:14:41 +02:00
ccrs
d92132f1dc Core/Unit: 6fe4d37f8d followup 2017-05-03 14:14:37 +02:00
Aokromes
5cdbbc29ab Core/Achievement: Fix startup 2017-05-03 05:49:31 +02:00
Chaouki Dhib
d625c0f619 Core/Spells: change to the way the spell effect SPELL_EFFECT_JUMP work 2017-05-02 23:59:21 +02:00
Chazy Chaz
309a7f7e2a Core/Misc: Update locales_achievement_reward to simple system
Closes #19528
2017-05-02 23:56:26 +02:00
ccrs
6fe4d37f8d Core/Unit: SendTeleportPacket corrections 2017-05-02 14:57:10 +02:00
ccrs
17579f8d91 Core/Creature: drop method SetPosition
eeeevil, use UpdatePosition. It was there just for old scripts compatibility.
2017-05-02 14:18:42 +02:00
ccrs
dd2151cc7a Core/Transport: fix logic error
justStopped was always set true, but when transports spawn and remain stationary timer, _currentFrame->ArriveTime and _currentFrame->DepartureTime are set to 0, making justStopped always remain true and triggering incorrect calls.
2017-05-02 13:47:51 +02:00
ccrs
b74264aef4 Core/Creature: IsMovementPreventedByCasting followup
Handle correctly move allowed channels: IsChannelActive checks if channel phase has started (after cast if any)
Must skip the other checks since all channels focus target.

ref #19532
2017-05-02 11:43:50 +02:00
ariel-
aa0b7dd152 Core/Misc: build fixes 2017-05-01 18:52:15 -03:00
ariel-
f913f3bb89 Core/Scripts: unified scripted gossip/quest api
- Changed self-accessor on GameObjectAI to "me", like UnitAI
- Moved all related functions to AI, now Unit and GameObject have the same function names with identical behaviour
- Remove "OnUpdate" from CreatureScript/GameObjectScript, was never used and we already have AI Update method
- Quest methods no longer return a bool, the return value was used to call the AI version if the ScriptMgr one returned false
- Implemented GameObjectAI::Destroyed hook (was never called), implemented Damaged method
- Rename OnStateChanged to OnLootStateChanged to reflect when it's really called, and created a new hook OnStateChanged that only gets called on GOState change
- Since the functions are now only getting called from AI, made GetAI methods full virtual. (CanSpawn method is anyways going to be used on creatures with AI)
2017-05-01 18:19:36 -03:00
ariel-
231ec8331b Core/Entities: moved PetAura handling to Player where it belongs 2017-04-28 19:12:48 -03:00
ariel-
b6b59f6c23 Core/Scripts: remove OnDummyEffect hook/sOnDummyEffect ai hook
- Duplicated logic never used, sometimes only ScriptMgr version was called, sometimes only AI
- They only encourage bad scripting practices
- You can still use OnSpellHit or a SpellScript
2017-04-28 18:59:14 -03:00
ariel-
4c4dca6d69 Core/Misc: camelize GetFaction/SetFaction properly 2017-04-28 18:37:38 -03:00
ccrs
5a2f0ce29e Core/Unit: revert 3ea46e57af
After discussion we realized, ariel and me, that Creature and Unit IsMovementPreventedByCasting() have not the same checks (order matters)
2017-04-27 19:40:23 +02:00
ariel-
3ea46e57af Core/Unit: 229444b74a follow-up
- IsFocusing is made virtual again, so there's no need to keep a duplicated function

This reverts commit 5043639c56.
2017-04-27 11:00:01 -03:00
ccrs
229444b74a Core/Misc: cleanup SetInFront uses
Set in front modifies only the serverside orientation, use with care.
Also check for current focus to prevent things like incorrect damage on casting creatures (ie dragon breath direction change in your face because of some taunt missclick)
2017-04-27 15:34:01 +02:00
ccrs
c7a57e2a09 Core/Unit: 2170541a51 followup
use true as default value since pretty much all the script calls will expect that
2017-04-27 14:55:06 +02:00
Keader
4431a1149d Core/Scripts: Re-hack Boss Loken. Followup 3a0cb90ea9
Loken still need ClearUnitState Hack to DoMeleeAttackifReady work
2017-04-27 09:41:07 -03:00
ccrs
df96e053a5 Core/Spell: move creature focus
bellow the possible interruptions
2017-04-27 14:16:40 +02:00
ccrs
5fc366d03b Core/CreatureAI: b6b0353bff followup 2017-04-27 14:00:57 +02:00
ccrs
5043639c56 Core/Misc: 522f537048 followup 2017-04-27 13:53:18 +02:00
ccrs
aa86dfddca Core/Petition: add missing increment on RemovePetitionsByOwnerAndType iteration 2017-04-27 13:29:51 +02:00
xinef1
e30e11d4c7 Core/Spells: Corrected aura SPELL_AURA_MOD_CASTING_SPEED_NOT_STACK handling for auras with very high values (#19054) 2017-04-27 03:34:43 -03:00
xinef1
a4aa95a5a3 Core/Misc: implemented petition manager (#19010)
- Implemented manager for petitions to perform all petition related tasks and synchronize data with database.
- This kills ugly synchronous querys on packet handlers
2017-04-27 02:02:33 -03:00
ariel-
a82a12b5ef Core/Player: don't check quest requirements against RewardNextQuest
- This field is only used to propose a new quest to player after completion, shouldn't be used to condition current quest

Closes #19515
2017-04-27 00:23:32 -03:00
ariel-
6892404b27 Core/AI: some tweaks on boundary functionality:
- Moved SetBoundary to public scope to allow for greater flexibility (ie set from external script)
- Extended to allow checking inverted boundaries
2017-04-26 04:20:38 -03:00
ariel-
3a2ecaa05f Core/AI: added a function to allow 0 damage attacks (sparring) depending on target 2017-04-26 04:16:32 -03:00
jackpoz
486b032343 Core/Misc: Fix static analysis issues 2017-04-25 17:33:53 +02:00
Keader
3194d089cb Core/Scripts: Added a missing break in Illidan Stormrage script
Thanks Jackpoz
2017-04-25 11:46:38 -03:00
jackpoz
65aeeafad3 Core/Misc: Fix static analysis issues 2017-04-25 14:27:53 +02:00
ariel-
85076dd799 Core/Scripts: fix gaseous bloat proc (again)
- UNIT_STATE_CASTING removal not needed for movement now, but it's needed for melee attacking
2017-04-25 02:57:58 -03:00
ariel-
157e9311c4 Core/Quests: implemented MSG_QUEST_PUSH_RESULT notifications
- Allow to share already completed (but not rewarded) quests, restriction was unblizzlike

thanks Cannix for the heads up
2017-04-24 16:34:50 -03:00
Keader
136f1e75aa Core/Scripts: Fix a typo in Blood Prince Council
Thanks ariel-
2017-04-24 08:48:34 -03:00
xinef1
cbbb745246 Various quest system fixes (seasonal quests, timed quests and more) (#18940)
- Unify quest status checking function, use dedicated function instead of direct map checks
- Fixed seasonal quest chains and ability to complete the same quests rewarded in past
- Update area dependent auras on quest status change (they often requires specific quest status)
- Send all not stored quest rewards by mail
- When casting quest reward spell, check if it is not self casted, if so - use player to cast this spell
- Perform full db save on quest reward to prevent data desynchronization
- Don't allow to fail completed timed quests, except for quests which are completed right from the start
- Don't allow to share pooled quests, if they are not available in the current pool (eg sharing easy dalaran weeklies, stored at alt character)
- Remove seasonal quest if rewarded quest is removed
- Don't complete whole quest on AreaExplore event, check if there are no more requirements that should be fulfilled
- Quests with flag QUEST_SPECIAL_FLAGS_PLAYER_KILL can be only credited in quest zone

Closes #18913
Closes #11187
Closes #15279
2017-04-24 00:46:06 -03:00