Commit Graph

21353 Commits

Author SHA1 Message Date
Aokromes
4bc52061e6 Core/Quests: Delete all quest bound items on quest reward, failure or abandoning
By runningnak3d
2016-07-30 12:13:01 +02:00
ariel-
21b19bd179 Core/GameObjects: fix typo 2016-07-30 12:05:41 +02:00
Nyeriah
fd1a0cd4f0 Core/Player: Actually close tickets when characters are deleted
* Solves issue with tickets being open indefinitely if characters are deleted while tickets are still open
2016-07-30 12:05:27 +02:00
Aokromes
e30845b587 Core/Updater: Clarify log 2016-07-30 12:04:58 +02:00
ariel-
88bb891a71 Core/Misc: fix issues reported by static analysis 2016-07-26 03:15:20 -03:00
ariel-
291a633c35 Core/Scripts: cleanup Asaad and get ride of a few static analysis issues while at it 2016-07-26 03:15:19 -03:00
Aokromes
69a6a182b1 Fix build 2016-07-25 15:55:07 +02:00
Aokromes
ed8b9fe1c4 Scripts/Misc: Add missing override 2016-07-25 15:49:08 +02:00
Aokromes
9dac2dbca9 Script/Stonecore: Fix coverity 82008 2016-07-25 15:29:38 +02:00
Aokromes
c23a2c6c69 Core: Fix coverity 82043 2016-07-25 10:32:36 +02:00
ariel-
a254ce1a7c Core/Achievements: Fix merge fail introduced in 2bdcce17f8, additional requirements weren't being checked and completed criteria was being checked twice instead.
Updates #51
2016-07-24 19:09:11 -03:00
Aokromes
9d5cb998b7 Merge branch '4.3.4' of https://gitlab.com/trinitycore/TrinityCore_434 into 4.3.4 2016-07-24 19:58:12 +02:00
Aokromes
9fb69216bc Import some enum's and struct's to achievements.
From ArkCORE.
2016-07-24 19:57:31 +02:00
ariel
d876b6a693 Core/PlayerAI: silence warning 2016-07-24 17:33:27 +00:00
ariel-
5bb0935bbb Core/IPC: fixed double free (virtual ~ZMQTask takes care of this, inherited class shouldn't handle base resources at all)
Coverity CID 82048
2016-07-24 00:07:56 -03:00
ariel-
c413e65d25 Core/Movement: partial revert 817eb007db and proper compile fixes, this was generating crashes
Closes #80
2016-07-23 23:44:34 -03:00
ariel-
f5e2b7db3a Core/Spells: Fix merge error in e34e3f379f causing instant spells to be wrongly Delayed
Closes #74
2016-07-23 17:59:46 -03:00
ariel-
9aea1aaa35 Core/Instances: Fix memory leak in InstanceSaveMgr
Fix memory leak in InstanceSaveMgr added in 1f170c99ef .
Make InstanceSave::SetToDelete() private since it's not supposed to be used by anything other than InstanceSave or its friend class InstanceSaveMgr .

Closes #82
2016-07-23 17:01:29 -03:00
ariel-
705c052fc2 Core/PlayerAI: update spec detection logic, still needs spells to be updated for 4.3.4 2016-07-23 16:54:03 -03:00
ariel-
4b24e404e7 Core/Spell: fix Wrecking crew
Closes #77
2016-07-23 16:52:00 -03:00
ariel-
ba734a5be1 Core/Spells: update f35df037b6 for 4.3 spells 2016-07-23 16:15:37 -03:00
ariel-
6434e98c01 Core/Scripts: Cleanup cs_modify.cpp
* Removed a chunk of duplicate code
* Generalized Message notification
* Generalized checking of resources modification with a min-max
* Generalized checking of single value modification
* Closes #16858

(cherry picked from commit 775b03bf6f)

Conflicts:
	src/server/scripts/Commands/cs_modify.cpp
2016-07-23 07:06:15 -03:00
ariel-
fa8662e617 Core/Movement: Clean up and improvements on Unit::SetSpeed (#16843)
- Clean up of Unit::SetSpeed (mostly cherry picks from the 6.x branch):
- the opcode sent depends on the unit. until now, MSG_MOVE_SET_* were sent for every units which isn't like retail behavior.
- Removed the unused method parameter "forced" from Unit::SetSpeed
- Renamed Unit::SetSpeed to SetSpeedRate
- Removed the unused method parameter "forced" from Unit::UpdateSpeed
- Added utility method Unit::SetSpeed which take the new flat value.
Conflicts:
	src/server/game/Entities/Unit/Unit.cpp
	src/server/scripts/Commands/cs_modify.cpp
	src/server/scripts/EasternKingdoms/ZulAman/boss_zuljin.cpp
	src/server/scripts/Kalimdor/zone_azshara.cpp
	src/server/scripts/Kalimdor/zone_durotar.cpp
	src/server/scripts/Northrend/Nexus/EyeOfEternity/boss_malygos.cpp
2016-07-23 07:02:25 -03:00
ariel-
a8b9edefbc Core/Spell: whitespace fix 2016-07-23 06:50:43 -03:00
ariel-
878ac1b90e Core/Scripts: update boss_altairus.cpp, indentation and whitespace cleanup 2016-07-23 06:42:52 -03:00
ariel-
2d3fa37ef1 Core/Scripts: Baleroc cleanup
- Remove redundant OnGameObjectCreate/Remove, base implementation already takes care of adding and removing doors
- Added missing overrides, fixup bracing and whitespace
- Revamped a little achievement script and get ride of ugly CAST_AI
2016-07-23 06:39:15 -03:00
ariel-
4a96106d60 Core/Spells: finish porting SPELL_AURA_MOD_SPELL_CATEGORY_COOLDOWN handling from 6.x 2016-07-23 06:11:56 -03:00
ariel-
ceb2b94e0b Core/Quests: cache areatrigger relationship in Quest object and send client correct data 2016-07-23 05:19:08 -03:00
ariel-
0923870dfb Core/Misc: useless flag is useless 2016-07-23 04:43:31 -03:00
ariel-
ea8bb37bc7 Core/Scripts: add missing override and silence a warning in MSVC 2016-07-23 04:21:08 -03:00
ariel-
1eeff3a295 Core/Player: misc codestyle 2016-07-23 04:20:44 -03:00
Aokromes
f32aca84ab Compile fix 2016-07-23 00:26:39 +02:00
Aokromes
7a4c33bc66 Core/Entities: implement SPELL_AURA_MOD_CRIT_CHANCE_FOR_CASTER, fixes talent Point of no Escape 2016-07-22 21:59:03 +02:00
Aokromes
9d5ff93e27 Core: Removed Whitespaces 2016-07-22 21:40:34 +02:00
Vincent-Michael
aa61332af8 Core: Revert fail
(cherry picked from commit b5329d8a03)
2016-07-22 18:51:10 +02:00
Vincent-Michael
0d7a6c6556 Core: Added missing overrides
(cherry picked from commit 5d584116fe)
2016-07-22 18:50:26 +02:00
treeston
d4de0ab053 AI/SmartScripts: Add action_param3 "disablePathfinding" to SMART_ACTION_MOVE_TO_POS (69). 2016-07-22 18:47:20 +02:00
Aokromes
9d67cafe92 Scripts/UtgardePinacle: Adjust King Ymiron boundaries 2016-07-22 18:45:29 +02:00
Keader
9ca2d0a62f Core/Scripts Added Black Temple Boundaries (#17579)
* Core/Scripts Added Black Temple Boundaries
2016-07-20 19:56:15 +02:00
Aokromes
7cb583a657 Core/Vehicle: delay position update in Vehicles, this may be deleted …
…on UpdatePosition, generating a crash
2016-07-20 19:55:44 +02:00
Killyana
ae7c54eb34 Core/Entities: Remove wrong immunity
Closes #17363
2016-07-20 19:53:25 +02:00
ariel-
65d6a4cca1 Core/Player: Misc codestyle 2016-07-20 19:51:39 +02:00
ForesterDev
64596c6739 Core/UnitAI: Removed unneccessary null checks in SpellTargetSelector. CID 1357405 (#17630) 2016-07-20 19:51:15 +02:00
Aokromes
75ca64a383 Scripts / Naxxramas : add missing null pointer check. Fixes CID 1354738 2016-07-20 19:50:00 +02:00
SnapperRy
836b9180fe Core/Mail: implement a way to specify NPC sender for mails when they should be different from the quest ender (#17601) 2016-07-20 19:46:37 +02:00
ariel-
08ce85d0fb Core/Loot: fix bug introduced in a49544cc18 in which creatures only having gold wouldn't show lootable sparks, and thus couldn't be looted 2016-07-20 19:45:26 +02:00
ccrs
2b863c2b8e Core/UnitAI: #17309 follow-up (#17608)
* Core/UnitAI: SelectTarget correction

Set CurrentVictim as first element on targetList if necessary, which is then filled with the threatlist elements that satisfy the predicate.
2016-07-20 19:45:08 +02:00
Gustavo
c31be4100e Core/AI Prevent bosses respawn when BossState is set to DONE (#17616) 2016-07-20 19:44:44 +02:00
ccrs
faa310252f Core/UnitAI: SelectTarget correction (#17309)
Core/UnitAI: SelectTarget correction - have current victim always be first element of target list
2016-07-20 19:41:37 +02:00
ariel-
ef8e83f99d Core/Player: silence warning 2016-07-20 19:40:53 +02:00