Commit Graph

2181 Commits

Author SHA1 Message Date
sirikfoll
4ea09dfcd4 Fix nopch 2019-02-25 18:12:19 -03:00
sirikfoll
a803342029 Scripts/Ulduar: Mimiron improvements
Closes #23043

Fix Aerial hover
Some visual issues
2019-02-25 17:50:24 -03:00
jackpoz
2fda1572d2 Core/Misc: Fix issues reported by static analysis
Fix issues reported by Coverity Scan
2019-02-05 21:10:39 +01:00
Sorikoff
806dd940ce DB/Quest: Sniff Out the Enemy
Closes #23006
2019-02-02 15:06:11 +01:00
Keader
71dde16ce9 Scripts/Utgarde Keep: Fix Ingvar Evading (again)
UNIT_FLAG_NON_ATTACKABLE makes ingvar become a invalid target and lose threatlist, so me->IsThreatened() will return false.
We dont need it at all, since UpdateAI will handle evade already.
2019-01-28 17:42:00 -03:00
ccrs
c5423fa474 Scripts/ICC: npc_suppresser corrections
closes #22908
2019-01-16 23:30:23 +01:00
Giacomo Pozzoni
8f9654d817 3.3.5 UnitAI (#22911)
* Core/AI: Revamp how UnitAI changes are applied

Revamp how UnitAI changes are applied by storing current AI in a variable and all previous AIs plus current in a stack.
The callers can push/pop AIs on the stack that will take effect only in next Unit::Update() call.
The current AI will be a valid object for the whole duration of Unit::Update() and until next Unit::Update() call.

* Core/AI: Apply new AI change code

* Core/AI: Fix build

* Core/AI: Fix crash on Creature::AIM_Create()

* Core/AI: Fix crash

* Core/AI: Restore ASSERT

* Core/AI: Fix UnitAI not being popped properly when restoring a charmed AI
2019-01-13 20:25:02 +01:00
Trond B. Krokli
a8558c4361 Scripts/Borean Tundra: Corastrasza gossip menu improvements (#22942)
- split the quest status check, the quest gossips are different
- remove old hardcoded text (deprecated method)
- enumerate already existing DB gossip menu option items
2019-01-13 16:48:55 +01:00
Trond B. Krokli
95398fadf9 Scripts/Quest: make Wounded Skirmisher reply talk show class & race (#22936)
Quest 12288: Overwhelmed!
- Upon casting the healing quest spell, Wounded Skirmisher (npc_wounded_skirmisher)
  shows $r and $c in their reply talk text because of the missing target argument,
  hence not targeting the player on the quest (or the specific caster, in this case).

Text used by the NPC Wounded Skirmisher:
    0  Ahh.... better.
    1  Whoa - I nearly died there. Thank you, $r!
    2  Thank you, $c.

Solution: add the missing target name, caster, to the Talk() script line.
2019-01-11 17:52:21 +01:00
Giacomo Pozzoni
08dcee0cf9 Scripts/Misc: Fix LoadMinionData() dynamic analysis issues
Fix issues reported by Address Sanitizer about LoadMinionData() calls on arrays that don't end with a {0, 0} pair.
2019-01-07 10:17:05 +01:00
Keader
dd81978f43 Scripts/Icecrown Citadel: Some fixes for Valithria Dreamwalker's encounter
Closes #22754 #21887 #17882
Ty sirikfoll for all help
Bonus fixes: Abomination letting worms when fight end, visual missing, archmages stop respawn if corpse despawn
2019-01-05 01:14:57 -03:00
DanVS
8051ff13df Core/Scripts: Move some spells to scripts (#22332) 2019-01-05 01:54:33 +01:00
Treeston
fcfcb0eb6f Happy New Year, folks. It's 2019! 2019-01-01 15:45:25 +01:00
PolarCookie
66720e5fd9 Spell/Script: Scourge Disguise and Haunting Phantoms (#22727) 2018-12-31 11:50:16 +01:00
Ghaster
bf3ab6d9c4 Core/Creatures: Port trainer changes from master
Closes #20493
2018-12-30 19:51:36 +01:00
Aokromes
6851ba638d Update zone_borean_tundra.cpp 2018-12-03 12:19:10 +01:00
Keader
f1a1acdc89 Scripts/Utgarde Keep: Fixed Ingvar evade in phase 2 (one more time)
Closes #21264
ScheduleEvents need happens after remove ImmuneToPc, or it will cause evade.
2018-11-09 11:02:15 -03:00
Keader
4c6f0eaa8d Scripts/ToC: Fixed Twin Valkyr stucking in progress and added hover
Closes: #22755
Update: #20961
2018-11-08 11:14:46 -03:00
Keader
266a9c3d41 Scripts/Ulduar: Fixed Sanctum Sentry accumulating events after wipes 2018-10-22 11:11:16 -03:00
Keader
1fe8fe30de Scripts/Ulduar: XT002 Crash fix
Closes: #22545
2018-09-30 02:44:24 -03:00
Killyana
0b0bbe4330 Fix warning 2018-09-25 20:09:44 +02:00
Killyana
a3c20cea2d Creature/Script: Wyrmrest Defender
Closes #22500
2018-09-25 20:02:07 +02:00
Trond B. Krokli
013d50f169 Scripts/Quest: Defending Wyrmrest Temple (#22513)
- use DB gossip instead of `#define` (deprecated)

Updates #22500
2018-09-25 16:55:28 +02:00
Killyana
868f810e11 DB/Quest: Hah...You're Not So Big Now!
Closes #22478
2018-09-21 15:29:34 +02:00
ccrs
2a78f4eb7c Scripts/ICC: 2e4358f726 followup
ref 2e4358f726 (r30588551)
2018-09-21 14:44:51 +02:00
ccrs
da19663514 Scripts/ICC: 2e4358f726 followup
std::list does not provide random access
2018-09-20 17:45:01 +02:00
ccrs
2e4358f726 Scripts/ICC: update Unchained Magic target selection
because we all love retri paladins and hate healers, right?, right?
2018-09-20 17:13:07 +02:00
DanVS
5b0f4009df Core/Scripts: Unify Chrono Literals (#22420)
* Unify Chrono Literals

* Retire IN_MILLISECONDS

* Build fix

* Build fix (sequel)

* Retire urand()

* Edge cases

* Build

* Whitespaces

* More edge cases

* Additional cases
2018-09-17 18:38:22 +02:00
ccrs
8ebf375183 Build: missing case from previous commit 2018-09-12 18:20:47 +02:00
Full-Stack Developer
8f60d48ea9 Scripts/VoA: Update events to use std::chrono (PR #22415) 2018-09-11 00:12:00 +02:00
Full-Stack Developer
3c5b1f0258 Scripts/VoA: Archavon no longer leaps in melee range (PR #22414) 2018-09-10 18:49:10 +02:00
Aokromes
cc49b7bb30 kill some whitespaces 2018-09-09 16:15:45 +02:00
Keader
ca7ee982db Scripts/Ulduar: Algalon the Observer fixes (#22320) 2018-08-31 21:48:56 -03:00
Keader
c78f454c0e Scripts/Misc: Removed more UpdateEntry on InstanceScripts 2018-08-30 11:00:16 -03:00
Keader
7ab8a8b70b Scripts/ICC: Removed not needed entrys added in last commit 2018-08-30 09:26:38 -03:00
Keader
92f260c5f9 Scripts/ICC: Fixed Deathbringer after Delay zone script's OnCreatureCreate
Also removed some UpdateEntry hacks
Followup: b4a1887c4d
2018-08-30 09:22:06 -03:00
Treeston
5cea572a9a Core/Threat: Threat system adjustments:
* Online states are now re-evaluated before victim update instead of continuously. Closes #22226. Tagging #21501.
* Victim update now happens every 1s as opposed to every server tick unless current target goes away.
* Suppressed threat is no longer re-established until the victim gains additional threat (by hitting the target, for instance).
* Assistance threat is now split between non-controlled units threatened by target, as opposed to all units threatened by target.
2018-08-27 19:08:17 +02:00
Keader
183c6e630d Build fix 2018-08-26 01:52:15 -03:00
Keader
81a6e2e510 Scripts/Uduar: XT002 Rework (#21566)
Closes #21489
2018-08-26 01:14:18 -03:00
Treeston
042f5515e4 Core/AI: Clean up charm AI handling, we now have two unique_ptr instead of a crapton of booleans 2018-08-23 16:34:42 +02:00
Treeston
c00a2efb21 Core/AI: Remove unnecessary parameter from DoZoneInCombat after eb1972f 2018-08-22 21:51:16 +02:00
Treeston
eb1972f21d Core/AI: Some cleanup to DoZoneInCombat and Malygos' AI that I found while working out #22226. 2018-08-20 19:04:21 +02:00
Keader
8b9d18f29c Scripts/Trial Of The Crusader: Fixed Anub'arak Pursuing Spikes
Closes #21420
2018-08-18 22:46:03 -03:00
Shauren
6cf12bcb4c Scripts/Icecrown Citadel: Fixed target selection for Vampiric Bite and Blood Mirror after threat rewrite
Closes #21537
2018-07-28 16:31:45 +02:00
Treeston
2ef9d301f0 Misc: Pass std::chrono types by value everywhere. 2018-07-18 17:48:15 +02:00
Keader
3102a6c903 Scripts/Ruby Sanctum: Fixed Baltharus target amount of Enervating Brand part 2
(I forgot the clones, ty Gildor)
2018-06-08 19:02:52 -03:00
Keader
8a312046b2 Scripts/Ruby Sanctum: Fixed Baltharus target amount of Enervating Brand 2018-06-07 22:45:06 -03:00
Keader
ee7c0c16f1 Kill a whitespace 2018-06-04 22:18:26 -03:00
Keader
6cf8bd5ae7 Scripts/Pit of Saron: Fixed Ick not updading victim
Closes #22001
2018-06-04 21:52:22 -03:00
ccrs
982643cd96 Core/Movement: MotionMaster reimplementation (#21888)
Internal structure and handling changes, nothing behavioural (or thats the intention at least).
2018-06-03 10:06:57 -07:00