Commit Graph

26874 Commits

Author SHA1 Message Date
Shauren
5237eda340 Core/Spells: Updated spell required items check, EquippedItemInventoryTypeMask should only be used for enchantments
(cherry picked from commit 28fd8a424d)
2016-11-19 23:41:38 -03:00
ariel-
25281ecb31 Core/Guild: avoid data integrity problems wrapping delete+insert statements in a transaction 2016-11-19 23:28:52 -03:00
ariel-
d2bf7237a3 Core/Guild: fix indentation and codestyle 2016-11-19 21:13:05 -03:00
ariel-
c5d1b46569 Core/Unit: do not allow judgement spells to bypass damage immunity
3f19eea5e4 follow-up. Without the #16658 regression
2016-11-19 20:17:17 -03:00
ariel-
9b00fd8d7b Core/Scripts: fixed Imp. Leader of the Pack
Closes #12830
2016-11-19 19:56:46 -03:00
ariel-
16c14593dc Core/Player: recheck shapeshift bonus auras when switching spec.
- Fixes Leader of the Pack stuck when switching specs while shapeshifted
2016-11-19 18:39:29 -03:00
ariel-
f30778c998 Core/Scripts: Seal of Corruption/Vengeance shouldn't reset periodic timer on reapply 2016-11-19 15:46:55 -03:00
ariel-
ef227d7e64 Core/Entities: fix interaction of traps with ffa pvp and sanctuary flags
- Traps should select ATTACKABLE not UNFRIENDLY targets (it shouldn't attack unfriendly targets on sanctuary zones for example)
- Made more readable the nasty oneliner in Unit::_IsValidAttackTarget

Closes #6464
Closes #18271
2016-11-19 15:43:22 -03:00
ariel-
e22fe2819f DB/Spell: Vampiric Embrace proc
Closes #18272
2016-11-19 14:32:29 -03:00
ariel-
3db5f4f5cb DB/Spell: fix Art of War procs
Closes #18276
2016-11-19 14:13:40 -03:00
ariel-
5db308b686 Core/Entities: better support of absorb, resist and block procs
2e457b3be4 followup

Closes #18275
2016-11-19 13:56:19 -03:00
ariel-
5b56c94e6d Core/Spell: restore old proc system behaviour on auras self proc.
- Use Spell::m_triggeredByAuraSpell and compare against trigger aura, it requires scripts to set triggeredByAura parameter.
- Fixed existing scripts lacking it

DB/Spell: Anger Capacitor (Tiny Abomination in a Jar) proc

Closes #18269
2016-11-19 03:05:44 -03:00
ariel-
503259e6fe Core/Spell: register items received through SPELL_EFFECT_SUMMON_CHANGE_ITEM for quest credit
- Also sends proper SMSG_ITEM_PUSH_RESULT packet

Closes #3505
2016-11-18 03:42:01 -03:00
ariel-
c0cb823a91 DB/Spell: fix some runtime errors 2016-11-18 03:16:48 -03:00
ariel-
2c8a6fb771 Core/Spell: Fixed Drain Soul incorrectly downscaling ranks when targetting lower level enemies 2016-11-18 03:11:35 -03:00
ariel-
e7ccd8ea3f Core/Spell: Added the possibility to explicitly disable auraEffect procs using attributes
- Renamed IsProcTriggeredOnEvent to GetProcEffectMask, since long ago this function returned bool, new name should better reflect its use
2016-11-18 02:15:45 -03:00
ariel-
3f19eea5e4 Core/Spell: spells with ignore hit result should pierce damage immunities 2016-11-16 23:04:19 -03:00
ariel-
400a69bf9e Core/Gameobject: fixed sometimes not found linked trap
Closes #18256
2016-11-16 04:59:43 -03:00
ariel-
56beec8aaf Core/Spell: Fixed irregular handling of SPELLMOD_DOT
- Applied twice for some dots
- Missing for Health Leech Periodic
- Missing in a few scripts

Closes #17463
2016-11-16 04:06:32 -03:00
ariel-
b6a8045adc Core/Unit: fix some SPELL_AURA_MOD_DAMAGE_PERCENT_DONE effects being applied more than once
No more overpowered dps for you

Closes #16755
2016-11-16 02:26:18 -03:00
ariel-
f3bdd705c0 Core/Unit: fix build
Ctrl-S failure
2016-11-15 22:50:28 -03:00
ariel-
ca1c4525c7 Core/Unit: damage immune improvements (9f5df023b7 follow up)
- Handling checked in sniffs: Spell 63710 Void Barrier vs 49143 Frost Strike
  * Send spell miss immune only if spell consists of damage effects
- Checked with 348 Immolate:
  * No packets sent if damage immune, aura is applied normally

Also... who the fuck uses 0 to compare against pointers
2016-11-15 22:39:15 -03:00
Killyana
524d6637ad DB/GameObjects: Cursed Egg
Add missing spawns with pooling and replace a hack script: d90a161619
2016-11-15 17:24:39 +01:00
ariel-
64304d8b2b Core/Spell: fix a potential null dereference crash 2016-11-15 12:02:31 -03:00
ariel-
cdd7461d25 DB/Spell: Vampiric Embrace proc
Closes #18250
2016-11-14 21:25:02 -03:00
ariel-
9f5df023b7 Core/Unit: don't use damage immunity to calculate hit result for the whole spell. Should be used only for damage 2016-11-14 20:40:17 -03:00
ariel-
425f6c3c34 Core/Spell: perform charmer check against player controlling unit. Fixes spellcasts while charmed 2016-11-14 15:22:41 -03:00
ariel-
1ad9c7d3fd Core/Spell: fix typo
Closes #18248
2016-11-14 13:59:32 -03:00
Duarte Duarte
674ac56303 Update THANKS file (#18247)
* Added missing names in THANKS file

* filter by nick/email and sorted

* Oops

* duplicates

* laze mind

* :)
2016-11-14 12:15:40 +00:00
Keader
fa0604223b :) 2016-11-14 09:31:01 -02:00
ariel-
a7259cef4f DB/Creature: correct 2 npc walk/run speed
Closes #18207
2016-11-14 04:57:25 -03:00
ariel-
352c84943c Core/Unit: improved handling of some spell attributes
- SPELL_ATTR1_UNAFFECTED_BY_SCHOOL_IMMUNE
- SPELL_ATTR2_UNAFFECTED_BY_AURA_SCHOOL_IMMUNE
- SPELL_ATTR3_IGNORE_HIT_RESULT
2016-11-14 04:04:30 -03:00
ariel-
f060efbdb4 Core/Spell: fix typos 2016-11-14 04:02:43 -03:00
ariel-
20cdf1a830 Core/Utils: build fix 2016-11-14 02:36:33 -03:00
ariel-
3f1d020a2c Core/GameObject: use a friendly trigger for positive spells.
Fixes an issue with Skadi Harpoons.

Note to self: should actually implement GameObject casting already :/
2016-11-14 02:12:41 -03:00
ariel-
361b185ef7 Core/Scripts: add checks to Master's Call script
Closes #8403
2016-11-14 02:12:38 -03:00
ariel-
5daabe303e Core/Spell: do not fail triggered Charge effects in case a root is present.
Fixes Master's call when pet is rooted
2016-11-14 02:12:35 -03:00
ariel-
5aa0228df9 Core/Spell: Fix warrior Enrage stacking with Wrecking Crew and Imp. Defensive Stance 2016-11-14 02:12:33 -03:00
ariel-
b99ca19eea Core/Globals: Load spellspecific and aurastate after loading spell ranks
Was breaking functionality (eg: stacking scroll auras)
2016-11-14 02:12:19 -03:00
ariel-
fd3423245c Core/Spell: use SpellEntry to select implicit targets in case RadiusEntry wasn't set for the current effect.
Closes #15388
2016-11-14 02:06:33 -03:00
ariel-
fc6844173f Core/Spell: Fixed immunities for some spells (they were broken before rewrite too)
- Warlord's Presence, Uncontrollable Frenzy, Free Friend
- Overload, Lightning Tendrils
- Fervor, Berserk
- Determination
2016-11-14 02:06:30 -03:00
ariel-
699e22cb4c Core/Unit: consider creatures with same faction to be on the same party/raid for the purposes of spell/aura targets
Ref #18233
2016-11-14 02:06:18 -03:00
ariel-
aa21137aeb Core/SpellScript: allow optional parameters to be passed to FinishCast
followup of 50a3ce5703
2016-11-14 02:05:54 -03:00
ariel-
cbb5c073ce Core/ScriptMgr: use vector instead of list to contain Spell and Aura scripts and hooks 2016-11-14 02:05:51 -03:00
ariel-
58c5011499 Core/Battleground: Fix issue reported by static analysis 2016-11-14 02:05:48 -03:00
Keader
33e7519dc3 laze mind 2016-11-14 00:28:31 -03:00
Keader
66028259a8 duplicates 2016-11-14 00:21:30 -03:00
Keader
24135903eb Oops 2016-11-14 00:11:05 -03:00
Keader
3a55105423 filter by nick/email and sorted 2016-11-14 00:08:44 -03:00
Keader
caeb357855 Added missing names in THANKS file 2016-11-13 21:18:18 -03:00