Commit Graph

26588 Commits

Author SHA1 Message Date
Treeston
852164132c Core/Movement: Some improvements to script interfaces for SplineChainMovementGenerator
(cherry picked from commit e63e0cb6fc)
2021-10-23 15:59:31 +02:00
Treeston
d57e74b3b5 Core/Scripting: Delay zone script's OnCreatureCreate until the creature has been added to map stores
(cherry picked from commit b4a1887c4d)
2021-10-23 14:53:14 +02:00
Treeston
fd930d4c83 Core/Maps: Properly re-create map on login for ephemeral player saves. Because it bugged me to no end when testing anything ever.
(cherry picked from commit dc86a8e5db)
2021-10-23 14:52:18 +02:00
Treeston
8760b7322e Core/Spells: Clean up some assist checks (no behavior change)
(cherry picked from commit 83ee145736)
2021-10-23 14:49:43 +02:00
Treeston
d81a74bc98 Core/Spells: Fix an incorrect check that was exempting negative spells from _IMMUNE_TO_x checks. Closes #21929.
(cherry picked from commit 75e7404bba)
2021-10-23 14:46:53 +02:00
Treeston
00b9c23e28 Core/Entities: Fixed an issue where creatures would not properly assist formation members in certain scenarios. Tagging #21967.
(cherry picked from commit a001bc63b1)
2021-10-23 14:45:40 +02:00
Treeston
34f9666f20 Core/Unit: Some charm fixes:
* Properly restore react state after possession expires. Closes #20769.
* Possessed creatures now don't override player control with random/waypoint motion
* SmartAI creatures now properly re-aggress charmer after charm expires

(cherry picked from commit da21ca80fc)
2021-10-23 14:44:05 +02:00
Ovah
e88536f258 Core/LFG: fixed random dungeon cooldown (#22321)
* Core/LFG: fixed random dungeon cooldown

The issue was that queuing up for random dungeons puts you into a queue for a already selected dungeon from the beginning so the dungeonId that we use here is actually the dungeonId that we will enter when out group is complete. We change that and use our selected dungeons as reference instead which contains the random dungeon at the very beginning (if we queued up for random dungeons so we check that too).

(cherry picked from commit bf8c6f220c)
2021-10-23 14:37:37 +02:00
Treeston
dd239e8b0f Scripts/Commands: .npc info now includes react state info
(cherry picked from commit 2c030ed5e7)
2021-10-23 14:33:21 +02:00
ModoX
437fb2aaba Core/CreatureTexts: Added new field SoundPlayType to enable usage of ObjectSounds within creature_text (#27136)
* Also adjusted Vigilant Quoram texts to use ObjectSounds
2021-10-23 13:10:32 +02:00
ModoX
8b171d7c01 Core/Instances: Drop allowMount column in instance_template as it is already handled properly by SPELL_ATTR0_OUTDOORS_ONLY (#27148) 2021-10-23 11:42:47 +02:00
Treeston
b6f4b53407 Core/Threat: Only send SMSG_THREAT_UPDATE if the threat list actually changed
(cherry picked from commit 4e5d1b7021)
2021-10-23 02:14:04 +02:00
Treeston
7a503ff597 Core/Threat: Further tweak to assist threat, all CC now prevents assist threat splitting (not just damage-breakable CC)
(cherry picked from commit 408ce48732)
2021-10-23 02:14:04 +02:00
Treeston
05119fd909 Core/Unit: Random code style/naming adjustments
(cherry picked from commit 710488ea20)
2021-10-23 02:14:04 +02:00
Treeston
392a644dc8 Core/Threat: Threat system adjustments:
* Online states are now re-evaluated before victim update instead of continuously. Closes #22226. Tagging #21501.
* Victim update now happens every 1s as opposed to every server tick unless current target goes away.
* Suppressed threat is no longer re-established until the victim gains additional threat (by hitting the target, for instance).
* Assistance threat is now split between non-controlled units threatened by target, as opposed to all units threatened by target.

(cherry picked from commit 5cea572a9a)
2021-10-23 02:14:04 +02:00
Treeston
395f58d651 Core/Unit: Inline some unnecessary helpers.
(cherry picked from commit ce06767ef5)
2021-10-23 02:14:04 +02:00
PolarCookie
9dd2748618 DB: Naxxanar and Voltarus teleporters
Closes #22311

(cherry picked from commit 151ed6f684)
2021-10-23 02:14:04 +02:00
Ovah
b2eef8903b Core/Maps: initialize PositionFullTerrainStatus to avoid having issues with those variables (#22315)
(cherry picked from commit bab06993e2)
2021-10-23 02:14:04 +02:00
Keader
0feb1592bf Scripts/Uduar: XT002 Rework (#21566)
Closes #21489

(cherry picked from commit 81a6e2e510)
2021-10-23 02:14:02 +02:00
Keader
c2666bd255 Utilities/EventProcessor: Added a overload to AddEventAtOffset accept rand time
(cherry picked from commit 4d9c36c8c3)
2021-10-23 00:23:22 +02:00
Keader
37c9553372 Scripts/Black Temple: Fixed some issues on Illidan
(cherry picked from commit 0ebb315d6c)
2021-10-23 00:22:53 +02:00
Treeston
a5989dcee9 Core/Unit: Store charmer and charmed pointers on Unit directly, no more map lookups for Unit::GetCharmer and Unit::GetCharmed
(cherry picked from commit d4ef2529e9)
2021-10-23 00:11:44 +02:00
Shauren
ab95c5e9d7 Core/Creatures: Restored old initialization order: AI after movement
Closes #22307

(cherry picked from commit cdf4040f4f)
2021-10-22 23:51:59 +02:00
Treeston
070bbb6707 Core/Unit: Acquire GetControllingPlayer. Use to fix duel bugs.
(cherry picked from commit d2d9f470c3)
2021-10-22 23:51:36 +02:00
Treeston
e4e8c1c59c Core/AI: Clean up charm AI handling, we now have two unique_ptr instead of a crapton of booleans
(cherry picked from commit 042f5515e4)
2021-10-22 23:47:51 +02:00
Treeston
6a91fe3fbe Core/Creature: Fall back to combat list if calling for help without threat list
(cherry picked from commit 0e4a49b0a4)
2021-10-22 23:21:01 +02:00
Treeston
f6ceb4bf0c Scripts/SmartScripts: _SET_IN_COMBAT_WITH_ZONE and _CALL_FOR_HELP no longer use a target. Because that feature made no sense and was unused.
(cherry picked from commit 5706d49e49)
2021-10-22 23:20:36 +02:00
Treeston
6b8329f6af Core/Creature: Some adjustments to Creature::CallForHelp. Now works even if the Creature hasn't selected a victim yet.
(cherry picked from commit 79f0e55dcb)
2021-10-22 23:17:41 +02:00
Treeston
fff5a32a13 Core/LFG: Order group members before creating LFG group (leader > tank > healer > dps). Closes #16244.
(cherry picked from commit dd54c80123)
2021-10-22 23:17:04 +02:00
jackpoz
b6f28a7ebc Core/Packets: Reduce memory footprint of cached queries (#22297)
Ensure only the minimum required memory is used by caching query packets by calling shrink_to_fit()

(cherry picked from commit deabd4ab45)
2021-10-22 23:15:27 +02:00
ZenoX92
eb241db187 DB/Quest: Move the Sunken Treasure to SAI
Closes #22290

(cherry picked from commit 42fec4a698)
2021-10-22 21:50:04 +02:00
PolarCookie
8c9e5cd3f3 [3.3.5] Core/Loot/Gameobject: Tempspawned Gameobjects after looting (#22124)
* spell spawned chest non-despawn fix

* fix the consumed game objects

(cherry picked from commit 97371533bf)
2021-10-22 21:39:28 +02:00
DanVS
1195e2cf1a Scripts/Scarlet Enclave: Death Comes From On High
(cherry picked from commit afc25d22ef)
2021-10-22 21:38:42 +02:00
Treeston
5d48e8db7d Core/AI: Remove unnecessary parameter from DoZoneInCombat after eb1972f
(cherry picked from commit c00a2efb21)
2021-10-22 13:29:34 +02:00
Seyden
8f097e4425 Core/Scripts: Implement script name reloading
* Authored by Seyden
* Co-authored by Naios
* We thank Shauren for your helpful feedback
2021-10-22 12:52:37 +02:00
Treeston
6a5edf0472 Core/AI: Some cleanup to DoZoneInCombat and Malygos' AI that I found while working out #22226.
(cherry picked from commit eb1972f21d)
2021-10-22 00:48:20 +02:00
Treeston
6f0e58cce0 Core/Movement: Prevent NO_PATH evades from incorrectly happening in a few places. Closes #22226.
(cherry picked from commit 86bba6421b)
2021-10-22 00:42:04 +02:00
Treeston
0c3690db91 Core/SmartAI: SetRun fix for SAI, because for some reason it has like 95% of escortai code duplicated??? shitshow zz
closes #21463

(cherry picked from commit f95a383293)
2021-10-22 00:41:41 +02:00
Treeston
45766c3d6e DBError follow-ups:
* broadcast_text mismatch (6eb7f06) is now a _INFO since Aok isn't nearly as fast as fixing as he claimed.
* SmartAI invoker misuse (482328b and a3c85c8) are now blocking errors

(cherry picked from commit 38d3b35561)
2021-10-22 00:41:07 +02:00
Treeston
58000148d3 Core/AI: EscortAI::SetRun now also adjusts already-in-progress waypoint paths, as opposed to only affecting future path loading. Closes #21290.
(cherry picked from commit 121346f1f9)
2021-10-22 00:40:20 +02:00
Keader
539fcb1862 Scripts/Trial Of The Crusader: Fixed Anub'arak Pursuing Spikes
Closes #21420

(cherry picked from commit 8b9d18f29c)
2021-10-21 23:13:53 +02:00
Shauren
cf4ec52d39 Core/Commands: Fixed .damage command to work with spell schools caused by bad strtok usage
Closes #22280

(cherry picked from commit bc3da555fe)
2021-10-21 00:18:13 +02:00
Treeston
abaf5d8068 Scritpts/Commands: Fix area name display if no area present. Closes #21727.
(cherry picked from commit 2a50f9202b)
2021-10-21 00:17:59 +02:00
ZenoX92
c16164f68d DB/Quest: The Missing Diplomat (Part 16)
Closes #22261

(cherry picked from commit cbacc72d93)
2021-10-21 00:05:14 +02:00
ZenoX92
20224aef17 DB/Quest: Cleansing Witch Hill
Closes #22262

(cherry picked from commit 25d7b7c819)
2021-10-20 00:30:28 +02:00
Shauren
8a309542ce Scripts/Commands: Fix .quest complete to properly work with PvP kill quests 2021-10-19 23:46:09 +02:00
Treeston
d3f93bcc26 Spells/Auras: Properly handle negative health modifiers on application. Closes #22211.
(cherry picked from commit 41982aa300)
2021-10-19 23:41:07 +02:00
illfated
5cafc211e6 Scripts/Eastern Kingdoms: zone_wetlands converted to SAI cleanup (#22252)
(cherry picked from commit 59edf6b100)
2021-10-19 23:38:02 +02:00
Treeston
0aee79dfb8 AI/SmartScripts: Replace SMART_ACTION_INVOKER_CAST with SMART_ACTION_SELF_CAST in action 85. SMART_ACTION_INVOKER_CAST moves to 134.
(cherry picked from commit 0df3cb5bcc)
2021-10-17 22:07:54 +02:00
Treeston
a2d266edf3 AI/SmartScripts: Warn on startup for ACTION_INVOKER_CAST without invoker (same as invoker targets)
(cherry picked from commit a3c85c8a2b)
2021-10-17 20:14:45 +02:00