Commit Graph

87 Commits

Author SHA1 Message Date
linencloth
59da698189 Core: Rename spell attributes, use more general names
--HG--
branch : trunk
2010-12-19 05:15:47 +01:00
Shauren
82f45966fc Core/Unit: Renamed addUnitState/hasUnitState/clearUnitState to AddUnitState/HasUnitState/ClearUnitState
Core/Vehicles: Allow the vehicle to always damage the passenger (removed unneded dbc hacks from scripts)

--HG--
branch : trunk
2010-12-17 13:43:24 +01:00
Anubisss
6d9029c12e Make some cleanup.
My thank goes to Az@zel for the code analysis.

--HG--
branch : trunk
2010-12-16 18:08:23 +01:00
Shauren
314376e32c Scripts: Fixed uninitialized variables, unreferenced parameters and virtual overrides
--HG--
branch : trunk
2010-12-14 16:24:59 +01:00
click
2642894342 Core: Add new system for parallelizing client packet processing. Handle WorldSession updates in Map::Update() where we are safe to proceed. Patch by Ambal.
(And clean up tabs and whitespace while rummaging around in there)
Closes issue 5084.

--HG--
branch : trunk
2010-12-13 22:37:56 +01:00
Shauren
e4e048ed57 Core/Scripts: Fixed possible crashes in instance scripts (Icecrown Citadel and Naxxramas)
Scripts/Sunwell Plateau: Fixed crash in Kil'jaeden
Scripts/Icecrown Citadel: Fixed crash in Blood-Queen Lana'thel

Closes issue #5051.
Closes issue #5050.
Closes issue #5035.

--HG--
branch : trunk
2010-12-08 17:24:31 +01:00
Spp
408fce1de6 Core: Some optimizations
- Declare some functions const
- Fix some mem leak
- Fix some resource leak
- Remove unused variables and functions
- Remove duplicate functions
- Reduce the scope of some variables
- Remove unused file

--HG--
branch : trunk
2010-12-06 02:07:53 +01:00
leak
6fe19b5a86 Core/Scripts: Split OnCreatureCreate() and OnGameObjectCreate() into two virtual functions each.
Note to scripters: be aware that you will need to hook into the Remove functions if you want to do stuff at GO/creature removal.
Closes issue 5011.

--HG--
branch : trunk
2010-12-05 18:04:10 +01:00
Spp
25ac835507 Core/Groups: Move all function definition from .h to .cpp
Core/Groups: Remove Group.h dependency from any .h file

--HG--
branch : trunk
2010-11-29 07:50:31 +01:00
azazel
87d723405e Core/Scripts: return const modifier to Player methods back (should restore compilation for those with custom scripts).
NOTE: The main idea of original change is to allow scripts change content of message so that calling method sends modified message to client.
For example, moderating script which cuts illegal words from message.

--HG--
branch : trunk
2010-11-18 10:26:34 +06:00
azazel
4fb572015a Core/Scripts: pass message parameter by reference in OnChat methods to make it possible to be modified inside the script.
--HG--
branch : trunk
2010-11-17 18:14:35 +06:00
linencloth
8fae0c176d Core/Units: Rename and change Get/SetVisibility to use a bool value instead of an unnecessary enum
Also replace some SetVisibility hacks to directly call UpdateObjectVisibility

--HG--
branch : trunk
2010-11-16 01:13:04 +01:00
Shauren
7133f3f08e Core: Fixed some build warnings
--HG--
branch : trunk
2010-11-11 13:40:52 +01:00
Shauren
f2fdcdf8f3 Core/Scripts: Added enum for generic script texts, fixed one broken text
Scripts/Icecrown Citadel: Blood-Queen Lana'Thel will no longer spawn for Blood Princes intro if they were already killed

--HG--
branch : trunk
2010-11-03 16:44:34 +01:00
Shauren
d03aeab9ad Scripts/Icecrown Citadel: Added Blood Prince Council script
Scripts/Icecrown Citadel: Festergut will not cast Vile Gas on melee targets if there are at least 3 (25 man: 8) ranged targets
Scripts/Icecrown Citadel: Festergut and Rotface gates will close with delay (when Putricide reaches the balcony)
Scripts/Icecrown Citadel: Replaced ASSERT(instance) with code disabling the AI if not inside instance
Core/Spells: Fixed TARGET_DEST_TARGET_RANDOM usage
Core/Scripts: Extended DamageDealt in AI to accept damage type as 3rd parameter
Scripts/Quests: Fixed quest "Unholy Infusion" (24749)

--HG--
branch : trunk
2010-10-24 21:27:02 +02:00
Supabad
153352aac0 More missing script_texts by Tome
- Master Kelerun Bloodmourn
- fix typo in previous commit
- fix typo in script and apply some standards

--HG--
branch : trunk
2010-10-24 00:46:21 +02:00
_manuel_
4ab3b63646 Core/Scripts: Applied some Coding Standards.
--HG--
branch : trunk
2010-10-21 23:24:12 -03:00
_manuel_
8ad97b1a47 Core/Scripts: Uldaman improvements.
Uldaman now is near to 99% blizzlike, datas and events are fully rewriten.
* Add save to instance.
* Add support for quest 2240 (Hidden Chamber).
* Archeadas Encounter more blizzlike.
* Ironaya Event (and animation) now working for Horde and Ally.

Author: D_Skywalk

Closes issue #4431.

--HG--
branch : trunk
2010-10-21 20:54:47 -03:00
click
34eed2de3f Core/Scripts: Fix menu clearing in onGossipSelect()-sections for some scripts (including examples) - patch/fix by Paradox
Closes issue 4524

--HG--
branch : trunk
2010-10-21 20:12:33 +02:00
Shocker
63aa6e44fb Core/Scripts: Small, insignificant cleanups
--HG--
branch : trunk
2010-09-21 04:57:08 +03:00
silinoron
48b29e6019 Scripts/Eastern Kingdoms/Scarlet Enclave: Fix some display issues.
Patch by Ramor.
Fixes issue #2503

--HG--
branch : trunk
2010-09-18 19:23:13 -07:00
Shocker
61c11f8f9b Scripts/Deadmines: Fix OnUse hook usage, thanks zaphod, closes issue 3942.
Note: If you spot similar errors (forgotten changes for hooks) in other scripts, please report them

--HG--
branch : trunk
2010-09-13 01:59:09 +03:00
Shauren
e0ffae436c Core/Quests: Fixed remaining issues with quest crediting (note: previous commits did not introduce issues, only revealed them)
Core/DBLayer: Fixed more compile warnings
Core/Spells: Corrected code style from revision 634af79146

Closes issue #3956.

--HG--
branch : trunk
2010-09-12 19:17:58 +02:00
click
bf664b7a44 Cleanup/Core: Remove whitespace and tabs
--HG--
branch : trunk
2010-09-12 01:40:27 +02:00
Shocker
3999444157 Core/Scripts: Use same standard for all GetInstanceScript's, closes issue 3890
--HG--
branch : trunk
2010-09-08 11:42:11 +03:00
Shocker
665bc1ffb9 Typo fixes, closes issue 3885, thanks zaphod & Paradox
--HG--
branch : trunk
2010-09-08 09:35:54 +03:00
click
8823a91cdc BuildSystem/ALL: Remove unused custom code (most are duplicated as in examples)
+ remove fileglobbing for scripts (less error-prone)
+ Create proper lists per "scriptsection"
NOTE! This change requires new files (cpp/h) to be MANUALLY ADDED to <type>/CmakeLists.txt

--HG--
branch : trunk
2010-09-05 17:19:41 +02:00
azazel
f500ef201b Scripts/Texts:
* fix script texts in various locations (thanks TerrorBringer for the heads up). Closes issue #2055. Closes issue #3087.
* cleanup world_script_texts.sql file (remove spaces, order entries)
Scripts/Misc:
* remove obsolete random seed initialization from scripts
* fix some warnings in scripts
* some cleanup in chat_log.cpp

--HG--
branch : trunk
2010-09-05 02:16:58 +06:00
azazel
b2a49ad79a Scripts/Blackrock Depths: fix spectral chalice spawning for quest with the same name (thanks niksad8). Closes issue #3086. Closes issue #2989.
--HG--
branch : trunk
2010-09-01 10:40:44 +06:00
Shauren
58ce3c77af Core/Scripts: Revert revision 619ba8b76250 and fix it properly
--HG--
branch : trunk
2010-08-31 15:37:29 +02:00
Spp
b5beb1c706 Better way to fix some warnings from rev 621c100eeb.
--HG--
branch : trunk
2010-08-31 13:31:38 +02:00
Spp
b9e19572c4 Core: Fix more warnings (very few left under linux 32)
--HG--
branch : trunk
2010-08-31 11:39:51 +02:00
Spp
e252b8abe7 Core: Fix more warnings
--HG--
branch : trunk
2010-08-30 23:07:14 +02:00
Spp
405f312918 Core: Fix more warnings
--HG--
branch : trunk
2010-08-30 15:25:15 +02:00
Liberate
f67441b863 Fixes gossip scripts or points of interests of npc's with a Scriptname assigned to them.
This fixes guards in Major cities.
Thanks to Aokromes for testing.
Thanks to click for converting all the scripts to work with this change.

--HG--
branch : trunk
2010-08-29 00:57:51 +02:00
QAston
30d31ca40a *Fix usage of EffectValueMultiplier in spell code.
*Remove some obsolete code from spell class.
*Rename some spellmod and dbc column names to be more accurate.

--HG--
branch : trunk
2010-08-26 19:07:55 +02:00
azazel
341e6303ef Core:
* add helping methods for manipulating unit's health and use it where applicable
* fix some conversion warnings and cleanup code (formatting, CRLF, tabs to spaces)

--HG--
branch : trunk
2010-08-26 01:20:57 +06:00
Shocker
91ebad0016 * Add support for quest 1393 (Galen's Escape), original code by przemratajczak, port by McBitter, closes issue 3463
* Fix typo in AuctionHouseHandler, thanks GriffonHeart, fixes issue 3609
* Forgotten thanks

--HG--
branch : trunk
2010-08-25 21:23:28 +03:00
azazel
caa3a58213 Core:
* add Player::HasEnoughMoney methods to check, whether player has specified amount of money and use new methods where applicable
* fix some signed/unsigned warnings and some typos

--HG--
branch : trunk
2010-08-23 22:58:32 +06:00
Spp
58e94dcb9d Core: Fix more warnings
--HG--
branch : trunk
2010-08-23 14:10:24 +02:00
azazel
399e35f8f5 Core:
* fix "warning C4305: 'initializing' : truncation from 'double' to 'float'" warnings
* fix some other warnings here and there

--HG--
branch : trunk
2010-08-22 23:46:40 +06:00
click
95f0d56077 Core/Scripts: Fix even more scriptbugs from convertion (thanks to Kierkegaard)
--HG--
branch : trunk
2010-08-18 20:35:29 +02:00
Machiavelli
075a4525d7 This should be the last of the malfunctioning AI scripts, thanks to click for the list
--HG--
branch : trunk
2010-08-14 10:28:45 +02:00
Machiavelli
3cf6af1779 Also fix npc_scarlet_miner
--HG--
branch : trunk
2010-08-14 05:51:29 +02:00
Machiavelli
cc351c7f1c Fix script (and crash in) npc_scarlet_miner_cart
--HG--
branch : trunk
2010-08-14 05:47:51 +02:00
Machiavelli
d5270f9e0d Globally find & replace InstanceScript* GetInstanceData_InstanceMapScript(Map* pMap) -> InstanceScript* GetInstanceScript(InstanceMap* pMap) const, this makes sure instance scripts get initialized properly and prevents crashes in scripts.
NOTE: this either breaks or fixes crlf, have no time to check now.

--HG--
branch : trunk
2010-08-11 21:52:44 +02:00
silinoron
a094d3e281 Properly initialize instance scripts with the appropriate map id to avoid loadup errors.
--HG--
branch : trunk
2010-08-09 10:37:28 -07:00
click
72d27a34fd Clean up some doubledefined ScriptPCH.h includes
--HG--
branch : trunk
2010-08-09 16:24:13 +02:00
click
abd261b1a1 Replace (CR) character from all converted scripts and replace it with it's proper (LF) counterpart
- should fix the "linking scripts" failure (not tested)

--HG--
branch : trunk
2010-08-09 01:52:26 +02:00
azazel
e5c797cef6 * Fix remaining errors in scripts project
* Remove now obsolete ScriptedInstance.h file

--HG--
branch : trunk
2010-08-09 00:56:10 +06:00