Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-20 17:27:36 +01:00
Code Issues Packages Projects Releases Wiki Activity
42,516 Commits 4 Branches 146 Tags
62156f57b285ee252c2c4143236a3df95f219ca5
Commit Graph

7419 Commits

Author SHA1 Message Date
Treeston
a121f47ba3 9ad11e6 follow-up, prevent Halion respawn without loot 
tagging #21198

(cherry picked from commit f0a394753a)
 2021-05-16 21:56:06 +02:00
Treeston
c31ae7ab33 Core/Threat: Fix a potential exploit allowing players to damage a boss without them taking damage. 
Scripts/Halion: General cleanup of old hacks no longer needed under new combat system.

(cherry picked from commit 9ad11e67fb)
 2021-05-16 21:56:06 +02:00
Treeston
8b7728f82e Core/Map: New Map::ForceRespawn to override objections and force a respawn (equivalent to force = true). Use this to fix various GM commands. 
Scripts/Valithria: Fix an issue that could get the encounter stuck in an unloaded state.

(cherry picked from commit 3bb33e3108)
 2021-05-16 21:56:06 +02:00
Shauren
c79e5528e1 Core/Units: Remove Unit::EnergizeBySpell overload taking spellId argument 2021-05-16 21:56:06 +02:00
Shauren
b9d63c2009 Core/Scripts: Remove deprecated overload of QuestReward without LootItemType argument 2021-05-16 21:56:06 +02:00
Treeston
dce39aedc2 Core/Combat: Some more sanity check asserts to try and track down #21187. 
Also, some anti-annoyance treatment for dot tele.

(cherry picked from commit fdacf12739)
 2021-05-16 21:56:05 +02:00
Moein
673cc20e79 MovementInform should overrides 
(cherry picked from commit 18f5eae835)
 2021-05-16 21:56:05 +02:00
Treeston
5aee452943 Core/Misc: A variety of clean-up changes, mostly following up on 532ab1c to fix legacy bugs exposed by it: 
- Triggers can no longer have a threat list (this may expose some ugliness in old legacy scripts)
- Threat entries are forced to OFFLINE if the AI refuses to attack the target
- Clean up passive creature evade behavior to be more consistent
- Fix a months old issue in spawn group management that would cause "Inactive" to incorrectly show in .list respawns for system groups outside of map 0
- Valithria script cleanups, remove old hacks and make it work with the new system. Closes #21174.
- Some strings cleanup

(cherry picked from commit 9f9507e6a1)
 2021-05-16 21:56:05 +02:00
Treeston
34c7810fe5 Core: Combat/threat system rewrite (PR #19930) 
- PvE combat is now always mutual. UNIT_FLAG_IN_COMBAT is backed by actual references to the units we're in combat with.
- PvP combat is now also tracked, and almost always mutual; spells like Vanish and Feign Death can break this rule. That means we can easily determine a list of players we're fighting.
- By extension, IsInCombatWith now has sensible behavior when invoked on nonplayers.
- Threat and combat systems are no longer the same.
  - They still have an enforced relationship (threat implies combat - clearing combat clears threat)...
  - ...but we can have combat without threat. A creature (with threat list) isn't considered to be engaged until it has an entry on its threat list...
  - ...which means we can now faithfully replicate retail engage behavior. Combat on projectile launch - engagement start on projectile impact. Yay for progress!
- AI method refactor, as already ported in 6113b9d - `JustEngagedWith`, `JustEnteredCombat` and `JustExitedCombat`.
- Vehicle threat is now properly pooled on the main vehicle body (fixes #16542).
- Various edge case bug fixes for threat redirects (Misdirection "cancelling" Vigilance and similar).
- Target re-selection is now significantly faster.
- Fixed a ton of other smaller edge case bugs, probably.

Closes #7951 and #19998.

(cherry picked from commit 532ab1c7f8)
 2021-05-16 21:56:01 +02:00
Shauren
12ed21e690 Scripts/Spells: Clear arcane charge damage/cost/cast time modifier aura when reaching 0 arcane charges (power) 2021-05-15 17:44:31 +02:00
Shauren
331c7ec7c2 Scripts/Spells: Remove manual damage adjustment from Arcane Barrage for scaling with arcane charges and use spell cast for mana energize 2021-05-15 17:44:31 +02:00
Shauren
fd7f854995 Scripts/Spells: Properly utilize all Arcane Explosion energize effects 2021-05-15 17:44:31 +02:00
Matan Shukry
be8cbab4b3 Scripts/Spells: Fixed arcane barrage + explosion 2021-05-15 17:44:31 +02:00
Shauren
2906926173 Core/Scenes: Fix scenes played by package id storing pointers to stack variables 2021-05-12 14:23:21 +02:00
Shauren
f072bc4ca1 Core/Commands: Add ItemContext argument to .additem and .additemset commands 2021-05-11 18:25:22 +02:00
Shauren
91b91b502f Core/Quests: Quest improvements 
* Add quest log slot argument to functions dealing with objective progress
* Implemented QUEST_OBJECTIVE_FLAG_SEQUENCED (prevent progressing hidden objectives)
 2021-05-09 20:21:32 +02:00
ariel-
9bf5a03bc4 Core/Scripts: fix Millhouse Manastorm resetting dialogs after Skyriss encounter 
Closes #21159

(cherry picked from commit fd7fff80c9)
 2021-05-06 07:06:27 +02:00
ariel-
82fa6ede59 Core/Scripts: cast "Trial of the Naaru: Tenacity" credit spell when criteria is achieved 
Closes #21155

(cherry picked from commit 036a05458e)
 2021-05-06 07:06:27 +02:00
ariel-
f77bd1e7c9 Core/Scripts: fixed npc immunity flags during Harbinger Skyriss encounter 
- Added missing _Reset
- Properly register Skyriss summons in SummonList

Closes #21154

Who ordered up an extra large can of whoop-ass?

(cherry picked from commit f8b148c334)
 2021-05-06 07:06:27 +02:00
ariel-
87d5544f05 Core/Scripts: Implemented Shifting Naaru Sliver 
(cherry picked from commit a5d4f34c31)
 2021-05-06 07:06:27 +02:00
ariel-
5ac40cf9d1 Core/Scripts: fix issues with 'Squeeze' on Yogg-Saron encounter 
- Unassigned spell script for 25-man difficulty
- Didn't remove aura on 25-man when tentacle killed

(cherry picked from commit de3fd4d076)
 2021-05-06 07:06:27 +02:00
Shauren
14098b28b3 Core/Chat: Allow incorrect spell/skill language assignments to mirror client behavior 2021-05-03 23:53:24 +02:00
Matan Shukry
3b578fc6b9 Core/Chat: Load chat language data from db2 and implement serverside chat translations 2021-05-03 23:53:24 +02:00
Matan Shukry
c99f93d53d Scripts/Spells: Implemented monk stagger (#26295) 2021-04-22 22:45:26 +02:00
Shauren
8a452c3d10 Scripts/Spells: Implemented discipline priest PvP talent Trinity 2021-04-21 23:14:02 +02:00
Matan Shukry
dbc082a2b2 Scripts/Spells: Implemented Atonement 
* Also renamed spell_priest_spirit_of_redemption to spell_pri_spirit_of_redemption
 2021-04-21 23:14:02 +02:00
Matan Shukry
81eac82656 Core/Spells: Implement priest holy words + modify cooldown for a charge (#26270) 
Co-authored-by: Shauren <shauren.trinity@gmail.com>
 2021-04-19 23:54:13 +02:00
Matan Shukry
530631e0a7 Core/Auras: Implemented SPELL_AURA_SCHOOL_ABSORB_OVERKILL (#26269) 2021-04-17 22:42:34 +02:00
jackpoz
4f643e3f32 Core/Misc: Removed unneeded checks 
(cherry picked from commit 513e153a13)
 2021-04-16 20:53:41 +02:00
Treeston
bce43de7f3 Core/AI: Some more refactoring prep for #19930. CreatureAI::EnterCombat is now called CreatureAI::JustEngagedWith. There's also two new methods on UnitAI, though they're never invoked right now. 
(cherry picked from commit 6113b9dec2)
 2021-04-16 20:22:13 +02:00
Treeston
9b141207d1 [3.3.5] CastSpell unclusterfucking (that's a word now) (#21123) 
Core/Spell: The giant CastSpell unclusterfucking (that's a word now) of this generation.

- CastSpell now always takes three arguments - target, spellId, and a struct containing extra arguments
- This struct (CastSpellExtraArgs, see SpellDefines.h) serves as a conglomerate of every previous combination of the 20 billion different CastSpell overloads, all merged into one
  - It has some great utility constructors - check them out! All of these can be used to implicitly construct the ExtraArgs object.
- A gajillion refactors to make everything behave the way it always has

(cherry picked from commit d507a7e338)
 2021-04-16 15:22:42 +02:00
Jeremy
446fc391f0 Core/Entities: Fix some weird movement due to los issues (#21125) 
* Core/Entities: Fix some weird movement due to los issues
- Made LoS check use collisionHeight instead of midsection. Value was too low.
- Gnomes will now have a breath bar more quickly than for example a tauren.
- Changes have been made to checking for ground z as well, some tweeking might be needed but removed most of the scattered +2.0f/+0.5f/we
* Add 0.05f to isInAir check in Creature::UpdateMovementFlags

(cherry picked from commit e42903ec16)
 2021-04-15 05:53:27 +02:00
ariel-
61585de8ae Core/Scripts: fix codestyle 
(cherry picked from commit e2a97ba7e7)
 2021-04-15 05:53:27 +02:00
Keader
6c2d0d709a Core/Scripts: Val'anyr Hammer of Ancient Kings should proc only with effective heal 
(cherry picked from commit 502864e86c)
 2021-04-15 05:53:27 +02:00
ariel-
313b2ff526 Core/Scripts: remove Quel'Delar from player inventory during "The Halls Of Reflection" quests (24480, 24561) 
(cherry picked from commit d13999c8d6)
 2021-04-15 05:53:27 +02:00
ariel-
cfa8474520 Core/Scripts: prevent Arthas in CoS losing his gossip flag and halting instance progress 
(cherry picked from commit 720ba9e973)
 2021-04-15 05:53:27 +02:00
ariel-
f8729f9aa0 Core/Scripts: fixed Festergut applying more than one stack of Inoculated at once 
(cherry picked from commit c409ba8d9d)
 2021-04-15 05:53:27 +02:00
Keader
a7883380ce Core/AI: Making guid const& in SetGUID method (#21128) 
(cherry picked from commit 465b43fabe)
 2021-04-15 05:53:27 +02:00
jackpoz
8244d60859 Core/Misc: Fix static analysis issues 
(cherry picked from commit ad56299846)
 2021-04-15 05:53:27 +02:00
jackpoz
0a528a525b Scripts/Trial of Crusader: Fix static analysis issues 
(cherry picked from commit cbc7642edd)
 2021-04-15 05:53:27 +02:00
jackpoz
e17e4e6f07 Core/Misc: Replace time(NULL) with GameTime::GetGameTime() 
(cherry picked from commit 12701cb0c6)

 Conflicts:
	src/server/game/Achievements/AchievementMgr.cpp
	src/server/game/AuctionHouse/AuctionHouseMgr.cpp
	src/server/game/AuctionHouseBot/AuctionHouseBotBuyer.cpp
	src/server/game/AuctionHouseBot/AuctionHouseBotSeller.cpp
	src/server/game/Battlefield/Battlefield.cpp
	src/server/game/Battlefield/Zones/BattlefieldWG.cpp
	src/server/game/Battlegrounds/BattlegroundMgr.cpp
	src/server/game/Calendar/CalendarMgr.h
	src/server/game/DungeonFinding/LFGQueue.cpp
	src/server/game/Entities/Corpse/Corpse.cpp
	src/server/game/Entities/Creature/Creature.cpp
	src/server/game/Entities/Item/Item.cpp
	src/server/game/Entities/Pet/Pet.cpp
	src/server/game/Entities/Player/Player.cpp
	src/server/game/Entities/Unit/Unit.cpp
	src/server/game/Globals/ObjectMgr.cpp
	src/server/game/Grids/ObjectGridLoader.cpp
	src/server/game/Guilds/Guild.cpp
	src/server/game/Handlers/AuctionHouseHandler.cpp
	src/server/game/Handlers/BattlefieldHandler.cpp
	src/server/game/Handlers/CalendarHandler.cpp
	src/server/game/Handlers/CharacterHandler.cpp
	src/server/game/Handlers/ChatHandler.cpp
	src/server/game/Handlers/LFGHandler.cpp
	src/server/game/Handlers/MailHandler.cpp
	src/server/game/Handlers/MiscHandler.cpp
	src/server/game/Handlers/MovementHandler.cpp
	src/server/game/Handlers/PetHandler.cpp
	src/server/game/Handlers/QueryHandler.cpp
	src/server/game/Handlers/TicketHandler.cpp
	src/server/game/Instances/InstanceSaveMgr.cpp
	src/server/game/Server/WorldSession.cpp
	src/server/game/Server/WorldSocket.cpp
	src/server/game/Spells/Auras/SpellAuras.cpp
	src/server/game/Tickets/TicketMgr.cpp
	src/server/game/Tickets/TicketMgr.h
	src/server/game/World/World.cpp
	src/server/scripts/Commands/cs_gobject.cpp
	src/server/scripts/Commands/cs_instance.cpp
	src/server/scripts/Commands/cs_list.cpp
	src/server/scripts/Northrend/zone_wintergrasp.cpp
	src/server/scripts/Spells/spell_item.cpp
 2021-04-15 05:53:27 +02:00
Keader
a5635526ed Scripts/Trial of Crusader: Northrend Beasts Rework (#21031) 
* Rewritten Gormok encounter
* Rewritten Snobold Vassal Script
* Rewritten Jormungars encounter
* Rewritten Icehowl encounter
* Added missing texts
* Added missing spells
* Implemented berserk mechanic on heroic diffs.
* Implemented Achievement requirement to make heroic diffs.
* Rewritten Barrett Ramsay scripts
* Added Barrett gossips and ported everything to DB.
* Added right Barrett in each encounter
* Removed a lot of hacks
* Rewritten Tirion Fordring script
* Rewritten Varian Wrynn script
* Rewritten Garrosh script
* Rewritten Wilfred event
* Rewritten Lich King event
* Updated codestyle
* Added missing spawns
* Fixed combat behavior before Gormok
* Fixed some visual stuff

(cherry picked from commit 2362e9c794)
 2021-04-15 05:53:27 +02:00
Killyana
eba8916ca2 Typo 
(cherry picked from commit b08280fcfe)
 2021-04-15 05:53:27 +02:00
Killyana
2e828b4026 Scripts/Stratholme: Fix a DB error 
Ref #20749

(cherry picked from commit be56a4669e)
 2021-04-15 05:53:27 +02:00
jackpoz
bddd58d469 Scripts/Stratholme: Add missing header for no-pch build 
(cherry picked from commit 9a515c29ba)
 2021-04-15 05:53:27 +02:00
jackpoz
cf04609c9a Scripts/Stratholme: Fix build 
(cherry picked from commit 828c5d08e7)
 2021-04-15 05:53:27 +02:00
jackpoz
b99654924c Scripts/Stratholme: Fix build 
(cherry picked from commit a98b2aa8c8)
 2021-04-15 05:53:27 +02:00
Riztazz
d01914ffcc Scripts/Stratholme: Few changes to how Ysida behaves during the Baron run (#20749) 
(cherry picked from commit 2a25d9d9a7)
 2021-04-15 05:53:27 +02:00
ariel-
16ec008290 Core/Spells: fix some DB errors 
Ref #18542

- Implemented Choking Vines transformation at 5 stacks
- Implemented periodic Aura of Fear ticks
- Fixed Savage Rend passive proccing on anything (raptor pets)

(cherry picked from commit de9f904269)
(cherry picked from commit 32e2207ab9)
(cherry picked from commit 9934a43e09)
 2021-04-15 05:53:27 +02:00
Keader
bd62bfc059 Scripts/Naxxramas: Fixed blizzards following same player in Sapphiron encounter (#21068) 
Closes #18765

(cherry picked from commit 143b2aeac0)
 2021-04-15 05:53:27 +02:00