MitchesD
718b0e6bdd
Core/SmartScripts: SMART_ACTION_EQUIP prevent to false errors
2014-04-03 19:47:27 +02:00
jackpoz
0930482fa4
Core/Misc: Fix uninitialized values
...
Fix Position members not being always initialized.
Valgrind log:
at : Position::NormalizeOrientation(float) (Object.h:388)
by : Position::SetOrientation(float) (Object.h:315)
by : Position::Relocate(Position const&) (Object.h:310)
by : spell_ulduar_stone_grip::spell_ulduar_stone_grip_AuraScript::OnRemoveVehicle(AuraEffect const*, AuraEffectHandleModes) (boss_kologarn.cpp:592)
2014-04-02 20:42:46 +02:00
Unholychick
8edf6247c0
Fix trinkets/talents procs on hots taken/done
2014-04-01 10:09:26 +02:00
Unholychick
8f607ed8a3
Revert f79a8813a0
2014-04-01 10:06:37 +02:00
jackpoz
f47962f670
Core/Misc: Fix some static analysis issues
...
Add some asserts and additional NULL checks as sanity checks.
2014-03-31 20:59:33 +02:00
Vincent-Michael
bacfbdc4ee
Core/Sai: Added new db errors :P (hihi)
2014-03-31 17:32:39 +02:00
Gacko
a01fd35dc9
Core/CreatureText: Unify log messages and add GUID
2014-03-30 22:17:03 +02:00
Shauren
b949d0b982
Core/Misc: Defined a few fields in Map.dbc and rewritten InstanceMap::GetMaxPlayers to match what the client does to determine max players
2014-03-30 15:42:05 +02:00
Gacko
7630b3c627
SmartAI: Use same method for removing auras in EnterEvadeMode as in CreatureAI
...
Also fixes warnings about duplicate auras. Self-casted auras were not removed on entering evade mode in SAI as they are in CreatureAI.
2014-03-30 15:05:04 +02:00
jackpoz
0056ec04c0
Core/Misc: Fix warning with GCC
2014-03-30 13:30:00 +02:00
jackpoz
dfca19444a
Core/Misc: Fix warning
2014-03-29 21:51:45 +01:00
jackpoz
4cffd2e707
Core/Commands: Handle "" as empty string argument
...
Fixes #11548
2014-03-29 21:07:46 +01:00
Shauren
973888ea2c
Core/Maps: Fixed incorrect difficulty markers shown on the interface inside Icecrown Citadel (always displaying normal mode)
2014-03-29 13:31:06 +01:00
Shauren
3fd6dd6175
Core/Loot
...
* Master Looter cannot freely loot items under threshold
* Update round robin looter only if loot is not empty
* Fixed loot bag icon appearing in raid frames when loot method was not Master Looter
* Fixed changing loot method reseting current round robin looter
2014-03-29 13:29:22 +01:00
Shauren
dee867547d
Merge pull request #11719 from Dehravor/master-loot
...
Core/Loot: Fix master loot
2014-03-29 13:24:48 +01:00
jackpoz
f7659e5c1a
Core/Battlegrounds: Fix log errors about creatures not found
...
Move "Battleground::GetBGCreature: creature not found for BG" error log to INFO level when the caller expects no creatures to be found, like on Battleground startup.
Closes #3538
2014-03-28 22:30:33 +01:00
jackpoz
8c44259fae
Core/Misc: Fix some static analysis issues
...
Fix uninitialized values, most of which are false positives, always initialized before being accessed.
Add some asserts and additional NULL checks as sanity checks. Use SpellMgr::EnsureSpellInfo() if the spell id is valid and always supposed to return a valid not-NULL SpellInfo* .
2014-03-27 21:43:59 +01:00
Discover-
17674182c4
Core/SAI: Allow only creature sources to use the event types SMART_EVENT_DISTANCE_CREATURE and SMART_EVENT_DISTANCE_GAMEOBJECT for now.
2014-03-26 13:50:36 +01:00
Discover-
76641bc7dc
Core/SAI: Only allow SMART_EVENT_TARGET_BUFFED to be used from creature sources.
2014-03-26 13:44:36 +01:00
deathicon
78e9a3eb65
Core/SAI: Implement two new event types that are triggered when a certain creature/gameobject entry or guid gets within a given distance of the source.
2014-03-26 10:23:34 +01:00
jackpoz
5570e32d0e
Core/Misc: Fix assertion triggered
...
Change an assertion added in 6dcd8c8545Fixes #11771
2014-03-24 20:13:55 +01:00
Shauren
c3d2236d14
Core/Misc: Removed unused defines, added missing include and removed a few warnings
2014-03-23 22:14:25 +01:00
Shauren
a4d8a26dc7
Scripts/Icecrown Citadel: Icecrown Gunship Battle
2014-03-23 02:01:13 +01:00
Shauren
550cbcad96
Core/Transports: Enabled LoS on transports
2014-03-23 00:23:30 +01:00
Shauren
3a1a55bb0a
Core/Spells: Fixed target selection hooks running twice for each effect if both target A and B were using the same hook type (OnObjectAreaTargetSelect, OnObjectTargetSelect, OnDestinationTargetSelect)
2014-03-22 21:39:38 +01:00
Shauren
3c16c63293
Core/Transports: Fixed crashes happening when a transport was despawned with players/dynamicobjects on it
2014-03-22 19:44:54 +01:00
Shauren
529cabea68
Core/Map: Save weather, light and music overrides in map to send them to players logging in
2014-03-22 19:40:36 +01:00
Shauren
0758c47491
Core/Spells: Fixed crash happening when a spell script set target to NULL in OnObjectTargetSelect hook for spells using nearby target selection
2014-03-22 16:35:11 +01:00
jackpoz
6dcd8c8545
Core/Misc: Fix some static analysis issues
...
Fix some static analysis issues about:
- uninitialized values, most of which are false positives, always initialized before being accessed
- unchecked return values
- dead code never executed
- bad formatting leading to wrong behavior
Please ensure EventMap is never used with event id set to 0 or those events will never execute.
2014-03-22 14:54:32 +01:00
jackpoz
9e99db035f
Core/Misc: Fix some static analysis issues
...
Add some asserts and additional NULL checks as sanity checks.
2014-03-21 22:47:58 +01:00
Shauren
ada0598bb0
Core/Transports: Fixed creatures micro movement on transport when attacking something (fixes interrupting melee animation)
2014-03-21 21:11:20 +01:00
Shauren
0c3633e775
Core/GameObjects: Added workaround for elevators having different position for every player
...
Closes #11504
2014-03-21 00:32:03 +01:00
jackpoz
4c27c83efa
Core/Misc: Fix some static analysis issues
2014-03-20 21:34:05 +01:00
Shauren
46ccb1d15e
Core/Creatures: Added check for creature_equip_template.id = 0. 0 is a special value telling core to unequip all items
2014-03-20 11:46:17 +01:00
Gacko
42d53d9891
Core/Game: Logical fix
2014-03-19 10:04:28 +01:00
Dehravor
7401ab7eab
Core/Loot: Fix an exploit that allowed players to loot infinite amount of items that have condition(s)
2014-03-17 18:46:17 +01:00
Shauren
69fb9642a3
Fixed build with TRINITY_DEBUG
2014-03-16 21:22:31 +01:00
Shauren
263c5cacf4
Core/Maps: Fixed height calculations used in WorldObject::UpdateGroundPositionZ/WorldObject::UpdateAllowedPositionZ, they will now take vmaps into account.
2014-03-16 20:13:25 +01:00
Shauren
f0f4a620fb
Core/Transports: Added support for DynamicObjects on transports
2014-03-16 20:00:09 +01:00
Dehravor
6a5c43b0d8
Core/Loot: Implement round robin for under threshold items in case of master loot
...
Thanks @Shauren for pointing out
2014-03-16 19:12:01 +01:00
jackpoz
f26a028d97
Core/Misc: Fix some static analysis issues
...
Fix some static analysis issues about uninitialized values. Most of them are false positives, always initialized before being accessed.
2014-03-16 14:18:33 +01:00
jackpoz
61c9891d6a
Core/Gossip: Fix crash added in 6c64fa8de3
...
Fix NULL dereference crash caused by a typo in 6c64fa8de3
2014-03-15 19:30:55 +01:00
Rochet2
6c64fa8de3
Core/Gossip: Add security to C++ scripted gossip options by checking guid of the object that the player is interecting with. Idea by @LilleCarl
...
Closes #11567
2014-03-13 20:27:11 +01:00
Rochet2
cfdd9421d2
Core/Gossip: Change max menu items to 32
...
Tested and a gossip menu can show max 32 items on a menu.
When sending 40 options: http://puu.sh/7rqb6.jpg
2014-03-12 10:20:26 +02:00
Dehravor
892d9eac79
Core/Loot: Fix master loot
...
Players will be able to open the loot window and see the items in case of master loot.
If the item is under threshold FFA applies, else the item becomes locked.
Also fix an exploit related to master loot item give.
2014-03-11 19:06:42 +01:00
Shauren
5221bd8c10
Core/Items: Fixed an exploit allowing people to put more gems than number of sockets on items.
...
Closes #11652
2014-03-10 12:58:03 +01:00
Discover-
6f1005ad94
Core/Misc: Get rid of whitespaces added in 96e0a7d71f
2014-03-10 06:54:24 +01:00
Warpten
d4416c0439
Merge pull request #11627 from Rochet2/OnPlayerSave
...
Core/Players: Call sScriptMgr::OnPlayerSave inside Player::SaveToDB rather than before calling it.
2014-03-09 21:51:57 +01:00
Rochet2
1f98435fda
Update Player.cpp
...
Dont trigger save hook on player create
2014-03-09 22:23:48 +02:00
kontownik
91850fa9e4
Core/Scripts: New ItemScript trigger, OnItemRemove
2014-03-03 22:18:47 +01:00
