Commit Graph

76 Commits

Author SHA1 Message Date
megamage
19bfa37ec6 [8405] Fixed possible crash in BGQueueRemoveEvent::Execute() when two paralell BattleGroundQueue Updates are called, optimalized code.
Signed-off-by: Triply <triply@getmangos.com>

--HG--
branch : trunk
2009-08-24 19:34:56 -05:00
Kudlaty
02071a74c0 Fix typo
--HG--
branch : trunk
2009-08-21 22:32:48 +02:00
Kudlaty
395b1f5130 Fix typo in battleground announcer. Thx Gyullo
--HG--
branch : trunk
2009-08-21 22:19:06 +02:00
megamage
7f8ce1d809 [8315] Fixed memory leaks (mostly at server shutdown) and code cleanups. Author: VladimirMangos
* Fixed leak in BattleGround::m_PlayerScores at BattleGround::Reset,
      add and use BattleGroundScoreMap typedef
    * Delete AreaTeam objects stored in global map at shutdown
    * Delete Corpse objects stored in global map at shutdown
    * Store guild bank log entries as objectes instead pointers in log event lists

--HG--
branch : trunk
2009-08-06 17:45:37 -05:00
QAston
1d96091d2a *Improvements in map managing.
--HG--
branch : trunk
2009-08-01 00:20:32 +02:00
megamage
06123fa3af *Add config option Arena.QueueAnnouncer.PlayerOnly
--HG--
branch : trunk
2009-06-19 19:30:32 -05:00
megamage
48ea016135 *Fix bg queue announce.
--HG--
branch : trunk
2009-06-19 12:41:16 -05:00
megamage
c17e9d62ab *Fix incorrect level in the bg queue announce
--HG--
branch : trunk
2009-06-19 11:29:34 -05:00
megamage
9d670fe6f5 *Switch to support client version 3.1.3
*I strongly recommend you not to use this until you get the 313 db. Now all destructible buildings cause client crash.

Source: Mangos
Thanks to TOM_RUS for most work to make this switch possible ;)

--HG--
branch : trunk
2009-06-11 00:45:59 -05:00
panaut0lordv
f6447e8f34 *Including style fixing - part 1
--HG--
branch : trunk
2009-06-04 21:41:07 +02:00
megamage
f92e8315cf [7918] Improve portability in work with uint64 string format specifiers and in code literals. Author: VladimirMangos
* Replace platform seelction MaNGOS code for select format descriptor for uint64 by using ACE define.
      I64FMTD renamed to UI64FMTD for more clear name.
    * Add new define UI64LIT (base at ACE seelction) for build portables uint64 literals.
      Please always use UI64LIT(0x00001) instead less portable 0x00001LL

--HG--
branch : trunk
2009-05-31 16:15:12 -05:00
megamage
295b634ca6 [7731] Some code cleanups, warrning fixes. Author: VladimirMangos
--HG--
branch : trunk
2009-04-29 00:31:03 -05:00
megamage
09af28301e [7716] Fixed some typos and possible crashes. Author: AlexDereka
--HG--
branch : trunk
2009-04-27 18:42:35 -05:00
megamage
1294bbac41 [7632] more "if"-condition related codestyle in battlegroundfiles Author: balrok,Triply
this time with this regex:
    sed -i 's/if *( *\(.*\) *)$/if (\1)/' BattleGround*

--HG--
branch : trunk
2009-04-08 16:33:46 -05:00
megamage
3a21b3d758 [7631] Removed useless method BattleGroundQueue::BGEndedRemoveInvites Author: Triply
Moved method BattleGroundMrg::InvitePlayer to BattleGroundQueue::InviteGroupToBG
    Added some comments to RemindInvite and RemoveInvite events.
    Optimalise code.

--HG--
branch : trunk
2009-04-08 16:29:28 -05:00
megamage
cb8b3fe5db [7607] Improvements in support some generic achievement classes Author: VladimirMangos
* Implement support achievements with refAchievement field != 0, that have criterias stored in achievement refAchievement.
    * Implement support achievement complete req. with specific count of completed critirias.
    * Avoid full achievement list scan at search achievement associated with criteria.

--HG--
branch : trunk
2009-04-03 16:36:20 -06:00
megamage
7d9a71a6cf [7523] Fixed: players will now drop flag in battleground if they cast immunity buff on themselves. Author: `win
TODO: players who carry flag in bg are imune to immunity buffs casted by friendly players. (todo added to code).
    Bug: if paladin casts Hand of protection on flag carrier - flag will be dropped, but he should get "target is immune" message.
    Fixed: Do not call Battleground::Update for battleground template objects.
    Fixed: Do not allow immune player to click on object in battleground (not sure if this is correct in all cases).

--HG--
branch : trunk
2009-03-24 09:36:50 -06:00
XTZGZoReX
9fe43fa9c0 * Implementing database logging:
** LogTime and LogColors config options removed due to incompatibility.
** Old file logging still available.
** Totally redone the Log class.
** Config options added: EnableLogDB, DBLogLevel, LogDB.Char, LogDB.RA, LogDB.GM -- remember to update config file.
** SQL updates attached.

--HG--
branch : trunk
2009-03-19 21:13:52 +01:00
megamage
c823272e34 [7449] Fixed BG queue invitation status showed on client. Fixed BG starting timer and BG ending timer. Author: Triply
TODO: make bg queue update player's status each minute.

--HG--
branch : trunk
2009-03-13 18:06:36 -06:00
megamage
a0fede4fc2 [7437] Fixed client visible instance ids for battlegrounds. Author: balrok
--HG--
branch : trunk
2009-03-10 15:30:44 -06:00
megamage
1c151b7244 [7436] Fixed Average Wait time for all BG/arena queue types. By Balrok and Triply.
--HG--
branch : trunk
2009-03-10 15:29:50 -06:00
megamage
f014ccd3bd [7416] Fixed minimap icon for battlegrounds and arenas. Author: balrok
--HG--
branch : trunk
2009-03-09 17:08:07 -06:00
megamage
c708eba713 [7415] Fixed removing player from battlegrounds Author: Triply
Probably fixed bug with not ending battlegrounds - reported in previous commit message
    Fixed player will loose arena rating if
    1. he doesn't click on enter rated arena window - and timer will expire
    2. he logs out during time he is invited to rated arena match
    3. if he logs out during fight in rated arena match
    Patch is not tested, i will test it as soon as possible.

--HG--
branch : trunk
2009-03-09 17:07:40 -06:00
megamage
1f296b7d40 [7414] Fixed premature finish timer messages for battleground (va_start was broken). Author: Triply
Fixed typo with BattleGroundPlayerMap.
    Optimized implementation for removing offline players from battleground.
    Fixed typo in BattleGroundMgr::DeleteAllBattleGrounds.
    Patch is tested and should work.

    TODO there is a bug if you disable premature finish timer, that can cause battlegrounds to be never ending!
    TODO rewrite BattleGround::RemovePlayer function - and fix bugs there!
    I might not have today enough time to fix those bugs.

--HG--
branch : trunk
2009-03-09 17:07:12 -06:00
megamage
520ce96257 [7399] Rewrited BattleGround starting code - moved it to battleground class. Author: Triply
Fixed message color for premature finish warnings.
    Fixed .debug bg command won't allow 1v0 arenas now, only battlegrounds 1v0.
    Added battleground announcer message removed in [7384].

[7401] Fixed bgqueue invitation to already started battlegrounds - not tested. Author: Triply

--HG--
branch : trunk
2009-03-07 12:05:30 -06:00
megamage
0d53225fdc [7392] Fixed SQL query for storing pending arena points for offline players for PGSQL. Author: ApoC
--HG--
branch : trunk
2009-03-06 18:14:41 -06:00
megamage
80cd305082 [7383] Changed some comments in config file, changed default MaxRatingDifference from 100 to 150 in default config.
[7384] Removed some comments.
    Fixed problem that queues doesn't invite new players to already running battlegrounds.
    Some other fixes for announce system will be soon.

Author: Triply

--HG--
branch : trunk
2009-03-05 19:02:08 -06:00
megamage
0b32a2c751 [7370] Fixed crash in CheckSkirmishForSameFaction() function, when we erased iterator which shouldn't be erased
Fixed crash in BattleGroundQueue::Update() by changing BGFreeSlotQueueType from deque to list. Author: Triply

--HG--
branch : trunk
2009-03-02 17:07:18 -06:00
megamage
8f874caccd [7366] Enabled skirmish arena matches for same faction. Author: Triply
Patch is tested and should not add crashes.

--HG--
branch : trunk
2009-03-02 17:02:27 -06:00
megamage
f503f320ad [7359] Fixed crash when removing battleground from BGFreeSlotQueue. Author: Triply
Fixed player will now drop a flag before he logs out, if he is in BG.

--HG--
branch : trunk
2009-03-02 16:46:43 -06:00
megamage
9ba3d07fc2 Fixed crashes when inviting same faction arena groups.
Fixed crash in BGEndedRemoveInvites (by setting queue type from deque to list). Author: Triply

--HG--
branch : trunk
2009-03-02 16:38:36 -06:00
megamage
59b5210574 Finally fixed problem with joining rated arena matches.
Thx to balrok for help and testing. Author: Triply

--HG--
branch : trunk
2009-02-27 12:58:02 -06:00
megamage
361f4b2e3c [7353] Fixed problem with joining rated arena matches. Thanks to balrok for help. Author: Triply
--HG--
branch : trunk
2009-02-27 12:57:33 -06:00
megamage
31e71cef1b [7352] Fixed conditions in FillPlayersToBG to correctly kick group only when other team's selection pool is empty. Problem reported by balrok. Author: Triply
--HG--
branch : trunk
2009-02-27 12:56:48 -06:00
megamage
9e392472d4 [7351] Fixed removing normal horde groups from queue. Author: Triply
Fixed Reflective shield - patch provided by Rastik. Thx

--HG--
branch : trunk
2009-02-27 12:56:00 -06:00
megamage
472f897b0a [7336] Implemented new BattleGroundQueue invitation system. Now it supports premade group versus premade group matches.
Added 2 new config options - InvitationType and PremadeGroupWaitForMatch - you can find more info in default config file.
    This patch can cause crashes.

Author: Triply

[7338] Little cleanup in battleground queues code. Author: ApoC

--HG--
branch : trunk
2009-02-27 12:13:59 -06:00
Drahy
5076e99df1 * Fixed recent crashes in battleground code at player leave. Thx VladimirMangos
--HG--
branch : trunk
2009-02-19 16:09:49 +01:00
panaut0lordv
966b6a4a8d Fix build
--HG--
branch : trunk
2009-02-18 22:39:00 +01:00
megamage
31637d4aac *Merge.
--HG--
branch : trunk
2009-02-18 11:36:19 -06:00
KingPin
14234c86fa Newline added to bottom of all files.
--HG--
branch : trunk
2009-02-17 20:07:49 -06:00
megamage
5881a1c25c Fixed crash at out of range access to array data in battleground code. Author: VladimirMangos
--HG--
branch : trunk
2009-02-16 20:11:24 -06:00
megamage
0a5b8f78f5 Small BattleGroundQueue::RemovePlayer cleanup. Author: VladimirMangos
--HG--
branch : trunk
2009-02-16 20:09:22 -06:00
megamage
59be8223e4 [7276] Rewrited fix for same faction arena matches
Added better Object-oriented calls to BattleGround::Reset()
    Added more checks to CreateBattleGround() method
    This commit doesn't fix anything

Author: Triply

--HG--
branch : trunk
2009-02-13 20:10:14 -06:00
megamage
096030e625 [7275] getbattlegroundqueueidfromlevel returns now bg-specific queueids
before this commit, queueids were staticaly given for
    9-19,20-29,30-39... but for instance alterac valley needs
    51-60,61-70,71-80.. this patch allows this,
    if you change the minlevel in battleground_template you also could make
    23-32,33-42.. levelranges
    not that we always use 10lvl-steps.. this is actually hardcoded..

Author: balrok

--HG--
branch : trunk
2009-02-13 20:07:49 -06:00
megamage
7305f57846 Fixed arena related client crash Author: tomrus88
--HG--
branch : trunk
2009-02-13 20:04:09 -06:00
megamage
8eb1f455a1 [7269] Use enum type for battleground queue type ids, and related cleanups.
* renamed a variable to make the content of it more clear: type->arenaslot
    * renamed BattleGroundQueueTypeId-variables to bgQueueTypeId
      just to make it easier reading the code (cause there existed
      3 different names for this..)
    * renamed GetBattleGroundQueueId to GetBattleGroundQueueTypeId
      again this is just for better understanding
    * Renamed [GS]etQueueType and m_Queue_type
    * Renamed to [GS]etQueueId and m_QueueId

Author: balrok

--HG--
branch : trunk
2009-02-13 19:56:22 -06:00
megamage
70798207f8 [7257] Fixed unexpected errors in log and non-freed memory at battleground system shutdown. Author: VladimirMangos
--HG--
branch : trunk
2009-02-10 09:55:16 -06:00
megamage
fe85f52142 [7252] Move all world global broadcast string (all arena/bg related) to mangos_string.
PLEASE, NOT USE string world broadcasts in real code. This function _only_ for debug purposes.

    Really allow with .debug bg start bg with 1 player.
    Added helps for some existed .debug commands.

Author: VladimirMangos

--HG--
branch : trunk
2009-02-10 00:59:10 -06:00
megamage
7f39dbd848 *add .debug bg to allow starting a battleground with just one player it's implemented like .debug arena - so you toggle debug bg on or off By balrok
--HG--
branch : trunk
2009-02-10 00:39:03 -06:00
megamage
d696381f32 [7250] Use bg type ids enum insted raw values and catch some bugs in result for fixing.
* Replace max bg type checks by DBC valid index check
    * Use in functions and fields BattlegroundTypeId type instead uint32
    * Fixed wrong use bg queue ids instead bg type ids in queue update/remove function calls.
      Many bg have same raw values for type id and queue id but some can be affected by this bug:
      BATTLEGROUND_EY, BATTLEGROUND_SA, and all areans (with small arena/team size exceptions)
    * Move Battlemaster to bg type ids map fron ObjectMgr to BatteleGroundMgr.
    * Remobe redundent for header itself includes for BG headers.
    * Use Auction location enum instead raw valus.
Author: VladimirMangos

--HG--
branch : trunk
2009-02-09 22:08:06 -06:00