Commit Graph

19880 Commits

Author SHA1 Message Date
ariel-
7de5befbc3 Core/Auras: fix more unused parameter warnings 2017-02-27 14:38:00 -03:00
ariel-
9047d8bd6f Core/Auras: fix comparison of integers of different signs warning 2017-02-27 14:34:23 -03:00
ariel-
40489b8d57 Core/Auras: fix unused parameter warning 2017-02-27 14:31:28 -03:00
ariel-
c69a7d1223 Core/Auras: reworked multiplicative AuraEffects calculation
- Splitted containers for flat modifiers and pct modifiers, as they now have different handling
- Amount is now multiplied only on apply; on unapply, iterate through auras and reset the counter
- Fixes many cases of rounding error due to applying/unapplying of small factors
- Allows amounts to be zeroed (ie with an AuraEffect of amount -100)
- Do a partial revert of 6dc37a9add, auras should update amounts only for items allowed (ie no more giving crit to a sword while having an axe in the other hand and being Poleaxe spec'd)
- SPELL_AURA_MOD_SCALE now scales additively, rather than multiplicatively (checked in sniffs)

Closes #18687
2017-02-27 14:24:20 -03:00
jackpoz
8f2bcd79da Core/Misc: Fix static analysis issues 2017-02-25 17:07:22 +01:00
jackpoz
6940071994 Core/Misc: Fix static analysis issues 2017-02-25 15:54:11 +01:00
jackpoz
b375bab225 Core/Misc: Fix static analysis issues 2017-02-25 13:33:51 +01:00
ariel-
ace2a75197 Core/Scripts: kill a warning 2017-02-25 05:17:33 -03:00
ariel-
01f5befcec Core/Scripts: Thrusting Hodir's Spear
- Everything is sniffed, enjoy this hell of a quest!

Closes #12808
2017-02-25 04:46:02 -03:00
Gustavo
4224259d83 Core/Unit: Correct speed calculus when affected by SPELL_AURA_MOD_MINIMUM_SPEED (#18136) 2017-02-24 12:20:20 +01:00
ariel-
9934a43e09 Core/Scripts: kill a warning 2017-02-23 11:33:40 -03:00
ariel-
32e2207ab9 Core/Scripts: Victory Rush and Rune Strike proc correction
(d0f760420a follow up)
Closes #19192
2017-02-23 11:30:25 -03:00
ariel-
6c9bda6093 Core/Conditions: CONDITION_SOURCE_TYPE_QUEST_ACCEPT should not prevent completed question mark from showing (#18151 follow up)
Closes #19188
2017-02-23 03:29:29 -03:00
ariel-
08fdac340c Core/Players: fix 2 Seal of Righteousness spells on paladins
Closes #14239
2017-02-23 02:51:31 -03:00
ariel-
d61e0f79c4 Core/Entities: Fix null-dereference crash
Closes #19191
2017-02-23 02:09:44 -03:00
ariel-
d0f760420a Core/Scripts: remove no longer needed scripts, use db attribute for disabling procs
(e7ccd8ea3f followup)

- Fix some broken procs after c0cb823a91

Closes #19068
2017-02-22 17:54:12 -03:00
ariel-
f948ae80fc Core/Spell: fix Glyph of Devastate interaction with Glyph of Sunder Armor
- Killed existing ModStackAmount hack, spell is always casted in sniffs (twice with Glyph of Devastate)

Closes #14633
2017-02-22 16:50:05 -03:00
Keader
bb3c964e7c Core/Scripts: Fixed Illidan epic sounds again (#19184) 2017-02-22 13:13:22 -03:00
ariel-
f609e7a08b Core/Spells: refactor spell_enchant_proc_data table
- Renamed fields to mimic those in spell_proc
- Added Enchant proc attributes for controlling specific enchant features

Ref #7789
2017-02-22 00:11:49 -03:00
ariel-
eac9c1f0b9 Core/Scripts: fix Nightfall proc chance and reduce it for victims with level above 60
Closes #15734
2017-02-21 22:38:30 -03:00
treeston
b3b4054eb4 Core/Creature: Fix SetSpawnHealth so it cooperates with the colossal hack that is Battleground::AddCreature. *puke* 2017-02-22 02:31:32 +01:00
ariel-
f4ae639961 Core/Spells: fix Hand of Justice proc chance and reduce it past level 60.
Ref #7789
2017-02-21 21:20:33 -03:00
ariel-
b4b031bcd4 Kill whitespace 2017-02-21 19:38:45 -03:00
ariel-
f96f1cebd4 Core/Packets: readd incorrectly removed line
Closes #19180
2017-02-21 17:14:11 -03:00
Gustavo
3a67c8e361 Core/Misc Remove Tabs and Whitespaces (#19179) 2017-02-21 18:37:34 +01:00
ariel-
2559874e8d Core/ItemTemplate: remove excedent #includes 2017-02-21 03:10:20 -03:00
ariel-
dd1aa64563 Core/Packet: convert query packets into new system.
- Extra c++11-ification of existing code
- Refs #18637
2017-02-21 03:03:58 -03:00
ariel-
c274ea8a98 Core/Misc: changed WorldPacket pointers to const
- Packet update sync with master
2017-02-20 16:43:16 -03:00
xinef1
ae9d01a324 Store cached static data queries, instead of building them in every query opcode (#18637)
- Added config option to enable / disable cache
- Reinitialize data on reload command use
- Always send WDB fields in item query
2017-02-20 16:27:08 -03:00
xinef1
4eae29d421 Properly stop attacking after player leaves ffa area (like Gurubashi Arena) (#18952) 2017-02-20 15:03:11 -03:00
ariel-
6d991e9361 Core/Misc: moved WeaponAttackType definition to SharedDefines to avoid including Unit.h 2017-02-20 14:22:49 -03:00
ariel-
0d3e1606a9 Core/Stats: cache all item attack power (includes given by equip spells)
- Used for Predatory Strikes calc, it will now properly use all weapon attack power
2017-02-20 14:14:48 -03:00
Keader
50973e9d6f Core/Scripts: Fixed epic sounds on Illidan Fight (#19172)
Thanks Kittnz for notice <3
2017-02-20 08:38:30 -03:00
Kittnz
495339a2c7 Script/GO: Alliance Bell, Horde Bell and Karazhan Bell will now send a bell sound on the start of each hour. (#19145)
* Script/GO: Alliance Bell, Horde Bell and Karazhan Bell will now send a bell sound on the start of each hour.

How many times it rings depence on the hour.

* fix little things from pr comments

* Added OnGameEvent

* Fix braces

* almost finished

* fix enum

* Add gameobjects to the game event

Fix override for InitializeAI

* enum squash

* remove braces

* Rename 9999_99_99_99_world.sql to 2017_02_19_01_world.sql
2017-02-19 20:47:40 +01:00
treeston
1beb2e5fd6 DB/Creature: The instance_encounters extra flag (CREATURE_FLAG_EXTRA_DUNGEON_BOSS) now properly propagates to all difficulty entries (not just difficulty 0).
This lets us simplify IsDungeonBoss() on Creature (and move it to header).

Closes #18824.
2017-02-19 19:26:44 +01:00
r00ty-tc
6bd9aa2787 [Core/AH] Correctly check player can pay deposit
- Deposit amount wasn't correctly checked in the case of multiple items,
   player with insufficient funds could auctin more items than they should
2017-02-19 15:18:09 +01:00
xinef1
9142c778dd Corrected points per level calculation for some spells (#19105) 2017-02-19 02:30:04 -03:00
xinef1
e261754c9c Fixed setting and unsetting of m_spellModTakingSpell (#19116)
- A problem when a different spell tries to overwrite existing ModTakingSpell should no longer happen
2017-02-19 02:10:50 -03:00
jackpoz
76f3e0edea Core/WorldSocket: Handle unhandled exceptions
Properly handle unhandled exceptions happening with malformed packets.
Fix #19128
2017-02-18 11:36:02 +01:00
xinef1
b0ae5fadd1 Core/SmartAI: Various fixes and extensions for smart scripts: (#18673)
- Possible crashes fixed
- Memory leak fixed
- Implemented checking of vehicle conditions
- Extended eventphasemask to 12 bits (sql required to change DB field type)
- SMART_EVENT_GOSSIP_HELLO - added possibility to detect for gameobject reportUse call
- Renamed action SMART_ACTION_SET_FLY to SMART_ACTION_SET_DISABLE_GRAVITY (to reflect actual functionality)
- Added targetsLimit to action SMART_ACTION_CAST and SMART_ACTION_INVOKER_CAST to limit max amount of targets (selected randomly)
- Action SMART_ACTION_TALK corrected to always work as intended
- Properly call GroupEventHappens in action SMART_ACTION_CALL_GROUPEVENTHAPPENS if invoker was charmed or owned by the player
- Properly utilize followAngle in action SMART_ACTION_FOLLOW (db orientation should be in degrees), but keep backward compatibility
- Added action SMART_ACTION_SET_CAN_FLY (119) 0/1
- Added action SMART_ACTION_REMOVE_AURAS_BY_TYPE (120) AuraType, can be used to exit vehicle for example
- Added action SMART_ACTION_SET_SIGHT_DIST (121) sightDist
- Added action SMART_ACTION_FLEE (122) fleeTime
- Added action SMART_ACTION_ADD_THREAT (123) +threat, -threat
- Added action SMART_ACTION_LOAD_EQUIPMENT (124) equipmentId
- Added action SMART_ACTION_TRIGGER_RANDOM_TIMED_EVENT (125) minId, maxId
- Added action SMART_ACTION_REMOVE_ALL_GAMEOBJECTS (126), removes all owned gameobjects
- Added action SMART_ACTION_STOP_MOTION (127), stopMoving, movementExpired
- Extended target SMART_TARGET_HOSTILE_SECOND_AGGRO with following parameters maxdist, playerOnly, powerType + 1
- Extended target SMART_TARGET_HOSTILE_LAST_AGGRO with following parameters maxdist, playerOnly, powerType + 1
- Extended target SMART_TARGET_HOSTILE_RANDOM with following parameters maxdist, playerOnly, powerType + 1
- Extended target SMART_TARGET_HOSTILE_RANDOM_NOT_TOP with following parameters maxdist, playerOnly, powerType + 1
- Extended target SMART_TARGET_THREAT_LIST with maxdist
- Extended target SMART_TARGET_OWNER_OR_SUMMONER to be able to get charmer/owner of current owner
- Added new target SMART_TARGET_FARTHEST with maxDist, playerOnly, isInLos restrictions
- Added SpellHit hook to GameObjectAI and extended SmartGameObjectAI to call SMART_EVENT_SPELLHIT when gameobject is hit by spell
- Call GameObjectAI Reset hook on gameobject respawn (for ex. to reset one time events in smart scripts)
- Fixed some logic errors in code
- SmartAI Escorts properly despawn escortee if no players are in range
- Disable Evading while charming creature with SmartAI
- Don't call SMART_EVENT_RESPAWN for dead units before they actually respawn
- Don't call SMART_EVENT_RESPAWN for not spawned gameobjects
- Properly call SMART_EVENT_RESPAWN for gameobject respawn
- Allow action SMART_ACTION_SET_IN_COMBAT_WITH_ZONE to utilize targetlist
- Allow action SMART_ACTION_CALL_FOR_HELP to utilize targetList
- Allow action SMART_ACTION_SET_INVINCIBILITY_HP_LEVEL to utilize targetList
- Allow action SMART_ACTION_SET_VISIBILITY to utilize targetList
- Allow action SMART_ACTION_SET_ACTIVE to utilize targetList
- Allow action SMART_ACTION_ATTACK_START to select random attack target instead of first on the list
- Allow gameobjects to summon gameobjects with action SMART_ACTION_SUMMON_GO
- Properly store action invokers for action SMART_ACTION_WP_START, if no player invokers are found, distance despawn check won't be used
- Allow action SMART_ACTION_WP_RESUME to compensate for the state the unit actually is in (eg. combat)
- Allow action SMART_ACTION_MOVE_TO_POS to select random of the avaiable targets, not only the first one.
- Allow action SMART_ACTION_MOVE_TO_POS to utilize x, y, z parameters as an offset to calculated coordinates
- Action SMART_ACTION_RESPAWN_TARGET should never modify respawntime of already spawned gameobjects, use dedicated function
- Properly delete ontime events created by SMART_ACTION_CREATE_TIMED_EVENT
- If action could not be started because conditions were not satisfied, do not recalculate the waittime to action repeattime, use smaller value to recheck more frequently
- Allow target SMART_TARGET_CLOSEST_PLAYER to be used by gameobjects
- Allow target SMART_TARGET_OWNER_OR_SUMMONER to be used by gameobjects
- Fixed SMART_EVENT_COUNTER_SET to be only called for the id that was incremented
- Changed the way counters work
- Protect PhaseInc from surpassing maximum phase
- Added loading checks for missing NON_REPEATABLE flag if no repeatmin, repeatmax is set
- Added spell validation for SMART_ACTION_CROSS_CAST
2017-02-17 21:33:18 +01:00
Kittnz
9d74252e8d Reverting: Game/Scripting: Add OnGameEvent hook for game objects. 2017-02-17 20:30:52 +01:00
Kittnz
a5ccbe9906 Fix tabs 2017-02-17 20:19:05 +01:00
Kittnz
343d2c7f91 Game/Scripting: Add OnGameEvent hook for game objects.
Called when specific game event starts
2017-02-17 20:16:22 +01:00
Aokromes
da3e38d5ff Update MapScripts.cpp 2017-02-17 10:10:55 +01:00
Aokromes
c63f3788d9 Update ObjectMgr.h 2017-02-15 10:09:44 +01:00
Aokromes
e50e3b36a7 Update ObjectMgr.h 2017-02-15 07:14:57 +01:00
xinef1
949b38b048 Core/Creatures: Remove template immunities only for hunter pets (#19100) 2017-02-14 20:34:19 +01:00
xinef1
e7a9549422 Core/Spells: Fixed some item ranged spells dealing wrong damage (#19104) 2017-02-13 21:52:51 +01:00
xinef1
b3f04ec157 Added some missing SetFallInformation calls (#19121)
Fixed HP drop bug on zeppelins
Fixed possible packet relocation problems on huge transports
2017-02-13 21:05:32 +01:00
xinef1
2412886ef6 Core/Misc: Fixed player corpse looting, added player corpse loot and some more (#19122)
* Fixed corpse looting in wintergrasp
Added corpse loot for wintergrasp quests and To the Looter Go the Spoils (1166) achievement
Don't generate money for loot if no loot mode is available
Simplified few things
2017-02-13 20:42:06 +01:00