Commit Graph

19310 Commits

Author SHA1 Message Date
Snapper
114f4c9715 Core/Quest: send SMSG_QUESTGIVER_STATUS_MULTIPLE after a quest is rewarded.
This updates the status of nearby questgivers and prevents them from being stuck in a state that's no longer valid (for example, stuck with yellow question mark until area update).
2016-06-07 10:22:23 +02:00
jackpoz
7ff0f3c65f Core/Player: Fix duel edge case crash
Fix a crash that could be triggered if an aura removed after duel finished would have caused damage to one of the players.
2016-06-05 21:53:38 +02:00
treeston
2f0f30b9f7 Revert "PvP/Dueling: Fix an edge case crash that could happen if a duel ended while an aura effect was being removed (Living Bomb, Unstable Affliction and similar). Closes #17177."
This reverts commit 73cfbdcf9f.
2016-06-05 19:18:52 +02:00
treeston
73cfbdcf9f PvP/Dueling: Fix an edge case crash that could happen if a duel ended while an aura effect was being removed (Living Bomb, Unstable Affliction and similar). Closes #17177. 2016-06-05 18:37:48 +02:00
tkrokli
b6d43623a2 Core/Scripts: boss_majordomo hardcoded text
2 more text lines removed in the ongoing series:
"Remove hardcoded text from core scripts".

Core script for boss Majordomo Executus:
- add missing gossip_menu_option entries
- link the options via the table gossip_menu
- remove hardcoded text from the script
- minor enum line order sorting cleanup
- replace OnGossipSelect() with sGossipSelect()

The scripted events are unchanged.
If the script is inaccurate, make a new PR.
2016-06-05 18:29:57 +02:00
treeston
650d7ab596 Scripts/BlackrockMountain: Nefarian. (#16346 f-u) 2016-06-04 22:21:49 +02:00
treeston
83e5df5638 Scripts/MoltenCore: Fix Ragnaros (#16346 follow-up). 2016-06-04 22:17:06 +02:00
treeston
27a3eaab33 Scripts/Instances: More #16346 follow-ups. Fixed this time: Halls of Reflection, Ignis the Furnace Master, Mimiron and Rend Blackhand. 2016-06-04 22:14:32 +02:00
Snapper
aaf10dccb0 Core/SmartAI: delay SMART_ACTION_FLEE_FOR_ASSIST if creature is rooted/stunned.
Prevents creatures from teleporting around when fleeing while stunned/rooted.
2016-06-04 21:17:15 +02:00
Snapper
30313fba8d Core/Player: Added support cast spell for some class spells
(Warrior's Battle Stance and Death Knight's Blood Presence) on first login.

(cherry-picked from commit c8eb69df10)

Closes #17232
2016-06-04 19:31:29 +01:00
jackpoz
1347d7cf7a Core/VMaps: Fix some vmap height edge cases
Fix Map::GetWaterOrGroundLevel() checking dynamic object only in phase 1 instead of current Unit phase.
Improve DynamicMapTree::getHeight() dynamic object check by casting the ray at +0.5f from the passed Z coordinate, this value will be tuned to improve even more the results.
2016-06-04 15:01:39 +02:00
Aokromes
069e1c8120 Update worldserver.conf.dist 2016-06-04 12:49:39 +02:00
Duarte Duarte
3ae1016082 Implement real time statistic visualization (#16956)
Docs at https://trinitycore.atlassian.net/wiki/display/tc/Monitoring+a+TrinityCore+server

* Common/Graphs: Initial proof of concept

* Move influx db code to its own class

* Reuse the same socket

* Allow to log values of different categories

* Allow to log events

* Pass the timestamp to influxdb

* Send events in batches

* Send data async

* Log server shutdown.
Fix memory leak.

* Allow to enable/disable Stats in the settings and at runtime

* Read interval between each batch send from config

* Add InfluxDB connection info to configs

* Move each event category to its own table

* Log pathfinding queries

* Move categories table initialization to constructor using enum as key to avoid assigning the table name to the wrong enum value

* Log player login/logout events.
Pass the hostname correctly in the HTTP request.

* Fix linux build

* Handle "Connection: close" HTTP header, reconnecting on next scheduled send.
Disable StatsLogger if connection fails, logging the error.

* Add an enum for categories of logged values, it's still possible to pass a string instead of the enum.

* Don't log the whole batchedData when InfluxDB returns an error, it's too long and unreadable on console.

* Allow to call a function at a specified interval in thread-safe World::Update() context to log data like player count.

* Log map tile load/unload

* Core/StatsLogger: Allow logging more value types other than ints

https://docs.influxdata.com/influxdb/v0.10/write_protocols/write_syntax/

* Fix a typo in string escape of StatsLogger

* Yet more fixes to the escaping in FormatInfluxDBValue

* DB/Gameobject: Fix respawn time of few Quest GameObjects

By Tauriella, closes #16701

* DB/Misc: Fix some engrish

By tkrokli closes #16648

* Tools/MMaps: Add format library linking to mmaps_generator

(Very) partial cherry pick of ed75b0649a

* Core/StatsLogger: Simplify code

Convert values and categories arrays to maps initialized in-place
Remove constructor and destructor

* Core/StatsLogger: Add realm name to the event and value tags

* Log amount of processed packet of each session

* Apply recent singleton changes to sStatsLogger too

* Fix influxdb data format if no realm name is present

* Remove unneeded newlines from request body, fixes response 400 from InfluxDB 0.10

* Rename Reporting folder to Metric

* Rename StatsLogger to Metric

* Rename InfluxDB configs to Metric

* Add Grafana dashboards

* Add a random annoying macro

* Move string formatting to Metric::SendBatch(), reducing performance footprint of Metric::LogEvent() and Metric::LogValue()

* Update grafana graphs refresing tags on load and showing now-15m data, refreshing every minute. These settings can be modified in grafana.

* Rename MetricData fields

* Contrib/Grafana: Rename dashboard files

* Contrib/Grafana: Replace hardcoded Windows/Ubuntu realm names by the default, Trinity

* Config/Worldserver: Add missing section to the index

* Contrib/Grafana: Add singlestat panels with current online players, update diff averages (1 min, 5 mins and 15 mins)

http://i.imgur.com/Zi8lfvS.png

* Core/Metric: Replace the enums MetricEventCategory and MetricValueCategory by strings

For the sake of simplicity and less recompile time when adding new metrics, similar to how TC_LOG_* works

* Contrib/Grafana: Display the current number of online players and not its average

Closes #15075
2016-06-04 11:23:29 +01:00
treeston
123e45c119 AI/SmartScripts: Add action_param3 "disablePathfinding" to SMART_ACTION_MOVE_TO_POS (69). 2016-06-04 00:51:19 +02:00
treeston
7fbd70d4c4 Compiler warning fix. 2016-06-03 22:41:30 +02:00
treeston
4407877f36 Scripts/TotC: More follow-up to #16346. Also code style cleanup. Who names all their creature pointers "temp"? 2016-06-03 22:39:04 +02:00
treeston
4e922a5146 Scripts/Instances: Follow-up to #16346. Fix Illidan and Northrend Beasts. 2016-06-03 22:14:09 +02:00
treeston
2d2544fab0 AI/PlayerAI: Fix potential edge case crash. 2016-06-03 17:57:05 +02:00
tkrokli
25881de7d3 Core/Scripts: move npc_mountaineer_pebblebitty to DB
- move gossip text to DB and add quest condition
- remove core script npc_mountaineer_pebblebitty,
- thereby removing the file zone_loch_modan.cpp
- because the original core script dialog is incorrect

This version of the dialog can be verified from the following web pages:
- http://wow.gamepedia.com/Key_to_Searing_Gorge_quest_chain
- http://www.wowhead.com/npc=3836/mountaineer-pebblebitty#comments:id=332234
2016-06-03 17:44:38 +02:00
tkrokli
582af02509 Core/Scripts: remove hardcoded text from npc_sayge
- remove hardcoded (and wrong) text from the script
- copy valid text from broadcast_text to gossip_menu_option
- gossip_menu / npc_text is already correct in TDB 335.61
- sort + clean up core script enum list and add new entries
- keep gossip handling unchanged in the script (low prio)
2016-06-03 17:43:45 +02:00
tkrokli
e6ee6e2ae8 Core/Scripts: remove hardcoded text from npc_locksmith
- remove hardcoded text from script
- move the gossip handling to DB SQL
- move the script conditions to DB SQL
- use correct gossip from broadcast_text
- remove options not existing in broadcast_text
- add Key to Searing Gorge option (related spell)
- add The Eye of Haramad option (related spell)
2016-06-03 17:42:55 +02:00
tkrokli
3acf6f36d1 Core/Scripts/DB: move npc_gregan_brewspewer to DB
- Remove npc_gregan_brewspewer, thereby removing hardcoded text
`#define GOSSIP_HELLO "Buy somethin', will ya?"`
- Move all gossip handling to DB (gossip texts already exist in TDB)
2016-06-03 17:38:58 +02:00
joschiwald
19aac66bc2 Core/Movement: enable item use and spell cast when dismounting
Remove error message and allow spell cast or item use from
mounted state on ground, especially when sitting on
a landed flying mount. Current behavior is that the player
will get the error message "You can't do that while moving"
when trying to cast a spell or pick up an item
while sitting on a flying mount after having landed.

By joschiwald, closes #6236
2016-06-03 17:38:01 +02:00
Sean Rhone
b253b694ed Update worldserver.conf.dist (#17276)
- Same as https://github.com/TrinityCore/TrinityCore/pull/17270
2016-06-03 15:40:30 +02:00
Trisjdc
34ef05ce0b Core/Creatures: Remove resetting of UNIT_FLAG_IMMUNE_TO_PC on combat clearing 2016-06-02 23:07:27 +01:00
Keader
43855b47d8 Core/Scripts Improve Felflame Infernal of Lord Jaraxxus fight (#16998) 2016-06-02 22:30:18 +02:00
Kittnz
8a386fb389 Merge pull request #17020 from Keader/jormungars
Core/Scripts: [Trial of the Crusader] Improve  Jormungars fight
2016-06-02 19:35:47 +02:00
jackpoz
6007f2a6a0 Merge pull request #17259 from SnapperRy/smart_ai
Core/SmartAI: Allow SMART_ACTION_FORCE_DESPAWN on no-SmartAI GameObjects
2016-06-02 00:31:32 +02:00
treeston
7eda9fb617 Scripts/Naxxramas: Fix Frogger event. Closes #16488. 2016-06-02 00:12:13 +02:00
Trond B Krokli
8fe8501712 Core/DB/Updater: engrish corrections in DBUpdater.cpp (#17262)
English grammar and syntax corrections in DBUpdater.cpp
- string texts corrected, source code unchanged
- comments improved and checked for typos
2016-06-01 21:10:20 +01:00
treeston
321d35417d Build fix for horrendous, outdated, non-standards-compliant compilers. Such as the one in VS 2013. I hate VS 2013.
Closes #17260.
2016-06-01 19:41:35 +02:00
Snapper
9803e58392 Core/SmartAI: remove unneeded check for SMART_ACTION_FORCE_DESPAWN.
Gameobjects do not need to use SmartAI in order to be targeted by other entities' scripts.
2016-06-01 13:41:58 +02:00
treeston
e3aa19281f AI/PlayerAI: Code style cleanup. 2016-05-31 22:18:26 +02:00
treeston & Keader
25c5570f47 AI/PlayerAI: Finally implement cast logic for controlled players. 2016-05-31 15:05:35 +02:00
Kittnz
80ca48e39c Merge pull request #17233 from SnapperRy/heirlooms
[3.3.5] Core/Player: apply heirloom stat mods before maxing health/power at level up
2016-05-31 10:55:45 +02:00
DDuarte
ca231cba0b Core/World: Remove unused config CONFIG_SIGHT_GUARDER 2016-05-30 23:45:48 +01:00
Snapper
eff6bcb697 Core/Player: apply heirloom stat modifiers before maxing out health/power at level up.
This allows characters with heirlooms to have their health/mana maxed out at level up, instead of having some missing due to the increased stat modifiers from heirlooms.
2016-05-30 22:55:38 +02:00
Snapper
07a8a35a46 Core/Spells: fix client crash caused by pressing ESC after using spells Neural Needle and Flaming Arrow. 2016-05-30 12:21:36 +02:00
DDuarte
5aae01986f Revert "Merge pull request #16433 from Tonghost/3.3.5"
This reverts commit e3d52990dd, reversing
changes made to 6d8e39f59c.

Opens #16759
2016-05-29 18:51:58 +01:00
Keader
7205b4dd65 Override and tkrokli again :D 2016-05-28 18:54:31 -03:00
SnapperRy
9480a210f2 Core/Quests: Remove wrong call to SendQuestComplete(). (#17200) 2016-05-28 15:28:48 +02:00
Kittnz
cac726ced8 Merge pull request #17198 from sirikfoll/Bombs
Core/Achievement A-bomb-inable and A-bomb-ination
by sirikfoll
2016-05-28 10:44:37 +02:00
Kittnz
adf68a993e Merge pull request #17186 from sirikfoll/combat
Core/Unit Do not allow addition of threat to units in evade mode
by sirikfoll
2016-05-28 09:54:53 +02:00
sirikfoll
e016bf8d06 Core/Achievement A-bomb-inable and A-bomb-ination 2016-05-27 22:48:20 -03:00
Shauren
258368a2bd Core/Scripts: build fix 2016-05-27 17:20:58 +02:00
Mikhail Redko
dd39cb8714 Core/Guilds: Fix Guild::HandleSetMemberNote logic according to method declaration. (#17078)
This change has no effect on server behavior.
2016-05-27 15:51:02 +01:00
Shauren
b36da77185 Core/Units: Renamed and documented UNIT_FLAG_DISABLE_MOVE to prevent people from trying to use this flag to root a creature leaving them wondering why it doesn't do anything 2016-05-27 14:45:06 +02:00
ForesterDev
c73c51d7b1 Merge branch '3.3.5' into creature_family 2016-05-27 12:51:28 +04:00
Trond B Krokli
dc67505a08 [3.3.5] Core/Spell: restore old pet values after dismount (#16551)
* Core/Spell: restore old pet values after dismount & re-summon
Original PR #15667 by ghost

Closes #873
2016-05-26 21:23:59 +02:00
Shauren
4a074ca470 Core/Loot: Fixed resaving looted items from containers
Closes #15299
2016-05-26 16:15:27 +02:00