Commit Graph

19310 Commits

Author SHA1 Message Date
Trisjdc
bb01c60a52 Core/Players: Improve quest item adding/removal checks, solves cases where quest item removal (under specific conditions) incorrectly incompletes quests 2014-06-06 10:41:45 +01:00
jackpoz
d565c2b303 Core/Talents: Align server checks to Client limits
Set the max amount of talents to process in CMSG_LEARN_PREVIEW_TALENTS_PET to 30 ( 24 talents rounded up ).
2014-06-05 22:50:11 +02:00
jackpoz
7d623eed18 Core/Talents: Align server checks to Client limits
Set the max amount of talents to process in CMSG_LEARN_PREVIEW_TALENTS to 150 ( 44 talents for 3 trees rounded up ).
2014-06-05 22:19:02 +02:00
Sebastian Valle Herrera
36102bea64 Merge pull request #12039 from Trisjdc/creature_ai_talk
Core/CreatureAI: Implement CreatureAI::TalkToMap for all your map-wide talking needs
2014-06-05 10:50:23 -05:00
Sebastian Valle Herrera
42d4144f90 Merge pull request #12045 from Trisjdc/session_expire
Core/WorldSession: After sudden disconnects, session should persist for a minute
2014-06-05 10:49:28 -05:00
Sebastian Valle Herrera
d098a3ce8d Merge pull request #12219 from Trisjdc/spell_swift_retribution
Core/Spells: Swift Retribution should be reapplied when needed to be able to gain spellmods
2014-06-05 10:13:08 -05:00
Shauren
22b04d39bf Merge pull request #12220 from Trisjdc/spelll_triggerflag_check
Core/Spells: *Properly* solve the Disarm vs Bladestorm issue
2014-06-05 14:07:48 +02:00
Trisjdc
afb7c705c2 Core/Spells: *Properly* solve the Disarm vs Bladestorm issue 2014-06-05 11:48:43 +01:00
Trisjdc
2282a4c359 Core/Spells: Swift Retribution should be reapplied when needed to be able to gain spellmods 2014-06-05 11:43:59 +01:00
Trisjdc
d4bdfebd9e Scripts/ToCr: Bosses shouldn't despawn so quickly 2014-06-05 11:37:24 +01:00
Trisjdc
d05bf542a5 Core/Spells: Corpse Explosion should not be able to pick the Ghoul out of implicit targets 2014-06-05 11:35:32 +01:00
blub
700baded7a Merge pull request #12215 from Trisjdc/warning_fix
Warning fix
2014-06-04 20:14:29 +02:00
Trisjdc
2a6d3fa67c Warning fix 2014-06-04 19:12:02 +01:00
jackpoz
bd45a0bba9 Core/Tickets: Don't try to save the same sub-survey more than once 2014-06-04 19:56:13 +02:00
Shauren
84d0094ffa Core/Tickets: Sprinkled some transaction magic on HandleGMSurveySubmit 2014-06-03 23:24:00 +02:00
Trisjdc
d12737d9bb Core/WorldSession: After sudden disconnects, session should persist for a minute
- With this change, if a player alt-f4, he'll only fade from world after a minute
2014-06-03 01:12:34 +01:00
Trisjdc
18868f5cbd Core/Maps: Allow logging players to enter in instances that have an encounter in progress 2014-06-03 00:57:36 +01:00
Trisjdc
d99f0362cb Core/Auras: Update model overwriting rules for SPELL_AURA_TRANSFORM 2014-06-03 00:39:20 +01:00
Sebastian Valle Herrera
409a19e623 Merge pull request #12201 from Unholychick/patch-2
Core/Spells: Implement SPELL_ATTR4_FIXED_DAMAGE
2014-06-02 18:23:17 -05:00
Sebastian Valle Herrera
d41779f8fa Merge pull request #12135 from Trisjdc/event_map_extension
Core/Util: A couple useful new functions for EventMap
2014-06-02 18:10:08 -05:00
Trisjdc
8db02c52ac Core/Util: A couple useful new functions for EventMap, as well as getting rid of some old junk 2014-06-02 23:59:35 +01:00
Sebastian Valle Herrera
d097a5ec97 Merge pull request #12182 from Xter/rbac
Core/RBAC: fix RBAC_PERM_COMMANDS_BE_ASSIGNED_TICKET and RBAC_PERM_LOG_G...
2014-06-02 17:47:40 -05:00
Sebastian Valle Herrera
f5e6292b48 Merge pull request #12032 from Trisjdc/haste_formula
Core/Players: Fix haste rating formulas
2014-06-02 17:23:16 -05:00
leak
0fa3a4923e Replaced LockedQueue ACE lock with std::mutex 2014-06-02 23:01:01 +02:00
jackpoz
0c1ddc970d Core/Misc: Kick player in case of multiple CMSG_PLAYER_LOGIN
Kick player in addition to logging an error in case of multiple CMSG_PLAYER_LOGIN.
2014-06-02 17:03:31 +02:00
Lucas
82cefb661d Core/Spells: Implement SPELL_ATTR4_FIXED_DAMAGE
Spells with this attribute will ignore damage taken auras except for mechanic damage taken (trauma, etc) and will ignore resilience because the damage caused by those spells is based off another spell' damage
2014-06-02 15:41:02 +02:00
leak
68e22ad311 Replaced ACE based typedefs for fixed width ints with C++11 versions 2014-06-01 20:55:31 +02:00
Gacko
26370223a0 Script/Shadowmoon Valley: Remove hack in npc_shadowmoon_tuber_node.
This script will be converted to SAI (if possible) later.
2014-06-01 19:39:57 +02:00
Gacko
8ef34535a4 Scripts: Remove unused variables (kept as comment) 2014-06-01 19:34:34 +02:00
Shauren
9fcd607e78 Core/Misc: Added utility method for checking is two sorted containers have a common element 2014-06-01 19:20:49 +02:00
jackpoz
282a7cad7d Core/Misc: Code cleanup
Remove old unused opcode handler WorldSession::HandlePageQuerySkippedOpcode() for CMSG_PAGE_TEXT_QUERY since it's already handled by WorldSession::HandlePageTextQueryOpcode()
2014-06-01 16:15:27 +02:00
jackpoz
70bd70080d Core/QuestPOI: Mitigate possible DoS with CMSG_QUEST_POI_QUERY
Avoid sending POIs for same quest if the client somehow sent duplicates quest id in same CMSG_QUEST_POI_QUERY packet. This also reduce the effects of possible DoS and increases the difficulty to cause it.
Fix a typo which caused no quest POIs to be sent at all if the client queried data for 25 quests.
2014-06-01 13:33:46 +02:00
jackpoz
6a54ed88c6 Core/NetworkIO: Fix performance loss when handling bad packets
Revert f9cb4280bd which retrieved the callstack each time a ByteBufferPositionException or a ByteBufferSourceException occurred, for example with bad packet structure.
2014-06-01 00:29:33 +02:00
leak
35aa142f6a Replaced ACE_INET_Addr with boost::asio::ip::address 2014-05-31 18:31:53 +02:00
leak
bf6e58b8d4 Ditched ACE_Singleton in favor of C++11 like Singleton 2014-05-31 15:58:59 +02:00
xter
19c56cbc0e Core/RBAC: fix RBAC_PERM_COMMANDS_BE_ASSIGNED_TICKET and RBAC_PERM_LOG_GM_TRADE permissions 2014-05-31 14:04:37 +02:00
leak
f05d540658 Restore PCH builds and make GCC happy 2014-05-31 01:02:03 +02:00
Warpten
7b49038454 Merge pull request #12171 from Ankso/player_update_zone
Core/Players: Update the player's zone and area only after the player's position is updated server-side.
2014-05-30 19:53:47 +02:00
Ankso
ab62fe30bc Core/Players: Update the player's zone and area after update the player's
position server side.
2014-05-30 17:18:52 +02:00
leak
b520f7da01 Damn you VS default settings.. 2014-05-30 15:46:17 +02:00
leak
5a363ee0e1 Replace authserver ACE related code with Boost/C++11 2014-05-30 14:54:56 +02:00
jackpoz
8d539ee6c0 Merge pull request #12162 from Trisjdc/aura_split_damage_breaking
Core/Spells: Break 'Fear' and similar auras on damage sharing of SPELL_AURA_SPLIT_DAMAGE_PCT
2014-05-29 21:21:39 +02:00
jackpoz
65917f52ea CoreCore/NetworkIO: Fix disconnect when canceling character creation
Remove the filter on CMSG_CHAR_ENUM added in 59b4c34924 since the same opcode is already throttled in the new improved system. DoS attacks using this opcode are still mitigated with same effect of before.
Fixes #10915
2014-05-29 21:11:41 +02:00
jackpoz
b92e1046be Merge pull request #12007 from Trisjdc/spell_pushback
Core/Spells: Define and implement SPELL_ATTR7_NO_PUSHBACK_ON_DAMAGE
2014-05-29 19:54:39 +02:00
jackpoz
fabceddacb Merge pull request #12160 from Trisjdc/petai
Core/PetAI: Pin should not be interrupted if the victim has a breakable aura
2014-05-29 19:45:48 +02:00
jackpoz
1b47f3270e Core/NetworkIO: Adjust more packet throttling values
Adjust more packet throttling values and add Player name to log to help investigate false positives.
2014-05-29 19:43:09 +02:00
Trisjdc
1301ad800b Core/Spells: Break 'Fear' and similar auras on damage sharing of SPELL_AURA_SPLIT_DAMAGE_PCT 2014-05-28 22:22:54 +01:00
Trisjdc
9f50dd3bd6 Core/PetAI: Pin should not be interrupted if the victim has a breakable aura 2014-05-28 21:52:01 +01:00
jackpoz
f312b86941 Core/NetworkIO: Adjust more packet throttling values 2014-05-27 21:19:19 +02:00
joschiwald
acc9f1575a Merge pull request #12146 from Trisjdc/spell_hymn
Core/Spells: Missing target conditions for Divine Hymn/Hymn of Hope's second effect
2014-05-27 02:32:49 +02:00