Commit Graph

38239 Commits

Author SHA1 Message Date
offl
896d12743a DB/SAI: Remove SMARTCAST_INTERRUPT_PREVIOUS from nearly all scripts
No longer needed after ca25e8d019

Explained in https://github.com/TrinityCore/TrinityCore/issues/24914

Some event types not affected because requires tests, events with No Repeat event flag skipped

(cherry picked from commit aae38bec11)
2022-02-02 20:22:18 +01:00
offl
4fa7d723ad DB/Creature: Add missing cosmetic channeled spell in Ahn'kahet
Closes #12024

(cherry picked from commit e8e3626073)
2022-02-02 20:20:58 +01:00
Cerveciento
d41ecc65f5 DB/Locale esES+esMX Texts missing in quets (Part 20)
Closes #25250

(cherry picked from commit 6bd104e0aa)
2022-02-02 20:20:26 +01:00
Shauren
c65340e761 Core/Spells: Implement SPELL_EFFECT_TRIGGER_SPELL delay (stored in MiscValue) 2022-02-02 19:50:22 +01:00
Shauren
b6bc8a50ac Core/Spells: Correct implementation of SPELL_ATTR2_TRIGGERED_CAN_TRIGGER_PROC, SPELL_ATTR3_TRIGGERED_CAN_TRIGGER_PROC_2, SPELL_ATTR3_CAN_PROC_WITH_TRIGGERED and rename them (SPELL_ATTR2_ACTIVE_THREAT, SPELL_ATTR3_NOT_A_PROC, SPELL_ATTR3_CAN_PROC_FROM_PROCS) 2022-02-02 13:56:49 +01:00
Shauren
7261592364 Warning fixes 2022-02-02 11:55:04 +01:00
Shauren
950db60435 Core/Pets: Updated pet summoning for latest client version (5 Call Pet spells and stable size 200) 2022-02-02 00:08:37 +01:00
Shauren
d6a2461fc7 Core/Misc: GCC build fix
Closes #27707
2022-02-01 23:44:14 +01:00
Shauren
fd9eb28322 Core/Pets: Adjust pet slot saving logic after constant changes in 22e823b5f9 2022-01-31 23:30:00 +01:00
Shauren
22e823b5f9 Core/Pets: Change PET_SAVE_NOT_IN_SLOT constant from 100 to -1 to truly avoid conflicts when growing stable size and change PET_SAVE_AS_DELETED from -1 to -2 2022-01-31 21:50:32 +01:00
Shauren
8349444749 Core/Pets: Save last summoned pet number in characters table 2022-01-31 21:34:48 +01:00
Shauren
0ef41fcda2 Core/Pets: Removed deprecated enum 2022-01-31 19:53:11 +01:00
Shauren
e458144442 Core/Pets: Removed storing stable slot count in db 2022-01-31 14:34:05 +01:00
Shauren
c654c15bcd Core/PacketIO: Removed handlers for two pet opcodes that no longer exist 2022-01-31 14:31:13 +01:00
Shauren
3642e3a765 Core/Pets: Fixed saving pets put in stable while not being summoned
Closes #26599

(cherry picked from commit 4acd6e1d38)
2022-01-31 00:27:29 +01:00
jackpoz
238d5b1587 Core/Pet: Fix assert triggered by e203ecda88
(cherry picked from commit 22a5b0fcde)
2022-01-31 00:27:02 +01:00
Giacomo Pozzoni
40d882b754 Core/Pet: Attempt to fix assertions triggered when summoning pets (#26501)
* Core/Pet: Attempt to fix an assertion triggered when re-summoning the current pet

* Core/Pet: Attempt to fix an assertion triggered when stabling a pet while in a vehicle

* Core/Pet: Attempt to fix an assertion triggered when stabling a pet and casting spell 6962

* Core/Pet: Attempt to fix an assertion triggered when casting spell 6962 while being dead

* Core/Pet: Attempt to fix an assertion triggered when summoning a pet while on vehicle 34775

* Handle cases in a generic way

* Code cleanup

* Core/Pet: Attempt to fix an assertion triggered when summoning a pet while on vehicle 34775 with a new character

(cherry picked from commit e203ecda88)
2022-01-31 00:26:54 +01:00
Shauren
33e747bc8f Core/Pets: Add missing nullptr check
(cherry picked from commit 0152878de5)
2022-01-31 00:25:17 +01:00
Shauren
688d1d9533 Core/Pets: Fixed crash happening when current pet is forcibly removed while being temporarily unsummoned (like on a mount)
(cherry picked from commit d163735abd)
2022-01-31 00:24:51 +01:00
Shauren
e102022eeb Core/Pets: Fixed crash happening when summoning a different pet than one that was unsummoned by summoning a guardian (imp -> infernal -> felhunter)
Closes #25478

(cherry picked from commit d29274f3a1)
2022-01-31 00:23:57 +01:00
Shauren
9147918363 Core/Pets: Fixed automatic resurrecting pets on battleground graveyards
Closes #25289

(cherry picked from commit 74a0d579ee)
2022-01-31 00:20:53 +01:00
Shauren
4de94169e9 Core/Pets: Fix loading pet data
Closes #25269

(cherry picked from commit a9a4f05a28)
2022-01-31 00:20:40 +01:00
Shauren
87b1c3700e Core/Spells: Fix summoning warlock pets in case that pet has never been summoned before
(cherry picked from commit bbcf00257e)
2022-01-31 00:20:30 +01:00
Shauren
48d491ae2f Core/Spells: Fix summoning SUMMON_PET type pets
Closes #25265

(cherry picked from commit 9c5876d8ab)
2022-01-31 00:18:48 +01:00
Shauren
ca92686b44 Core/Pets: Pet management refactoring (#25191)
* Core/Pets: Pet management refactoring

* Preload basic pet data on character login with async query
* Load additional pet data (declined names/auras/spells/cooldowns) using async query after we are sure pet loading will succeed
* Remove all select queries related to pet stable/unstable
* Remove all silent pet deletions except explicit UI-triggered abandons
* Fixed displaying stable master content when current pet is not summoned
* Allow to stable/swap unsummoned current pet

Closes #3610
Closes #21266

(cherry picked from commit 5c1fc5e387)
2022-01-31 00:17:21 +01:00
Shauren
b79a91039b Core/DBUpdater: Apply each sql update file in a separate transaction 2022-01-30 15:50:35 +01:00
Shauren
9a0a56dc88 Misc: Adjust max line length in editorconfig to something that better fits 1080p screens 2022-01-30 14:14:40 +01:00
Teleqraph
af0edf5afc Scripts/Spells: Moved Blessing of Faith script to spell_items (#27692) 2022-01-30 13:10:08 +01:00
Shauren
78283e3ef2 Scripts/Spells: Fixed Holy Shock visuals 2022-01-30 12:55:57 +01:00
Nyr
0d9b1072b5 Scripts/Spells: Updated Holy Shock spell script.
* renamed related enums.
* removed unnecessary rank dependency checks.
2022-01-30 12:55:57 +01:00
Shauren
2cc652b305 Core/Scripts: Expose IsCrit to hit hooks for spell scripts 2022-01-30 12:36:29 +01:00
Shauren
ea82454932 Core/Guilds: Fixed loading of guild member logout time
Closes #27690
2022-01-30 11:57:19 +01:00
Teleqraph
72839e660e Scripts/Spells: Judgment (Holy) will now apply Rank 3 debuff if the paladin knows it (#27685) 2022-01-30 00:10:04 +01:00
Shauren
faf12a8883 Core/Objects: Don't consider SMSG_UPDATE_OBJECT packets that contain only destroyed objects as empty 2022-01-29 20:35:25 +01:00
Shauren
7044204130 Core/Objects: Cleanup SmoothPhasing code - move to separate files and better integrate it with visibility system 2022-01-29 20:35:25 +01:00
Seyden
a5c713eaf2 Core/Objects: Implement SmoothPhasing part of CreateObject and replacing visible objects 2022-01-29 20:35:25 +01:00
Shauren
5a82a0381d Core/Objects: Properly choose between "Destroyed" or "OutOfRange" during visibility update 2022-01-29 16:01:57 +01:00
Shauren
472384e757 Core/Objects: Add overridable function UpdateObjectVisibilityOnDestroy 2022-01-29 15:18:27 +01:00
Shauren
2864efdc53 Build: Disable Visual Studio 2022 MSBuild resource manager to make compile take only as much time as it does in Visual Studio 2019 2022-01-28 12:52:05 +01:00
Shauren
4fbf6dacff Core/Spells: Exclude empty mods from affecting spells and ignore PointsIndexX mods for spells that don't have any effect at that index 2022-01-28 11:19:48 +01:00
Robingad
5b57722211 Scripts/Spells: Fix shaman Lava Surge proc (#27667)
Co-authored-by: Shauren <shauren.trinity@gmail.com>
2022-01-28 11:18:45 +01:00
Robingad
1696d73860 Scripts/Spells: Move shaman Lava Burst crit chance calculation to scripts and add Lava Burst Overload (#27676) 2022-01-27 23:23:37 +01:00
Shauren
7fa2fa2f5e DB/Gossip: Restore gossip_menu_option Box* values that were wrongly set by 88659dcebf 2022-01-27 22:43:36 +01:00
Robingad
3e725e1d25 Scripts/Spells: Fix shaman Earthquake (#27620)
Co-authored-by: Shauren <shauren.trinity@gmail.com>
2022-01-27 22:18:46 +01:00
shamage
2b7545378a DB/GameObject: Remove duplicate board spawn in Stormwind
* removing cata era one

Closes #27672
2022-01-27 17:00:12 +01:00
ModoX
842e280d9e DB/Creature: Fixed sheath state of Apprentice Mages in Wizards Sanctum (Stormwind) 2022-01-27 16:59:02 +01:00
Shauren
d0bfca5a73 SQL: Fix 2022_01_26_45_world.sql for mysql 5.7 2022-01-27 11:13:04 +01:00
Shauren
88659dcebf Core/Gossip: Sync naming and db structure with 3.3.5 2022-01-26 23:49:42 +01:00
Peter Keresztes Schmidt
d33214c50a Core/ChatCommands: Do not parse partial strings for numeric paramters (PR #25259)
Check if integral/floating point type arguments were parsed successfully.

std::stoull will happily parse floating point strings until the decimal separator and return the value.
Make sure for all parsing methods that we actually parsed the whole token.

This allows to use handler arguments like Variant<uint32, float> which will be populated with the right type
depending on the token value (e.g "10" vs "10.0").

(cherry picked from commit 7edad0d601)
2022-01-26 22:30:13 +01:00
Giacomo Pozzoni
f2ee365da4 Core/SAI: Spell casts that cannot be executed because the unit is currently casting another spell will be retried asap with priority over other events (#25238)
* Core/SAI: Spell casts that cannot be executed because the unit is currently casting another spell will be retried asap with priority over other events

* Core/SAI: Re-sort the events only when needed

* Fix some priority reset and wrong mEventSortingRequired handling

* Code cleanup.
Sort only events loaded from db (not stored events, not timed action list).

* Code cleanup.
Raise priority of failed casts so they are retried before other spells

* Keep priority of the action fails and is rescheduled on next update

* Don't try recasting a spell in SMART_ACTION_CAST if there are multiple targets and at least 1 was successful

(cherry picked from commit ca25e8d019)
2022-01-26 22:26:08 +01:00