Commit Graph

15973 Commits

Author SHA1 Message Date
Malcrom
9d2d4ba921 Scripting/Hellfire: Moved some gossip to db and fix some magic numbers. 2013-12-24 12:15:41 -03:30
Malcrom
eacc165a12 Scripting/Ghostlands: Moved some gossip to db and fixed some magic numbers. 2013-12-24 08:39:35 -03:30
Shauren
5e8f829181 Core/SAI: Fixed a crash in call for help/flee for assist actions when they had an emote attached 2013-12-24 11:26:07 +01:00
Malcrom
8f4011cf6e Scripting/Zones: Some cleanup. 2013-12-24 00:56:15 -03:30
joschiwald
fd6167cf66 Scripts:
- cleanup obsidian sanctum script
- prevent yelling texts if non player died in some scripts
2013-12-23 23:55:15 +01:00
Malcrom
6858a234b3 Scripting/Borean Tundra: Fix some magic numbers. 2013-12-23 19:13:29 -03:30
Malcrom
7ef49db25d Scripting/Bloodmyst Isle: Moved Captured Sunhawk Agent gossip to db. 2013-12-23 16:20:04 -03:30
Malcrom
464632b0bc Scripting/Blasted Lands: Shouldn't have removed ScriptedGossip.h 2013-12-23 13:48:49 -03:30
Malcrom
59ac2437d8 Scripting/Blasted Lands: Fixed up gossip and teleport spell for quest 3628.
Can someone please test this. I can't do group testing locally.
Also snuck in a fix for zone_axshara.cpp
2013-12-23 13:36:36 -03:30
Malcrom
ab3eced989 Scripting/Misc: Some cleanup. 2013-12-23 12:12:31 -03:30
Malcrom
59eca906ef Scripting/Blades Edge: Moved gossip to db for Overseer Nuaar and Sai'kkal the Elder. 2013-12-23 11:19:21 -03:30
Shauren
a316b86a79 Core/Spells: Prevent adding sockets to items that have 3 sockets in item_template or already had a socket added to them 2013-12-23 14:25:34 +01:00
Shauren
107af52853 Core/Chat: Refactored building chat packets
* Moved everything into one specialized method instead of being scattered all over the place
* Allow localizing creature names in chat messages (when using $N)
* Send SMSG_GM_MESSAGECHAT for gm messages
2013-12-23 14:23:49 +01:00
Malcrom
6402fa02ac Scripting/Storm Peaks: A little work on Quest 13010 Krolmir, Hammer of Storms 2013-12-23 01:31:30 -03:30
Malcrom
d741335a02 DB/Creature_text: Updated more text from sniff. 2013-12-22 20:18:07 -03:30
Malcrom
8aef1748bf DB/Creature text: Added some missing text from sniff. 2013-12-22 18:38:46 -03:30
Malcrom
5055a8fde4 Scripting/Bloodmaul Brute: CombatAI moved to cpp for quest 10512. 2013-12-22 14:41:37 -03:30
Malcrom
34ce605a2c Scripting/DB: Fixed some npcs so they wouldn't have AIName & scriptname. 2013-12-22 11:43:10 -03:30
jackpoz
b0ffbb2179 Core/Auth: Fix expiring account bans
Fix a database race condition in authserver that would delay the account ban expiry by 1 login because the query that would have removed the ban was executed asynchronously.
2013-12-22 14:00:14 +01:00
Malcrom
0b7a9a4559 DB/Misc: Three more creature moved to SAI only. 2013-12-19 22:14:24 -03:30
Malcrom
d89a3b2fb2 DB/Gossip: Moved Highlord Demitrian gossip to db.
npc had SmartAI and cpp script.
2013-12-19 21:23:51 -03:30
Malcrom
57332e1d3e DB/SAI: Scripted all ogres in Blades Edge Mountains.
Sorry I had to remove the awesome cpp script.
2013-12-19 16:28:08 -03:30
Discover-
61c5857fc6 Merge branch 'master' of https://github.com/TrinityCore/TrinityCore 2013-12-19 10:50:37 +01:00
Discover-
c5788de8a4 Core/SAI: Fix another memory leak, thanks to @Xter 2013-12-19 10:50:16 +01:00
Spp
39331ea7b9 Core/Logging: Use logger cache for speed up logger filter search 2013-12-19 10:34:55 +01:00
Discover-
e44e932d4d Core/SAI: Fix two memoryleaks in my previous commits. Thanks to @Xter for the notice. 2013-12-19 10:28:45 +01:00
Spp
ec62bc6e88 Core/Dungeon Finder: Improve join log message to try to detect cases when one of the selected dungeons is 0
* Added specialization to all loggers related to lfg (allows to enable "lfg.join" in debug mode and keep all the rest in error)
2013-12-19 09:39:00 +01:00
Malcrom
676baa890f Scripting/Dragonblight: Commander Eligor Dawnbringer now scripted.
Purely cosmetic but it was a fun thing to script :)
2013-12-18 18:06:30 -03:30
Discover-
e5f7beecf5 Core/SAI: Using SMART_ACTION_FORCE_DESPAWN now despawns the given target_type instead of always the creature itself. 2013-12-18 10:06:19 +01:00
Discover-
a0f7fee922 Core/SAI: Fix compile
Core/SAI: Don't limit SMART_ACTION_SET_INGAME_PHASE_MASK to unit targets only. Thanks to @Shauren for the notice.
2013-12-17 11:38:29 +01:00
Discover-
154ee466eb Core/SAI: Using the action_type SMART_ACTION_SET_REACT_STATE now sets the react state of the target_type. Won't break any scripts as all current cases of this action_type have target_type 1 (SMART_TARGET_SELF). 2013-12-17 11:10:23 +01:00
Discover-
1f4d585bef Core/SAI: In all npc flag related action_types we now check if the target is a creature instead of an unit (creature/player). 2013-12-17 11:06:07 +01:00
Discover-
20a22662df Core/SAI: Using SMART_ACTION_SET_FOLLOW with target_type 0 (SMART_TARGET_NONE) will now stop the following completely. Fixes 6 scripts in a clean TDB already using this functionality even though it wasn't implemented. 2013-12-17 10:12:23 +01:00
Discover-
54b7162f1d Core/SAI: Make SMART_ACTION_SET_INGAME_PHASE_MASK set the phasemask of the target_type instead of always the source calling the action type. 2013-12-17 09:44:06 +01:00
Malcrom
b8f9442ec9 Core/Player: Fix logic for questgiver cast spell 2013-12-16 18:50:51 -03:30
jackpoz
b3c810a0fb Core/Misc: Fix warning
Partially revert f0a742a8c4 to fix a warning about unhandled switch case (the same case that Coverity reported as dead code) .
2013-12-16 19:52:50 +01:00
jackpoz
b8908606fc Core/AH: Fix memory leak
Fix memory leak in Auction House when creating an auction with stackable items and a stack of the same amount in the inventory. Leak added in 15a2acfb52 .
2013-12-16 19:38:49 +01:00
Malcrom
f1a82a578b Core/Waypoints: Stop creatures from skipping at waypoint nodes
and add smoothing to pathing.
2013-12-15 20:26:11 -03:30
jackpoz
e90a7f82d4 Core/AI: Fix CreatureAI left uninitialized
Fix CreatureAI left uninitialized for 1 server tick for Creatures with DeathState:DEAD . This is a workaround required after c9cf2f059f changes .

Valgrind log:
 Conditional jump or move depends on uninitialised value(s)
  at : npc_draenei_survivor::npc_draenei_survivorAI::MoveInLineOfSight(Unit*) (zone_azuremyst_isle.cpp:104)
  by : CreatureAI::MoveInLineOfSight_Safe(Unit*) (CreatureAI.cpp:123)
  by : CreatureUnitRelocationWorker(Creature*, Unit*) (GridNotifiers.cpp:134)
  by : Trinity::AIRelocationNotifier::Visit(GridRefManager<Creature>&) (GridNotifiers.cpp:252)
 Uninitialised value was created by a heap allocation
  at : operator new(unsigned long) (vg_replace_malloc.c:319)
  by : npc_draenei_survivor::GetAI(Creature*) const (zone_azuremyst_isle.cpp:66)
  by : ScriptMgr::GetCreatureAI(Creature*) (ScriptMgr.cpp:792)
  by : FactorySelector::selectAI(Creature*) (CreatureAISelector.cpp:41)
  by : Creature::AIM_Initialize(CreatureAI*) (Creature.cpp:716)
  by : Creature::AddToWorld() (Creature.cpp:190)
2013-12-15 21:14:47 +01:00
jackpoz
dd4a774c4c Core/Transports: Fix memory leak on shutdown
Fix world transports not being deleted on shutdown.
2013-12-15 18:51:34 +01:00
Malcrom
a2e7191b26 Core/Unit: prevent COMMAND_ATTACK being added for Trained Rock Falcon.
Also added spells for Trained Rock Falcon to db.
2013-12-15 13:43:18 -03:30
jackpoz
f0a742a8c4 Core/Misc: Remove unused code
Remove unused debugging code added in MaNGOS r5067.
Remove dead code from a switch found by Coverity.
2013-12-15 13:37:49 +01:00
w1sht0l1v3
89ee8cbac1 Core/Unit: Add switch to prevent COMMAND_ATTACK being added to action bar for supplied creature entries. 2013-12-15 14:09:49 +02:00
Malcrom
dcfbe53552 Core/Player: Fix questgiver spell cast. 2013-12-14 20:22:39 -03:30
joschiwald
d5f6c2e2a2 Merge branch 'master' of github.com:TrinityCore/TrinityCore 2013-12-14 19:45:01 +01:00
joschiwald
f5c2dca1d5 Scripts: fix crash in spell_jokkum_scriptcast
Closes #11313
2013-12-14 19:43:29 +01:00
Discover-
e17af3f203 Core/Quests: Fix an issue where auto-completed quests would not be automatically completed if the quest was added through either the SmartAI action_type SMART_ACTION_ADD_QUEST, the spell effect SPELL_EFFECT_QUEST_START or the opcode CMSG_QUEST_CONFIRM_ACCEPT. Also fixes auto-complete quests in the SAI and opcode case not calling the AI hook. 2013-12-14 19:42:31 +01:00
Discover-
ec8e94c6ac Core/AI: Fix an issue where the OnQuestAccept hooks were not called for auto-completed quests.
Fixes #11304
2013-12-14 19:39:47 +01:00
jackpoz
ca6b9df261 Core/Misc: Fix some static analysis issues
Fix some static analysis issues about uninitialized values.
2013-12-14 19:36:43 +01:00
jackpoz
1c0903e286 Core/Misc: Fix some static analysis issues
Fix some static analysis issues about uninitialized values. Most of them are false positives, always initialized before being accessed, while some of them are real issues spotted by valgrind too.
2013-12-14 18:41:26 +01:00