Commit Graph

7303 Commits

Author SHA1 Message Date
Anubisss
a33b26ba0e Allow spell Rupture to crits on ticks.
Fixes issue #1796.

--HG--
branch : trunk
2010-05-18 23:48:26 +02:00
malcromdev@gmail.com>
0d4bbd9641 SCRIPT_COMMAND_ORIENTATION fixed right. (thanks Mach)
--HG--
branch : trunk
2010-05-18 19:08:08 -02:30
malcromdev@gmail.com>
7ce2853ca8 Fix SCRIPT_COMMAND_ORIENTATION db script command.
--HG--
branch : trunk
2010-05-18 17:45:15 -02:30
malcrom
2b7d92a401 Some more engrish to english logerror updates.
--HG--
branch : trunk
2010-05-18 14:22:51 -02:30
malcrom
d1b9a54951 Converted some log error messages in AchievementMgr.cpp to English.
--HG--
branch : trunk
2010-05-18 10:31:03 -02:30
Rat
5a0b2f3fef fixed crash when trying to spawn a not existing creature
--HG--
branch : trunk
2010-05-18 09:32:51 +02:00
click
953c267369 Fix broken linuxcompile broken in r53601d50dd
--HG--
branch : trunk
2010-05-18 05:46:32 +02:00
malcromdev@gmail.com>
b5342fe754 Add ablility to select closest creature of entry (dataint), range (x) as target for spell (datalong) SCRIPT_COMMAND_CAST_SPELL.
--HG--
branch : trunk
2010-05-17 21:24:21 -02:30
malcromdev@gmail.com>
4077f525f0 Add Ability for db script command SCRIPT_COMMAND_ORIENTATION to set creature orientation to face player.
--HG--
branch : trunk
2010-05-17 20:37:13 -02:30
click
d607693123 Add proper use of precompiled headers on linux - this removes an approx 50% reduction of total compiletime
--HG--
branch : trunk
2010-05-18 00:17:14 +02:00
Rat
eba819ae79 fixed double honor count error in battleground player list window
--HG--
branch : trunk
2010-05-17 23:29:13 +02:00
Rat
9a631614e3 display honor gained from kills in bg score window
--HG--
branch : trunk
2010-05-17 17:10:24 +02:00
Anubisss
47b32302f1 Fix a crash in realmd.
That crash occurs when realmd get an unknown packet and try to "shutdown" the socket.

Note that: don't try to release an ACE_Message_Block if it is _not_ dynamically allocated.

--HG--
branch : trunk
2010-05-17 15:58:12 +02:00
_manuel_
d3f0bddd3f Makes cage doors open at Drakos death.
--HG--
branch : trunk
2010-05-16 16:37:19 -03:00
Anubisss
e619948fc6 Fix a typo. This table contains also another types of spells and not just exlirs.
--HG--
branch : trunk
2010-05-16 19:45:04 +02:00
Anubisss
0f0619ae0b Fix spell Improved Devouring Plague's damage.
Core part of the patch by PrinceCreed.
SQL part of the patch by sinka.isi.

Fixes issue #1965.
Closes issue #1004.

--HG--
branch : trunk
2010-05-16 18:49:51 +02:00
Rat@walamy
9771757c4c you can now reload creatures from creature_template table
NOTE: reload is limited to one creature at a time
Usage: .reload creature_template $entry
Warning: this is mainly for developers, reloading a creature can cause unexpected behaviors!!

--HG--
branch : trunk
2010-05-16 17:45:45 +02:00
Machiavelli
a1ef8aaa66 Don´t kick sessions in the tiny window (barely a few ms) between the login queue and the char selection screen either.
--HG--
branch : trunk
2010-05-16 16:30:02 +02:00
_manuel_
4671e6fd99 Support for spell 51336 (Magic Pull).
--HG--
branch : trunk
2010-05-16 11:03:47 -03:00
_manuel_
80a5ddcac3 Improvements in boss_draoksAI and npc_unstable_sphereAI, removed hack for spell 51336.
--HG--
branch : trunk
2010-05-16 11:03:18 -03:00
Machiavelli
2129e56f78 Don´t kick sessions that are ´idle´ in the login queue.
--HG--
branch : trunk
2010-05-16 14:46:49 +02:00
Machiavelli
cef21f6e39 Fix crash introduced in 8199 (5a30b77777b7)
--HG--
branch : trunk
2010-05-16 14:14:54 +02:00
Machiavelli
437a5d90b2 Fix a possible crash in SqlTransaction::Execute(), using post-iterating on the LockedQueue instead of pre-iterating.
Thanks to click for the insight and Spp for testing.

--HG--
branch : trunk
2010-05-16 13:31:52 +02:00
click
89887b9b65 Correct SMSG_INSTANCE_DIFFICULTY structure (fixes raid difficulty display).
Move GetDifficulty() in under Map-scope, so it's reachable for map-based functions

--HG--
branch : trunk
2010-05-16 04:03:53 +02:00
Machiavelli
6ee54548f3 Fix Autokick timer. Will work again properly for people on the char selection screen. In addition, it now also catches non-terminated, lingering sessions.
--HG--
branch : trunk
2010-05-16 03:42:05 +02:00
Spp
a99c6bd5a9 Fix localization of gossip menu options
Original patch by Qowyn
Adapted to trinity (and tested) by Durotar and Aokromes

--HG--
branch : trunk
2010-05-16 00:58:24 +02:00
Machiavelli
fa57ce4cd1 Reimplement ACE_Based::LockedQueue as SQL holder for the SqlTransaction class, since std::queue is not safe when multiple threads are reading/writing to it at the same time (SqlDelayThread and a MapUpdate Thread).
Original patch by thenecromancer, was removed for ungrounded reasons.
Thanks to Zor for the insight.
Please give feedback on how this affects mtmaps usage.

--HG--
branch : trunk
2010-05-15 14:58:16 +02:00
Machiavelli
7ff9e82f1a Use delete[] on object allocated with new[x+y*z] in TileAssembler.
--HG--
branch : trunk
2010-05-15 13:48:31 +02:00
Spp
9a5f744256 SMSG_PARTY_COMMAND_RESULT: Send proper operation value with uninvite commands
--HG--
branch : trunk
2010-05-15 06:23:56 +02:00
click
a0105b5bde Add logout-notice in charlog on player logout
--HG--
branch : trunk
2010-05-15 01:26:28 +02:00
click
85ec98ff9f Allow multiple classes for quest requirements - patch by Shauren
(This should make Malcrom happy)
Fixes issue 1476. Fixes issues 1972. Fixes issue 430.

--HG--
branch : trunk
2010-05-14 23:43:42 +02:00
Anubisss
7ef50b62c8 Drop out Grobbulus's Mutating Injection spell code from core.
It's handled correctly via table spell_linked_spell.

Also, this commit fixes the bug that spell Mutating Injection casted on the target two times by each casts.

--HG--
branch : trunk
2010-05-14 22:22:26 +02:00
Anubisss
6851fae8e2 Fix Glyph of Preparation.
Patch based on microbius51's patch.
Closes issue #1371.

--HG--
branch : trunk
2010-05-14 21:42:55 +02:00
Anubisss
5c596f32d4 Generate an error message when forgot to allocate memory for a script.
This message is useful to find don't allocated scripts, like in rev r5915a3a871.

--HG--
branch : trunk
2010-05-14 20:07:45 +02:00
Anubisss
a7295810e3 Fix Glyph of Life Tap.
SpellMgr.cpp part of the code by Karolis.Rudzevicius, thanks for it.
Fixes issue #1440.

--HG--
branch : trunk
2010-05-14 18:02:31 +02:00
Machiavelli
3c9fc9b9e3 Fix Linux compile
--HG--
branch : trunk
2010-05-14 15:12:50 +02:00
Anubisss
2425edfdab Fix Glyph of Shred.
--HG--
branch : trunk
2010-05-14 14:32:43 +02:00
Machiavelli
98a5c09af0 Add config option SessionAddDelay to replace the hard coded 10ms default Networkthread sleep time after WorldSocket::HandleAuthSession calls and adding the session to the world session map.
--HG--
branch : trunk
2010-05-14 00:50:26 +02:00
Machiavelli
d390ff46c2 Make ObjectMgr::GetGuildByName and ObjectMgr::GetArenaTeamByName searches case insensitive.
Fixes issue #307.
Credits to Loread

--HG--
branch : trunk
2010-05-13 20:04:36 +02:00
Xanadu
5bf4af15dc Prune some deadwood.
--HG--
branch : trunk
2010-05-13 19:28:23 +02:00
click
c8e648e18e Make questgivers automatically inform of quests in their gossipmenu when available - removes need of extra gossip option to show quests
Fix by Liberate (made for Malcrom so he stops complaining)

--HG--
branch : trunk
2010-05-13 19:06:20 +02:00
Machiavelli
f286f583fc Prevent SQL injection in Player::_SaveEquipmentSets()
--HG--
branch : trunk
2010-05-13 18:25:32 +02:00
Machiavelli
bf9d8f9423 Implement enchantments for ITEM_MOD_SPELL_PENETRATION and ITEM_MOD_BLOCK_VALUE.
Inspired by patch provided by Metthal
Closes issue #1766

--HG--
branch : trunk
2010-05-13 18:01:55 +02:00
Xanadu
a891692d05 Fixed spell casting upon vehicle summoning.
--HG--
branch : trunk
2010-05-13 17:57:59 +02:00
Machiavelli
144a146810 Fix crash introduced in 4610bbf047.
- Update SqlAsyncTask´s destructor, properly NULLpoint SqlOperation* m_op so other threads can deal with it accordingly.
- Don´t keep NULL´d elements in transaction queues, remove them instead.

This now means you should be able to run a stable server with > 2 MapUpdate threads. Please leave feedback.

Courtesy of click and myself.

--HG--
branch : trunk
2010-05-13 17:24:54 +02:00
_manuel_
28bbc233d1 Added missing newscript = new Script; , my fault. Thanks to Anubisss.
--HG--
branch : trunk
2010-05-13 11:36:18 -03:00
_manuel_
899736d89c Changes in scripts for quest chain The Amphitheater of Anguish:
- Added blizzlike content, like texts.
- Corrected some spells and timers.
- As i saw in offi can be more than 1 player doing different parts of the chain at the same time.
- Added code to prevent the npc gets out of the ring.
- Added support for The Amphitheater of Anguish: From Beyond.

--HG--
branch : trunk
2010-05-13 11:09:10 -03:00
Anubisss
852254d258 Fix a duplicated script: go_gilded_brazier.
Remove it from one file and also merge the 2 scripts in one file.

The error message:
ScriptName: 'go_gilded_brazier' already assigned with the same ScriptName, so the script can't work.

--HG--
branch : trunk
2010-05-13 14:29:06 +02:00
Machiavelli
5e48be89d5 Fix a crash in SqlAsyncTask::call caused by the fact that the SQLOperation to be called was a NULL pointer.
The crash was mostly noticable on servers with relatively high MapUpdate Threads, since the window between SqlAsyncTask::call()´s NULLpointer check for m_op and the usage of this pointer was larger when more map threads are calling Database::CommitTransaction()´s and NULLing this pointer.
Fixes crash specified in comment #24 in issue #1259, and most likely will affect other crashes specified there as well.
Courtesy of click and myself, and our lengthy and deep brainstorming session.

--HG--
branch : trunk
2010-05-13 14:22:00 +02:00
Anubisss
10bf921a65 Generate an error message when core tries to assign a script's ScriptName which is already assigned.
This means if that happened the core override the older script.
As a result, the earlier one doesn't work and can't deallocate so generates memory leak.

This commit also fixes memory leaks caused by that.

Valgrind log:

==4753== 354 (312 direct, 42 indirect) bytes in 1 blocks are definitely lost in loss record 1,194 of 1,218
==4753==    at 0x4C2626C: operator new(unsigned long) (vg_replace_malloc.c:230)
==4753==    by 0x1039D85: AddSC_go_scripts() (go_scripts.cpp:1015)
==4753==    by 0xDC196F: AddScripts() (ScriptLoader.cpp:534)
==4753==    by 0xC19943: ScriptMgr::ScriptsInit() (ScriptMgr.cpp:70)
==4753==    by 0xD1CCAE: World::SetInitialWorldSettings() (World.cpp:1608)
==4753==    by 0x9100A6: Master::Run() (Master.cpp:234)
==4753==    by 0x90F5D6: main (Main.cpp:146)

--HG--
branch : trunk
2010-05-13 14:15:11 +02:00