Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-23 02:25:38 +01:00
Code Issues Packages Projects Releases Wiki Activity
23,840 Commits 4 Branches 146 Tags
a6f7bb029c8d29c19de8596d5d402222ca6c00a2
Commit Graph

10251 Commits

Author SHA1 Message Date
w1sht0l1v3
8367944171 Core/Scripts: Fix kill credit for quest The Hunter and the Prince(13400). 2014-01-19 00:30:25 +02:00
Dehravor
e60977911a Core/Tickets: Fix memory leak when malformed CMSG_GMTICKET_CREATE is received 2014-01-18 21:12:56 +01:00
Machiavelli
68af9376f6 Core/Calendar: Add documentation regarding fix in previous commit 2014-01-18 14:00:19 +01:00
Machiavelli
ca6fd8aad2 Merge pull request #11462 from Dehravor/add-event-memleaks 
Core/Calendar: Fix memory leaks due to BytebufferException thrown
 2014-01-18 04:57:29 -08:00
Shauren
c431f463a1 Core/Items: Fixed swapping equipment sets in combat 2014-01-18 12:58:01 +01:00
Dehravor
3a9a634a91 Core/Calendar: Fix memory leak when guild announcement is created 2014-01-18 11:47:05 +01:00
Dehravor
51e38872c7 Core/Calendar: Fix memory leak when malformed CMSG_CALENDAR_ADD_EVENT is received 2014-01-18 10:30:39 +01:00
Bonitas
09a73a398a Core/Spells: Fix proc for spells that should trigger on taken hots 2014-01-18 01:50:19 +01:00
Discover-
735cebf7a3 Core/Commands: The .setskill command is now usable even if the player doesn't already have the skill learned. 2014-01-18 01:05:03 +01:00
Discover-
bbd84d211d Merge branch 'master' of https://github.com/TrinityCore/TrinityCore 2014-01-17 18:44:01 +01:00
Discover-
ebfdeb067f Core/Spells: Rename Spell::EffectSummonDeadPet with Spell::EffectResurrectPet and get rid of two TODO's that are already done. 2014-01-17 17:54:52 +01:00
Machiavelli
e2376fcb72 Merge pull request #11397 from Dehravor/guild-view-offinote 
Core/Guild: Don't allow players to view officer notes without proper rights
 2014-01-17 03:47:01 -08:00
Zabustak
101cad1f28 Show Kick, Mute and Ban in world 2014-01-17 12:23:36 +01:00
Discover-
c1a468365b Core/Misc: When a player changes its faction its only removed from all its arena teams if cross-faction interaction is turned off. 2014-01-17 08:17:09 +01:00
joschiwald
940e52236b Core/Entities: bg vehicle will also have charmer's faction (save faction before charm and restore old faction after charm) 2014-01-17 01:07:37 +01:00
Discover-
45dc95c8dc Core/Items: Fix an exploit where the player was able to send CMSG_SET_AMMO with items they didn't have in their bags. Only a visual bug (not sure if it gave bonuses too, which iirc do appear in later expansions). 2014-01-16 20:48:37 +01:00
Discover-
61f45283ef Core/Misc: Fix an exploit where moving while consuming something that would fade when the player stands up would stay if the player started moving and using the effect at the same time. Thanks to @FrozenSoul and @jildor. 
Fixes #6271
 2014-01-16 20:44:03 +01:00
jackpoz
cbba22ba68 Core/SAI: Fix assertion triggered in SmartScript 
Remove assertion in SmartScript added in b8625f41bd and handle SmartScripts with GetBaseObject() returning NULL , like SmartTrigger . In this case SmartScript::mTargetStorage cannot be sanitized and might contain references to free'd WorldObjects if the script doesn't last a single Map::Update() call.
 2014-01-15 20:20:01 +01:00
jackpoz
d78e69cdc6 Core/Instances: Fix memory leak in InstanceSaveMgr 
Fix memory leak in InstanceSaveMgr added in 1f170c99ef .
Make InstanceSave::SetToDelete() private since it's not supposed to be used by anything other than InstanceSave or its friend class InstanceSaveMgr .
 2014-01-13 22:52:35 +01:00
Elron103
88ecc9533a Core/Entities: Fix combat state setting when FFA PvP flag is set 
Description:
Currently there is an issue, when you are in FFA areas, but you dont have PvP flag activated.

You should get the PvP-In-Combat delay timer, but instead you just get the usual timer as if you would not fight in PvP.

Reproduction:
1) Get two players in FFA area Gurubashi arena down in the battle area (.tele Gurubashi)

2) Fight each other

3) When stopping combat, the combat state will switch off immediately. But it is supposed to switch off after some delay, because it was a PvP fight.

Closes #11103

Signed-off-by: Duarte Duarte <dnpd.dd@gmail.com>
 2014-01-13 17:03:43 +00:00
Duarte Duarte
80a398372d Core/Player: Fix compile error introduced in ##11377 merge 2014-01-13 16:50:07 +00:00
Duarte Duarte
949dc9bf16 Merge pull request #11377 from Yelvann/master 
Core/Instances: Fix exploit too much players in instances/raids
 2014-01-13 08:33:29 -08:00
jackpoz
b8625f41bd Core/SAI: Fix crash in SmartScript 
Fix crash in SmartScript storing WorldObject* instead of guid as targets in SmartScript::mTargetStorage , used by SMART_TARGET_STORED target type , SMART_ESCORT_TARGETS and other escort related code.
Fixes #11228 , #10157 .

Valgrind log:
 Invalid read of size 4
  at : Object::GetTypeId() const (Object.h:140)
  by : SmartScript::IsPlayer(WorldObject*) (SmartScript.h:73)
  by : SmartScript::ProcessAction(SmartScriptHolder&, Unit*, unsigned int, unsigned int, bool, SpellInfo const*, GameObject*) (SmartScript.cpp:330)
  by : SmartScript::ProcessEvent(SmartScriptHolder&, Unit*, unsigned int, unsigned int, bool, SpellInfo const*, GameObject*) (SmartScript.cpp:2662)
  by : SmartScript::ProcessAction(SmartScriptHolder&, Unit*, unsigned int, unsigned int, bool, SpellInfo const*, GameObject*) (SmartScript.cpp:2226)
  by : SmartScript::ProcessTimedAction(SmartScriptHolder&, unsigned int const&, unsigned int const&, Unit*, unsigned int, unsigned int, bool, SpellInfo const*, GameObject*) (SmartScript.cpp:2238)
  by : SmartScript::ProcessEvent(SmartScriptHolder&, Unit*, unsigned int, unsigned int, bool, SpellInfo const*, GameObject*) (SmartScript.cpp:2685)
  by : SmartScript::UpdateTimer(SmartScriptHolder&, unsigned int) (SmartScript.cpp:3198)
  by : SmartScript::OnUpdate(unsigned int) (SmartScript.cpp:3244)
  by : SmartAI::UpdateAI(unsigned int) (SmartAI.cpp:331)
  by : Creature::Update(unsigned int) (Creature.cpp:544)
  by : void Trinity::ObjectUpdater::Visit<Creature>(GridRefManager<Creature>&) (GridNotifiers.cpp:340)
 2014-01-12 20:23:13 +01:00
DarkBrain2580
de1d75af70 Spells: Fix Alcohol-Free Brewfest Sampler 
Closes #10956

Signed-off-by: Duarte Duarte <dnpd.dd@gmail.com>
 2014-01-12 00:41:54 +00:00
zengwf
23acf75d3b Core/Movement: Add LOS check for fleeingmovement target point. 
Prevents fleeing or feared units from going to upper floor ignoring walls/ceilings with mmaps on(and usually get stucked).

Current implementation just randomly selects a distance and angle against the frighting unit, when in narrow circumstance such as underground caves, such targeting point would be at another floor.

Closes #11300
Ref #9475 (needs fixed confirmation)
 2014-01-12 00:33:33 +00:00
Duarte Duarte
0eadb41ed1 Merge pull request #11310 from Ric101/can_quest_reward 
Core/Players: On CanRewardQuest, use the same item dest vector for all potential rewards

Solves issues where the player has enough bag space for each item individually, but not all of them together.

Example to reproduce previous issue:

Obtain Battle of the Crimson Watch (10781)
Make sure you only have 1 slot available in your inventory
Turn in the quest, watch as you don't receive one of the rewards
 2014-01-11 16:21:41 -08:00
Duarte Duarte
65c941b88d Merge pull request #11342 from Carbenium/Svala 
Scripting/Utgarde Pinnaccle: Fix visual during Svala's transformation
 2014-01-11 16:20:16 -08:00
Dr-J
b83c252851 Scripts/NPCs: Remove core script for rogue trainers which was overriding db conditions 
SAI and conditions for rogue trainers to provide elegant leter to rogues provided that is level 24 or higher, does not have elegant letter and does not have taken, rewarded or complete the quest which elegant letter starts

Closes #11378

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
 2014-01-12 00:17:21 +00:00
mthsena
0b5728f8a7 Core&Conf: Small cosmetic fixes 
Closes #11392

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
 2014-01-12 00:07:29 +00:00
Duarte Duarte
e42cc9d5dd Merge pull request #11426 from Dehravor/invalidate-player 
Core/Entities: Implement SMSG_INVALIDATE_PLAYER
 2014-01-11 12:47:12 -08:00
Dehravor
4d3b7e6799 Core/Entities: Don't allow to login while character is forced to rename 2014-01-11 21:20:24 +01:00
Dehravor
619f42c1b0 Core/Entities: Implement SMSG_INVALIDATE_PLAYER 2014-01-11 18:22:56 +01:00
jackpoz
086622bfc1 Core/Battlegrounds: Fix offline players not being resurrected when Battleground ends 
Fixes #7081
 2014-01-11 17:18:36 +01:00
jackpoz
6f6ad952b9 Core/Wintergrasp: Fix typo in CMSG_HEARTH_AND_RESURRECT handler 
Fix CMSG_HEARTH_AND_RESURRECT handler trying to resurrect players with 100x hp/mana/energy ( SetHealth()/SetPower() were sanitizing the input anyway ) .
 2014-01-11 15:23:52 +01:00
jackpoz
8fcfabe784 Core/Spells: Fix potions cooldown in combat 
Fix a cooldown issue related to potions allowing Players in combat to use more than 1 potion in a row, especially with high latency.
This also fixes an exploit about using infinite potions in combat just by skipping the client-side check.
The original implementation c064c2e2e1 was missing a check in Spell::CheckCast() about this particular case since Potion cooldown is added only after the Player goes out of combat.
Fixes #1259 .
 2014-01-10 22:39:08 +01:00
joschiwald
41b613186e Core/Battlefield: some codestyle changes 2014-01-10 17:42:08 +01:00
joschiwald
7378baee49 Scripts/PoS/Garfrost: cleanup saronit blocks after death 2014-01-10 17:37:03 +01:00
joschiwald
7ec7fcf78c Core/SAI: drop unneeded code 2014-01-10 17:36:04 +01:00
joschiwald
6fff9d08b2 Fix build 2014-01-09 23:31:52 +01:00
joschiwald
e80d1f3465 Scripts/BloodFurnace: 
* cleanup InstanceScript
* fix broggok poison cloud

Scripts/Naxxramas/Grobbulus:
* fix poison cloud
* fix mutating injection
 2014-01-09 23:17:02 +01:00
joschiwald
a60ba240b7 Core/Entities: add some log messages in CheckCreatureTemplate 
* Happy Error Spam
 2014-01-06 20:30:11 +01:00
Shauren
619edff196 Misc: 
* Tools: Fixed a compile warning
* Commands: Fixed npcflag format in .npc info
 2014-01-06 13:53:29 +01:00
Shauren
15cbe5858c Core/Movement: Fixed vehicle passengers disappearing clientside 
Closes #11411
 2014-01-06 13:51:40 +01:00
joschiwald
95f14f921b Scripts/HoS: update Maiden of Grief 2014-01-05 16:47:07 +01:00
Shauren
ad84759d2f Core/Threading: Handle CMSG_ZONEUPDATE only in WorldSession update - changing zones triggers changing chat channels, what is not a thread safe operation 2014-01-05 00:52:10 +01:00
joschiwald
738afccfc1 DB/Spells: correct more spelldifficulty_dbc entries 
* add log message to find wrong entries
 2014-01-05 00:49:54 +01:00
joschiwald
cd76d32907 Core/Entities: correct creature damage, offhand damage should work too 
* todo: some creatures need dmg_multiplier update in creature_template
 2014-01-04 18:22:06 +01:00
Warpten
ff61e4d79d Scripts/Halion: Fixed Soul Consumption's pull effect. 
Thanks to Winterfell for pointing out the issue.
 2014-01-04 17:48:51 +01:00
jackpoz
1f170c99ef Core/Instances: Fix Instance binding 
Fix players not being bound to instance if the group was disbanded before killing any boss.
Fixes #437
 2014-01-03 18:56:11 +01:00
Shauren
9d6904f03d Core/Vehicles 
* Fixed vehicle orientation on transports
* Fixed exiting vehicles on moving transports
 2014-01-02 14:20:05 +01:00