Commit Graph

11055 Commits

Author SHA1 Message Date
Machiavelli
701649cb3f Scripts/Storm Peaks: Fix some (embarassing) errors in npc_hyldsmeet_protodrake (script is working now) and correct seat ID in vehicle_template_accessory. 2011-08-18 13:13:30 +02:00
Machiavelli
fdbfa5156c Core/DBLayer: Possible crash fix for ProcessQueryCallbacks on GCC builds. Ref issue #2136 #1422 #1335.
There's no need for an explicit ACE_Thread_Mutex in the ACE_Refcounted_Auto_Ptr objects since concurrent read/write access is guarded by ACE_Future's implicit ACE_Recursive_Thread_Mutex. Perhaps the double locking was the reason the reference count's atomic incrementing crashing.
Please try to test and confirm.
2011-08-18 12:43:42 +02:00
QAston
dc3a3772ba Merge pull request #2617 from Chaplain/master
Core/Spells: Fixed exploit found in 9936921206.
2011-08-18 03:03:00 -07:00
QAston
1de095f7cf Core/Spells: Add required and implicit target object type data for spell effects - will be used in future patches. 2011-08-18 11:50:31 +02:00
Lopin
9e9a84cf0e Core/Events: Fixed items removing from World Events. The items will be removed on first player's login after the end of the event. Also prevents using those items between the end and login of the player 2011-08-17 18:47:34 +02:00
Chaplain
2233018f52 Core/Spells: Fixed exploit found in 9936921206.
When we count twice multipliar for spells with SPELL_SCHOOL_MASK_NORMAL.
Also now it will show correct data in character info like damage reduction % from defence stance in warrior case.
Also fixed some minor logic issues.
2011-08-17 16:11:38 +03:00
Shauren
1c606d0d0c Core/Battlegrounds: Don't send SOTA transports removal twice 2011-08-17 12:02:34 +02:00
QAston
ec95ead0ac Fix build. 2011-08-17 12:00:20 +02:00
QAston
a44e1c505e Core/Spells: Add new spell implicit target categories data - will be used in future patches. 2011-08-17 11:30:47 +02:00
tobmaps
a23c4592af Core/Spells: Diminishing returns shouldn't prevent direct damage caused by spells - fixes dispel damage of Unstable Affliction if target immune to silence now 2011-08-17 04:09:12 +07:00
QAston
a3fc4e897c Core: Add missing forward declarations in SpellInfo.h 2011-08-16 20:08:13 +02:00
QAston
a077a26aa5 Core/Spells: update the core to the changes from 1fb1988d46 . To make your custom code work with those changes simply lookup the value of Targets enum value from prev rev, and update the name in your code. 2011-08-16 19:44:18 +02:00
QAston
1fb1988d46 Core/Spells: change Targets enum to use consistent naming schema. This is not a functional change, but it's needed for upcoming changes, also this makes target type research and use easier. 2011-08-16 19:42:36 +02:00
QAston
d4b90d1f86 Core/Spells: Remove OriginalVictim parameter from Unit::CastSpell(x,y,z) - setting unit target was enough for all spells which used it, there's never a need to cast with both unit and dest target on retail (in such cases unit target + DEST_TARGET target types are used). 2011-08-16 16:53:29 +02:00
QAston
73bbc3aca8 Core/Spells: Update some targeting related attribute definitions to make them more clear and consistent. 2011-08-16 16:06:21 +02:00
Lopin
8ae5750c15 Core/Maps: Changed InstanceSave error message to show also Name & GUID of player and Entry & Name & InstanceId of instance map 2011-08-16 15:42:32 +02:00
QAston
e0d43388af Core/Spells: define SPELL_ATTR2_CAN_TARGET_NOT_IN_LOS and SPELL_ATTR6_CAN_TARGET_INVISIBLE (big thanks to joschiwald for the second one) 2011-08-16 15:11:07 +02:00
Shauren
d2ae95ec00 Scripts/Pit of Saron: Removed unneccessary line 2011-08-16 15:03:51 +02:00
QAston
961b2629c5 Merge pull request #2593 from fredi/clean
Core/Account: Code style and cleanups in AccountMgr
2011-08-16 04:47:31 -07:00
QAston
9936921206 Merge pull request #2580 from hacknowledge/damagemodfix
Core/Spells: Fixed weapon dependent damage mods for players as well as au
2011-08-16 03:41:23 -07:00
Lopin
9f196f23f1 Script/Ulduar: Small cosmetic changes and magic numbers in Hodir's script. Be prepared for Thorim soon! 2011-08-15 21:08:00 +02:00
Machiavelli
826ec0582a Core/GameObject: Fix GameObject::Use log error message 2011-08-15 15:41:06 +02:00
Fredi Machado
12fc1d58e7 Core/Account: Code style and cleanups in AccountMgr 2011-08-15 10:12:30 -03:00
Machiavelli
b560090692 Core/GameObject: Fix interaction distance with GameObjects in all corner cases by overriding Object:_IsWithinDist. Distance calculation to GO's need to take in account GameObjectDisplayInfoDBC entries, otherwise distance would not be calculated from the edges properly and ie. quest interaction with large gameobjects would fail. 2011-08-15 14:09:20 +02:00
Souler
948a119fa3 Core/Tools: Restore .pdump load command 2011-08-15 14:50:46 +03:00
Spp
0c30139527 Cosmetic: Some cosmetic changes here and there 2011-08-15 11:46:48 +02:00
XTZGZoReX
4276c73be8 Core: Cosmetic cleanups and additional comments in ScriptMgr. 2011-08-14 13:45:42 +02:00
leak
d01bb754d7 Core/Commands: Remove useless file, commands were already converted to command scripts a bit ago 2011-08-14 13:07:43 +02:00
Machiavelli
8b83ae0c05 Scripts/Storm Peaks: Typo in 0cb688, thanks to simlt 2011-08-14 11:07:00 +02:00
hacknowledge
0c500486f3 Core/Spells: Fixed weapon dependent damage mods for players as well as autohit damage mods for NPCs and pets. This fixes also meta sockel effects. Also fixed displaying the correct values in the char info. I also took care of applying and unapplying the weapon based damage mods when the player is being disarmed and equips/unequips his weapon.
Fixes #178, #418, #1276, #259 and possible a few other issues.
2011-08-13 23:26:16 +02:00
Machiavelli
0cb68815ec Scripts/Storm Peaks: Make Hyldsmeet Drakerider properly respawn. 2011-08-13 22:04:05 +02:00
Machiavelli
65a29d1315 Scripts/Spells: Fix a typo in spell_hun_masters_call 2011-08-13 21:46:25 +02:00
tobmaps
54cf7f28d2 Core/Misc: Fix some typos in af040fc18d 2011-08-13 20:53:24 +07:00
leak
af040fc18d Core/Players: Allow players to answer gamemaster whispers even if whispers are disabled. Whitelist can be reset by .whispers off 2011-08-13 15:10:45 +02:00
leak
6db242473e Core/Commands: Console should be able to add/remove rights in any case 2011-08-13 13:24:48 +02:00
leak
91a3bfe42a Core/Commands: .pinfo improvements
- Allow .pinfo <guid>
- Add map/zone/subzone/phase to output
2011-08-13 13:00:38 +02:00
Shauren
bac78de203 Core/Battlegrounds: SotA will no longer crash in update 2011-08-13 12:28:36 +02:00
Shauren
f03ef48b3e Core/Object: Removed incorrect code (never affected anything) 2011-08-13 11:44:51 +02:00
Shauren
6ea362e9e0 Core/PacketIO: Documented structure of SMSG_OVERRIDE_LIGHT 2011-08-13 11:44:05 +02:00
idostyle@zoit
93238fe6c3 Core/Players: Corrected faction id check for RepObjectiveFaction2 2011-08-13 11:40:45 +02:00
Manuel Carrasco
d9d5bce568 Scripts/Malygos: - Applied TC code style.
- Every Hover Disk will correctly change the faction once the creature passenger dies.
                 - Player's mount will be despawned when the passenger leaves it.
2011-08-12 16:29:43 -03:00
Shauren
f797f9f74d Core/Spells: Failed triggered spell casts will no longer cause the proc aura that triggered them to be removed (this behavior should only apply to channeled spells), also corrected UNIT_FIELD_CHANNEL_OBJECT setting 2011-08-12 13:22:53 +02:00
idostyle@zoit
8c411ffa42 Spell: Mark of the Fallen Champion
Forcing gcc to use the right overloaded function here.
2011-08-12 05:01:31 +02:00
QAston
b81fb4d423 Core/Spells: Rename SPELL_ATTR2_ALWAYS_APPLY_MODIFIERS to SPELL_ATTR2_DISPLAY_IN_STANCE_BAR, and make auras to be recalculated when permament instead of using that wrongly defined flag. 2011-08-11 23:11:10 +02:00
QAston
0d1a5314dc Core/Spells: Define some new attributes: SPELL_ATTR6_ONLY_CAST_WHILE_POSSESSED, SPELL_ATTR6_DONT_DISPLAY_COOLDOWN, SPELL_ATTR5_ALLOW_TARGET_OF_TARGET_AS_TARGET, SPELL_ATTR4_AREA_TARGET_CHAIN, SPELL_ATTR3_DONT_DISPLAY_RANGE 2011-08-11 23:03:43 +02:00
Machiavelli
e671021527 Merge pull request #2537 from Kapoeira/master
[Scripts/Commands] Killing more engrish and cleanin' up.
2011-08-11 08:58:40 -07:00
Fest
c1f0833672 Core/ReferAFriend : fix strange grantableLevels value in DB 2011-08-11 17:42:02 +02:00
idostyle@zoit
eedeeaf2b2 Spell: m_castItemGUID initialization
Closes #105
Closes #1193
2011-08-10 15:08:22 +02:00
Cron
e2c1dac196 Scripts/Commands: Forgotten change & fix a mistake. 2011-08-09 07:43:42 -03:00
Cron
564fa1a557 Scripts/Commands: Killed some more engrish in debug CommandScripts. 2011-08-09 07:40:49 -03:00