Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-20 01:15:35 +01:00
Code Issues Packages Projects Releases Wiki Activity
26,855 Commits 4 Branches 146 Tags
b6a8045adcbccfba4fa4a48a3dfcc2ccf1972206
Commit Graph

19534 Commits

Author SHA1 Message Date
ariel-
b6a8045adc Core/Unit: fix some SPELL_AURA_MOD_DAMAGE_PERCENT_DONE effects being applied more than once 
No more overpowered dps for you

Closes #16755
 2016-11-16 02:26:18 -03:00
ariel-
f3bdd705c0 Core/Unit: fix build 
Ctrl-S failure
 2016-11-15 22:50:28 -03:00
ariel-
ca1c4525c7 Core/Unit: damage immune improvements (9f5df023b7 follow up) 
- Handling checked in sniffs: Spell 63710 Void Barrier vs 49143 Frost Strike
  * Send spell miss immune only if spell consists of damage effects
- Checked with 348 Immolate:
  * No packets sent if damage immune, aura is applied normally

Also... who the fuck uses 0 to compare against pointers
 2016-11-15 22:39:15 -03:00
ariel-
64304d8b2b Core/Spell: fix a potential null dereference crash 2016-11-15 12:02:31 -03:00
ariel-
9f5df023b7 Core/Unit: don't use damage immunity to calculate hit result for the whole spell. Should be used only for damage 2016-11-14 20:40:17 -03:00
ariel-
425f6c3c34 Core/Spell: perform charmer check against player controlling unit. Fixes spellcasts while charmed 2016-11-14 15:22:41 -03:00
ariel-
1ad9c7d3fd Core/Spell: fix typo 
Closes #18248
 2016-11-14 13:59:32 -03:00
ariel-
352c84943c Core/Unit: improved handling of some spell attributes 
- SPELL_ATTR1_UNAFFECTED_BY_SCHOOL_IMMUNE
- SPELL_ATTR2_UNAFFECTED_BY_AURA_SCHOOL_IMMUNE
- SPELL_ATTR3_IGNORE_HIT_RESULT
 2016-11-14 04:04:30 -03:00
ariel-
f060efbdb4 Core/Spell: fix typos 2016-11-14 04:02:43 -03:00
ariel-
20cdf1a830 Core/Utils: build fix 2016-11-14 02:36:33 -03:00
ariel-
3f1d020a2c Core/GameObject: use a friendly trigger for positive spells. 
Fixes an issue with Skadi Harpoons.

Note to self: should actually implement GameObject casting already :/
 2016-11-14 02:12:41 -03:00
ariel-
361b185ef7 Core/Scripts: add checks to Master's Call script 
Closes #8403
 2016-11-14 02:12:38 -03:00
ariel-
5daabe303e Core/Spell: do not fail triggered Charge effects in case a root is present. 
Fixes Master's call when pet is rooted
 2016-11-14 02:12:35 -03:00
ariel-
5aa0228df9 Core/Spell: Fix warrior Enrage stacking with Wrecking Crew and Imp. Defensive Stance 2016-11-14 02:12:33 -03:00
ariel-
b99ca19eea Core/Globals: Load spellspecific and aurastate after loading spell ranks 
Was breaking functionality (eg: stacking scroll auras)
 2016-11-14 02:12:19 -03:00
ariel-
fd3423245c Core/Spell: use SpellEntry to select implicit targets in case RadiusEntry wasn't set for the current effect. 
Closes #15388
 2016-11-14 02:06:33 -03:00
ariel-
fc6844173f Core/Spell: Fixed immunities for some spells (they were broken before rewrite too) 
- Warlord's Presence, Uncontrollable Frenzy, Free Friend
- Overload, Lightning Tendrils
- Fervor, Berserk
- Determination
 2016-11-14 02:06:30 -03:00
ariel-
699e22cb4c Core/Unit: consider creatures with same faction to be on the same party/raid for the purposes of spell/aura targets 
Ref #18233
 2016-11-14 02:06:18 -03:00
ariel-
aa21137aeb Core/SpellScript: allow optional parameters to be passed to FinishCast 
followup of 50a3ce5703
 2016-11-14 02:05:54 -03:00
ariel-
cbb5c073ce Core/ScriptMgr: use vector instead of list to contain Spell and Aura scripts and hooks 2016-11-14 02:05:51 -03:00
ariel-
58c5011499 Core/Battleground: Fix issue reported by static analysis 2016-11-14 02:05:48 -03:00
ariel-
c98ab6bd94 Core/Misc: codestyle fixes in GridNotifiers.h 
- Removed dead code, outdated comments
- Fixed indentation
- Explicitly delete copy ctors
- const'd the operator() definitions
 2016-11-13 19:13:10 -03:00
Keader
81edee5648 Core/Scripts: Cleanup in instance_black_temple and added missing datas (#18246) 
* Core/Scripts: Cleanup in instance_black_temple and added missing datas

* Fixed door timing issue

* Remove redundant call
 2016-11-13 20:23:52 +01:00
Shauren
08057b6d8b Core/Auras: Fixed removing auras triggered by aurastates 
Closes #17868

(cherry picked from commit f94e6cee38)
 2016-11-13 00:43:13 +01:00
ariel-
7943150dcb Core/Unit: misc codestyle 
use typedef for constant reference
 2016-11-12 18:12:26 -03:00
ariel-
3588ff894b Core/Spell: fix warning 2016-11-12 18:04:45 -03:00
ariel-
50a3ce5703 Core/Spell: revamp of immunities system 
- Spell attributes research
- Container optimization
- Do not skip damage immunity checks on SPELL_ATTR0_UNAFFECTED_BY_INVULNERABILITY present
- Added additonal arguments support to SendCastResult / CheckCast, spells can now send proper error messages
- Loads spell immune masks/states/effects at startup.
- This cached info is used whenever a spell cast requires immunities to be known beforehand (to see if an aura could be applied for example)

Closes #16658
Closes #16901
Closes #18114
 2016-11-12 17:58:00 -03:00
ariel-
5cb8409f1e Core/Spell: move attribute helpers to spellInfo 
- Renamed CheckEffectExecuteData to AssertEffectExecuteData and made const, better reflects its purpose
- Added missing attribute check to IsNextMeleeSwingSpell
- Reworked SPELL_ATTR4_CAST_ONLY_IN_OUTLAND attr check (researched behavior)
 2016-11-12 17:12:42 -03:00
Chaosvex
ed2cd6b34f Core/Auth: Resolved authentication bypass 2016-11-10 23:00:58 +01:00
Keader
c4dd6d1676 Core/Scripts: Fixed a typo and removed randtime of Shade of Akama events (#18231) 2016-11-10 13:00:57 -03:00
ariel-
70a867531d Core/SpellMgr: overwrite dbc range for Unleashed Souls 
Closes #17968

By sirikfoll
 2016-11-09 00:58:46 -03:00
ariel-
bb8763534e Core/Spell: reimplemented TRIGGERED_DISALLOW_PROC_EVENTS trigger flag 
Triggered spells shouldn't chain-trigger other spells

Closes #18217
 2016-11-09 00:39:49 -03:00
ariel-
44ea63e34d Core/Entities: add yet another utility overload to CastSpell, fixes AppVeyor build 
Ninja NULL->nullptr cleanup
 2016-11-08 00:08:11 -03:00
ariel-
ed49626c22 Core/Spell: fix interaction of on taken damage procs with triggered casts 
DB/Spell: Seal of Righteousness proc
- Lightining and Water Shield should proc with triggered

Closes #18211
 2016-11-07 23:50:18 -03:00
ariel-
85143f305d Core/Spell: make a distinction between triggered flags with debugging purposes, and don't use them when casting triggered spells 
Fixes #9721 (also other spells affected, example Threat of Thassarian, Stormstrike)
 2016-11-07 20:36:23 -03:00
ariel-
1ae3da101c Core/Gameobject: remove immune flags from trigger used to cast GO spells 
Spells were failing flags check in Unit::_IsValidAttackTarget

Closes #18206
 2016-11-07 13:34:04 -03:00
ariel-
555fe2fe5b Core/SpellMgr: add some trap effect range overrides 
Ref #18206
 2016-11-07 13:31:40 -03:00
ariel-
2e457b3be4 Core/Spells: do not add PROC_HIT_NORMAL/PROC_HIT_CRITICAL flags if damage is fully nullified 
- Aka: full absorbs/full resists/full blocks/immune
 2016-11-05 01:52:38 -03:00
ariel-
4f1ef6985e Core/Spell: apply SPELLFAMILY_GENERIC mods to all spells by default 
Closes #18160
 2016-11-04 14:22:27 -03:00
Richard
f5d3343f27 [3.3.5] Core/Loot: Fix conditional Master Loot (#17943) 
* Core/Loot: Fix master looting of conditional items

follow_loot_rules was a flag intended to force certain quest items to be
master looted. It should not be used for the
NonQuestNonFFAConditionalLoot.

The flag was originally introduced in 869ea349
"Core/Loot: fix the way quest items are handled. so far ive only found 3
quest items that should be able to be masterlooted. added a new flag to
item_template.flagsCustom to allow for making a quest item always follow
loot rules. a bonus may be the fix of the handlelootmasteropcode crash!"

* Core/Loot: Rename QuestItem to NotNormalItem

QuestItem struct was being used for quest items, ffa items, and
conditional items. Renaming it to avoid confusion when working with ffa
and conditional items

* Core/Loot: Use existing AddAllowedLooter rather than reaching into allowedGUIDs directly

* Core/Loot: Rename NotNormalItem to NotNormalLootItem
 2016-11-04 12:20:47 +01:00
ariel-
6214c7181d Core/Player: fix static analysis issue 2016-11-03 23:47:06 -03:00
ariel-
7a79443281 Core/SpellMgr: static analysis checks 2016-11-03 22:42:34 -03:00
treeston
aeb5762170 Core/Creature: Correctly reset pathfinding capability on respawn. Prevents evade chains on some bosses. Closes #18188. 2016-11-03 13:55:30 +01:00
ariel-
ca1a050e8a Core/Globals: normalize DBC data for Maelstrom Weapon ranks 2016-11-03 03:06:23 -03:00
tkrokli
2b26894eb1 Core/Scripts: Archmage Arugal event script (#17922) 
Implement boss script for Archmage Arugal
- add yells used in boss event to DB
- use proper spells instead of only melee fighting
- add DataType in shadowfang_keep.h
- add event scheduling in the script

By Riztazz
Closes issue #17916
 2016-11-03 06:50:03 +01:00
SnapperRy
a38c094a11 Core/GameObject: spawn linked traps at gameobject creation instead of using DB spawns. (#18172) 
Closes #11328.
 2016-11-01 22:24:03 +01:00
Dr-J
1fc8e2d5f2 Remove reference to eastern plaguelands script 2016-11-01 13:10:16 +00:00
Dr-J
9be0362606 Remove obsolete file 2016-11-01 12:59:18 +00:00
jackpoz
189edc0f23 Shared/Metric: Initial support for tag value escaping 
Fix #18175
 2016-10-31 20:34:22 +01:00
ariel-
697147a596 Core/Auras: fix elixir aura saving 2016-10-30 15:20:54 -03:00