Commit Graph

27829 Commits

Author SHA1 Message Date
ccrs
b74264aef4 Core/Creature: IsMovementPreventedByCasting followup
Handle correctly move allowed channels: IsChannelActive checks if channel phase has started (after cast if any)
Must skip the other checks since all channels focus target.

ref #19532
2017-05-02 11:43:50 +02:00
tkrokli
cf8380a3a7 Fix missed apostrophe in previous commit
- beasts -> beast's
2017-05-02 02:16:16 +02:00
tkrokli
f6a4065f5e DB/Quests: minor correction in A Husband's Last Battle (6162)
Replacing the word 'head' with 'claw' in the quest progress gossip.
Check quest item 15879, it is a claw, not a head (obviously).

http://www.wowhead.com/item=15879/overlord-rors-claw
http://www.wowhead.com/quest=6162/deprecated-a-husbands-last-battle
2017-05-02 02:12:06 +02:00
ariel-
aa0b7dd152 Core/Misc: build fixes 2017-05-01 18:52:15 -03:00
ariel-
f913f3bb89 Core/Scripts: unified scripted gossip/quest api
- Changed self-accessor on GameObjectAI to "me", like UnitAI
- Moved all related functions to AI, now Unit and GameObject have the same function names with identical behaviour
- Remove "OnUpdate" from CreatureScript/GameObjectScript, was never used and we already have AI Update method
- Quest methods no longer return a bool, the return value was used to call the AI version if the ScriptMgr one returned false
- Implemented GameObjectAI::Destroyed hook (was never called), implemented Damaged method
- Rename OnStateChanged to OnLootStateChanged to reflect when it's really called, and created a new hook OnStateChanged that only gets called on GOState change
- Since the functions are now only getting called from AI, made GetAI methods full virtual. (CanSpawn method is anyways going to be used on creatures with AI)
2017-05-01 18:19:36 -03:00
tkrokli
e4481c016a DB/Quests: remove wrong $C in quest completion text (2284)
- Quest reward text should not change depending on player class.
- Quest: Necklace Recovery, Take 2 (ID 2284)
- NPC: Remains of a Paladin (entry 6912)

http://www.wowhead.com/quest=2284/necklace-recovery-take-2
2017-05-01 22:03:57 +02:00
tkrokli
a8f7c55d34 DB/Gossip: fix bad update in 2017_04_30_00_world_335.sql
* Properly remove text0_1 content from npc_text ID 16432

Ref. commit 88413de9d8

Ref. issue #19527
(DB/Gossip: npc_text contains "MISSING TEXT" and missing info in 48 rows)
2017-04-30 19:19:19 +02:00
tkrokli
9d3810c3c8 DB/Gossip: update npc_text info for Ravenholdt Guards
- all the information is available in broadcast_text
- npc_text updated both for ID 5934 and 5935
2017-04-30 11:03:44 +02:00
tkrokli
88413de9d8 Update 2017_04_30_00_world_335.sql
- remove BroadcastTextID0 for Jangdor Swiftstrider's gossip
- insert only text0_0 because NPC is a male
2017-04-30 08:23:31 +02:00
tkrokli
d4d85c764f DB/Gossip: update npc_text info for 3 NPCs
- set correct gossip_menu.text_id for Jangdor Swiftstrider
- add missing text for Terl Arakor and Griniblix the Spectator

* Thanks to MaNGOS Zero / billy1arm for providing the right clues.

Updates #19527
2017-04-30 07:50:40 +02:00
ariel-
231ec8331b Core/Entities: moved PetAura handling to Player where it belongs 2017-04-28 19:12:48 -03:00
ariel-
b6b59f6c23 Core/Scripts: remove OnDummyEffect hook/sOnDummyEffect ai hook
- Duplicated logic never used, sometimes only ScriptMgr version was called, sometimes only AI
- They only encourage bad scripting practices
- You can still use OnSpellHit or a SpellScript
2017-04-28 18:59:14 -03:00
ariel-
4c4dca6d69 Core/Misc: camelize GetFaction/SetFaction properly 2017-04-28 18:37:38 -03:00
Killyana
5a3a9381e4 DB/Creature: Add some missing spawns to Naxxanar area 2017-04-28 17:50:30 +02:00
ccrs
5a2f0ce29e Core/Unit: revert 3ea46e57af
After discussion we realized, ariel and me, that Creature and Unit IsMovementPreventedByCasting() have not the same checks (order matters)
2017-04-27 19:40:23 +02:00
Killyana
67a6e61908 DB: New line 2017-04-27 19:27:17 +02:00
Killyana
01d9df27d5 DB: Some Pathing on Coldarra area 2017-04-27 19:24:42 +02:00
ariel-
553103963f DB/Spell: fix Glyph of Shadow proc
- Fixes not proccing with Imp. Devouring Plague/Mind Flay/Mind Sear
2017-04-27 12:52:50 -03:00
ariel-
3ea46e57af Core/Unit: 229444b74a follow-up
- IsFocusing is made virtual again, so there's no need to keep a duplicated function

This reverts commit 5043639c56.
2017-04-27 11:00:01 -03:00
ccrs
229444b74a Core/Misc: cleanup SetInFront uses
Set in front modifies only the serverside orientation, use with care.
Also check for current focus to prevent things like incorrect damage on casting creatures (ie dragon breath direction change in your face because of some taunt missclick)
2017-04-27 15:34:01 +02:00
ccrs
c7a57e2a09 Core/Unit: 2170541a51 followup
use true as default value since pretty much all the script calls will expect that
2017-04-27 14:55:06 +02:00
Keader
4431a1149d Core/Scripts: Re-hack Boss Loken. Followup 3a0cb90ea9
Loken still need ClearUnitState Hack to DoMeleeAttackifReady work
2017-04-27 09:41:07 -03:00
ccrs
df96e053a5 Core/Spell: move creature focus
bellow the possible interruptions
2017-04-27 14:16:40 +02:00
ccrs
5fc366d03b Core/CreatureAI: b6b0353bff followup 2017-04-27 14:00:57 +02:00
ccrs
5043639c56 Core/Misc: 522f537048 followup 2017-04-27 13:53:18 +02:00
ccrs
aa86dfddca Core/Petition: add missing increment on RemovePetitionsByOwnerAndType iteration 2017-04-27 13:29:51 +02:00
xinef1
e30e11d4c7 Core/Spells: Corrected aura SPELL_AURA_MOD_CASTING_SPEED_NOT_STACK handling for auras with very high values (#19054) 2017-04-27 03:34:43 -03:00
xinef1
a4aa95a5a3 Core/Misc: implemented petition manager (#19010)
- Implemented manager for petitions to perform all petition related tasks and synchronize data with database.
- This kills ugly synchronous querys on packet handlers
2017-04-27 02:02:33 -03:00
ariel-
a82a12b5ef Core/Player: don't check quest requirements against RewardNextQuest
- This field is only used to propose a new quest to player after completion, shouldn't be used to condition current quest

Closes #19515
2017-04-27 00:23:32 -03:00
tkrokli
4477b49330 DB/Quests: fix Guarded Thunderbrew Barrel / Distracting Jarven
* Neither 308 nor 403 are typical "quests in a quest"
  for which a negative PrevQuestID would be required.
  The whole thing is controlled by conditions now,
  rather than simple quest chaining - and this is blizzlike.

Closes #10626
2017-04-27 04:12:12 +02:00
ariel-
6892404b27 Core/AI: some tweaks on boundary functionality:
- Moved SetBoundary to public scope to allow for greater flexibility (ie set from external script)
- Extended to allow checking inverted boundaries
2017-04-26 04:20:38 -03:00
ariel-
3a2ecaa05f Core/AI: added a function to allow 0 damage attacks (sparring) depending on target 2017-04-26 04:16:32 -03:00
jackpoz
486b032343 Core/Misc: Fix static analysis issues 2017-04-25 17:33:53 +02:00
Keader
3194d089cb Core/Scripts: Added a missing break in Illidan Stormrage script
Thanks Jackpoz
2017-04-25 11:46:38 -03:00
jackpoz
65aeeafad3 Core/Misc: Fix static analysis issues 2017-04-25 14:27:53 +02:00
ariel-
85076dd799 Core/Scripts: fix gaseous bloat proc (again)
- UNIT_STATE_CASTING removal not needed for movement now, but it's needed for melee attacking
2017-04-25 02:57:58 -03:00
ariel-
157e9311c4 Core/Quests: implemented MSG_QUEST_PUSH_RESULT notifications
- Allow to share already completed (but not rewarded) quests, restriction was unblizzlike

thanks Cannix for the heads up
2017-04-24 16:34:50 -03:00
Killyana
4c09b8a02f DB/Creature: Caer darrow area
Closes #19256
By Rushor, cala
2017-04-24 20:59:36 +02:00
Killyana
2885dc92d0 DB/Gossip: Maddix and Alieshor
Updates #19432
2017-04-24 19:02:22 +02:00
Xyventh
c423b37143 DB/Gossip: Apprentice Shatharia and Magister Quallestis
Closes #19509
2017-04-24 18:56:08 +02:00
Xyventh
beceb0a83f DB/Creature: Hargin Mundar
Closes #19508
2017-04-24 18:48:41 +02:00
Xyventh
6a20861af2 DB/Quest: The Prodigal Lich Returns, end event
Closes #19507
2017-04-24 18:14:09 +02:00
Xyventh
caed8b43c8 DB/Creature: R-3D0
Closes #19506
2017-04-24 17:33:54 +02:00
Xyventh
7559d837b9 DB: RP event for Dame Auriferous, High Executor Mavren, Advisor Valwyn and Deathstalker Maltendis
Closes #19503
2017-04-24 17:23:15 +02:00
Xyventh
95ef739012 DB/Gossip: Add Missing gossip texts for some NPCs in Sunstrider Isle
Closes #19501
2017-04-24 16:38:17 +02:00
Keader
136f1e75aa Core/Scripts: Fix a typo in Blood Prince Council
Thanks ariel-
2017-04-24 08:48:34 -03:00
xinef1
cbbb745246 Various quest system fixes (seasonal quests, timed quests and more) (#18940)
- Unify quest status checking function, use dedicated function instead of direct map checks
- Fixed seasonal quest chains and ability to complete the same quests rewarded in past
- Update area dependent auras on quest status change (they often requires specific quest status)
- Send all not stored quest rewards by mail
- When casting quest reward spell, check if it is not self casted, if so - use player to cast this spell
- Perform full db save on quest reward to prevent data desynchronization
- Don't allow to fail completed timed quests, except for quests which are completed right from the start
- Don't allow to share pooled quests, if they are not available in the current pool (eg sharing easy dalaran weeklies, stored at alt character)
- Remove seasonal quest if rewarded quest is removed
- Don't complete whole quest on AreaExplore event, check if there are no more requirements that should be fulfilled
- Quests with flag QUEST_SPECIAL_FLAGS_PLAYER_KILL can be only credited in quest zone

Closes #18913
Closes #11187
Closes #15279
2017-04-24 00:46:06 -03:00
ariel-
522f537048 Core/Movement: allow focused spells to not break movement if it's movement allowed spell
- Core/Unit: made IsFocusing virtual

Thanks to ccrs for suggestion
2017-04-23 21:48:07 -03:00
ariel-
1f4439ece4 Core/Spell: don't make creature change orientation to 0 if channeling self 2017-04-23 21:48:06 -03:00
ariel-
3a0cb90ea9 Core/Spell: define channels without movement interrupt flags as allowed move
- Remove script hacks no longer needed
2017-04-23 21:48:06 -03:00