Commit Graph

33116 Commits

Author SHA1 Message Date
Shauren
bbcf00257e Core/Spells: Fix summoning warlock pets in case that pet has never been summoned before 2020-08-17 11:52:44 +02:00
Shauren
9c5876d8ab Core/Spells: Fix summoning SUMMON_PET type pets
Closes #25265
2020-08-17 09:19:43 +02:00
illfated
a9d493c456 DB/Text: Add correct text to Sylvanas (Lament of the Highborne)
Closes #25262
2020-08-17 03:57:18 +03:00
offl
e084d9e37a DB/Areatrigger: Add correct teleport positions from world safe locs to more areatriggers 2020-08-17 03:57:00 +03:00
Treeston
ffc3e355fe Core/ChatCommands: Move Trinity::ChatCommands::Variant from boost::variant to std::variant (for real this time) 2020-08-17 02:23:38 +02:00
Treeston
7bceff1b2a revert 1aeb7a0 and f9e7dbd until I can work around GCC being silly 2020-08-17 01:05:09 +02:00
Treeston
1aeb7a0980 How did this even build in VS???? (don't kill me shauren) (f9e7dbd follow-up) 2020-08-17 00:55:19 +02:00
Treeston
f9e7dbd8b4 Core/ChatCommands: Move Trinity::ChatCommands::Variant from boost::variant to std::variant, which means we no longer need visitors 2020-08-17 00:49:07 +02:00
Peter Keresztes Schmidt
30a825e2ac Core/ChatCommands: Add support for std::array-type arguments (#25261) 2020-08-17 00:15:53 +02:00
offl
68557e9ca3 DB/Gameobject: Remove gameobjects with negative respawn time from dynamic scaling spawn group 2020-08-16 23:38:39 +03:00
offl
c5b303ef56 DB/Areatrigger: Add correct teleport positions from world safe locs to some areatriggers 2020-08-16 23:37:59 +03:00
offl
aae38bec11 DB/SAI: Remove SMARTCAST_INTERRUPT_PREVIOUS from nearly all scripts
No longer needed after ca25e8d019

Explained in https://github.com/TrinityCore/TrinityCore/issues/24914

Some event types not affected because requires tests, events with No Repeat event flag skipped
2020-08-16 23:37:05 +03:00
offl
e8e3626073 DB/Creature: Add missing cosmetic channeled spell in Ahn'kahet
Closes #12024
2020-08-16 23:36:29 +03:00
Cerveciento
6bd104e0aa DB/Locale esES+esMX Texts missing in quets (Part 20)
Closes #25250
2020-08-16 23:36:03 +03:00
Shauren
5c1fc5e387 Core/Pets: Pet management refactoring (#25191)
* Core/Pets: Pet management refactoring

* Preload basic pet data on character login with async query
* Load additional pet data (declined names/auras/spells/cooldowns) using async query after we are sure pet loading will succeed
* Remove all select queries related to pet stable/unstable
* Remove all silent pet deletions except explicit UI-triggered abandons
* Fixed displaying stable master content when current pet is not summoned
* Allow to stable/swap unsummoned current pet

Closes #3610
Closes #21266
2020-08-16 21:39:25 +02:00
Peter Keresztes Schmidt
7edad0d601 Core/ChatCommands: Do not parse partial strings for numeric paramters (PR #25259)
Check if integral/floating point type arguments were parsed successfully.

std::stoull will happily parse floating point strings until the decimal separator and return the value.
Make sure for all parsing methods that we actually parsed the whole token.

This allows to use handler arguments like Variant<uint32, float> which will be populated with the right type
depending on the token value (e.g "10" vs "10.0").
2020-08-16 21:32:31 +02:00
Giacomo Pozzoni
ca25e8d019 Core/SAI: Spell casts that cannot be executed because the unit is currently casting another spell will be retried asap with priority over other events (#25238)
* Core/SAI: Spell casts that cannot be executed because the unit is currently casting another spell will be retried asap with priority over other events

* Core/SAI: Re-sort the events only when needed

* Fix some priority reset and wrong mEventSortingRequired handling

* Code cleanup.
Sort only events loaded from db (not stored events, not timed action list).

* Code cleanup.
Raise priority of failed casts so they are retried before other spells

* Keep priority of the action fails and is rescheduled on next update

* Don't try recasting a spell in SMART_ACTION_CAST if there are multiple targets and at least 1 was successful
2020-08-16 16:50:04 +02:00
Peter Keresztes Schmidt
df29f60595 Core/ChatCommands: Honor exact matches during enum arg parsing (PR #25255) 2020-08-16 16:27:19 +02:00
Peter Keresztes Schmidt
86dc58974a Scripts/Commands: Use enum type arg for HandleDebugAnimCommand (PR #25256)
* Core/Shared: Make Emote enum smart
* Scripts/Commands: Use enum type arg for HandleDebugAnimCommand
2020-08-16 16:26:47 +02:00
Treeston
b74dc4754d Core/DB: Move every gameobject that uses the spawntimesecs < 0 hack into the legacy spawn group 2020-08-16 16:02:26 +02:00
scizzydo
4125a81bb1 Core/Warden: Fix for LUA_STR_CHECK (#25247)
The check above is what I use to actually get a real result for LUA_STR_CHECK, which when I used variables that would have a string to them it actually fails the check. When checking for items like a function if it exists of course it won't work... In addition, fixing the Unk2 to Unk3 causes people to be able to adjust the address of the check to the address 0x00419210 to make warden perform the FrameScript__Execute to run lua on the client. This seems to be the big request like in https://github.com/TrinityCore/TrinityCore/issues/23035
2020-08-16 14:50:08 +02:00
Peter Keresztes Schmidt
5e40eb20e2 Core/ChatCommands: Add support for enum type arguments (PR #25242) 2020-08-16 14:11:21 +02:00
Peter Keresztes Schmidt
6c7837f947 Core/Unit: Make HandleEmoteCommand typesafe (#25249)
* Scripts/ScarletMonastery: Fix wrong emote during Headless Horseman encounter

* Scripts/HoR: Fix wrong emote during escape event

* Core/Unit: Make improve type safety of HandleEmoteCommand

Change argument type to the expected enum type Emote

* Scripts/CoS: Use SetUInt32Value to set UNIT_NPC_EMOTESTATE

UNIT_NPC_EMOTESTATE is no flag field
2020-08-15 15:29:43 +02:00
Peter Keresztes Schmidt
34d403e83f Core/Spells: Mark constructors of Spell/AuraScript handlers as explicit (#25248)
Mostly to make clang-tidy happier
2020-08-15 13:50:26 +02:00
Peter Keresztes Schmidt
87211d9f4d Core/PacketIO: Update SMSG_QUESTGIVER_QUEST_DETAILS (#25232)
* Core/PacketIO: Update SMSG_QUESTGIVER_QUEST_DETAILS

* Core/PacketIO: Name RewardFactionFlags field of QuestInfo struct
2020-08-15 13:25:23 +02:00
TDB Release
43986954fd TDB 335.20081 - 2020/08/15 TDB335.20081 2020-08-15 09:37:46 +00:00
Aokromes
681c738c61 Script/Quest: The Light of Dawn (#25243)
remove incorrect check, source:
https://www.wowhead.com/spell=53606/the-light-of-dawn
Flags	
Can be used while dead

https://www.wowhead.com/quest=12801/the-light-of-dawn#comments:id=1495830
https://www.wowhead.com/quest=12801/the-light-of-dawn#comments:id=374127
2020-08-15 11:10:47 +02:00
offl
ee6d6426fa DB/Misc: Add correct teleport positions to one areatrigger and some spells from sniffs 2020-08-15 02:19:28 +03:00
Rushor
40e4777831 DB/Creature: Add script & waypoints to Warden Treelos
Closes #13055
2020-08-15 02:19:01 +03:00
offl
9d11c25e18 DB/Creature: Add CREATURE_FLAG_EXTRA_NO_COMBAT to Toxic Tunnel (Naxxramas)
Closes #16490
2020-08-15 02:18:33 +03:00
offl
49e40f48c9 DB/Quest: The Missing Diplomat (Part 16): Make Private Hendel act more correctly and fix script stuck
Closes #25244
2020-08-15 02:18:08 +03:00
Cerveciento
afd2146ad2 DB/Locale/esES+esMX Texts missing in quests (Part 19)
Closes #25245
2020-08-15 02:17:36 +03:00
Cerveciento
e9a1f747fc DB/Locale/esES+esMX Texts missing in quests (Part 18)
Closes #25241
2020-08-15 02:17:02 +03:00
Giacomo Pozzoni
298d799485 Core/AI: Remove code that removed UNIT_DYNFLAG_LOOTABLE from possessed units (#25229)
* Core/AI: Remove code that removed UNIT_DYNFLAG_LOOTABLE from possessed units

* Update PassiveAI.cpp

Restored logic that removes loot flag while being possessed

* Restored logic that removes loot flag while being possessed
2020-08-13 21:12:37 +02:00
offl
dc7691a549 DB/Quest: Update support for 'The Plains of Nasam' (11652)
Closes #23695
2020-08-13 15:52:37 +03:00
offl
2b8f314183 DB/Creature: Remove some wrong spawns
Ref #23791
2020-08-13 15:52:15 +03:00
offl
4c4e3b956f DB/Creature: Fix gold value for world bosses
Source d10a189755
2020-08-12 21:57:11 +03:00
Cerveciento
5188f723b4 DB/Locale/esES+esMX Texts missing in quests (Part 17)
Closes #25240
2020-08-12 21:22:03 +03:00
Cerveciento
870e754998 DB/Locale/esES+esMX Texts missing in quests (Part 16)
Closes #25237
2020-08-12 21:21:40 +03:00
offl
8ed3efd820 DB/Creature: Fix gold value for TBC raid bosses
Closes #19262
2020-08-12 21:20:53 +03:00
Gildor
7035a9caf1 Scripts/Naxxramas: Adjust Frogger event timer (#25214)
* Scripts/Naxxramas: Adjust Frogger event timer

Co-authored-by: Carbenium <carbenium@outlook.com>
2020-08-12 17:24:41 +02:00
Rothend
a375f15ae2 Script/Quest: fix (More) Torch Catching (#24907)
* Script/Quest: fix (More) Torch Catching.

Closes #24893

Co-authored-by: Carbenium <carbenium@outlook.com>
2020-08-12 13:40:28 +02:00
Treeston
6116e5b385 Core/Warden: Warden refactors (PR #25235) 2020-08-11 18:04:36 +02:00
offl
cce1ccdd5c DB/Locale: Add missing esMX quest locales
Copied from already added esES locales since they're almost always similar
2020-08-11 00:38:36 +03:00
Cerveciento
ca9ce8a70b DB/Locale/esES+esMX Texts missing in quests (Part 15)
Closes #25234
2020-08-10 23:42:56 +03:00
dr-j
be8affa5be DB/Creature: Sindragosa's Fall Wyrm Reanimator/Frost Brood Spawn events
Closes #25231
2020-08-10 23:42:36 +03:00
offl
8a9cc0f65d DB/Gameobject: Remove signs from Menethil's signpost
Closes #25046

Both signs were removed in WotLK
2020-08-10 15:31:57 +03:00
Cerveciento
b8f21d4540 DB/Locale/esES+esMX Texts missing in quests (Part 14)
Closes #25228
2020-08-10 03:40:39 +03:00
offl
2ff51396c0 DB/SAI: Rework support for corrupted & cleansed plants from Felwood
Closes #4960
2020-08-10 03:40:17 +03:00
Giacomo Pozzoni
63a6e1e048 Core/SAI: Fix creatures casting with flag SMARTCAST_COMBAT_MOVE not switching to melee when the school of the spell they are trying to cast gets silenced (and other cases of spell failure) (#25226)
* Core/SAI: Fix creatures casting with flag SMARTCAST_COMBAT_MOVE not switching to melee when the school of the spell they are trying to cast gets silenced (and other cases of spell failure)

* Core/SAI: Retry casting after 500ms if a cast failed

Fixes #24914
2020-08-09 21:24:15 +02:00