Treeston
bce43de7f3
Core/AI: Some more refactoring prep for #19930 . CreatureAI::EnterCombat is now called CreatureAI::JustEngagedWith. There's also two new methods on UnitAI, though they're never invoked right now.
...
(cherry picked from commit 6113b9dec2 )
2021-04-16 20:22:13 +02:00
Treeston
9b141207d1
[3.3.5] CastSpell unclusterfucking (that's a word now) ( #21123 )
...
Core/Spell: The giant CastSpell unclusterfucking (that's a word now) of this generation.
- CastSpell now always takes three arguments - target, spellId, and a struct containing extra arguments
- This struct (CastSpellExtraArgs, see SpellDefines.h) serves as a conglomerate of every previous combination of the 20 billion different CastSpell overloads, all merged into one
- It has some great utility constructors - check them out! All of these can be used to implicitly construct the ExtraArgs object.
- A gajillion refactors to make everything behave the way it always has
(cherry picked from commit d507a7e338 )
2021-04-16 15:22:42 +02:00
Jeremy
446fc391f0
Core/Entities: Fix some weird movement due to los issues ( #21125 )
...
* Core/Entities: Fix some weird movement due to los issues
- Made LoS check use collisionHeight instead of midsection. Value was too low.
- Gnomes will now have a breath bar more quickly than for example a tauren.
- Changes have been made to checking for ground z as well, some tweeking might be needed but removed most of the scattered +2.0f/+0.5f/we
* Add 0.05f to isInAir check in Creature::UpdateMovementFlags
(cherry picked from commit e42903ec16 )
2021-04-15 05:53:27 +02:00
ariel-
61585de8ae
Core/Scripts: fix codestyle
...
(cherry picked from commit e2a97ba7e7 )
2021-04-15 05:53:27 +02:00
Keader
6c2d0d709a
Core/Scripts: Val'anyr Hammer of Ancient Kings should proc only with effective heal
...
(cherry picked from commit 502864e86c )
2021-04-15 05:53:27 +02:00
ariel-
313b2ff526
Core/Scripts: remove Quel'Delar from player inventory during "The Halls Of Reflection" quests (24480, 24561)
...
(cherry picked from commit d13999c8d6 )
2021-04-15 05:53:27 +02:00
ariel-
cfa8474520
Core/Scripts: prevent Arthas in CoS losing his gossip flag and halting instance progress
...
(cherry picked from commit 720ba9e973 )
2021-04-15 05:53:27 +02:00
ariel-
f8729f9aa0
Core/Scripts: fixed Festergut applying more than one stack of Inoculated at once
...
(cherry picked from commit c409ba8d9d )
2021-04-15 05:53:27 +02:00
Keader
a7883380ce
Core/AI: Making guid const& in SetGUID method ( #21128 )
...
(cherry picked from commit 465b43fabe )
2021-04-15 05:53:27 +02:00
jackpoz
8244d60859
Core/Misc: Fix static analysis issues
...
(cherry picked from commit ad56299846 )
2021-04-15 05:53:27 +02:00
jackpoz
0a528a525b
Scripts/Trial of Crusader: Fix static analysis issues
...
(cherry picked from commit cbc7642edd )
2021-04-15 05:53:27 +02:00
jackpoz
e17e4e6f07
Core/Misc: Replace time(NULL) with GameTime::GetGameTime()
...
(cherry picked from commit 12701cb0c6 )
Conflicts:
src/server/game/Achievements/AchievementMgr.cpp
src/server/game/AuctionHouse/AuctionHouseMgr.cpp
src/server/game/AuctionHouseBot/AuctionHouseBotBuyer.cpp
src/server/game/AuctionHouseBot/AuctionHouseBotSeller.cpp
src/server/game/Battlefield/Battlefield.cpp
src/server/game/Battlefield/Zones/BattlefieldWG.cpp
src/server/game/Battlegrounds/BattlegroundMgr.cpp
src/server/game/Calendar/CalendarMgr.h
src/server/game/DungeonFinding/LFGQueue.cpp
src/server/game/Entities/Corpse/Corpse.cpp
src/server/game/Entities/Creature/Creature.cpp
src/server/game/Entities/Item/Item.cpp
src/server/game/Entities/Pet/Pet.cpp
src/server/game/Entities/Player/Player.cpp
src/server/game/Entities/Unit/Unit.cpp
src/server/game/Globals/ObjectMgr.cpp
src/server/game/Grids/ObjectGridLoader.cpp
src/server/game/Guilds/Guild.cpp
src/server/game/Handlers/AuctionHouseHandler.cpp
src/server/game/Handlers/BattlefieldHandler.cpp
src/server/game/Handlers/CalendarHandler.cpp
src/server/game/Handlers/CharacterHandler.cpp
src/server/game/Handlers/ChatHandler.cpp
src/server/game/Handlers/LFGHandler.cpp
src/server/game/Handlers/MailHandler.cpp
src/server/game/Handlers/MiscHandler.cpp
src/server/game/Handlers/MovementHandler.cpp
src/server/game/Handlers/PetHandler.cpp
src/server/game/Handlers/QueryHandler.cpp
src/server/game/Handlers/TicketHandler.cpp
src/server/game/Instances/InstanceSaveMgr.cpp
src/server/game/Server/WorldSession.cpp
src/server/game/Server/WorldSocket.cpp
src/server/game/Spells/Auras/SpellAuras.cpp
src/server/game/Tickets/TicketMgr.cpp
src/server/game/Tickets/TicketMgr.h
src/server/game/World/World.cpp
src/server/scripts/Commands/cs_gobject.cpp
src/server/scripts/Commands/cs_instance.cpp
src/server/scripts/Commands/cs_list.cpp
src/server/scripts/Northrend/zone_wintergrasp.cpp
src/server/scripts/Spells/spell_item.cpp
2021-04-15 05:53:27 +02:00
Keader
a5635526ed
Scripts/Trial of Crusader: Northrend Beasts Rework ( #21031 )
...
* Rewritten Gormok encounter
* Rewritten Snobold Vassal Script
* Rewritten Jormungars encounter
* Rewritten Icehowl encounter
* Added missing texts
* Added missing spells
* Implemented berserk mechanic on heroic diffs.
* Implemented Achievement requirement to make heroic diffs.
* Rewritten Barrett Ramsay scripts
* Added Barrett gossips and ported everything to DB.
* Added right Barrett in each encounter
* Removed a lot of hacks
* Rewritten Tirion Fordring script
* Rewritten Varian Wrynn script
* Rewritten Garrosh script
* Rewritten Wilfred event
* Rewritten Lich King event
* Updated codestyle
* Added missing spawns
* Fixed combat behavior before Gormok
* Fixed some visual stuff
(cherry picked from commit 2362e9c794 )
2021-04-15 05:53:27 +02:00
Killyana
eba8916ca2
Typo
...
(cherry picked from commit b08280fcfe )
2021-04-15 05:53:27 +02:00
Killyana
2e828b4026
Scripts/Stratholme: Fix a DB error
...
Ref #20749
(cherry picked from commit be56a4669e )
2021-04-15 05:53:27 +02:00
jackpoz
bddd58d469
Scripts/Stratholme: Add missing header for no-pch build
...
(cherry picked from commit 9a515c29ba )
2021-04-15 05:53:27 +02:00
jackpoz
cf04609c9a
Scripts/Stratholme: Fix build
...
(cherry picked from commit 828c5d08e7 )
2021-04-15 05:53:27 +02:00
jackpoz
b99654924c
Scripts/Stratholme: Fix build
...
(cherry picked from commit a98b2aa8c8 )
2021-04-15 05:53:27 +02:00
Riztazz
d01914ffcc
Scripts/Stratholme: Few changes to how Ysida behaves during the Baron run ( #20749 )
...
(cherry picked from commit 2a25d9d9a7 )
2021-04-15 05:53:27 +02:00
ariel-
16ec008290
Core/Spells: fix some DB errors
...
Ref #18542
- Implemented Choking Vines transformation at 5 stacks
- Implemented periodic Aura of Fear ticks
- Fixed Savage Rend passive proccing on anything (raptor pets)
(cherry picked from commit de9f904269 )
(cherry picked from commit 32e2207ab9 )
(cherry picked from commit 9934a43e09 )
2021-04-15 05:53:27 +02:00
Keader
bd62bfc059
Scripts/Naxxramas: Fixed blizzards following same player in Sapphiron encounter ( #21068 )
...
Closes #18765
(cherry picked from commit 143b2aeac0 )
2021-04-15 05:53:27 +02:00
Andrew Letson
dbd9f88bf0
Scripts/Commands: Add failure state for quest remove ( #20611 )
...
Add more verbose messaging to the .quest remove command
(cherry picked from commit 1cedcf0bf3 )
2021-04-15 05:53:27 +02:00
Matan Shukry
079bc7800e
Core/Cheats: Power - set max power on all powers initially + on regenerate ( #26235 )
2021-04-13 19:05:36 +02:00
Shauren
38ad6c2cf0
Scripts/Spells: Removed facing requirements from penance healing component
2021-04-12 22:34:10 +02:00
Matan Shukry
d2b70397ab
Spells/Scripts: Updated Gift of the Naaru script
...
Closes #22468
2021-04-12 22:32:53 +02:00
Shauren
e858dd16ef
Core: Fix linking with gcc 8.3
2021-04-12 12:24:28 +02:00
Matan Shukry
cf3ea20825
Core/Spells: Fixed multiple druid's spells ( #26223 )
...
* Tooth And Claw proc correctly (was incorrect attribute)
* Tiger Dash will now transform to cat
* Travelform doesn't require learning riding skill
* Aquatic Form only useable if player has the spell (passive at level 17)
* Doesn't allow stag form inside water
* Bristling Fur will generate rage based on max rage
* Now also removing prowl when cat form is removed
2021-04-11 21:16:41 +02:00
Matan Shukry
b92e20f6c8
Script/Spells: shaman spell fixes ( #26192 )
...
* Flametongue Weapon
* Tremor Totem
* Healing Stream Totem
* Liquid Magma Totem
* Healing Rain
2021-04-11 19:23:19 +02:00
Shauren
d29dd1eeb5
Core/Misc: Change all unix time columns in character database to bigint (signed)
2021-04-05 23:47:05 +02:00
Shauren
33b3ebcae6
Core/Objects: Pass privateObjectOwner guid directly to SummonCreature functions
2021-03-28 20:22:05 +02:00
Matan Shukry
abaeb12ba3
Scripts/Spells: Implemented druid eclipse system ( #26090 )
2021-03-24 00:50:28 +01:00
Shauren
69e0b9a985
Core/Auras: Update AuraState enum and implement missing new ones
2021-03-16 20:48:42 +01:00
Shauren
566f9f368d
Scripts/Icecrown Citadel: Corrected spell ids used by Professor Putricide
2021-03-16 18:36:40 +01:00
Matan Shukry
0c73895826
Scripts/Spells: corrections to Death Knight spell Blood Mastery ( #26082 )
2021-03-15 22:53:30 +01:00
Shauren
6585666e6e
Core/Spells: Define all spell modifier types and implement ProcCooldown mod and PeriodicHealingAndDamage for melee periodic damage
2021-03-15 21:03:06 +01:00
ForesterDev
7bd3914663
Scripts/Commands: modify command .dismount to target any selected player ( #19788 )
...
- change security lvl for command .dismount to 2 (gamemasters). For players there is /dismount command
Closes #19788
(cherry picked from commit 661dfee80e )
2021-03-15 20:17:31 +01:00
ariel-
f60b0ead83
Core/Scripts: more nopch
...
(cherry picked from commit deebac9639 )
2021-03-15 20:17:31 +01:00
ariel-
1891edb455
Core/Scripts: nopch fix
...
(cherry picked from commit 7fb70e74f2 )
2021-03-15 20:17:31 +01:00
ariel-
33fbd7c773
Core/Scripts: fix drink auras
...
(cherry picked from commit 5fc4d36a1f )
2021-03-15 20:17:31 +01:00
ariel-
794a3e4388
Core/Auras: fixed off by one error in counting SPELL_ATTR5_START_PERIODIC_AT_APPLY ticks
...
- Made SpellInfo::GetMaxTicks and AuraEffect::GetTotalTicks return the same number without mods (dumped arbitrary default return value of 6 and arbitrary 30 sec limit)
- They should be streamlined whenever SPELL_AURA_48 is implemented
(cherry picked from commit 7dff0e3246 )
2021-03-15 20:17:31 +01:00
ariel-
8eb3e6c243
Core/Scripts: more travis
...
(cherry picked from commit 2d07d4f7b3 )
2021-03-15 20:17:31 +01:00
ariel-
6042126916
Core/Scripts: travis fixes
...
(cherry picked from commit ea0224e3bd )
2021-03-15 20:17:31 +01:00
ariel-
44c8ccadd7
Core/Auras: periodics refactor part 5: ported periodic trigger spell auras to scripts
...
(cherry picked from commit a36e804ae4 )
2021-03-15 20:17:31 +01:00
ariel-
d9b145615d
Core/Auras: periodics refactor part 4: ported periodic dummy auras to scripts
...
(cherry picked from commit 193bd3b452 )
2021-03-15 20:17:31 +01:00
ariel-
97e869e8b3
Core/Auras: periodics refactor part 3: move more switch hacks to scripts
...
- Incidentally fixed some spells which were supposed to be removed by proc instead of healing to full
(cherry picked from commit 16e20711d2 )
2021-03-15 20:17:31 +01:00
ariel-
fd786c03a3
Core/Auras: periodics refactor part 2: Move UpdatePeriodic to AuraScripts
...
(cherry picked from commit 0510bf7afe )
2021-03-15 20:17:31 +01:00
ariel-
5f9e0d92d5
Core/Auras: periodics refactor part 1:
...
- Don't skip ticks if diff is greater than amplitude
- Fixed spells without ampltude in DBC
(cherry picked from commit 5d91beb1db )
2021-03-15 20:17:31 +01:00
Golrag
fe362cf2c9
Core/Entities: Some changes to LoS z checking & MotionMaster::MoveJumpTo (PR #20970 )
...
- Use Midsection height for LoS checking.
- Changed MotionMaster::MoveJumpTo to use correct z. This change also makes sure the _owner will jump towards the given angle. Instead of jumping to a unintended angle if the first one is not in LoS.
(cherry picked from commit 95456ab5d8 )
2021-03-15 20:17:31 +01:00
ariel-
88ae43fa51
Core/Misc: minor typo and codestyle fixes
...
- Replace NULL uses in new code with nullptr
- Fix wrong (accumulated) load time log when loading calendar invites
- Make Creature::CanRegenerateHealth const as its just a getter
- Mark OnlyOnceAreaTriggerScript::OnTrigger as final in case someone wants to override that (you are supposed to use protected _OnTrigger hook)
(cherry picked from commit 78a1c687a2 )
2021-03-15 20:17:31 +01:00
Shauren
b94851b824
Scripts/Spells: Fixed Fingers of Frost proc passive
...
Closes #19589
2021-03-13 01:02:48 +01:00