Commit Graph

19960 Commits

Author SHA1 Message Date
jackpoz
bcee801e4b Core/Network: Fix race condition in WorldSession timeout
Helgrind log:
 Lock at 0x2BD582E0 was first observed
  at : pthread_mutex_init (hg_intercepts.c:443)
  by : ACE_OS::mutex_init(pthread_mutex_t*, int, char const*, pthread_mutexattr_t*, int, int) (in /usr/lib/libACE-6.0.3.so)
  by : ACE_Thread_Mutex::ACE_Thread_Mutex(char const*, pthread_mutexattr_t*) (in /usr/lib/libACE-6.0.3.so)
  by : WorldSocket::WorldSocket() (WorldSocket.cpp:106)
  by : ACE_Acceptor<WorldSocket, ACE_SOCK_Acceptor>::make_svc_handler(WorldSocket*&) (Acceptor.cpp:261)
  by : ACE_Acceptor<WorldSocket, ACE_SOCK_Acceptor>::handle_input(int) (Acceptor.cpp:396)
  by : ACE_Dev_Poll_Reactor::dispatch_io_event(ACE_Dev_Poll_Reactor::Token_Guard&) (in /usr/lib/libACE-6.0.3.so)
  by : ACE_Dev_Poll_Reactor::handle_events(ACE_Time_Value*) (in /usr/lib/libACE-6.0.3.so)
  by : ACE_Reactor::run_reactor_event_loop(ACE_Time_Value&, int (*)(ACE_Reactor*)) (in /usr/lib/libACE-6.0.3.so)
  by : ReactorRunnable::svc() (WorldSocketMgr.cpp:170)
  by : ACE_Task_Base::svc_run(void*) (in /usr/lib/libACE-6.0.3.so)
  by : ACE_Thread_Adapter::invoke_i() (in /usr/lib/libACE-6.0.3.so)

 Possible data race during write of size 8 at 0x2BD6F6F8 by thread #12
 Locks held: 1, at address 0x2BD582E0
  at : WorldSession::ResetTimeOutTime() (WorldSession.h:372)
  by : WorldSocket::ProcessIncoming(WorldPacket*) (WorldSocket.cpp:709)
  by : WorldSocket::handle_input_payload() (WorldSocket.cpp:517)
  by : WorldSocket::handle_input_missing_data() (WorldSocket.cpp:610)
  by : WorldSocket::handle_input(int) (WorldSocket.cpp:282)
  by : ACE_Dev_Poll_Reactor::dispatch_io_event(ACE_Dev_Poll_Reactor::Token_Guard&) (in /usr/lib/libACE-6.0.3.so)
  by : ACE_Dev_Poll_Reactor::handle_events(ACE_Time_Value*) (in /usr/lib/libACE-6.0.3.so)
  by : ACE_Reactor::run_reactor_event_loop(ACE_Time_Value&, int (*)(ACE_Reactor*)) (in /usr/lib/libACE-6.0.3.so)
  by : ReactorRunnable::svc() (WorldSocketMgr.cpp:170)
  by : ACE_Task_Base::svc_run(void*) (in /usr/lib/libACE-6.0.3.so)
  by : ACE_Thread_Adapter::invoke_i() (in /usr/lib/libACE-6.0.3.so)
  by : ACE_Thread_Adapter::invoke() (in /usr/lib/libACE-6.0.3.so)

 This conflicts with a previous write of size 8 by thread #7
 Locks held: none
  at : WorldSession::UpdateTimeOutTime(unsigned int) (WorldSession.h:368)
  by : WorldSession::Update(unsigned int, PacketFilter&) (WorldSession.cpp:256)
  by : World::UpdateSessions(unsigned int) (World.cpp:2646)
  by : World::Update(unsigned int) (World.cpp:2003)
  by : WorldRunnable::run() (WorldRunnable.cpp:60)
  by : ACE_Based::Thread::ThreadTask(void*) (Threading.cpp:186)
  by : ACE_OS_Thread_Adapter::invoke() (in /usr/lib/libACE-6.0.3.so)
  by : mythread_wrapper (hg_intercepts.c:233)
2013-11-03 18:07:17 +01:00
Aokromes
bc6920a80b DB/Misc: Missing Scout
by dr-j, closes #10380
2013-11-03 17:51:09 +01:00
Aokromes
7082dc4e98 DB/Misc: Wooly Justice
original work by Trista, updated by ZxBiohazardZx, final work by FireEmerald, closes #6587
2013-11-03 16:51:47 +01:00
Aokromes
a20772929e DB/Spawn: Lordaeron Citizen
by Hobbilis, closes #7914
2013-11-03 16:43:13 +01:00
Aokromes
6613001ece DB/Misc: Argent Squire / Argent Gruntling items
by BlackangelWow, updates #4710
2013-11-03 16:02:56 +01:00
Aokromes
4ccbfe8eaa DB/Misc: Update to Vordrassil's Heart Credit 2013-11-03 15:33:00 +01:00
Aokromes
ba9b8da299 DB/Misc: Astor Hadren
by dr-j, closes #10512
2013-11-03 14:07:48 +01:00
Aokromes
00897518c9 DB/Misc: The Broken Front
by dr-j, closes #7585
2013-11-03 14:04:53 +01:00
Aokromes
6a19060632 DB/Misc: Blazerunner's Script from EAI to SAI
by dr-j, closes #10547
2013-11-03 13:52:45 +01:00
Aokromes
5f6061460e DB/Misc: Burn Skorn ,Burn / Towers of Certain Doom
by dr-j, closes #10907
2013-11-03 13:49:16 +01:00
Aokromes
56cce65db1 DB/Misc: Lupus Pupus
by dr-j, closes #10436
2013-11-03 13:38:45 +01:00
Aokromes
ce55c8b018 DB/Misc: Words for Delivery description/completion text
by Crysicle, minor fix by xjose93, closes #10609
2013-11-03 12:43:11 +01:00
Aokromes
7c7ed52a2b DB/Misc: A hero's Burden + Oracles / Frenzyheart Rep Swapping
by dr-j, minor update by untaught, closes #8710 closes #6534
2013-11-03 11:28:07 +01:00
Discover-
27fe7d1842 Merge branch 'master' of https://github.com/TrinityCore/TrinityCore 2013-11-03 10:36:17 +01:00
Aokromes
1d2a070de4 Merge pull request #11165 from untaught/master
Fix quest ... Or Maybe We Don't (12138) and remove the core script
2013-11-03 01:36:08 -08:00
Discover-
b98cc11a49 Core/Misc: Fix compile after 316da388d5 2013-11-03 10:36:02 +01:00
untaught
45e0af089c Fix quest ... Or Maybe We Don't (12138) and remove the core script 2013-11-03 11:34:20 +02:00
Aokromes
741eed4740 DB/Misc: March of the Giants
by Justiciar, closes #10246
2013-11-03 10:23:33 +01:00
Aokromes
7b28dba13c Merge pull request #11164 from untaught/master
Fix quest Redeeming the Dead (9685) and remove the core script
2013-11-03 01:20:06 -08:00
untaught
316da388d5 Fix quest Redeeming the Dead (9685) and remove the core script 2013-11-03 11:17:28 +02:00
Aokromes
c1056b5711 Merge pull request #11163 from untaught/master
[Area Trigger Scripts]Support for Teleport for Quest: Breaking Through and Last Rites
2013-11-03 01:45:36 -07:00
untaught
b28c27cb7c [Area Trigger Scripts] Add Support for Teleport for Quest: Breaking Through (11898) 2013-11-03 10:35:12 +02:00
Aokromes
940e671d42 DB/Misc: Kaganishu
by untaught, closes #10704
2013-11-03 09:11:33 +01:00
Aokromes
dc8cf9f14f DB/Misc: Fix some startup errors
Note: if those mobs starts moving now needs to be properly fixed, no hacked with speed 0.
2013-11-03 09:04:32 +01:00
Aokromes
172007ba5a DB/Misc: Fix some startup errors 2013-11-03 08:30:42 +01:00
Aokromes
e766f75116 DB/SAI: Winterskorn creatures
by trista, closes #5906
2013-11-03 08:02:25 +01:00
Aokromes
b569d05c1b DB/Misc: Thistleshrub Rootshaper
by untaught, updates #10944
2013-11-03 07:51:28 +01:00
Aokromes
7cba781153 DB/SAI: Little Morsels cannot feed mobs
by dr-j, closes #10892
2013-11-03 07:49:02 +01:00
Aokromes
e6e16f377f DB/Misc: Fix Bros. Before Ho Ho Ho's
by nelegalno, closes #4332
2013-11-03 07:45:17 +01:00
Aokromes
ab396c4314 DB/Quest: Fix quest ender for To Fordragon Hold!
by dr-j, closes #5121
2013-11-03 07:21:33 +01:00
Aokromes
9065b166e5 DB/Misc: Make Caladis Brightspear visible when having proper quest
by Foldor, updates #11015
2013-11-03 06:47:29 +01:00
Aokromes
2760d19156 DB/Disables: Tempering The Blade queldalar LoS
by dr-j, closes #8920
2013-11-03 06:38:43 +01:00
Aokromes
d84bdcc1d0 DB/Misc: Lunar Festival Invitation - Teleport Moonglade
by zaphod77, updates #4945
2013-11-03 06:14:05 +01:00
Aokromes
2dd80b813e DB/Misc: Heart of the Phoenix Cooldown must ignore LoS
By mweinelt, updates #10198
2013-11-03 05:55:13 +01:00
Aokromes
8726c4dca2 DB/Gameobject: Battle plans of the Kvaldir
By Justiciar, closes #10291
2013-11-03 05:48:22 +01:00
Aokromes
1d31b5f4a7 DB/SAI: Book of the Ancients
By dr-j, closes #10146
2013-11-03 05:40:52 +01:00
Aokromes
51dd1ebd4e DB/Misc: Argent tournament quests without progress
By Crysicle, closes #7988
2013-11-03 05:36:29 +01:00
Aokromes
6843734b8f DB/SAI: There's Something Going On In Those Caves
By dr-j, closes #10786
2013-11-03 05:13:36 +01:00
Aokromes
73533f646f DB/SAI: Boiling Point
By untaught, closes #10761
2013-11-03 05:10:19 +01:00
Aokromes
6eac86a26f DB/Quest: A Dark Influence
By wintergreen77, fixes #6777
2013-11-03 04:51:26 +01:00
Aokromes
0cd02caaa8 DB/Misc: Kyle the friendly
By dr-j, closes #10564
2013-11-03 04:29:50 +01:00
Aokromes
2125c572e0 DB/Misc: Required classes for all versions of The Purification of Quel'Delar
By dr-j, closes #10594
2013-11-03 04:23:58 +01:00
Aokromes
6f9a548bd6 DB/SAI: Still At It
By dr-j, closes #8008
2013-11-03 04:01:08 +01:00
Aokromes
13df07e8fa DB/Creature: Scalesworn Elite inhabittype
By untaught, closes #10831
2013-11-03 03:54:55 +01:00
Aokromes
d42fe0c9a9 DB/SAI: Fix more credit fixes
By Pitcrawler, closes #10022
2013-11-03 03:49:40 +01:00
Aokromes
27a4e48771 DB/Conditions: Skill requirements to ride flying carpets and flying machines
By dr-j, closes #10572
2013-11-03 03:43:53 +01:00
Aokromes
d9a1609501 DB/Gameobject: Ulduar Flame Leviatan secondary force field
By PanDaemonAeon, closes #4793
2013-11-03 03:19:35 +01:00
Aokromes
1efb60c78e DB/Misc: Remove spells with effects SPELL_EFFECT_SUMMON
By xjose93, closes #7653 closes #10212
2013-11-03 02:54:06 +01:00
Aokromes
10d20fdcd0 DB/Creature: IoC template updates
By milotic, closes #8591
2013-11-03 02:22:49 +01:00
Aokromes
3c0228f609 DB/Gameobject: Dip in the Moonwell
By untaught, closes #7523
2013-11-03 01:44:52 +01:00