Ovahlord
c2be4c4a86
Misc: fixed issues discovered by static analysis
...
closes #290
2021-09-10 09:56:49 +02:00
Ovahlord
60c68dacca
Core/Spells: moved avoidance bonus handling to Unit::SpellDamageBonusTaken as it does affect all area attacks instead of periodic auras only
2021-09-01 21:26:12 +02:00
Shauren
21e7ffe1b7
Core/Misc: Fix windows nopch build
...
Closes #25363
2021-09-01 20:33:48 +02:00
Ovahlord
3506dae653
Core/Spells: ported PROC_FLAG_ENTER_COMBAT implementation from master branch and handle the Worgen transformation via its proc aura
2021-08-30 19:24:36 +02:00
Keader
f27c4609fc
Scripts/Black Temple: Removed Illidari Council Enconter Frame
2021-08-30 18:05:08 +02:00
UltraNix
50d0bf915e
Core/Maps: initialize vmapZ offset in Map::GetAreaId with the given z offset to retrieve the correct area Id with spawning things inside of WMOs that have their own area data
2021-08-30 17:34:49 +02:00
Ovahlord
7ac3d6fca9
Core/Players: Worgen will now transform into their altered form at engage instead of at dealing or taking damage
2021-08-29 18:36:33 +02:00
Ovahlord
a5caf1af95
Core/Units: removed now unused attacker argument from Unit::GetUnitCriticalChanceTaken
2021-08-29 02:13:16 +02:00
Ovahlord
fd815dfe33
Core/Units: remove an incorrect check for SPELL_AURA_MOD_CRIT_CHANCE_FOR_CASTER from Unit::GetUnitCriticalChanceTaken as that aura is only being involved for increasing crit chance values for spells with a class mask value
2021-08-29 01:52:39 +02:00
Ovahlord
01dad8b74e
Core/Spells: Eclipse states will no longer proc while the druid has no balance specialization active
2021-08-29 00:59:51 +02:00
Ovahlord
432e57b064
Core/Spells: fixed damage formula for bear form's Maul
2021-08-29 00:34:17 +02:00
Ovahlord
4c6cfee2dd
Core/Units: normalize melee damage while in bear or cat form
2021-08-29 00:19:06 +02:00
Ovahlord
a3a7a9b181
Core/Spells: Blood Shield will now only use effective healing for its shield calculation
2021-08-28 23:34:52 +02:00
Ovahlord
cfc3f25b46
Core/Spells: corrected multiple effect value calculations for procs that should use effective healing values instead of raw healing
2021-08-28 23:05:43 +02:00
Ovahlord
1ba6fc1a6a
Core/Spells: fixed Warlocks's Decimation talent
2021-08-28 15:44:05 +02:00
Nyr
bfad2b7027
Core/Spells: corrected Ids of triggered spells inDemon Soul's spell script ( #289 )
2021-08-28 15:07:51 +02:00
Ovahlord
7fcb1c03da
Correct script name added in 9616582b05
2021-08-28 15:05:24 +02:00
Ovahlord
9616582b05
Core/Spells: load BonusCoefficient into SpellInfo and use it for Goblin's Rocket Barrage Racial spell damage calculation
2021-08-28 15:01:28 +02:00
Ovahlord
ce1901524f
Tools/VMapExtrator: ported m2 model bounds issue fix from master branch
2021-08-28 14:39:19 +02:00
Ovahlord
5ed7516280
Core/Transports: fixed a logic mistake introduced in be614ded97
2021-08-19 06:20:05 +02:00
Ovahlord
be614ded97
Core/Misc: fixed issues reported by pvs studio
...
closes #281
2021-08-18 21:11:20 +02:00
Ovahlord
8186f9d450
make CI happy
2021-08-17 15:38:13 +02:00
Ovahlord
da5564fa47
Core/Packets: converted SMSG_CLEAR_COOLDOWN and SMSG_CLEAR_COOLDOWNS to packet class
2021-08-16 11:02:22 +02:00
Ovahlord
8ac7e71690
Core/Spells: implement summon properties parameter types based on the leaked enumerated strings values
...
Summon spells can now be commanded to interpret their basepoints depending on the parameter type that has been assigned to the summon properties dbc record Id
* implemented SummonCreatureExtraArgs to reduce the amount of arguments in Map::SummonCreature
2021-08-15 10:35:02 +02:00
Ovahlord
c927ca98ba
Core/Spells: allow knockback spell effects to use negative misc values as well for forward knockbacks
2021-08-15 07:07:37 +02:00
Ovahlord
1568798985
Core/Spells: fixed Glyph of Shadow Word: Death
2021-08-15 06:56:32 +02:00
Ovahlord
3e56f75d7c
fixed build and a typo in recent sql file
2021-08-02 13:13:50 +02:00
Ovahlord
e785b6d386
Scripts/Mulgore: several fixups for Camp Narache
...
* scripted Captured Brave's behavior when released from their cages
* respawned Armored Quillboars and got rid of duplicate spawns
* scripted Armored Quillboar's visual events, combat ability and behavior when ignited via torch
* added waypoints to Brave Windfeather
* nuked cooler's shitty sai for chief squealer thornmantle and replaced it with a c++ script to handle the death spell cast event
* corrected timers for Chief Hawkwind's ceremony texts
* spawned a missing spellfocus and removed some gameobject spawns which are suposed to be tempoary
* added some emote events to Camp Narache trainers
2021-08-01 15:21:05 +02:00
Ovahlord
280dd50af4
Core/Quests: also check previous quests when checking exclusive groups to allow chaining one quest group into another
2021-08-01 15:13:34 +02:00
jackpoz
1ea6bef697
Core/SOAP: Fix memory leak on shutdown reported by ASan
2021-07-31 21:44:43 +02:00
jackpoz
24d4e6977c
Core/SOAP: Fix new/free mismatch reported by ASan
2021-07-31 21:44:38 +02:00
Ovahlord
f9fafbab7d
Scripts/Deadmines: move entrance faction spawns to instance_spawn_groups and handle them via faction flags instead
2021-07-31 21:42:32 +02:00
ariel-
0792739a98
Core/Scripts: fixed npc immunity flags during Harbinger Skyriss encounter
...
- Added missing _Reset
- Properly register Skyriss summons in SummonList
Closes #21154
Who ordered up an extra large can of whoop-ass?
(cherry picked from commit f8b148c334
2021-07-29 21:41:02 +02:00
Ovahlord
e03b2f41bf
Core/Guilds: implement weekly bonus money packet field in guild bank queries
2021-07-29 18:45:49 +02:00
jackpoz
5d9b3b59d2
Core/Misc: Remove whitespace
2021-07-29 17:32:15 +02:00
jackpoz
d53a176746
Core/MMAPs: Reduce chances of breaking tile connections
...
Reduce chances of breaking tile connections caused by floating point rounding issues.
2021-07-29 17:32:05 +02:00
Gildor
a91f7a3ef3
Core/Quest: When removing an item required for a quest, update every quest in the quest log instead of stopping at the first objective that matches the removed item. ( #26760 )
...
Closes #25662
Closes #10586
2021-07-29 17:31:54 +02:00
Gildor
1466176aef
Core/Quests: Improve ItemRemovedQuestCheck logic ( #26758 )
...
Closes #25603
2021-07-29 17:31:23 +02:00
Ovahlord
8cabdc6c85
Scripts/LCT: fixed Siamat's Achievement 'Headed South'
2021-07-29 17:29:36 +02:00
Ovahlord
c58d2752d3
Core/Creatures: fixed build and clamp the damage pct limit instead of blindy relying on arguments
2021-07-26 15:57:29 +02:00
Ovahlord
0dfa919f09
Core/Creatures: optimized sparring checks by handling them via variable instead of map lookups and expose its value to helpers to allow manipulation during runtime
2021-07-26 15:48:16 +02:00
Ovahlord
ae13da2159
fixed build
2021-07-25 15:03:43 +02:00
Ovahlord
7648eff6db
Core/Quests: check if a player can take the next quest provided by its query data before trying to request its details
2021-07-25 14:57:41 +02:00
funjoker
a36e52e587
Core/DB: Use correct Get function
2021-07-24 01:25:07 +02:00
Ovahlord
9c55fc66ac
Core/Packets: added some missing bit flushing to trade status packets
2021-07-23 20:32:42 +02:00
Ovahlord
7bd1afe406
Core/Units: corrected check for SPELL_ATTR7_CANT_MISS in Unit::MagicSpellHitResult
...
thx to @Jildor for the headsup
2021-07-23 19:44:14 +02:00
Ovahlord
b236bd39df
Core/Movement: updated smartAI waypoint support to use the new smooth transition field as well
2021-07-16 16:56:47 +02:00
Ovahlord
b7ab244e79
Core/Packets: converted all remaining trade packets to packet class
2021-07-13 15:56:31 +02:00
funjoker
11e3cfd66d
Add missing include
2021-07-13 12:27:15 +02:00
Ovahlord
81098f738f
fixed nopch build
2021-07-12 09:01:53 +02:00
